October 2014 - Wine-Devel - list.winehq.org

Re: kernel32: fix incorrect lastpart in GetFullPathNameA with DBCS
by Dmitry Timoshkov Oct. 9, 2014

Oct. 9, 2014

Aric Stewart <aric(a)codeweavers.com> wrote: > --- a/dlls/kernel32/path.c > +++ b/dlls/kernel32/path.c > @@ -271,7 +271,8 @@ DWORD WINAPI GetFullPathNameA( LPCSTR name, DWORD len, LPSTR buffer, > > if (*p != '\\') > { > - while ((p > buffer + 2) && (*p != '\\')) p--; > + while ((p > buffer + 2) && > + ((*p != '\\') || IsDBCSLeadByte(*(p-1)))) p--; This probably should depend on whether ansi or oem code page is active. -- Dmitry.

1 0

Re: [PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.
by Henri Verbeet Oct. 9, 2014

Oct. 9, 2014

On 8 October 2014 14:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > These two patches fix test failures when the process is not in > foreground that print changing error lines. This avoids generating > warnings from the testbot whenever d3d8/tests/device.c is touched. > > There are many more failures in d3d8:device when the test is not in > foreground. Those failures write static lines and I'd prefer the testbot > to be changed to run them in foreground instead. Why does this affect d3d8, but not d3d9?

2 1

Re: [PATCH 7/7] mshtml: Added script element readyState and onreadystatechange tests.
by Marvin Oct. 9, 2014

Oct. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9400 Your paranoid android. === w7u (32 bit script) === script.c:632: Test failed: L"elem.readyState = loading" === w8 (32 bit script) === script.c:632: Test failed: L"elem.readyState = loading" script.c:632: Test failed: L"extern_res_script_rs = loaded0,eval,complete1, expected eval,complete1,"

1 0

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar. (try 2)
by Alexandre Julliard Oct. 8, 2014

Oct. 8, 2014

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Sorry, I noticed a couple of errors in the utf7_mbstowcs and > utf7_wcstombs documentation. They are now corrected. You still haven't addressed the issues I mentioned last time around. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: msvcr90: Prefer native dll if manifest is not present
by Nikolay Sivov Oct. 8, 2014

Oct. 8, 2014

> +#if _MSVCR_VER == 90 > + static const WCHAR msvcr90W[] = {'m','s','v','c','r','9','0','.','d','l','l',0}; > + ACTCTX_SECTION_KEYED_DATA askd = { sizeof(askd) }; > + > + if(FindActCtxSectionStringW(FIND_ACTCTX_SECTION_KEY_RETURN_HACTCTX, NULL, > + ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, msvcr90W, &askd)) { > + ReleaseActCtx(askd.hActCtx); > + return TRUE; > + } > + > + return FALSE; > +#endif It looks like you won't be using context handle anyway, so you can just set flags to zero, and return FindActCtxSectionStringW() value immediately.

2 1

Re: [PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.
by Marvin Oct. 8, 2014

Oct. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9361 Your paranoid android. === w8 (32 bit device) === device.c:3043: Test failed: Expected wndproc 0x412d00, got 0x412d00.

1 0

Re: msvcr90: Prefer native dll if manifest is not present
by Stefan Dösinger Oct. 8, 2014

Oct. 8, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-08 16:35, schrieb Piotr Caban: > DVDFab 9.x is distributed with custom version of msvcr90.dll that > is not compatible with normal dll. I think this comment should go into the code because Alexandre removes it from the commit log. It will be hard to find out the reason for this code without it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUNU0oAAoJEN0/YqbEcdMwalAP/2PgH8yjUYkTImTuMCeFj0+z ZBNVOkDz6+1/qeWZvA7YdnkZ8GqBaAZ48KBTgMMFyjUjiot2Ee2SbfyEJfHGBNE3 PBBaLzWIoxxkSDzkVK4A5XTDqx3gAueiTX79dS3cYd1R2Zb+rnFSkDkxSv0S03Q0 xY/ig2KDcYnm5BXfPcrV9PKTsBzLrJ+73t+4uBh3cKY623V8umZObyjq9yYNdwFn lSH3fIhUM60U6r4xMOw4YkiI7GJ5otlf7ORAA6zh+4N0oKwkcPiC6NJ3a/HLW6xG dyw9fQ3183puDWE+3Fi0ufHSTcbp6evMqY4WhOWwNYRNTjQdMcIY23S6rATGfqS9 TieSwABJ4L3quQ0zjmw920x4rTh7/XAMC3gEpXjlFF23LniHDnQtKjwckHk5a2vh qqDQ7+y7bywb6CDGUJCo/Mp6mT5Mt4qcL3/CZtuCsLM5FLYgvAXaGw3IYTCCxAnF F198/g1En1zjdbJmvDWAda4YAD9ffdmkWrppW0Oq7p8klyd35OktJ4LS6ULqb2jo K90+Ss+5N55rmhfGqPRgWifu+gRK3bdO08YpKkhhGyv6J+5DFyyB7uBqbSnjMNbR 25M2aPGvH4jB9vDD9DVSkt4q35FDmHVRYThW+3L3W92q0WatHhyWwoMTY6f+rvGj ftkB6MWECB/XTl1QxMQW =qeov -----END PGP SIGNATURE-----

1 0

Wine 1.7.28 source code
by Игорь Чебаненко Oct. 8, 2014

Oct. 8, 2014

Hello,I scanned Wine 1.7.28 source code with cppcheck 1.63. I hope my scanning will get attention. Threre's lots of false-positives,but,I think,in my file you will see interesting things. P.S Thank you for Wine. It is very interesting,and important open source project.

3 2

Re: kernel32: add a stub for GetSystemFileCacheSize (2/2)
by Alistair Leslie-Hughes Oct. 8, 2014

Oct. 8, 2014

On 08/10/14 06:37, Austin English wrote: > > @·stub·SetSystemFileCacheSize > +@·stdcall·SetSystemFileCacheSize(long·long·long)·kernel32.SetSystemFileCacheSize > This patch doesn't match the subject. Best Regards Alistair Leslie-Hughes

2 1

Re: [PATCH] mscoree: Use E_NOT_SUFFICIENT_BUFFER definition
by Marvin Oct. 8, 2014

Oct. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9344 Your paranoid android. === wxppro (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === wvistau64 (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w2008s64 (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w7u (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w8 (32 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === wvistau64 (64 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f === w2008s64 (64 bit mscoree) === mscoree.c:343: Test failed: CreateConfigStream returned 8007007f

2 1