November 2014 - Wine-Devel - list.winehq.org

RE: [PATCH v3 04/10] reg: Add sane_path function to do preliniary key validation
by Hugh McMaster Nov. 10, 2014

Nov. 10, 2014

On Saturday, 8 Nov 2014 11:26:45 +0100, Jonathan Vollebregt wrote: >+static LSTATUS sane_path(const WCHAR *key) >+{ >+ if (key[0] == '\\' && key[1] == '\\' && key[2] != '\\') >+ return ERROR_NO_REMOTE; >+ >+ return ERROR_SUCCESS; >+}Where are you handling (invalid) keys beginning with backslashes, e.g.: \\HKEY_CURRENT_USER\\Console? Windows only allows two consecutive backslashes at the beginning of a key. >+ if (key[0] == '\\' && key[1] == '\\' && key[2] != '\\') HKEY... --> ERROR_SUCCESS \HKEY... --> ERROR_SUCCESS !!! \\HKEY... --> ERROR_NO_REMOTE \\\HKEY... --> ERROR_SUCCESS !!! Those two marked with !!! need to be handled. Do you do this in a later patch? -- Hugh McMaster

2 2

Re: [PATCH 2/2] user32/tests: Test exception handling for timer callbacks. (try 2)
by Marvin Nov. 10, 2014

Nov. 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10156 Your paranoid android. === w7u (32 bit msg) === msg.c:12189: Test failed: unexpected hwnd 0018014A

1 0

Re: [2/2] wined3d: Take abs() of vertex z coordinate as FFP fog coordinate (try 5)
by Matteo Bruni Nov. 9, 2014

Nov. 9, 2014

2014-11-06 21:51 GMT+01:00 Joachim Priesner <joachim.priesner(a)web.de>: > Take the absolute value of vertex.z as fog coordinate instead of just > the z coordinate. This fixes e.g. fog for applications that use > right-handed projection matrices. > > Also test the clamp behavior of the oFog vertex shader output. > > Tested on openSuse 13.1 and Windows 8.1 (VMware Player). > > Try 5 that fixes a test failure I overlooked. > --- > dlls/d3d8/tests/visual.c | 296 +++++++++++++++++++++++++++++++++++++ > dlls/d3d9/tests/visual.c | 360 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw7.c | 161 ++++++++++++++++++++ > dlls/wined3d/glsl_shader.c | 2 +- > 4 files changed, 818 insertions(+), 1 deletion(-) > > diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c > index 163110c..a1eabcd 100644 > --- a/dlls/d3d8/tests/visual.c > +++ b/dlls/d3d8/tests/visual.c > @@ -696,6 +696,301 @@ done: > DestroyWindow(window); > } > > +/* This test tests fog in combination with negative vertex z coordinates. */ > +static void fog_negative_z_test(void) > +{ > + enum > + { > + C_ALPHA_0x00 = 0x00000000, > + C_CLEAR = 0xffff00ff, > + C_FOGGED = 0x0000ff00, > + C_HALF_FOGGED = 0x00808000, > + C_UNFOGGED = 0x00ff0000, > + C_CLAMPED_FOG = 0xdeadbeef /* triggers special codepath when used as middle_color */ > + }; > + > + /* Fill the null-shader entry with the FVF (SetVertexShader is "overloaded" on d3d8). */ > + DWORD vertex_shader[3] = {D3DFVF_XYZ | D3DFVF_DIFFUSE | D3DFVF_SPECULAR, 0, 0}; > + DWORD pixel_shader[2] = {0, 0}; > + IDirect3D8 *d3d; > + IDirect3DDevice8 *device; > + BOOL has_vs_support, has_ps_support, has_table_fog_support; > + unsigned int i, ps, y; > + D3DCOLOR color, expected_middle_color; > + ULONG refcount; > + D3DCAPS8 caps; > + HWND window; > + HRESULT hr; > + > + /* Basic vertex shader without fog computation ("non foggy") */ > + static const DWORD vertex_shader_code1[] = > + { > + 0xfffe0100, /* vs_1_0 */ > + /* output.Pos.z = input.Pos.z * 0.5 + 0.5 */ > + 0x00000005, 0x80010000, 0x90aa0000, 0xa0000000, /* mul r0.x, v0.z, c0.x */ > + 0x00000002, 0xc0040000, 0x80000000, 0xa0000000, /* add oPos.z, r0.x c0.x */ > + /* output.Pos.xyw = input.Pos.xyw */ > + 0x00000001, 0xc00b0000, 0x90e40000, /* mov oPos.xyw, v0 */ > + /* output.Color = input.Color */ > + 0x00000001, 0xd00f0000, 0x90e40001, /* mov oD0, v1 */ > + 0x0000ffff, /* END */ > + }; Where are you setting the value of c0 in the d3d8 test?

3 3

Re: [PATCH v3 08/10] reg: Add wchar/raw data conversion functions
by Stefan Dösinger Nov. 9, 2014

Nov. 9, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, The first 7 patches look worthy of Alexandre's review. Don't resend this yet, I'd suggest to wait for Alexandre's opinion first. Am 2014-11-08 11:26, schrieb Jonathan Vollebregt: > + static const WCHAR empty = 0; You could make this on the global scope, call it empty_wchar (or empty_string or something similar) and use it to replace the RegDeleteKeyA with RegDeleteKeyW. That's only a minor style suggestion though, not a requriement. > + FIXME("Check for integer overflow.\n"); Print this only if i == UINT_MAX. If i is smaller you know no overflow has happened. > + if (0) > + return ERROR_ARITHMETIC_OVERFLOW; > ... > + case ERROR_NOT_NUMBER: > + reg_message(STRING_NOT_INT_OR_NEG); > + return; > + case ERROR_ARITHMETIC_OVERFLOW: > + reg_message(STRING_ERANGE); > + return; I don't like the dead code. It also seems that native prints the same error message in both cases, so you don't need to separate between underflows, overflows and strings that are not numbers. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXiejAAoJEN0/YqbEcdMwWTsP/2HaBgIt6J3EqvC+jpj42MPs tgHXaZ/lhLxUTtHCcnSzsrVt5zmVN7AOnET54KQFHjbY2OoEcT9PpDDjW/9LVGTc dj0ciXNpOLuo6MdYWbjmTMtIFVBPMISSYJks2FxvZ1peYa5g+dQQZ6blHWzlcA1k dLK7UHPeh5kyHACgbr3i0wdL9CNeQ9pafWCUtpnZwxHbXVWlOB1XRZZumKg7snz8 QyLDJylKzYZEJ6CBjU5YxZKl/NXrCoiHplhkF8Tddl8Xmh+AqpWnvMwsWBbiFgXC ZybdSnHY0vvCojJPb9dYpscbY2uy2Xjap2t8a61xlI288/Tz+8tvnm3qkd99i13w S9Tf2TGmhHKN1DG/ljnvALRh9JTYH20jFf/lvgZOApew4iyuHWHsLKdjp9LvpwGW ogIpBHT+kpNPSHuPgbHm9lK/k2OAYBGUZqbH2c0bznQdVWUqEABdR/cMM/wVjYbs LpUdstKs2oLbhr2gxvLkX0C3f4zdowetYnlnynuL1S+krcAKeQgPxE14MtwKeX49 rYeT931uOvhYi9Dh8a0DU8FTVfI9DKAbRfcBRt81AgJ6zymDC050s2MkELZTyDod WhPrkpXV/FUOsn2Sef0yxI78XtgbaaGEUIdBz9rThVvJNy4Wrw7zA2MICUhgEQe1 S5rqOajVwtKqqjX0JeJJ =CJwM -----END PGP SIGNATURE-----

2 2

Re: [PATCH] vbscript: Implemented String(try 4)
by Marvin Nov. 8, 2014

Nov. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10122 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

2 1

Ideas for simplifying tabular UTF-7 tests?
by Alex Henrie Nov. 8, 2014

Nov. 8, 2014

Hi, I have two patches for adding tabular UTF-7 tests at https://github.com/alexhenrie/wine/commits/master However, before I submit them to wine-patches, I'd like to ask for wider feedback. Sebastian Lackner has commented: * too many values for each test, difficult to maintain, and looks redundant * initializing big structures on the stack should be avoided The problem is that I don't see a good way to simplify this any further: * The chars_written variable (number of characters actually written) cannot be eliminated and determined implicitly from the len and dstlen variables alone. See the second-to-last encoding test case, where len is 0 and dstlen is 4, but chars_written is 3. * The dst variable (destination buffer) is almost always set to the output variable, but one test requires dst to be NULL. * These are just tests, so I'm not worried about complicating the code in order to improve performance. I've tried replacing chars_written and dst with a set of flags (ONE_NOT_WRITTEN and NULL_DST) and corresponding if statements, but this looks ugly to me. Furthermore, removing the output variable from the table obscures the reason why dstlen is usually set to sizeof(output) - 1. All in all, I think that writing out all the parameters explicitly is the most intuitive way to go. What do the rest of you think? How would you write this code? -Alex

1 1

Re: msvcp90: Add std_Ctraits::Isnan implementation.
by Nikolay Sivov Nov. 7, 2014

Nov. 7, 2014

On 11/4/2014 11:22, YongHao Hu wrote: > --- > dlls/msvcp90/math.c | 9 +++++++++ > dlls/msvcp90/msvcp90.spec | 6 +++--- > dlls/msvcp90/tests/misc.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 60 insertions(+), 3 deletions(-) > > > > You need to update msvcp80.spec too.

2 1

Re: [PATCH v2 6/8] reg: Add wchar/raw data conversion functions
by Stefan Dösinger Nov. 7, 2014

Nov. 7, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-07 17:29, schrieb Jonathan Vollebregt: > + if (input[0] == '0' && (input[1] == 'x' || input[1] == 'X')) > + i = strtoulW(input, &temp, 16); > + else > + i = strtoulW(input, &temp, 10); > + > + if (input[0] == '-' || temp[0] || temp == input) > + return ERROR_NOT_INT_OR_NEG; Please add tests for a valid DWORD value >= 0x80000000 and a test with a value > 0xffffffff. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXTDPAAoJEN0/YqbEcdMw02oP/1mjnMjeqJQY3jUE6KpOUJ2c xi6mFcxcP1p9j6UfpAqVr2Ho+7Qdc3t+JR0++TYqONZw5u8PXMMYBCTbP5DcGnRq 3BuE0a9XKj+0WBsUqqfi3RDz/VXdmlHpRk28NTKtzQETnEJ9h+au6Afhivz/j23v q/SkQrrElU3DEuaYE++0nChLseLnzc2W9LoU6ltNxCEOgvWB5jNz2pQdPg1c9USp AFvkXCJbLe8H70wkRlK3soSBA1i0fB6aZShA1rnAg93VnIeprQJH38j4Aua4CBmA iZ+1mrxn2rTBxPJnyceJ68pcxT8XV8EPqRmuK9DXneMYJfW1xHS37ehOvMIKmOQ3 RjsLfZ1pV/+QPVKEWHIrNY1YIY88e1wzJmrZatygzmw0OEIzk4FP52rSrEDEhudD Ue9iddJ6gvfFl8oRT33/mJ8ss9ITr56QU9wwXo8AtnQwP1gK4GSu9tfUkgbQHfbX rrF/MaVAFNRSspxR3uO41Gr4X9zwtW0ghSFrEUDNkG0ijZ8VvOgVczmGS7x45Mh6 6TAtS1qe1+zzGhORa8VJI/VvgeD7wuLS+f+BSwB/ONp51RDJaWvPs8lGRXp5Bqzz 1FXowdYyXqX+8iaEBNzlawvbIYHKWYsdeAR2big9dXIpYSFJKgBugTeOkT1v2FA2 OxLaUmdTYdK3/ItWvsPR =yNQY -----END PGP SIGNATURE-----

1 0

Rocksmith ALSA patches test
by Luke A. Guest Nov. 7, 2014

Nov. 7, 2014

Hi, I just built 1.7.29 on Gentoo with all 6 patches. I ran the game from the start, new profile, beginner, etc. So far, it seems stable, but there is a lot of noise when the guitar is not in use. Also, tuning is difficult, as the game is not responding as quickly as it should, pluck then wait until the tuner moves. This is also a problem when doing that first "Aerosmith" riff at the start. If there is anything you want me to test, I can, just email me. Thanks for the hard work, Luke (and future users of said work :D)

1 0

Re: [PATCH 4/5] mmdevapi: add property for device path
by Bruno Jesus Nov. 7, 2014

Nov. 7, 2014

On Fri, Nov 7, 2014 at 12:58 PM, Mark Harmstone <hellas(a)burntcomma.com> wrote: > --- > dlls/mmdevapi/devenum.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) Hi, I can't tell if your patch is right or wrong, what I can say is that you are using C++ comments in this patch, they are not allowed in wine, please switch to /* */. Best regards, Bruno

1 0