November 2014 - Wine-Devel - list.winehq.org

Re: [2/2] ntdll: Implement Rtl[Add|Remove]VectoredContinueHandler semi-stubs.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10262 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/003C0001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/002C0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [1/2] ntdll/tests: Add basic tests for Rtl[Add|Remove]VectoredContinueHandler.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10261 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00350000/00350001 exception: unhandled exception 80000004 at 00350000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/00350001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/003D0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/003C0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [PATCH 5/7] d3d8/tests: Test style changes on focus loss.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10250 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2889: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2893: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2916: Test failed: Failed to reset device, hr 0x88760868. device.c:2920: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2924: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2938: Test failed: Failed to set foreground window. device.c:2942: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:2946: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 4/7] d3d8/tests: Test messages on focus loss.
by Marvin Nov. 14, 2014

Nov. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10249 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000301BA, got 0002004C. device.c:2888: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2892: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2915: Test failed: Failed to reset device, hr 0x88760868. device.c:2919: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2923: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3291: Test failed: Failed to reset device. device.c:3298: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3306: Test failed: Expected wndproc != 0x413100.

1 0

Re: winemac: WS_EX_DLGMODALFRAME shouldn't prevent the window being resizeable.
by Ken Thomases Nov. 13, 2014

Nov. 13, 2014

Hi, On Nov 13, 2014, at 3:26 AM, Huw Davies <huw(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index e61a517..54bd56e 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -72,12 +72,12 @@ static void get_cocoa_window_features(struct macdrv_win_data *data, > if (ex_style & WS_EX_TOOLWINDOW) wf->utility = TRUE; > } > } > - if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > - else if (style & WS_THICKFRAME) > + if (style & WS_THICKFRAME) > { > wf->shadow = TRUE; > if (!data->shaped) wf->resizable = TRUE; > } > + else if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) wf->shadow = TRUE; > } I think that's the correct logic, but it would be better to separate out setting resizable and shadow. The shadow stuff can be a single "if" with the conditions ORed together. Resizable can be a single "if" or even a simple assignment of a boolean expression. Thanks, Ken

1 1

RE: [PATCH] reg.exe: Modernise print functions
by Hugh McMaster Nov. 13, 2014

Nov. 13, 2014

On Monday, 10 November 2014, Jonathan Vollebregt wrote: >> WCHAR msg_buffer[1024]; >No easy way to get the expected size and dynamically allocate the output I take it? >I looked into it before but besides _vscprintf (In msvcrt, which we're >not allowed to use) there doesn't seem to be a way to get the expected >output size besides perhaps growing the buffer over and over again until >it fits (Which seems inefficient for a simple printing function) One possible way would be to avoid using vsnprintfW() and pass everything through to output_vprintf(). static void __cdecl reg_printfW(const WCHAR* msg, ...) { __ms_va_list va_args; __ms_va_start(va_args, msg); output_vprintf(msg, va_args); __ms_va_end(va_args); } This would have the advantage of using FormatMessage() to allocate memory. But we would have to replace all format specifiers (four or five?) with their FormatMessage() equivalents. static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','x',' ',' ','d','a','t','a',' ','%','s','\n',0}; becomes static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','1','!','x','!',' ',' ','d','a','t','a',' ','%','2','\n',0};

3 4

Re: [PATCH 2/6] wined3d: Minimize device windows on focus loss (v3).
by Henri Verbeet Nov. 13, 2014

Nov. 13, 2014

On 12 November 2014 22:15, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) > +{ > + if (!activate && !(swapchain->device->create_parms.flags & WINED3DCREATE_NOWINDOWCHANGES)) > + ShowWindow(swapchain->device_window, SW_MINIMIZE); > +} This patch is mostly just blocked by the tests failing, but I'd also have to wonder if the window proc should be installed in the first place if the device is created with NOWINDOWCHANGES.

2 1

Re: [5/5] windowscodecs: Implement ComponentFactory_CreateMetadataReaderFromContainer.
by Alexandre Julliard Nov. 13, 2014

Nov. 13, 2014

Vincent Povirk <madewokherd(a)gmail.com> writes: > From a3735fa76b9dc568f32561eda4617e216af82138 Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Wed, 12 Nov 2014 15:51:09 -0600 > Subject: [PATCH 5/7] windowscodecs: Implement > ComponentFactory_CreateMetadataReaderFromContainer. > > --- > dlls/windowscodecs/imgfactory.c | 101 +++++++++++++++++++++++++++++++++++- > dlls/windowscodecs/tests/metadata.c | 25 +++++---- > 2 files changed, 115 insertions(+), 11 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M windowscodecs.dll -p windowscodecs_test.exe.so metadata && touch metadata.ok metadata.c:953: Test succeeded inside todo block: unexpected count 1 make[1]: *** [metadata.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll/tests: Get rid of "defined but not used" warnings on non-x86(_64) platforms
by Marvin Nov. 13, 2014

Nov. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10227 Your paranoid android. === w2000pro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:484: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:484: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00340000/00340001 exception: unhandled exception 80000004 at 00340000 exception.c:484: Test failed: 42: Wrong exception address 7751ED97/00340001 === w2008s64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:484: Test failed: 42: Wrong exception address 77E5ED97/002C0001 === w7u (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:484: Test failed: 42: Wrong exception address 77CDE34F/003D0001 === w8 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:484: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [PATCH 6/6] ddraw/tests: Test focus loss style changes.
by Marvin Nov. 13, 2014

Nov. 13, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10223 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 7256F329

1 0