April 2014 - Wine-Devel - list.winehq.org

Re: [1/3] taskschd/tests: Add some tests for task registration info.
by Nikolay Sivov April 11, 2014

April 11, 2014

On 4/11/2014 11:26, Dmitry Timoshkov wrote: > + hr = IRegistrationInfo_get_Description(reginfo, &bstr); > +todo_wine > + ok(hr == S_OK, "get_Description error %#x\n", hr); > +if (hr == S_OK) > +{ > + ok(bstr && !lstrcmpW(bstr, Task1), "expected Task1, got %s\n", wine_dbgstr_w(bstr)); It's redundant to check for 'bstr' being not NULL, lstrcmpW test will fail in this case too. For other tests when it returns NULL bstr it would be cleaner to set pointer to some non-zero value to test that each method actually resets it to NULL.

2 3

Re: [3/3] taskschd: Implement setters for IRegistrationInfo string properties. Take 2.
by Marvin April 11, 2014

April 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6298 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] taskschd: Implement getters for IRegistrationInfo string properties. Take 2.
by Marvin April 11, 2014

April 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6297 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] taskschd: Implement getters for IRegistrationInfo string properties.
by Nikolay Sivov April 11, 2014

April 11, 2014

On 4/11/2014 11:27, Dmitry Timoshkov wrote: > + *description = reginfo->description ? SysAllocString(reginfo->description) : NULL; > + return S_OK; SysAllocString(NULL) returns NULL, so no need to handle it separately.

1 0

Re: [3/3] taskschd: Implement setters for IRegistrationInfo string properties.
by Nikolay Sivov April 11, 2014

April 11, 2014

On 4/11/2014 11:27, Dmitry Timoshkov wrote: > static HRESULT WINAPI RegistrationInfo_put_Description(IRegistrationInfo *iface, BSTR description) > { > - FIXME("%p,%p: stub\n", iface, debugstr_w(description)); > - return E_NOTIMPL; > + registration_info *reginfo = impl_from_IRegistrationInfo(iface); > + > + TRACE("%p,%p\n", iface, debugstr_w(description)); > + > + if (!description) return E_INVALIDARG; > + > + reginfo->description = heap_strdupW(description); > + /* FIXME: update XML on the server side */ > + return reginfo->description ? S_OK : E_OUTOFMEMORY; Looks like you need to free previously set string.

1 0

Re: [2/2] dpnet: Improve Error checking in Get/Set SP (try 6)
by Stefan Dösinger April 11, 2014

April 11, 2014

Am 11.04.2014 um 04:21 schrieb Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > Fixed Copy/paste issue. > > Changelog: > dpnet: Improve Error checking in Get/Set SP > > > Best Regards > Alistair Leslie-Hughes Looks good to me!

1 0

Re: mshtml: Ignore &IID_IWebBrowserPriv2IE7 in wb_qi.
by Marvin April 11, 2014

April 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6273 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 5)
by Stefan Dösinger April 10, 2014

April 10, 2014

Am 10.04.2014 um 11:51 schrieb Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: Is this intentional? > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); Otherwise this looks good to me.

1 0

Re: [PATCH] gdiplus: fix segfault in gdip_format_string
by Vincent Povirk April 10, 2014

April 10, 2014

Looks good to me, thanks. (Maybe we should consider setting format to an empty GpStringFormat if it's not specified.)

1 0

Re: wined3d: Add NVIDIA Geforce GTX 750 to device list.
by Henri Verbeet April 10, 2014

April 10, 2014

On 10 April 2014 08:47, Ryan Turner <zdbiohazard2(a)gmail.com> wrote: > + CARD_NVIDIA_GEFORCE_GTX750 = 0x1381, > + CARD_NVIDIA_GEFOREE_GTX750TI = 0x1380, Did you try to compile this?

2 1