May 2014 - Wine-Devel - list.winehq.org

Re: msvcrt: Don't crash on NULL struct _tm in asctime
by Marvin May 12, 2014

May 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6983 Your paranoid android. === w2000pro (32 bit time) === time: unhandled exception c0000005 at 78028AD5 === wxppro (32 bit time) === time: unhandled exception c0000005 at 77C4A8B6

1 0

Re: [PATCH 2/2] oleacc: Add GetStateText implementation (try2)
by Nikolay Sivov May 12, 2014

May 12, 2014

> + state_id = IDS_STATE_MIN; > + while(dwStateBit) { > + state_id++; > + dwStateBit /= 2; > + } It looks like ffs() could be used to do that. Actually it would be better to find a way to connect those resource ids with actual STATE_SYSTEM_* symbols, not sure if it's possible to do cleanly. Also I don't like formatting, especially prefixed names, but that's probably considered to be submitter choice.

2 3

Re: user32: Track the number of GL surfaces for a window rather than the pixel format.
by Alexandre Julliard May 12, 2014

May 12, 2014

Ken Thomases <ken(a)codeweavers.com> writes: > The specific pixel format was never used. It was effectively just a flag > indicating if the window had a GL surface. This generalizes it from a flag > to a count, to allow for multiple GL surfaces. I'm not convinced that the concept of multiple surfaces makes sense, except maybe as a driver implementation detail. -- Alexandre Julliard julliard(a)winehq.org

4 15

Re: [PATCH] gdi32: Add MS Shell Dlg tests
by Dmitry Timoshkov May 12, 2014

May 12, 2014

Alex Henrie <alexhenrie24(a)gmail.com> wrote: > + memset(&efnd, 0, sizeof(efnd)); > + strcpy(lf.lfFaceName, "MS Shell Dlg"); > + ret = EnumFontFamiliesExA(hdc, &lf, enum_fullname_data_proc, (LPARAM)&efnd, 0); > + ok(ret, "font MS Shell Dlg is not enumerated\n"); > + ret = strcmp((char*)efnd.elf[0].elfLogFont.lfFaceName, "MS Shell Dlg"); > + todo_wine ok(!ret, "expected MS Shell Dlg got %s\n", efnd.elf[0].elfLogFont.lfFaceName); > + ret = strcmp((char*)efnd.elf[0].elfFullName, "MS Shell Dlg"); > + ok(ret, "did not expect MS Shell Dlg\n"); Please add the tests for other font enumeration APIs (the may behave differently), and the tests with NULL face name (according to my tests in that case MS Shell Dlg won't be enumerated). Since that would clutter existing tests I'd suggest to move the new one into separate body and name it appropriately. -- Dmitry.

2 1

Re: comctl32/listview: Fix custom draw stage sequence
by Marvin May 12, 2014

May 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6975 Your paranoid android. === w2000pro (32 bit listview) === listview.c:5115: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5120: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === wxppro (32 bit listview) === listview.c:5115: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5120: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === wvistau64 (32 bit listview) === listview.c:5115: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5120: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w7u (32 bit listview) === listview.c:5115: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5120: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w8 (32 bit listview) === listview.c:5115: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5120: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === wvistau64 (64 bit listview) === listview.c:5115: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5120: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5115: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5120: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Re: [PATCH] gdi32: Add MS Shell Dlg tests
by Marvin May 12, 2014

May 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6979 Your paranoid android. === wvistau64 (32 bit font) === The test timed out === wvistau64 (64 bit font) === The test timed out

1 0

Federal circuit reverses ruling on Java APIs
by Alex M May 11, 2014

May 11, 2014

https://www.eff.org/deeplinks/2014/05/dangerous-ruling-oracle-v-google-fede… This is very worrying news. What are the implications for WINE if this manages to go through entirely? -- Malo periculosam libertatem quam quietum servitium.

4 3

Testbot
by Mikael Ståldal May 11, 2014

May 11, 2014

I see in the patch list http://source.winehq.org/patches/ that the testbot run on some patches, but not all. What determine if it run or not?

2 4

Re: ced401: add initial support
by André Hentschel May 9, 2014

May 9, 2014

Am 09.05.2014 14:42, schrieb Alois Schlögl: > The attached patch includes the stubs for the ced1401 driver dll. > > This is a starting point to support ced1401/spike2/signal software. > > It's my first patch submission to wine - feedback welcome. > I also doubt that this wrapper get's included as it's too special. But when you finished your work, could you please share a link to github or somewhere with me. (I'm collecting wrappers for Wine on my website: http://dawncrow.de/wine/index.html )

1 0

Re: gdi32: Report unsubstituted font face names. (try 5)
by Alexandre Julliard May 9, 2014

May 9, 2014

Alex Henrie <alexhenrie24(a)gmail.com> writes: > I kept the full name tests, but now they make sure that the full name > is a SUBSTITUTED font name. It breaks the gdiplus tests: ../../../tools/runtest -q -P wine -T ../../.. -M gdiplus.dll -p gdiplus_test.exe.so font && touch font.ok font.c:759: Test failed: wrong face name MS Shell Dlg font.c:770: Test failed: wrong face name MS Shell Dlg make: *** [font.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0