May 2014 - Wine-Devel - list.winehq.org

Re: [PATCH] gdi32: Report unsubstituted font face names. (try 3)
by Alexandre Julliard May 8, 2014

May 8, 2014

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -4741,6 +4741,17 @@ static void test_EnumFonts(void) > ret = EnumFontFamiliesA(hdc, NULL, enum_all_fonts_proc, (LPARAM)&lf); > ok(ret, "font Arial Italic Bold should not be enumerated\n"); > > + /* MS Shell Dlg and MS Shell Dlg 2 must exist */ > + ret = EnumFontFamiliesA(hdc, "MS Shell Dlg", enum_fonts_proc, (LPARAM)&lf); > + ok(!ret, "font MS Shell Dlg is not enumerated\n"); > + ret = strcmp(lf.lfFaceName, "MS Shell Dlg"); > + ok(!ret, "expected MS Shell Dlg got %s\n", lf.lfFaceName); > + > + ret = EnumFontFamiliesA(hdc, "MS Shell Dlg 2", enum_fonts_proc, (LPARAM)&lf); > + ok(!ret, "font MS Shell Dlg 2 is not enumerated\n"); > + ret = strcmp(lf.lfFaceName, "MS Shell Dlg 2"); > + ok(!ret, "expected MS Shell Dlg 2 got %s\n", lf.lfFaceName); Please add tests for the full name too. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] comctl32/tests: Fix propsheet and listview tests which depend on being in foreground.
by Bernhard Übelacker May 7, 2014

May 7, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, the comctl32:propsheet and comctl32:listview are regularly failing on the Windows testbots. This is visible in these test runs with an "empty" patch to these tests: https://testbot.winehq.org/JobDetails.pl?Key=6828 https://testbot.winehq.org/JobDetails.pl?Key=6829 This is because windows forbids them to get into foreground. This patch is working around this by simulating an ALT key press and then calling SetForegroundWindow. These are the results with an earlier revision of this patch: https://testbot.winehq.org/JobDetails.pl?Key=6832 https://testbot.winehq.org/JobDetails.pl?Key=6833 Kind regards, Bernhard -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTaVcbAAoJEOlvol+DpkHmDb8IAKD/G0FWgDP8v44SpfqhHY2W 0g8fCzJY6/GhjweV6Mybwqx/YmeBwmc8qvRuHshDUm8WWZbI6yH14LEGz5GwbccI XH/kJgiqqaJH8AiCQM6chF+JBAz3URf9SsAsuDKBjNmpHSMkPAhC/JXecI43GMyX E2AoggKh6DXtEq3yOnGJIRSMAhGPJGYP1Vny5+rq6+rvg2DpNdGI11Xk4oCVgJvc cYCk3yVNKquv4JW8vg80ZJboglDff7omTBLJdF5Nkk5xSGY4iV7amp9CChEJN33N lsohSyvIXeDWegeCWaXGNGhTPXwuTb56tQG22uR7IxJscT8/cXsDQ4jYvuTHoXM= =hTJp -----END PGP SIGNATURE-----

2 2

Re: shell32: Use SW_HIDE with ShellExecuteA in tests.
by Marvin May 7, 2014

May 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6894 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1220: Test failed: expected 1 args, got 4 === w8 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\wtDFC3.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\wtDFC3.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2111: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtDF45.tmp\wtDFC3.tmp" Exec") succeeded: rc=42

1 0

Re: [PATCH 1/2] include: Added atlcom.h
by Vincent Povirk May 7, 2014

May 7, 2014

I think you should add this new header to include/Makefile.in.

2 1

Re: [PATCH] user32: Don't depend on HMENU being valid for popup menus
by Vincent Povirk May 7, 2014

May 7, 2014

if (menu->FocusedItem != NO_SELECTED_ITEM) { + ERR("focused: %u, nitms: 0x%x\n", + menu->FocusedItem, + menu->nItems); menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); menu->FocusedItem = NO_SELECTED_ITEM; } Is this stray debugging code or a real error condition? - * Return the handle of the submenu, or hmenu if no submenu to display. + * Return the handle of the submenu, or menu if no submenu to display. Still slightly inaccurate as the returned submenu is no longer a handle. @@ -4787,24 +4770,29 @@ static BOOL SetMenuItemInfo_common(MENUITEM * menu, menu->wID = lpmii->wID; if (lpmii->fMask & MIIM_SUBMENU) { - menu->hSubMenu = lpmii->hSubMenu; - if (menu->hSubMenu) { - POPUPMENU *subMenu = MENU_GetMenu(menu->hSubMenu); - if (subMenu) { - if( MENU_depth( subMenu, 0) > MAXMENUDEPTH) { + if(menu->fType & MF_POPUP){ + if(menu->submenu) + InterlockedDecrement(&menu->submenu->refcount); + } How do we know this isn't the last reference? I'm not sure this frees submenus correctly. If I create a popup menu and add a submenu to it, that submenu has two references (one because it has an HMENU and one because it is a submenu). DestroyMenu should recursively destroy submenus. So it seems to me, destroying a menu needs to destroy the handles to submenus (if they have one) and release its references to them.

2 1

Re: [2/2] dpnet: Implement IDirectPlay8Client Initialize (try 2)
by Stefan Dösinger May 7, 2014

May 7, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-07 03:39, schrieb Alistair Leslie-Hughes: > Hi, Just a rebase. This looks ok to me. It depends on the test added by patch 1 though, so it'll have to wait until the test is sorted out. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTajllAAoJEN0/YqbEcdMwiTYP/icYQO8oZyCNCRTwoJ3Vdsbl mBbpWrXI2pT0ASEj30+WdJ7a7iJvZXc8tVSvvV8UtbQPLBRGI5Y9asJi9rKpNCLb ksP5vXKmsSxUewGGbX+rtYqRS/hL67NSTai1mb/hxkqGmmJqLbchzM3NP+GX4fvv e9w9p/DpfcOXGCrAtvuKSCzFPDwn60IVIIZVXTCnEs6KR3Vvq+NGnxmV9kwtEjCj idZI0cgPXwR/R0ybJdhFJpU3GHiyNWPAhI6kZcXNCv+kP90A6aDJ8rgd3SvcNEyt oxROFT7PsHUJmC72xixpscGMM5DLDijffVmtooTIgGHsM2iC8Yi4B5s+U77P0sBJ 3LGfYH68AIZtAA187A21WM+WLOtWV5vjihHIHxEO9UFmdI1G88f/9bG0n5YRlzkf Rh4xevGBw7/oks3q08uEMY2EwQdCL/NSx1HWNBtbohBKClZv+373cXEY9+lXPbl2 vA6P0KCUHf/JRM9v2b19UG7vffklCoymroQ8i4TD8qksBHdGq640MUqqyQaMfuu4 ZBrJH3Q+VTe79fcPTG4AyQrEUb1Xy+ohNIY5gN4e8UuvydEpcIId5a0Isu04u9Xr 02tjdraySJaW7ELq5+NoegH30O2Q8aJzPkY7aS2lWe+Kt8lgAUG+KKQXF4fKoeSH x6wbbtc5ojYjXXS91b8S =59Gh -----END PGP SIGNATURE-----

1 0

Re: [1/2] dpnet: Add IDirectPlay8Client tests (try 2)
by Stefan Dösinger May 7, 2014

May 7, 2014

Am 2014-05-07 03:39, schrieb Alistair Leslie-Hughes: > Hi, > Changed test_init_dp to return a boolean. Sorry, I was a bit slow with replying to your previous mail. Is there anything that prevents you from having a helper function that creates a new client object for each test? If you share one client object and the tests modify the state, then the tests end up depending on each other. We had a similar situation in the d3d8/9 visual tests (and still have in ddraw:visual), and it leads to hard to debug test failures. If the client object takes too long to create (I'd say > 0.25 seconds) then that's a reason to keep the client around. Otherwise creating a fresh one for each test and destroying it afterwards will really help you in the long run. Somewhat related: > +static BOOL test_init_dp(void) > ... > + hr = CoInitialize(0); > ... > +static void test_cleanup_dp(void) > ... > + CoUninitialize(); > +} I'd move that to the test's main function. (And no, I don't think there's a need to call CoInitialize / CoUninitialize more than once.) Cheers, Stefan

1 0

Re: dplayx: Initial msgtid variable
by Stefan Dösinger May 7, 2014

May 7, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-07 04:08, schrieb Alistair Leslie-Hughes: > + obj->msgtid = 0; > obj->ref = 0; > obj->refA = 0; > obj->ref2 = 0; IMO it would be better to use HEAP_ZERO_MEMORY in the HeapAlloc call a few lines above. This problem will keep coming back when more members are added. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTajXtAAoJEN0/YqbEcdMwF6kP/iJveqvV58YLeyd2bpJKOjim H2dF+Cll8hAayzziokzOhgf6BoMikhnwqQHtXSgZKuGjQl7oF6sy2qCr5wvfl13V bC9Me4DbXE9PEwT2ArEDiGkejg0G7KQ8qFVo6vFNIaRBEt0mgH0bFUntGPtZZgbV 9qT3KgoNGqOw4iI8rzh4ATabu9NizkI+b2UxMY+9lEf/RSur9pnX/XQhjRIvzZKS YT4exS5bdjZXcSN9aEPax9f+VmYKRyVBvo6O5PfdkqQNarFMc5bw6Utkab/0VbQb j5IM5dRdevTsqx1ZdqzAxlDCHEtRlQWR07A0unsg6JuCX8Rwn+lAh78NTozHWwIV qG31CoHV37WJggleZc2Rk5oSatlAVARwX/f2qJ9GA3fv5muJkpThc8HcEvTN1e/V zSmWBLljyF0I6a6a4P8k2Ch9ZmDnmDvIaGaJshnETt+ypgK2T2QI35pb2bh/pGmC ltWvEwRpbATmftl62Bu4511Afo8AGcXEa83SvfukPmHaAtiJ2TNI9/c1vCP/Pvke TeARP1gtvSh3Q7pwcXPIaAry/RLEYmMPJDAoKRkc+FM2O/4gNiUDUBIDeEpKJaB1 BM2HE0/TCrrIEkfE1RI9JseX79uylagiStAIUgKkqMfJxrXA50VX0bLnQq/qtayD vRfIAuYYb3hvpNll1gIT =rA1r -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/2] gdi32: Report unsubstituted font face names.
by Alexandre Julliard May 7, 2014

May 7, 2014

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -5765,6 +5765,11 @@ static BOOL enum_face_charsets(const Family *family, Face *face, struct enum_cha > else > strcpyW(elf.elfFullName, family->FamilyName); > } > + /* Make sure that MS Shell Dlg says "MS Shell Dlg" and not "Tahoma" */ > + if (unsubstituted_face_name) > + { > + lstrcpynW(elf.elfLogFont.lfFaceName, unsubstituted_face_name, LF_FACESIZE); > + } So what happens to the full name in that case? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: Make Treeview Notify the parent on a return key press
by Nikolay Sivov May 7, 2014

May 7, 2014

Quick testing doesn't show this notification, so I'm not convinced it's a right change. Please add a test.

1 0