May 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 8/11] qcap: get the SmartTee filter to a minimally functional level
by Marvin May 28, 2015

May 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13650 Your paranoid android. === w2000pro (32 bit smartteefilter) === The test timed out

1 0

Re: [PATCH 7/11] qcap: implement the SmartTee allocator functions
by Marvin May 28, 2015

May 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13649 Your paranoid android. === w2000pro (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time === wxppro (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time === w7u (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time === w8 (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time

1 0

Re: winex11: Fix ctrl-<symbol> to generate codes below 0x20 where necessary.
by Marvin May 28, 2015

May 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13631 Your paranoid android. === wvistau64 (32 bit input) === input.c:731: Test failed: 0 (a4/0): 10 from 01 -> 00 unexpected input.c:731: Test failed: 0 (a4/0): 11 from 01 -> 00 unexpected input.c:731: Test failed: 0 (a4/0): a0 from 01 -> 00 unexpected input.c:731: Test failed: 0 (a4/0): a2 from 01 -> 00 unexpected

2 1

Save the Date: WineConf on September 19, 20 in Vienna
by Stefan Dösinger May 28, 2015

May 28, 2015

Hi, I am happy to announce that we will have a WineConf again this year: It will be on Saturday September 19th and Sunday September 20th 2015 in Vienna, in the InterCityHotel Wien. I have added some basic information to http://wiki.winehq.org/WineConf2015 , and more detailed information will follow soon. Please help by suggesting talk topics and adding them to the list. I will write another mail to the list once we have an RSVP page set up. Cheers, Stefan

1 2

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 10)
by Stefan Dösinger May 28, 2015

May 28, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I'm sorry for the late review. I completely forgot about this patch (also in the private mail you sent me). It looks good to me, except one issue noted below that I missed earlier. Am 2015-05-23 um 13:22 schrieb Alistair Leslie-Hughes: > index 7e10136..bad84ef 100644 > --- a/dlls/dpnet/address.c > +++ b/dlls/dpnet/address.c > @@ -405,9 +405,58 @@ static HRESULT WINAPI IDirectPlay8AddressImpl_GetComponentByIndex(IDirectPlay8Ad > const DWORD dwComponentID, WCHAR *pwszName, DWORD *pdwNameLen, void *pvBuffer, > DWORD *pdwBufferSize, DWORD *pdwDataType) > { > - IDirectPlay8AddressImpl *This = impl_from_IDirectPlay8Address(iface); > - TRACE("(%p): stub\n", This); > - return DPN_OK; > + IDirectPlay8AddressImpl *This = impl_from_IDirectPlay8Address(iface); > + struct component *entry; > + int namesize; > + > + TRACE("(%p)->(%p %p %p %p)\n", This, pwszName, pvBuffer, pdwBufferSize, pdwDataType); You're not tracing dwComponentID and pdwNameLen here. In particular dwComponentID seems important, as it is the thing that the method call retrieves. > + if(!pdwNameLen || !pdwBufferSize || !pdwDataType) > + return DPNERR_INVALIDPOINTER; > + > + if(dwComponentID > This->comp_count) > + return DPNERR_DOESNOTEXIST; As I've noted in other patches it would be a good idea to write a WARN in error cases, especially in a COM method where +relay can't be used to check return values. You can also print the available and required size in case of DPNERR_BUFFERTOSMALL. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVZvMGAAoJEN0/YqbEcdMww2sP+gJRvmzLAZ4oXx3FJFSPIvpn JsbdhoKeZkmdsTCPQjvfPVAUKj1qSQcm1w9rRFBthZhkVWNgXGDTbsbTmtVRiATz qqoX+MjKKQeguWmgnEiQY0k/NW15kAvUkP/vT1qQfKOyqadXJs1a6gli0zfqHSqO uviq2P5mQ82vvIYbv5rS8tAGBTh/FHd1802tSPcMGXQqrqqjW3UH/rV4DymP33FF IsSpPBt2niCz7jSt6QGg/8R9Q2xK8D2sOOe1CcLvtRzrh7Ws+j0p1B8Y73aX8047 s7Pp/oUgfmcEUGheeD+c1YlAQOW6Xp9urjiCc9Pqp+sJBv9fJ5p40r9A6wXrP/Jb Zkei91cF+XcwuhZysQX/qJCwff2VyqG55cDdS1R7DTva/DSamhFB6jYrRAjotgrT g4ulnkbVR4khDzJRVk4K9rxJ2OPwoUkPVpspjrKzuT7oEm2U31PVHPUQa8qeIWzr b1vLyDnG/Zz+B27yHc9sLfwZm5olWz2XTDht7kZKGMU2FRy1Q2wK0wZ6Q6ekB/f5 jnnQep7DmgsMe4EN175k5L5e3yW/SISk0U2O/VtukKMbZQ/hoIhHw8ieiaAo16MM S6nvCRbHxRCe9vB/0zKt5+5SAzWrTTsdw03qdeFg82PSGi6I/F7RrrQnY76GtYKB gtjHMs5QPp0FZRriR0T0 =MUbC -----END PGP SIGNATURE-----

1 0

Re: [PATCH] kernel32: Return ERROR_CALL_NOT_IMPLEMENTED in GetUserPreferredUILanguages.
by Alexandre Julliard May 27, 2015

May 27, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > On 27/05/15 14:12, Alexandre Julliard wrote: >> Not that it really matters, but I don't see why you'd need to change >> Wine in order to be able to write a test. > > How am I supposed to know if GetUserPreferredUILanguages fails because it's not implemented, > or fails for some other reason? That doesn't matter. You are testing the Windows behavior, so unless there's a Windows version that returns ERROR_CALL_NOT_IMPLEMENTED, you should never need to check for it. Once your test succeeds on Windows, you add todo_wine in places where Wine differs. Whether that's because the function is unimplemented, or because it's implemented but broken, doesn't make any difference as far as the test is concerned. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] msvcp110: Add _File_size implementation and test.
by Piotr Caban May 27, 2015

May 27, 2015

On 05/27/15 04:35, YongHao Hu wrote: > +/* filesystem */ > +static unsigned long long (__cdecl*p_tr2_sys__File_size)(char const*); You should avoid using "long long" type. Please e.g. use ULONGLONG instead. > + mkdir("tr2_test_dir"); > + file = CreateFileA("tr2_test_dir/f1", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); > + SetFilePointerEx(file, large, NULL, FILE_BEGIN); > + SetEndOfFile(file); Please test return values of CreateFile, SetFilePointerEx and SetEndOfFile. > + large.LowPart = 4000000000u; > + large.HighPart = 120; > + file = CreateFileA("tr2_test_dir/f2", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); > + SetFilePointerEx(file, large, NULL, FILE_BEGIN); > + SetEndOfFile(file); > + val = p_tr2_sys__File_size("tr2_test_dir/f2"); > + ok(val == 519396075520 || broken(val == 0), "file_size is %llu\n", val); /* not enough storage on the testbots */ > + CloseHandle(file); Please remove this test. It's not a good idea to create ~500GB file in the tests. > + val = p_tr2_sys__File_size("tr2_test_dir"); > + ok(val == 0, "file_size is %llu\n", val); > + > + val = p_tr2_sys__File_size("tr2_test_dir/not_exists_file"); > + ok(val == 0, "file_size is %llu\n", val); It would be nice to test GetLastError and errno value after this calls. What happens if NULL is passed as the argument? > +ULONGLONG __cdecl tr2_sys__File_size(const char* path) > +{ > + WIN32_FILE_ATTRIBUTE_DATA fad; Please add a trace message. > + if(!GetFileAttributesExA(path, GetFileExInfoStandard, &fad)) > + return (ULONGLONG)0; This cast is not needed, you can just return 0 here. > + if(fad.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) > + return (ULONGLONG)0; > + return ((ULONGLONG)(fad.nFileSizeHigh) << (sizeof(fad.nFileSizeLow)*8)) + fad.nFileSizeLow; I think that it's better to simply write 32 instead of sizeof(fad.nFileSizeLow)*8 here. Thanks, Piotr

2 2

Re: libport: Fix build on PowerPC
by Grazvydas Ignotas May 27, 2015

May 27, 2015

On Tue, May 26, 2015 at 11:16 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > It was broken by recent commits > --- > libs/port/interlocked.c | 15 +++++++++++++++ Maybe we could just drop all this powerpc specific code, especially considering missing cmpxchg64 implementation (better use mutex fallback there) and that some other platforms (ARM/ARM64) don't have any of this anyway and just use the fallbacks. Gražvydas

2 1

Re: [PATCH] kernel32: Return ERROR_CALL_NOT_IMPLEMENTED in GetUserPreferredUILanguages.
by Alexandre Julliard May 27, 2015

May 27, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > I want to include GetUserPreferredUILanguages in a test I'm writing, but can't at present as > it doesn't return the stub error code. Not that it really matters, but I don't see why you'd need to change Wine in order to be able to write a test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] msvcp110: Add _Equivalent implementation and test.
by Piotr Caban May 27, 2015

May 27, 2015

On 05/27/15 04:36, YongHao Hu wrote: > +static void test_tr2_sys__Equivalent(void) > +{ > + BOOL val; > + int i; > + FILE *file; > + struct { > + char const *file_path1; > + char const *file_path2; > + BOOL equivalent; It will make more sense to define it as int. > + } tests[] = { > + { "f1", "tr2_test_dir", -1 }, > + { "tr2_test_dir", "tr2_test_dir", -1 }, > + { "not_exists_file" , "not_exists_file", -1 }, > + { "tr2_test_dir/./f1", "tr2_test_dir/f2", FALSE }, > + { "tr2_test_dir/f1" , "tr2_test_dir/f1", TRUE }, > + { "tr2_test_dir\\f1", "tr2_test_dir/././f1", TRUE }, > + { "tr2_test_dir/../tr2_test_dir/f1", "tr2_test_dir/f1", TRUE }, Please add following test: { NULL, NULL, ... }, { "not_existing_file", "tr2_test_dir/f1", ... } The tests are also failing when run from VirtualBox share. It's caused by the virtual machine bug (their probably generate a random FileIndexHigh/Low every time file is opened). Could you please create the test files inside temp directory to workaround this bug? Cheers, Piotr

1 0