June 2015 - Wine-Devel - list.winehq.org

Re: [3/3] advapi32/tests: Add preliminary event tracing tests.
by Marvin June 8, 2015

June 8, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13996 Your paranoid android. === w2000pro (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wxppro (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2003std (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wvistau64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2008s64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w7u (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w8 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:791: Test failed: Expected ERROR_DISK_FULL, got 87 eventlog.c:798: Test failed: Expected success eventlog.c:806: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wvistau64 (64 bit eventlog) === eventlog.c:695: Test failed: Expected failure eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got -559038737 eventlog.c:755: Test failed: Expected ERROR_INVALID_PARAMETER, got 183 eventlog.c:798: Test failed: Expected success === w2008s64 (64 bit eventlog) === eventlog.c:695: Test failed: Expected failure eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got -559038737 eventlog.c:755: Test failed: Expected ERROR_INVALID_PARAMETER, got 183 eventlog.c:798: Test failed: Expected success

1 0

Re: inetcpl: implement default page button (resend)
by Alexandre Julliard June 8, 2015

June 8, 2015

Jared Smudde <computerwhiz02(a)hotmail.com> writes: > @@ -35,6 +35,7 @@ > WINE_DEFAULT_DEBUG_CHANNEL(inetcpl); > > static const WCHAR about_blank[] = {'a','b','o','u','t',':','b','l','a','n','k',0}; > +static const WCHAR default_home[] = {'h','t','t','p',':','/','/','w','w','w','.','w','i','n','e','h','q','.','o','r','g',0}; This should come from the registry. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msvcirt: Add implementation of streambuf::allocate
by Piotr Caban June 8, 2015

June 8, 2015

On 06/07/15 20:54, Iván Matellanes wrote: > + return CALL_VTBL_FUNC(this, 40, int, (streambuf*), (this)); The code will be easier to read if you define call_streambuf_doallocate macro and use it here. It would be also nice to change order of allocate and doallocate functions. Cheers, Piotr

1 0

Re: [PATCH 2/2] d3dx9_36: Implement triangle filter when create textures
by Nikolay Sivov June 8, 2015

June 8, 2015

On 07.06.2015 23:13, Sergey Isakov wrote: > It is probably not triangle filter but works with similar result so I place it in appropriate places. > As well load surface and volume works with DXTn textures now. External conversion is a stub. > The best test will be graphical. See two sscreenshots: textures made by DxTex.exe (from DirectXSDK), one with point filter, second with triangle filter my version. > PS. About copyright. It is my mathematics. (c)Isakov S.L. > > +#ifdef DXTN_COMPESSION_SUPPORTED > + switch (format) > + { > + case D3DFMT_DXT1: > + if (!wined3d_dxtn_supported()) return NULL; > + return encode ? wined3d_dxt1_encode : wined3d_dxt1_decode; This diff is not against wine-git tree, there's no wined3d_dxtn_supported() funtion in wine.

1 0

Re: [PATCH 1/2] d3dx9_36: Implemented D3DXSaveVolumeToFile including DDS files
by Nikolay Sivov June 8, 2015

June 8, 2015

On 07.06.2015 23:02, Sergey Isakov wrote: > I decided to improve builtin d3dx9_36 library with support of more file > formats, texture formats, volume textures. It's not your work though, it looks to me like 3 or so patches from Christian Costa squashed together. Why didn't you mention it?

1 0

Re: [1/3] ws2_32: Fix uninitialized memory access in do_poll (Coverity).
by Nikolay Sivov June 7, 2015

June 7, 2015

On 30.05.2015 18:20, Sebastian Lackner wrote: > --- > dlls/ws2_32/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I guess it fixes a warning, but timeout == 0 means no timeout and you don't need a timestamp. select() is the only user of it, and it has this: --- if (ws_timeout) timeout = (ws_timeout->tv_sec * 1000) + (ws_timeout->tv_usec + 999) / 1000; ret = do_poll(pollfds, count, timeout); --- so probably 0 value should be handled differently within a loop, or need to have a separate case that call poll() once and return right away.

1 0

programs/regsvr32: Do not set wsCommandLine multiple times
by Hugh McMaster June 7, 2015

June 7, 2015

Please disregard this patch. The functionality is still needed.

1 0

Re: include: Convert vfw.h to vfw.idl.
by Nikolay Sivov June 7, 2015

June 7, 2015

Hi, I see it went to pending, so let me suggest something. We need this idl mostly for automated proxy/stub generation and registration, right? Maybe we could introduce an idl that contains interfaces only and not all regular header stuff that vfw.h is made of. I would probably work to duplicate interfaces locally at dll level, and leave header alone.

2 1

Wineconf: workshop(s)?
by Marcus Meissner June 7, 2015

June 7, 2015

Hi, I am wondering if it makes sense to hold a workshop / hack session and how to. As we seem to be accustomed to working as single developers this is a bit hard, also "making good use of available time" is a factor. Do we have scenarios where some hours of short term working together would benefit us? - We had regression triaging some years ago which was working okish I think, but might not have been the best use of time. - We also had a "make all tests green on my laptop" shared activity, which was also a bit useful. - Bug triaging is not really a team activity, although if its necessary we could just force everyone present to do it for some hours. - other things? Ciao, Marcus

2 1

Re: inetcpl: implement default page button (try 2)
by Andrew Eikum June 5, 2015

June 5, 2015

Wine doesn't use the L string prefix, because unfortunately some compilers don't support it. Your previous patch has been marked Pending: <http://source.winehq.org/patches/>. I'd wait for another commit release cycle on Monday to see if that changes. Andrew On Fri, Jun 05, 2015 at 12:59:17PM -0500, Jared Smudde wrote: > This patch implements the button default page to set back the default homepage is the user changes the homepage. > --- >

1 0