June 2015 - Wine-Devel - list.winehq.org

Re: shlwapi: Fix error handling in IUnknown_GetClassID (Coverity)
by Marvin June 3, 2015

June 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13825 Your paranoid android. === w2000pro (32 bit ordinal) === ordinal.c:3225: Test failed: got wrong clsid {cccccccc-cccc-cccc-cccc-cccccccccccc} === wxppro (32 bit ordinal) === ordinal.c:3225: Test failed: got wrong clsid {cccccccc-cccc-cccc-cccc-cccccccccccc} === w2003std (32 bit ordinal) === ordinal.c:3225: Test failed: got wrong clsid {cccccccc-cccc-cccc-cccc-cccccccccccc}

1 0

Re: [PATCH 2/5] wined3d: Clamp per-vertex point size in vertex shaders.
by Henri Verbeet June 3, 2015

June 3, 2015

On 2 June 2015 at 16:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -6711,7 +6721,8 @@ static void set_glsl_shader_program(const struct wined3d_context *context, const > WORD map = vshader->reg_maps.input_registers; > struct wined3d_string_buffer *tmp_name = string_buffer_get(&priv->string_buffers); > > - reorder_shader_id = generate_param_reorder_function(priv, vshader, pshader, gl_info); > + reorder_shader_id = generate_param_reorder_function(priv, vshader, pshader, > + state->gl_primitive_type == GL_POINTS && vshader->reg_maps.point_size, gl_info); This works because "state->gl_primitive_type == GL_POINTS" is mirrored in struct vs_compile_args, but it isn't necessarily very obvious or pretty.

2 2

Re: [PATCH 3/5] wined3d: Handle point sprites with PS 3.0.
by Henri Verbeet June 3, 2015

June 3, 2015

On 2 June 2015 at 16:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + else if (args->pointsprite && shader_match_semantic(semantic_name, WINED3D_DECL_USAGE_TEXCOORD)) > + shader_addline(buffer, "ps_in[%u].xy = vec2(gl_PointCoord.x, gl_PointCoord.y);\n", input->register_idx); Why not "ps_in[%u].xy = gl_PointCoord.xy;\n"? Also, do the z and w components have a defined value?

2 1

Re: [1/2] msvcirt: Add initial implementation of streambuf (try 3)
by Piotr Caban June 3, 2015

June 3, 2015

On 06/03/15 13:50, Iván Matellanes wrote: > +DEFINE_RTTI_DATA0(streambuf, 0, ".?AVstreambuf@@") You need to call init_streambuf_rtti function to initialize RTTI in 64-bit case. Cheers, Piotr

1 0

Re: [1/2] msvcirt: Add initial implementation of streambuf (try 2)
by Piotr Caban June 3, 2015

June 3, 2015

On 06/02/15 18:20, Iván Matellanes wrote: > +/* ?seekoff(a)streambuf@@UAEJJW4seek_dir(a)ios@@H(a)Z */ > +/* ?seekoff(a)streambuf@@UEAAJJW4seek_dir(a)ios@@H(a)Z */ > +DEFINE_THISCALL_WRAPPER(streambuf_seekoff, 16) > +long __thiscall streambuf_seekoff(streambuf *this, long offset, int dir, int mode) > +{ > + FIXME("(%p %ld %d %d): stub\n", this, offset, dir, mode); > + return EOF; > +} You can't use long type here, please use LONG instead (it's used also in some other functions). Thanks, Piotr

1 0

Re: include: add initial winsta.h
by Austin English June 3, 2015

June 3, 2015

On Tue, May 26, 2015 at 10:21 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin Patch has been pending for several days, is there something I can do to improve it? Nikolay asked in #winehackers where this came from, it's on MSDN: https://msdn.microsoft.com/en-us/library/cc248871.aspx and also in Process Hacker's source: http://processhacker.sourceforge.net/doc/winsta_8h_source.html -- -Austin

2 4

Re: [PATCH 5/5] d3d8/tests: Port the point size test to D3D8.
by Marvin June 2, 2015

June 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13782 Your paranoid android. === w8 (32 bit visual) === visual.c:6788: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 0, 3, size 0). visual.c:6788: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 1, 3, size 0). visual.c:6788: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 2, 3, size 0). visual.c:6788: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 3, 3, size 0). visual.c:6788: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 4, 7, size 0).

1 0

Re: [PATCH 4/5] d3d9/tests: Add more tests for point size.
by Marvin June 2, 2015

June 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13781 Your paranoid android. === w8 (32 bit visual) === visual.c:10462: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 0, 3, size 0). visual.c:10462: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 1, 3, size 0). visual.c:10462: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 2, 3, size 0). visual.c:10462: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 3, 3, size 0). visual.c:10462: Test failed: Expected color 0x0000ffff, got 0x00000000 (case 4, 3, size 0). visual.c:10462: Test failed: Expected color 0x0000ffff, got 0x0000ff00 (case 5, 7, size 0). visual.c:10462: Test failed: Expected color 0x0000ffff, got 0x00000000 (case 6, 7, size 0).

1 0

Re: [2/2] msvcirt/tests: Add initial tests for streambuf (try 2)
by Marvin June 2, 2015

June 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13771 Your paranoid android. === wvistau64 (64 bit msvcirt) === No test summary line found === w2008s64 (64 bit msvcirt) === No test summary line found

1 0

Re: [PATCH 1/3] ntdll: Implemenent ObjectTypeInformation class support in NtQueryObject.
by Nikolay Sivov June 2, 2015

June 2, 2015

On 01.06.2015 12:52, Qian Hong wrote: > Hi, > > This patch fixed QQ crashing on recent Wine. Thanks Sebastian for > improving my patch. > Tested with wine-staging for weeks. > > --- > dlls/ntdll/om.c | 64 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/tests/om.c | 28 +++++++++++----------- > server/directory.c | 5 ---- > server/handle.c | 18 +++++++++++++++ > server/object.h | 5 ++++ > server/protocol.def | 9 ++++++++ > 6 files changed, 110 insertions(+), 19 deletions(-) > > + if (!(status = server_get_unix_name( handle, &unix_name ))) > + { > + static const WCHAR type_fileW[] = {'F','i','l','e','\0'}; > + int type_size = sizeof(type_fileW); > + > + if (len < sizeof(*p)) > + status = STATUS_INFO_LENGTH_MISMATCH; > + else if (len < sizeof(*p) + type_size) > + status = STATUS_BUFFER_OVERFLOW; > + else > + { > + p->TypeName.Buffer = (WCHAR *)(p + 1); > + p->TypeName.Length = type_size - sizeof(WCHAR); > + p->TypeName.MaximumLength = type_size; > + memcpy( p->TypeName.Buffer, type_fileW, type_size ); > + > + } > + if (used_len) *used_len = sizeof(*p) + type_size; > + RtlFreeAnsiString( &unix_name ); > + break; > + } Why do you need a separate server call/special case for files?

2 1