November 2016 - Wine-Devel - list.winehq.org

Re: [v2 PATCH 1/3] dpnet/test: Add IDirectPlay8Client EnumHost tests
by Alexandre Julliard Nov. 16, 2016

Nov. 16, 2016

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +static HRESULT lastAsyncCode = E_FAIL; > +static DPNHANDLE lastAsyncHandle = 0xdeadbeef; > + > +#define CHECK_LAST_ASYNC_OP(hr, handle) \ > + ok(lastAsyncCode == hr, "got 0x%08x\n", lastAsyncCode); \ > + ok(lastAsyncHandle == handle, "got 0x%08x\n", handle); \ > + lastAsyncCode = E_FAIL; lastAsyncHandle = 0xdeadbeef; Please don't define such macros. In this case you should simply spell it out explicitly, it's not a lot of code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v3 PATCH] winex11.drv: import X11's "text/html" as "HTML Format"
by Alexandre Julliard Nov. 16, 2016

Nov. 16, 2016

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > +static char *standardize_text_html( const char *data, size_t size ) > +{ > + char *textHtml = NULL; > + > + /* Firefox uses UTF-16LE with byte order mark. Convert to UTF-8 without the BOM. */ > + if (size >= 2 && ((BYTE*)data)[0] == 0xff && ((BYTE*)data)[1] == 0xfe) > + { > + INT textHtmlSize = WideCharToMultiByte(CP_UTF8, 0, (LPCWSTR)&data[2], (size-2)/2, NULL, 0, NULL, NULL); > + textHtml = HeapAlloc(GetProcessHeap(), 0, textHtmlSize); > + if (textHtml) > + WideCharToMultiByte(CP_UTF8, 0, (LPCWSTR)&data[2], (size-2)/2, textHtml, textHtmlSize, NULL, NULL); > + else > + ERR("out of memory\n"); > + } > + return textHtml; It seems to me that you should still import it even if it's not in Firefox format. -- Alexandre Julliard julliard(a)winehq.org

1 0

Question about wineconf 2016 decisions
by CARLOS RODRIGUEZ Nov. 16, 2016

Nov. 16, 2016

Hi After see alexander julliard wineconf 2016 decisions Only i have ask if CSMT can arrive in wine 2.0 or will be postponed to next wine development cicle wine 2.1 Thanks

3 2

build error on wininet.h on wine testbot
by Daniel Lehman Nov. 16, 2016

Nov. 16, 2016

I'm getting the errors below when submitting a patch to test bot, even though the patch doesn't modify wininet.h full log is https://urldefense.proofpoint.com/v2/url?u=http-3A__testbot.winehq.org_JobD… am I doing something wrong? Thanks daniel Applying patch + git apply --verbose /home/winetest/tools/testbot/var/../var/staging/patch.diff Checking patch dlls/urlmon/tests/uri.c... Checking patch dlls/urlmon/uri.c... Applied patch dlls/urlmon/tests/uri.c cleanly. Applied patch dlls/urlmon/uri.c cleanly. Making test executable + time make -j4 -C dlls/urlmon/tests make: Entering directory `/home/winetest/tools/testbot/var/build-mingw32/dlls/urlmon/tests' i686-w64-mingw32-gcc -c -o uri.o ../../../../wine/dlls/urlmon/tests/uri.c -I. -I../../../../wine/dlls/urlmon/tests \ -I../../../include -I../../../../wine/include -D__WINESRC__ -D_REENTRANT -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -D_WIN32 In file included from ../../../../wine/dlls/urlmon/tests/uri.c:33:0: ../../../../wine/include/wininet.h:1:1: error: stray '\35' in program ../../../../wine/include/wininet.h:1:3: warning: null character(s) ignored [enabled by default] ../../../../wine/include/wininet.h:1:1: error: stray '\210' in program ../../../../wine/include/wininet.h:1:1: error: stray '\377' in program ../../../../wine/include/wininet.h:1:1: error: stray '\377' in program ../../../../wine/include/wininet.h:1:1: error: stray '\200' in program ../../../../wine/include/wininet.h:1:1: error: unknown type name 'b' ../../../../wine/include/wininet.h:1:1: error: stray '\36' in program ../../../../wine/include/wininet.h:1:11: warning: null character(s) ignored [enabled by default] ../../../../wine/include/wininet.h:1:1: error: stray '\210' in program ../../../../wine/include/wininet.h:1:1: error: stray '\377' in program ...

2 1

Steam in Windows 7 mode
by Alex Henrie Nov. 16, 2016

Nov. 16, 2016

Hi all, Everybody at WineConf (myself included) seemed pretty happy about the idea to have Wine use Windows 7 mode by default. However, it looks like Steam does not accept the -no-cef-sandbox parameter in Windows Vista and later. This means that if we switch to Windows 7, most parts of Steam will crash. I see a few options: 1. Ask the Steam developers to make -no-cef-sandbox work in all versions of Windows. 2. Tell users to switch to Windows XP mode before using Steam. 3. Commit some nasty hack to handle the syscall and continue normal processing. This needs further discussion. -Alex

2 1

Re: [17/23] wined3d: Implement return instruction.
by Andrew Wesie Nov. 16, 2016

Nov. 16, 2016

Is the correct thing to add a test to dlls/d3d11/tests/d3d11.c that illustrates the bug and shows that the patch fixes the bug? -Andrew On Mon, Nov 14, 2016 at 5:07 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Rejected". > > This means that the patch has been rejected by a reviewer. You should > have received a mail explaining why it was rejected. You need to fix > the issue and resend the patch, or if you are convinced that your > patch is good as is, you should reply to the rejection message with > your counterarguments. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email. >

2 1

Debugging wine and finding the cause of a crash
by Fabian Maurer Nov. 16, 2016

Nov. 16, 2016

I'm currently trying to get a program to work that doesn't work with wine, causing an access-violation at some unreadable address. The "+seh" output shows that it's the first crash, and "+relay" doesn't help much, since the last calls are "user32.GetKeyState" and similar. I already tried debugging the program, but at the place of the crash there aren't any wine functions called, so I assume it's some earlier parts (e.g. during loading) causing the issue. How do I go about finding which wine functions are the culprit? Any tips for that, how do you investigate such issues? It would be easy if it crashed directly after calling a WinApi function, but since it seems to crash much later in a completely different part of the code, I don't really know how to proceed.

2 2

Re: [PATCH 2/2] ntdll: Added TokenIsAppContainer semi-stub implementation.
by Marvin Nov. 15, 2016

Nov. 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26665 Your paranoid android. === w1064 (32 bit security) === security.c:4035: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4039: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4048: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4035: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4039: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4048: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: [PATCH 1/2] advapi32: Added TokenIsAppContainer tests.
by Marvin Nov. 15, 2016

Nov. 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26664 Your paranoid android. === w1064 (32 bit security) === security.c:4036: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4040: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4049: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4036: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4040: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4049: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: [PATCH] winegstreamer: Fix memory leak in amt_from_gst_caps_video.
by Andrew Eikum Nov. 15, 2016

Nov. 15, 2016

This is an improvement, but I think we should go further and fix leaks in all of the failure cases. The problem is we're using the amt_from_gst_caps_video return value inconsistently. In accept_caps_sink, we unconditionally free the resulting AM_MEDIA_TYPE. But in setcaps_sink, we only free it, via the pin->pmt assignment, if amt_from_gst_caps_video succeeds. I think we should always free the allocated memory in the failure cases in amt_from_gst_caps_video, and then only free the resulting AMT in the calling functions if amt_from_gst_caps_video succeeded. The resulting AMT should never be used or freed if amt_from_gst_caps_video fails. Note that amt_from_gst_caps_audio has the same inconsistent return type handling. I would accept a separate patch to fix this handling, too. (Unlike for video, it doesn't currently matter in practice because of amt_from_gst_caps_audio's implementation.) Does that make sense? Andrew On Mon, Nov 14, 2016 at 11:43:21PM -0700, Alex Henrie wrote: > Cc: Andrew Eikum <aeikum(a)codeweavers.com> > > Coverity #713781, "Variable vih going out of scope leaks the storage it > points to." > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/winegstreamer/gstdemux.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c > index a6a41ab..5d97510 100644 > --- a/dlls/winegstreamer/gstdemux.c > +++ b/dlls/winegstreamer/gstdemux.c > @@ -179,18 +179,21 @@ static gboolean amt_from_gst_caps_audio(GstCaps *caps, AM_MEDIA_TYPE *amt) > > static gboolean amt_from_gst_caps_video(GstCaps *caps, AM_MEDIA_TYPE *amt) > { > - VIDEOINFOHEADER *vih = CoTaskMemAlloc(sizeof(*vih)); > - BITMAPINFOHEADER *bih = &vih->bmiHeader; > + VIDEOINFOHEADER *vih; > + BITMAPINFOHEADER *bih; > gint32 width = 0, height = 0, nom = 0, denom = 0; > GstVideoInfo vinfo; > > if (!gst_video_info_from_caps (&vinfo, caps)) > return FALSE; > width = vinfo.width; > height = vinfo.height; > nom = vinfo.fps_n; > denom = vinfo.fps_d; > > + vih = CoTaskMemAlloc(sizeof(*vih)); > + bih = &vih->bmiHeader; > + > amt->formattype = FORMAT_VideoInfo; > amt->pbFormat = (BYTE*)vih; > amt->cbFormat = sizeof(*vih); > -- > 2.10.2 >

2 1