April 2016 - Wine-Devel - list.winehq.org

Re: ddraw [V2]: Move ComputeSphereVisibilty to ddraw7
by Marvin April 18, 2016

April 18, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22282 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: ddraw: Move ComputeSphereVisibilty to ddraw7
by Marvin April 18, 2016

April 18, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22281 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: d3dxof & d3dx9_36: Unknown spelling fixes.
by Matteo Bruni April 17, 2016

April 17, 2016

2016-04-15 14:29 GMT+02:00 Francois Gouget <fgouget(a)free.fr>: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > dlls/d3dx9_36/tests/shader.c | 2 +- > dlls/d3dxof/tests/d3dxof.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) The changes look fine but could you please split the patch in two?

1 0

Re: [PATCH 6/6] d3dx9: Add test for D3DXSHMultiply3 arguments aliasing.
by Matteo Bruni April 17, 2016

April 17, 2016

2016-04-14 14:10 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: A few nitpicks: > + const FLOAT expected_aliased[20] = > + { 454.092499f,2.126404f, 5.570401f, 15.330379f, 22.796087f, 43.604126f, > + 4.273841f, 175.772034f, 237.672729f, 1.09f, 1.1f, 1.11f, 1.12f, 1.13f, > + 1.14f, 1.15f, 1.16f, 1.17f, 1.18f, 1.19f }; You can use just 'float' and the indentation style we use in "modern" code. You can fixup the previous array declaration too if you want but it's also fine if you don't. > + for (i = 0; i < 20; i++) > + c[i] = a[i]; > + D3DXSHMultiply3(c, c, b); > + for (i = 0; i < 20; i++) > + ok(relative_error(c[i], expected_aliased[i]) < admitted_error, "Expected[%d] = %f, received = %f\n", i, expected[i], c[i]); This line is too long.

1 0

Re: [PATCH 3/6] d3dx9: D3DXQuaternionSquadSetup should support arguments aliasing.
by Matteo Bruni April 17, 2016

April 17, 2016

2016-04-14 14:10 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: Neither of those are your faults, but since you're at it... > - if ( D3DXQuaternionDot(pq0, pq1) < 0.0f ) > + if (D3DXQuaternionDot(pq0, pq1) < 0.0f) > temp2 = add_diff(&zero, pq0, -1.0f); > else > temp2 = *pq0; also remove the double space. > @@ -1634,7 +1635,9 @@ void WINAPI D3DXQuaternionSquadSetup(D3DXQUATERNION *paout, D3DXQUATERNION *pbou > temp1.z *= -0.25f; > temp1.w *= -0.25f; > D3DXQuaternionExp(&temp1, &temp1); > - D3DXQuaternionMultiply(pbout, pcout, &temp1); > + D3DXQuaternionMultiply(pbout, &cout, &temp1); > + *paout = aout; > + *pcout = cout; > > return; > } Please also remove the unnecessary return.

1 0

Re: [v12 4/4] d3dx9: Implement setting named shader constants in effect.
by Matteo Bruni April 17, 2016

April 17, 2016

2016-04-14 12:30 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: A bunch of nitpicks: > + for (i = 0; i < parameters_count; i++) ++i > + TRACE("sampler %s, register index %u, state count %u.\n", params[i]->name, > + cdesc[i].RegisterIndex, sampler->state_count); You probably want to use debugstr_a(). > +static HRESULT set_shader_constants_device(struct IDirect3DDevice9 *device, struct d3dx_regstore *rs, > + D3DXPARAMETER_TYPE type, enum pres_reg_tables table) > +{ > + unsigned int start, n; Better to call it "count" for consistency IMO. > + if (!n) > + continue; That works but a break seems clearer.

1 0

Re: d3d9/tests: Spelling fixes for a couple of ok() calls.
by Marvin April 16, 2016

April 16, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22235 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [2/2] kernel32/tests: Port stack commit tests to x86_64.
by Alexandre Julliard April 15, 2016

April 15, 2016

Sebastian Lackner <sebastian(a)fds-team.de> writes: > START_TEST(virtual) > { > +#ifdef __x86_64__ > + static const char code_current_teb[] = { > + 0x65, 0x48, 0x8b, 0x04, 0x25, 0x30, 0x00, 0x00, 0x00, 0xc3 }; > +#endif It would be cleaner to use the existing inline function from winnt.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] wined3d: Implement texture DC creation on top of D3DKMTCreateDCFromMemory().
by Marvin April 14, 2016

April 14, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22198 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 2/6] wined3d: Implement texture DC creation on top of D3DKMTCreateDCFromMemory().
by Marvin April 14, 2016

April 14, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22197 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0