April 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] dwrite/tests: Some basic tests for fontface references
by Marvin April 19, 2016

April 19, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22329 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Ignore invalid exit_frame when exiting thread.
by Alexandre Julliard April 19, 2016

April 19, 2016

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > When applications switch to a custom stack, exit_frame is not necessarily > valid anymore. How does it become invalid? Does the app unmap the previous stack? -- Alexandre Julliard julliard(a)winehq.org

2 6

[PATCH] Added Nvidia GT 9700M
by Kim Malmo April 19, 2016

April 19, 2016

Thanks for your feedback Henri. By looking at similar cards in the code I found the GT/GTS description were often omitted from mobile (M) cards. I wanted to keep the same text formatting. This is indeed the GT version and I can add that to the patch. I will sign off the next patch, still getting to grips with git. -- Date: Mon, 18 Apr 2016 19:00:33 +0200 From: Henri Verbeet<hverbeet(a)gmail.com> To: wine-devel<wine-devel(a)winehq.org> Cc: Kim Malmo<kimmalmo(a)protonmail.ch> Subject: Re: [PATCH] Added Nvidia GT 9700M Message-ID: <CAOsNvwyqyR1swwYaPUhiOpu7+TtBRuC9yg33Zi4+KYE1J0EyEw(a)mail.gmail.com> Content-Type: text/plain; charset=UTF-8 On 18 April 2016 at 18:39, Kim Malmo<berencamlost(a)msn.com> wrote: > From: Kim Malmo<kimmalmo(a)protonmail.ch> > > --- > dlls/wined3d/directx.c | 2 ++ > dlls/wined3d/wined3d_private.h | 1 + > 2 files changed, 3 insertions(+) > You're missing the Signed-off-by line. Passing -s to format-patch will add it. > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9700M, "NVIDIA GeForce 9700M", DRIVER_NVIDIA_GEFORCE8, 512 }, Is that the correct description string for the card? I'm only finding references to the 9700M GT and 9700M GTS.

2 2

Re: [PATCH 04/10] wined3d: Add support for rendering to 2D array textures.
by Henri Verbeet April 19, 2016

April 19, 2016

On 19 April 2016 at 00:01, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Layered rendering is not supported yet. > > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/wined3d/context.c | 84 +++++++++++++++++++++++++----------------- > dlls/wined3d/directx.c | 6 +++ > dlls/wined3d/wined3d_private.h | 5 ++- > 3 files changed, 60 insertions(+), 35 deletions(-) > This one conflicts with 121430.

1 0

Re: [PATCH 2/2] include/wincon.h: add some undocumented prototypes
by Hugh McMaster April 19, 2016

April 19, 2016

On Tuesday, 19 April 2016 11:25 AM UTC+10, Austin English wrote: > +/* Undocumented */ > +WINBASEAPI DWORD WINAPI GetNumberOfConsoleFonts(void); [...] > +/* Undocumented */ > +WINBASEAPI BOOL WINAPI SetConsoleFont(HANDLE, DWORD); [...] > +/* Undocumented */ > +WINBASEAPI BOOL WINAPI SetConsoleIcon(HICON); > +WINBASEAPI BOOL WINAPI SetConsoleMode(HANDLE,DWORD); As with your previous patch, these functions can only be called via GetModuleHandle and GetProcAddress on Windows, so they shouldn't be included in wincon.h. -- Hugh McMaster

1 1

RE: [PATCH 1/2] kernel32: add GetConsoleFontInfo stub
by Hugh McMaster April 19, 2016

April 19, 2016

On Tuesday, 19 April 2016 11:25 AM, Austin English wrote: >+BOOL WINAPI GetConsoleFontInfo(HANDLE hOutput, BOOL bMaximize, DWORD numFonts, CONSOLE_FONT *info) >+{ >+ FIXME("(%p %d %u %p): stub!\n", hOutput, bMaximize, numFonts, info); >+ SetLastError(ERROR_CALL_NOT_IMPLEMENTED); >+ return FALSE; >+} Please add this function after the GetConsoleFontSize function. We should keep the "Ex" functions in their own group at the bottom of console.c. Also, avoid Hungarian notation for bMaximize. That's okay for the HANLDE, although it should be hConsole. to match the surrounding code. >+/* Undocumented */ >+WINBASEAPI BOOL WINAPI GetConsoleFontInfo(HANDLE, BOOL, DWORD, CONSOLE_FONT *); I can't check right now, but I'm fairly certain GetConsoleFontInfo should not be included in wincon.h. IIRC, this function cannot be called directly from a console program, only via GetModuleHandle and GetProcAddress. -- Hugh McMaster

1 0

Re: [PATCH 4/4] inetcomm/tests: Add IMimeMessage SetOption tests
by Marvin April 19, 2016

April 19, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22311 Your paranoid android. === wvistau64 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w864 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w1064 (64 bit mimeole) === Found no trace of the test summary line or of a crash

1 0

Re: ddraw/tests: A spelling fix for a d3d ok() message.
by Marvin April 19, 2016

April 19, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22306 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: advapi32/tests: Some spelling fixes for the security ok() messages.
by Marvin April 19, 2016

April 19, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22304 Your paranoid android. === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: [Tools] testbot/TestAgent: Better indicate the file transfer position/range in case of errors.
by Francois Gouget April 19, 2016

April 19, 2016

Should I resend or change this patch? On Mon, 11 Apr 2016, Francois Gouget wrote: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > testbot/lib/WineTestBot/TestAgent.pm | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm > index 74e7395..82ca97f 100644 > --- a/testbot/lib/WineTestBot/TestAgent.pm > +++ b/testbot/lib/WineTestBot/TestAgent.pm > @@ -486,7 +486,7 @@ sub _RecvFile($$$$) > if (!defined $r) > { > alarm(0); > - $self->_SetError($FATAL, "got a network error while receiving '$Filename' ($self->{rpc}:$Name:$Pos/$Size): $!"); > + $self->_SetError($FATAL, "got a network error while receiving '$Filename' ($self->{rpc}:$Name:$Pos+$s/$Size): $!"); > return; # out of eval > } > if ($r == 0) > @@ -501,7 +501,7 @@ sub _RecvFile($$$$) > if (!defined $w or $w != $r) > { > alarm(0); > - $self->_SetError($ERROR, "an error occurred while writing to '$Filename' ($self->{rpc}:$Name:$Pos/$Size): $!"); > + $self->_SetError($ERROR, "an error occurred while writing to '$Filename' ($self->{rpc}:$Name:$Pos+$r/$Size): $!"); > $self->_SkipRawData($Name, $Remaining); > return; # out of eval > } > @@ -806,7 +806,7 @@ sub _SendFile($$$$) > if (!defined $r) > { > alarm(0); > - $self->_SetError($FATAL, "an error occurred while reading from '$Filename' ($self->{rpc}:$Name:$Pos/$Size): $!"); > + $self->_SetError($FATAL, "an error occurred while reading from '$Filename' ($self->{rpc}:$Name:$Pos+$s/$Size): $!"); > return; # out of eval > } > if ($r == 0) > @@ -821,7 +821,8 @@ sub _SendFile($$$$) > if (!defined $w or $w != $r) > { > alarm(0); > - $self->_SetError($FATAL, "got a network error while sending '$Filename' ($self->{rpc}:$Name:$Pos+$s/$Size): $!"); > + # Overwrite _Write()'s error message with a more appropriate one > + $self->_SetError($FATAL, "got a network error while sending '$Filename' ($self->{rpc}:$Name:$Pos+$r/$Size): $!"); > return; # out of eval > } > } > -- > 2.8.0.rc3 > > > -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1