April 2016 - Wine-Devel - list.winehq.org

Re: [tools] winemono.php: Set default version to 4.6.2.
by Alexandre Julliard April 6, 2016

April 6, 2016

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -4,7 +4,7 @@ > */ > > // Default version if none given > -$sVersion = '4.6.0'; > +$sVersion = '4.6.2'; Do we need this? Is there anything that actually uses the default version? -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [4/4] webservices: Always skip comment and empty text nodes in WsReadType.
by Sebastian Lackner April 6, 2016

April 6, 2016

On 06.04.2016 14:09, Hans Leidekker wrote: > + if ((hr = read_node( reader ) != S_OK)) return hr; Only moved by your patch, but this looks like a typo.

1 0

Re: [3/4] webservices: Reset the read position if an opening bracket is not followed by a valid name character.
by Sebastian Lackner April 6, 2016

April 6, 2016

On 06.04.2016 14:09, Hans Leidekker wrote: > +static inline void read_rewind( struct reader *reader, unsigned int count ) > +{ > + while (reader->read_pos && count) > + { > + reader->read_pos--; > + count--; > + } > +} I know its also done similar in the function above, but it still looks weird to me. Is it really necessary to unroll simple math functions like addition and subtraction?

1 0

Re: user32: Use top level window as dialog parent for modal dialogs.
by Dmitry Timoshkov April 6, 2016

April 6, 2016

Hi Jacek, Jacek Caban <jacek(a)codeweavers.com> wrote: > This is part of the fix for bug 40282. Could you please add actual tests that show the handling of disabled window state? Neither current tests nor the new ones actually check that at all, having such tests would prevent new regressions in this area. Feel free to use my tests from the staging repository as a base if desired, or write your own ones that use the same approach. -- Dmitry.

4 23

Re: krnl386.exe16: Do not reassign default handles after they got closed.
by Alexandre Julliard April 6, 2016

April 6, 2016

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -363,7 +363,7 @@ HFILE16 WINAPI _lclose16( HFILE16 hFile ) > } > TRACE("%d (handle32=%p)\n", hFile, dos_handles[hFile] ); > CloseHandle( dos_handles[hFile] ); > - dos_handles[hFile] = 0; > + dos_handles[hFile] = (hFile < 5) ? INVALID_HANDLE_VALUE : 0; This will cause functions that take default handles to not return the correct errors. Is that really how it's supposed to work? What bug is this for? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: user32: Use top level window as dialog parent for modal dialogs.
by Marvin April 5, 2016

April 5, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21903 Your paranoid android. === w864 (64 bit win) === win.c:8544: Test failed: msg.message = 320

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLWindow6::postMessage semi-stub implementation.
by Marvin April 5, 2016

April 5, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21874 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

FW: [PATCH 1/2] ucrtbase: Add _get_initial_wide_environment
by Daniel Lehman April 4, 2016

April 4, 2016

ignore - didn't sign. Will resend later

1 0

Wine Download Server
by Nathan April 4, 2016

April 4, 2016

I am having difficulty downloading the three files: https://dl.winehq.org/wine/wine-appdb-*.tar.gz https://dl.winehq.org/wine/wine-bugzilla-*.tar.gz https://dl.winehq.org/wine/wine-wiki-*.xml.gz * not part of the actual file names.

6 10

Re: [PATCH 1/2] ntoskrnl.exe: add PsRemoveLoadImageNotifyRoutine stub
by Sebastian Lackner April 4, 2016

April 4, 2016

On 04.04.2016 02:59, Austin English wrote: > /*********************************************************************** > + * PsRemoveLoadImageNotifyRoutine (NTOSKRNL.EXE.@) > + */ > + NTSTATUS WINAPI PsRemoveLoadImageNotifyRoutine(PLOAD_IMAGE_NOTIFY_ROUTINE NotifyRoutine) > + { > + FIXME( "stub: %p\n", NotifyRoutine ); > + return STATUS_SUCCESS; > + } Its too late to fix it now, but please check the formatting a bit more careful the next time. Some lines contain an unnecessary space at the beginning.

1 0