April 2016 - Wine-Devel - list.winehq.org

Re: kernel32: add GetVolumeInformationByHandleW stub
by Nikolay Sivov April 4, 2016

April 4, 2016

> +@ stdcall GetVolumeInformationByHandleW(ptr wstr long ptr ptr ptr wstr long) All string buffers are out parameters. > + FIXME("%p %s %d %p %p %p %s %d\n", handle, debugstr_w(volnamebuf), volnamesize, volserial, maxlength, flags, debugstr_w(fsnamebuf), fsnamesize); Should be fixed too.

1 0

Re: [PATCH] msvcr120: Add remainder (try 2)
by Piotr Caban April 4, 2016

April 4, 2016

On 04/04/16 17:05, Daniel Lehman wrote: > Try2: handle y == 0 You should probably also check if x and y is finite (I haven't tested it myself). Thanks, Piotr

1 0

Re: [PATCH] ucrtbase: Add some wide functions called on startup
by Piotr Caban April 4, 2016

April 4, 2016

The functions looks like stubs. Is this is a correct implementation? If not please change TRACE to FIXME. Thanks, Piotr

2 1

Re: [PATCH 2/2] msvcr120: Add remainder
by Piotr Caban April 4, 2016

April 4, 2016

On 04/02/16 02:09, Daniel Lehman wrote: > +/********************************************************************* > + * remainder (MSVCR120.@) > + */ > +double CDECL MSVCR120_remainder(double x, double y) > +{ > +#ifdef HAVE_REMAINDER > + return remainder(x, y); > +#else > + FIXME( "not implemented\n" ); > + return 0.0; > +#endif Please handle y==0 case. Thanks, Piotr

1 0

Re: [PATCH] wininet: Dont fail on invalid Certificates when masking errors.
by Jacek Caban April 4, 2016

April 4, 2016

Hi Alistair, On 04/04/16 11:48, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/wininet/netconnection.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c > index 7305860..723705a 100644 > --- a/dlls/wininet/netconnection.c > +++ b/dlls/wininet/netconnection.c > @@ -200,7 +200,10 @@ static DWORD netconn_verify_cert(netconn_t *conn, PCCERT_CONTEXT cert, HCERTSTOR > conn->server->cert_chain = NULL; > } > if(conn->mask_errors) > + { > conn->server->security_flags |= conn->security_flags & _SECURITY_ERROR_FLAGS_MASK; > + err = ERROR_SUCCESS; > + } I don't think we should do that. mask_errors means that we should combine errors, not ignore them. I don't know what you're trying to fix, but I'd suggest to concentrate on error source (maybe there shouldn't be an error in the first place or it should be ignored due to security_flags). If you think that the error is right, maybe we don't handle failure correctly. Cheers, Jacek

2 1

Re: [PATCH] comctrl32/tooltips: AddTool doesn't fails on empty TTTOOLINFO structure
by Marvin April 4, 2016

April 4, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21855 Your paranoid android. === wxppro (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2003std (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === wvistau64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2008s64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7u (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7pro64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w8 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w864 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w1064 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === wvistau64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2008s64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7pro64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w864 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w1064 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed

1 0

Re: sfc_os: add SRSetRestorePointA/W stubs
by Alistair Leslie-Hughes April 4, 2016

April 4, 2016

Hi Austin, On 04/04/16 10:24, Austin English wrote: > For https://bugs.winehq.org/show_bug.cgi?id=40397 / > https://bugs.winehq.org/show_bug.cgi?id=40410 > > > +BOOL WINAPI SRSetRestorePointA(RESTOREPOINTINFOA *restorepoint, STATEMGRSTATUS *status) >... > + return 0; > +} > It would be better to return TRUE or FALSE for the BOOL type. Best Regards Alistair

1 0

wine-1.8.2-rc2 Available
by Michael Stefaniuc April 3, 2016

April 3, 2016

Hello, I have pushed now wine-1.8.2-rc2 (Warning: forced update). Many thanks to Sebastian for reviewing 1.8.2-rc1. As I've missed 3 dependency patches for the fix for bug #13683 I have rebased the stable branch and added a fix for a fix and two test patches. The 1.8.2-rc1 tag is still available. Missed dependencies: 85faafc user32: Ensure that button responds only to changes in WM_CAPTURECHANGED handler. 0bea2f7 comctl32: Ensure that trackbar respond only to changes in WM_CAPTURECHANGED handler. ff063d9 comctl32: Ensure that toolbar respond only to changes in WM_CAPTURECHANGED handler. Fix: 97c70c8 wined3d: Fix driver version check. Tests 1bebee9 kernel32/tests: Add test to show that CompareStringW aborts on first non-matching character. 32f7298 kernel32/tests: Add tests for RtlInterlockedPushListSList[Ex]. The changes excluding tests are: comctl32/toolbar.c | 1 + comctl32/trackbar.c | 1 + user32/button.c | 1 + wined3d/directx.c | 3 +-- 4 files changed, 4 insertions(+), 2 deletions(-) bye michael

1 0

Re: [PATCH] loader: Fix wld_prctl prototype.
by Qian Hong April 3, 2016

April 3, 2016

On Mon, Apr 4, 2016 at 1:42 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > reserve debugging Typo, should be "Reverse Debugging". One can debug with "backward step in" and "backward next". Maybe useful for Wine developers. -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 1/2] t2embed: Implement TTIsEmbeddingEnabledForFacename()
by Dmitry Timoshkov April 2, 2016

April 2, 2016

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + if (!strcasecmp(name, facename)) strcasecmp() is not suitable for strings in windows encodings. -- Dmitry.

1 0