September 2016 - Wine-Devel

Re: [10/11] kernel32: Implement LCMAP_FULLWIDTH.
by Alexandre Julliard Sept. 28, 2016

Sept. 28, 2016

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -3246,6 +3385,24 @@ INT WINAPI LCMapStringEx(LPCWSTR name, DWORD flags, LPCWSTR src, INT srclen, LPW > goto done; > } > > + if (flags & LCMAP_FULLWIDTH) > + { > + len = min(srclen, dstlen); > + buffer = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + if (!buffer) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return 0; > + } > + srclen = map_to_fullwidth(src, srclen, buffer, len); > + if (!srclen) > + { > + HeapFree(GetProcessHeap(), 0, buffer); > + return 0; > + } > + src = buffer; > + } It seems to me that you should be able to do this without allocating an intermediate buffer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Call glGetIntegerv() through the gl_info function pointer.
by Józef Kucia Sept. 27, 2016

Sept. 27, 2016

On Tue, Sep 27, 2016 at 12:04 AM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Fixes a1e718ccabc7c330dd16c7face78022965b03e20. > > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > dlls/wined3d/directx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 7ab68aa..05e04e8 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -3629,7 +3629,7 @@ static BOOL wined3d_adapter_init_gl_caps(struct wined3d_adapter *adapter, DWORD > > if (gl_version >= MAKEDWORD_VERSION(3, 2)) > { > - glGetIntegerv(GL_CONTEXT_PROFILE_MASK, &context_profile); > + gl_info->gl_ops.gl.p_glGetIntegerv(GL_CONTEXT_PROFILE_MASK, &context_profile); > checkGLcall("Querying context profile"); > } > if (context_profile & GL_CONTEXT_CORE_PROFILE_BIT) FWIW, there are other places where GL functions aren't called through gl_ops. I've got patches to fix others.

1 0

Re: [PATCH v2 1/5] wined3d: Use round() on core profile.
by Henri Verbeet Sept. 27, 2016

Sept. 27, 2016

On 27 September 2016 at 00:04, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > v2: Key the use of the round() builtin on the GLSL version used by the > shader. I'm not sure this is exactly what you had in mind but at least > this looks quite a bit nicer to me than v1. > Close enough. I think you can just use shader_glsl_get_version() and "#version %u" in the places you're currently using shader_glsl_get_version_declaration(), but it doesn't matter that much.

1 0

Re: [PATCH] wined3d: Add NVIDIA GTX 675MX to the GPU list.
by Henri Verbeet Sept. 26, 2016

Sept. 26, 2016

On 24 September 2016 at 00:00, Filip Frąckiewicz <fjfrackiewicz(a)gmail.com> wrote: > - {"NVE4", CARD_NVIDIA_GEFORCE_GTX680}, /* 690 */ > + {"NVE4", CARD_NVIDIA_GEFORCE_GTX680}, /* 690 / 675MX */ It's not wrong, but I don't think this is very useful. In general what's essentially the same GPU is available under many different names and PCI IDs, and the wined3d source code isn't the best place to document those.

2 1

Re: [PATCH] wined3d: Add NVIDIA GTX 980 Ti to the GPU list.
by Henri Verbeet Sept. 26, 2016

Sept. 26, 2016

On 23 September 2016 at 22:56, Filip Frąckiewicz <fjfrackiewicz(a)gmail.com> wrote: > @@ -2160,6 +2162,7 @@ cards_amd_mesa[] = > cards_nvidia_mesa[] = > { > /* Maxwell */ > + {"NV120", CARD_NVIDIA_GEFORCE_GTX980TI}, /* Titan X */ > {"NV124", CARD_NVIDIA_GEFORCE_GTX970}, > {"NV118", CARD_NVIDIA_GEFORCE_840M}, > {"NV117", CARD_NVIDIA_GEFORCE_GTX750}, Please keep these ordered where possible.

2 1

Ancient Parallel Port PIC Programmer - support under newer versions of Wine?
by Bob Wya Sept. 25, 2016

Sept. 25, 2016

Can anyone help out with this user question on the WineHQ Forums? forum.winehq.org/viewtopic.php?f=8&t=27503 Since the programmer used to work - with older versions of Wine - I presume that it might still be possible to get it working? Perhaps starting with parallel port device symlinks in "${WINEPREFIX}/dosdevices" ... Any thoughts? -- Thanks, Robert

2 1

Re: [PATCH 1/5] wined3d: Use round() on core profile.
by Henri Verbeet Sept. 23, 2016

Sept. 23, 2016

On 22 September 2016 at 20:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > dlls/wined3d/directx.c | 5 +++++ > dlls/wined3d/glsl_shader.c | 4 ++-- > dlls/wined3d/wined3d_gl.h | 1 + > 3 files changed, 8 insertions(+), 2 deletions(-) > This works, but I'm not sure it really scales beyond one or two instructions. It also seems to me that what you actually want to know is the GLSL version of the current shader, not entirely unlike shader_glsl_get_version().

1 0

Re: [PATCH 5/5] api-ms-win-service-winsvc-l1-1-0: add dll
by Sebastian Lackner Sept. 22, 2016

Sept. 22, 2016

On 22.09.2016 19:38, Austin English wrote: > +# Generated from /home/austin/win7-SysWOW64/api-ms-win-service-winsvc-l1-1-0.dll by winedump. [...] > +C_SRCS = \ > + api-ms-win-service-winsvc-l1-1-0_main.c Are you sure this is the version you wanted to submit? And where is the main.c file?

1 0

Re: [11/11] kernel32: Implement LCMAP_HALFWIDTH.
by Marvin Sept. 22, 2016

Sept. 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25911 Your paranoid android. === w1064 (32 bit locale) === locale.c:2648: Test failed: LCMapStringEx should fail with bad locale name locale.c:2649: Test failed: unexpected error code -559038737 locale.c:2740: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4476: Test failed: IsValidLocaleName should have failed locale.c:4478: Test failed: IsValidLocaleName should have failed locale.c:4861: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4863: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2648: Test failed: LCMapStringEx should fail with bad locale name locale.c:2649: Test failed: unexpected error code -559038737 locale.c:2740: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4476: Test failed: IsValidLocaleName should have failed locale.c:4478: Test failed: IsValidLocaleName should have failed locale.c:4861: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4863: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [10/11] kernel32: Implement LCMAP_FULLWIDTH.
by Marvin Sept. 22, 2016

Sept. 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25910 Your paranoid android. === w1064 (32 bit locale) === locale.c:2644: Test failed: LCMapStringEx should fail with bad locale name locale.c:2645: Test failed: unexpected error code -559038737 locale.c:2736: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4472: Test failed: IsValidLocaleName should have failed locale.c:4474: Test failed: IsValidLocaleName should have failed locale.c:4857: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4859: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2644: Test failed: LCMapStringEx should fail with bad locale name locale.c:2645: Test failed: unexpected error code -559038737 locale.c:2736: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4472: Test failed: IsValidLocaleName should have failed locale.c:4474: Test failed: IsValidLocaleName should have failed locale.c:4857: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4859: Test failed: For id 7, Expected IVC, got ''

1 0