September 2016 - Wine-Devel

wine-1.8.5-rc1 Available
by Michael Stefaniuc Sept. 17, 2016

Sept. 17, 2016

Hello guys, I have pushed wine-1.8.5-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ By chance it has the same amount (66) of patches like wine-1.8.4-rc1. Nothing fancy in this release. Maybe noticeable is that I went over the fixed bugs in 1.9.[0-4] and cherry-picked some more from that era. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. ---------------------------------------------------------------- Bugs fixed in 1.8.5 (total 59): 16971 Windows Movie Maker 2.x needs ole32.dll.StgOpenPropStg 19538 Microsoft Publisher 2007 and 2010 crash when opening documents/templates (TSF manager 'ITextStoreACPSink' must support QI with 'IID_ITextStoreACPServices') 20896 Use-after-free in DdeClientTransaction in user32 dde tests 23298 Windows utility 'relog.exe' crashes on unimplemented function 'pdh.dll.PdhGetLogFileTypeW' 24645 PDF Factory 3.x/4.x installer fails to install printer drivers (winspool.SetPrinterW lacks support for level 8, global default printer settings) 31693 CAPCOM games using gamepad start with axes X/Y pressed up/left 31913 EasyPal version August 6 2012 crashes on unimplemented function msvcp60.dll.??Dstd@@YA?AV?$complex(a)N@0(a)ABNABV10@@Z 32491 dbghelp doesn't support DW_FORM_flag_present 32936 SmartMusic 2012/2014 crashes on startup (Core Audio adapter 'PKEY_DeviceInterface_FriendlyName' property not supported) 33140 Photos opened in Nikon Capture NX 2.4 have inverted red and blue channel for displaying. 33398 Word / Excel 2010: crash when clicked (2nd or 3rd times) on a link 33457 An integer overflow @line 268 of dsa.c ? 34281 PlotSoft PDFill 10 fails on startup, reports 'No Fonts found under: C:\\windows\\Fonts' (at least one font name in registry must contain 'truetype' token) 34286 dinput doesn't report DIDOI_ASPECT* for joystick axes 34504 __unDName doesn't support function pointer with type "P8" 34507 __unDName doesn't support data type "$$B" 34870 Multiple games and applications crash on unimplemented function msvcr100.dll _crt_debugger_hook (ArchiCAD 16, Far Cry 4) 35286 Borderlands (Steam) crashes on unimplemented function msvcr90.dll._crt_debugger_hook 35824 UltraISO 'ISODrive.sys' crashes in entry point (SCM doesn't start SERVICE_FILE_SYSTEM_DRIVER type services with winedevice hosting process) 35892 sdb2xml (.NET 2.0 app) crashes on unimplemented function apphelp.dll.SdbGetAppPatchDir 36625 can't set text background color in richedit 38276 IsDialogMessage(NULL,...) must always return FALSE 38310 Trackbar control (msctls_trackbar32) does not send WM_CTLCOLORSTATIC as it does in Windows 39034 SuperTux 0.3.5a crashes on startup 39074 IXMLDOMDocument::cloneNode crash 39181 "When Monster Strikes", "The Vanishing of Ethan Carter Redux" require msvcr120.dll._set_FMA3_enable 39195 msvcr120.dll.nextafter is needed by Sonkwo 39475 PhysX 9.15.0428 installer does not run ('advapi32.RegOpenCurrentUser' must return a real handle instead of 'HKEY_CURRENT_USER' for user root key) 39677 Zararadio crashes when it has to change from a playlist to another. 39744 No sound with winepulse.drv in multiple applications when PulseAudio fails to allocate full buffer 39792 Saturn PCB Design Toolkit 6.86 fails to load, reporting missing 'SHCore.dll' dependency (import descriptors with empty thunk list must be ignored) 39823 "fixme:nls:CompareStringEx semi-stub behavor for flag(s) 0x10000000" appears thousands of times in terminal when running the Lego Mindstorms EV3 software 39852 3DMark03: Mother Nature test: waterfall has no transparency if AllwaysOffScreen=disabled 39861 Windows utility 'relog.exe' crashes on unimplemented function 'pdh.dll.PdhBindInputDataSourceW' 39874 Alien Shooter crashes often with access violation 39892 UFile crashes with runtime error when rendering certain pages 39950 Cabal II can't be opened, needs msvcp100.dll.?lowest@?$numeric_limits(a)M@std@@SAMXZ 40034 Linksys usb wireless adapter installer needs wlanapi.dll.WlanEnumInterfaces 40035 VMware shared folders network provider fails loading in MPR 40411 Regedit.exe /e only exports HKLM 40580 TASCAM US-16x08 soundcard controller crashes 40734 Unreal Tournament 3 doesn't quit properly when Pulseaudio is used 40757 GOG Galaxy crashes with unimplemented function api-ms-win-crt-stdio-l1-1-0.dll.__stdio_common_vsnwprintf_s 40758 GOG Galaxy crashes with unimplemented function api-ms-win-crt-runtime-l1-1-0.dll._get_wide_winmain_command_line 40815 comctl32: Leftmost position of trackbar not selectable with mouse, slider initial position wrong 40882 Nvidia GT 740M is not correctly recognized 40905 Multiple applications need api-ms-win-crt-runtime-l1-1-0.dll._get_narrow_winmain_command_line (PCSX2 1.4.0, Battle.Net Launcher) 41010 TVS_TRACKSELECT uses wrong hittest region 41015 comctl32/treeview: Alt-Up/Down keyboard shortcuts don't work 41040 VariantChangeTypeEx lead to error when casting IUnknown(nil) -> IDispatch 41044 Age of Mythology: Extended Edition needs api-ms-win-crt-stdio-l1-1-0.dll.__stdio_common_vswprintf_s 41066 Unhandled page fault in RtlWow64EnableFsRedirectionEx when passed bad *old_value pointer 41079 Hauppauge Capture crashes on unimplemented function cfgmgr32.dll.CM_Get_Version 41094 comctl32/treeview: TVS_FULLROWSELECT style does not work 41103 Fails to parse Extended Properties since it has quotes around its value. 41109 8-bit Armies launches with a very small window 41111 CPU-Z driver needs hal.dll.WRITE_PORT_UCHAR 41165 MiTeC System Information X needs unimplemented function wlanapi.dll.WlanCloseHandle 41182 Don't export QT_QPA_PLATFORM ---------------------------------------------------------------- Changes since 1.8.4: Akihiro Sagawa (1): comctl32: Prevent invalid focus change notifications from LVS_OWNERDATA lists. Alex Henrie (2): ole32: Implement StgCreatePropStg. ole32: Implement StgOpenPropStg. Alistair Leslie-Hughes (1): comctl32/trackbar: Use WM_CTLCOLORSTATIC when painting background. Andrew Church (1): dinput: Report DIDOI_ASPECTPOSITION flag for axes objects. Andrew Eikum (3): winepulse.drv: Buffer data locally when needed. winepulse.drv: Don't hold PA-owned buffer between capture callbacks. mmdevapi: Fix some DEVPKEY definitions. Andrey Melnikov (1): gdi32: Handle NULL filename in GetICMProfileA(). André Hentschel (3): winspool: Implement SetPrinterW for level 8. hal: Add WRITE_PORT_UCHAR stub. msvcrt: Don't continue on demangle failure (Coverity). Austin English (6): pdh: Add PdhGetLogFileTypeA/W stubs. pdh: Add PdhBindInputDataSourceA/W stubs. kernel32: Make CompareStringEx semi-stub flag FIXME only show once. wlanapi: Add a stub for WlanEnumInterfaces. wlanapi: Add WlanCloseHandle() stub. apphelp: Add SdbGetAppPatchDir stub. Benjamin Hodgetts (1): wined3d: Add Nvidia 1XXX range to detection list. Bruno Jesus (1): dinput: Use the correct index to remap the axis. Daniel Lehman (1): ucrtbase: Add some wide functions called on startup. Jacek Caban (2): mshtml: Fixed OnStopBinding if it's called called after we aborted document binding. mshtml: Properly convert VT_NULL to string in get_elem_attr_value_by_dispid. Jeremy Audiger (1): wined3d: Add Nvidia GT 740M to the GPU list. Joerg Schiermeier (1): loader/wine.inf: Correct wrong symlink. Józef Kucia (2): user32/tests: Add more tests for setting window styles. user32: Prevent resetting WS_MINIMIZE through SetWindowLong. Kenneth Haley (1): v4 resend: Riched20: allow setting background text color. Matt Robinson (1): ntdll: Catch page fault in RtlWow64EnableFsRedirectionEx. Nikolay Sivov (21): gdi32: Keep font tables tags defined in one place. gdi32: Support special 'ttcf' tag in GetFontData(). oleaut32: Fix return value when converting from NULL interface pointers. ucrtbase: Added __stdio_common_vsnwprintf_s(). ucrtbase: Added __stdio_common_vswprintf_s(). comctl32/treeview: Handle WM_SYSKEYDOWN. comctl32/treeview: Set hot item when hovering over item, not entire row. ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line. comctl32/trackbar: Update thumb on range change. comctl32/trackbar: Fix mouse position to thumb position conversion rounding. dbghelp: Recognize DW_FORM_flag_present. oledb32: Support quoted values in initialisation strings. setupapi: Added CM_Get_Version(). user32: Handle invalid dialog handles in IsDialogMessage(). gdi32: Append "TrueType" suffix to registry key names. advapi32: Make RegOpenCurrentUser() return real key handles for current SID. msxml3: Fix cloneNode() for document nodes. comctl32/treeview: Fix hot-tracking with TVS_FULLROWSELECT. comctl32/treeview: Fill full row for TVS_FULLROWSELECT style. msctf: Make ITextStoreACPSink a part of context object. msctf: Added stub ITextStoreACPServices support for context ITextStoreACPSink. Pierre Schweitzer (1): mpr: Add support for REG_EXPAND_SZ for providers path. Piotr Caban (7): msvcp100: Add numeric_limits<*>::lowest implementation. msvcp60: Export more complex numbers operators. msvcr120: Add _set_FMA3_enable stub. msvcrt: Add support for member function pointers demangling in unDName function. msvcrt: Add support for $$B datatype description format in unDName. msvcp120: Add vtordisp field to classes with virtual base. msvcrt: Add _crt_debugger_hook implementation. Sebastian Lackner (3): kernel32: Do not inherit QT_* environment variables to Windows environment. ntdll: Skip unused import descriptors when loading libraries. services: Start SERVICE_FILE_SYSTEM_DRIVER services with winedevice. Stefan Dösinger (2): d3d8: Don't validate 2D texture lock coordinates. wined3d: Rotate through swapchain buffers. Thomas Faller (1): dde: Fix use-after-free. Xiaoshan Sun (1): comctl32/dsa: Handle overflow in DSA_InsertItem(). YongHao Hu (1): msvcr120: Enable MSVCRT__nextafterf when _MSVCR_VER>=120. -- Michael Stefaniuc mstefani(a)winehq.org

2 1

Re: user32/tests: Add space for the mask data to prevent failures on Win 8 and 10.
by Marvin Sept. 16, 2016

Sept. 16, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25848 Your paranoid android. === w864 (32 bit cursoricon) === cursoricon.c:2625: Test failed: LoadImage() failed with 0. cursoricon.c:2625: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:2625: Test failed: LoadImage() failed with 0. cursoricon.c:2625: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:2625: Test failed: LoadImage() failed with 0. cursoricon.c:2625: Test failed: LoadImage() failed with 0.

2 1

Re: [6/6] windowscodecs: Fix 32bppGrayFloat to 8bppGray conversion.
by Dmitry Timoshkov Sept. 16, 2016

Sept. 16, 2016

Hi Vincent, Vincent Povirk <madewokherd(a)gmail.com> wrote: > From: Vincent Povirk <vincent(a)codeweavers.com> > > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> I'm not opposed that you're taking my patches from the staging tree, but in this particular case it's not really clear that the bug with converting 32bppGrayFloat to 8bppGray was debugged and found by somebody else. Adding "Spotted by ..." would be enough and appropriate, since for some reason you didn't like the version of the patch in staging and decided to fix the bug in a different way. -- Dmitry.

2 2

Re: libwine: Do not compare strings "ab-c" and a-bc" as equal.
by Marvin Sept. 16, 2016

Sept. 16, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25415 Your paranoid android. === w1064 (32 bit locale) === locale.c:2562: Test failed: LCMapStringEx should fail with bad locale name locale.c:2563: Test failed: unexpected error code -559038737 locale.c:2654: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4384: Test failed: IsValidLocaleName should have failed locale.c:4386: Test failed: IsValidLocaleName should have failed locale.c:4769: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4771: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2562: Test failed: LCMapStringEx should fail with bad locale name locale.c:2563: Test failed: unexpected error code -559038737 locale.c:2654: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4384: Test failed: IsValidLocaleName should have failed locale.c:4386: Test failed: IsValidLocaleName should have failed locale.c:4769: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4771: Test failed: For id 7, Expected IVC, got ''

2 1

Re: [PATCH v2] mpr: Implement connected resources enumeration.
by Alexandre Julliard Sept. 15, 2016

Sept. 15, 2016

Pierre Schweitzer <pierre(a)reactos.org> writes: > @@ -97,7 +99,11 @@ typedef struct _WNetEnumerator > DWORD dwScope; > DWORD dwType; > DWORD dwUsage; > - LPNETRESOURCEW lpNet; > + union > + { > + NETRESOURCEW* net; > + HANDLE* handles; > + }; Please don't use anonymous unions. > @@ -1211,6 +1240,126 @@ static DWORD _enumerateContextW(PWNetEnumerator enumerator, LPDWORD lpcCount, > return ret; > } > > +static DWORD _copyStringToEnumW(WCHAR* source, DWORD* left, void** end) > +{ > + DWORD len; > + void* local = *end; > + > + len = strlenW(source) + 1; > + len *= sizeof(WCHAR); > + if (*left < len) > + return WN_MORE_DATA; > + > + local = (PVOID)((ULONG_PTR)local - len); Please try to use proper pointer arithmetic instead of casting to integer types. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] hid: Stub HidP_TranslateUsagesToI8042ScanCodes
by Sebastian Lackner Sept. 15, 2016

Sept. 15, 2016

On 14.09.2016 14:05, Aric Stewart wrote: > Resolves Bug 39447 > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/hid/hid.spec | 2 +- > dlls/hid/hidp.c | 9 +++++++++ > include/ddk/hidpi.h | 29 +++++++++++++++++++++++++++++ > 3 files changed, 39 insertions(+), 1 deletion(-) > > > > 0001-hid-Stub-HidP_TranslateUsagesToI8042ScanCodes.txt > > > diff --git a/dlls/hid/hid.spec b/dlls/hid/hid.spec > index 4c5e505..2131af2 100644 > --- a/dlls/hid/hid.spec > +++ b/dlls/hid/hid.spec > @@ -39,6 +39,6 @@ > @ stub HidP_SetUsageValue > @ stub HidP_SetUsageValueArray > @ stub HidP_SetUsages > -@ stub HidP_TranslateUsagesToI8042ScanCodes > +@ stdcall HidP_TranslateUsagesToI8042ScanCodes(ptr long long ptr ptr ptr) > @ stub HidP_UnsetUsages > @ stub HidP_UsageListDifference > diff --git a/dlls/hid/hidp.c b/dlls/hid/hidp.c > index 3d7a12e..f42482a 100644 > --- a/dlls/hid/hidp.c > +++ b/dlls/hid/hidp.c > @@ -23,6 +23,7 @@ > #include <stdarg.h> > > #define NONAMELESSUNION > +#include "ntstatus.h" > #define WIN32_NO_STATUS > #include "windef.h" > #include "winbase.h" > @@ -519,3 +520,11 @@ ULONG WINAPI HidP_MaxUsageListLength(HIDP_REPORT_TYPE ReportType, USAGE UsagePag > } > return count; > } > + > +NTSTATUS WINAPI HidP_TranslateUsagesToI8042ScanCodes(USAGE *ChangedUsageList, ULONG UsageListLength, HIDP_KEYBOARD_DIRECTION KeyAction, HIDP_KEYBOARD_MODIFIER_STATE *ModifierState, PHIDP_INSERT_SCANCODES InsertCodesProcedure, VOID *InsertCodesContext) > +{ > + ERR("stub: %p %i %i %p, %p, %p\n", ChangedUsageList, UsageListLength, > + KeyAction, ModifierState, InsertCodesProcedure, InsertCodesContext); Shouldn't this be a FIXME? And why are there only commas between the last three arguments? > + > + return STATUS_NOT_IMPLEMENTED; > +} > diff --git a/include/ddk/hidpi.h b/include/ddk/hidpi.h > index 4cfac61..853cbac 100644 > --- a/include/ddk/hidpi.h > +++ b/include/ddk/hidpi.h > @@ -136,6 +136,34 @@ typedef struct _HIDP_CAPS > USHORT NumberFeatureDataIndices; > } HIDP_CAPS, *PHIDP_CAPS; > > +typedef enum _HIDP_KEYBOARD_DIRECTION { > + HidP_Keyboard_Break, > + HidP_Keyboard_Make > +} HIDP_KEYBOARD_DIRECTION; > + > +typedef struct _HIDP_KEYBOARD_MODIFIER_STATE { > + union { > + struct { > + ULONG LeftControl: 1; > + ULONG LeftShift: 1; > + ULONG LeftAlt: 1; > + ULONG LeftGUI: 1; > + ULONG RightControl: 1; > + ULONG RightShift: 1; > + ULONG RightAlt: 1; > + ULONG RigthGUI: 1; > + ULONG CapsLock: 1; > + ULONG ScollLock: 1; > + ULONG NumLock: 1; > + ULONG Reserved: 21; > + } DUMMYSTRUCTNAME; > + ULONG ul; > + } DUMMYUNIONNAME; > +} HIDP_KEYBOARD_MODIFIER_STATE, *PHIDP_KEYBOARD_MODIFIER_STATE; > + > +typedef BOOLEAN (*PHIDP_INSERT_SCANCODES) (VOID *Context, CHAR *NewScanCodes, ULONG Length); Are you sure that this isn't a STDCALL callback? > + > + > NTSTATUS WINAPI HidP_GetButtonCaps(HIDP_REPORT_TYPE ReportType, PHIDP_BUTTON_CAPS ButtonCaps, PUSHORT ButtonCapsLength, PHIDP_PREPARSED_DATA PreparsedData); > NTSTATUS WINAPI HidP_GetCaps(PHIDP_PREPARSED_DATA PreparsedData, PHIDP_CAPS Capabilities); > NTSTATUS WINAPI HidP_GetUsages(HIDP_REPORT_TYPE ReportType, USAGE UsagePage, USHORT LinkCollection, PUSAGE UsageList, PULONG UsageLength, PHIDP_PREPARSED_DATA PreparsedData, PCHAR Report, ULONG ReportLength); > @@ -144,6 +172,7 @@ NTSTATUS WINAPI HidP_GetValueCaps(HIDP_REPORT_TYPE ReportType, PHIDP_VALUE_CAPS > NTSTATUS WINAPI HidP_InitializeReportForID(HIDP_REPORT_TYPE ReportType, UCHAR ReportID, PHIDP_PREPARSED_DATA PreparsedData, PCHAR Report, ULONG ReportLength); > ULONG WINAPI HidP_MaxUsageListLength(HIDP_REPORT_TYPE ReportType, USAGE UsagePage, PHIDP_PREPARSED_DATA PreparsedData); > NTSTATUS WINAPI HidP_GetScaledUsageValue(HIDP_REPORT_TYPE ReportType, USAGE UsagePage, USHORT LinkCollection, USAGE Usage, PLONG UsageValue, PHIDP_PREPARSED_DATA PreparsedData, PCHAR Report, ULONG ReportLength); > +NTSTATUS WINAPI HidP_TranslateUsagesToI8042ScanCodes(USAGE *ChangedUsageList, ULONG UsageListLength, HIDP_KEYBOARD_DIRECTION KeyAction, HIDP_KEYBOARD_MODIFIER_STATE *ModifierState, PHIDP_INSERT_SCANCODES InsertCodesProcedure, VOID *InsertCodesContext); > > #ifndef FACILITY_HID_ERROR_CODE > #define FACILITY_HID_ERROR_CODE 0x11 > > >

1 0

Re: [PATCH v4] ntoskrnl.exe: Send PnP and Power IRPs to plug and play devices
by Sebastian Lackner Sept. 15, 2016

Sept. 15, 2016

On 14.09.2016 20:58, Aric Stewart wrote: > v2: use same helper function as get_device_id > Suggestions from Sebastian Lackner > v3: shift code to ntoskrnl.c > v4: Suggestions from Sebastian Lackner > > The drivers AddDevice function will be well behaved and call > IoAttachDeviceToDeviceStack. The Plug and Play manager will then > proceed to call IRP_MN_START_DEVICE on the top device of the device > stack. Then a IRP_MJ_POWER/IRP_MN_SET_POWER to PowerDeviceD0. > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > > > v4-0001-ntoskrnl.exe-Send-PnP-and-Power-IRPs-to-plug-and-pl.txt > > > diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c > index aebb3de..6c4c984 100644 > --- a/dlls/ntoskrnl.exe/ntoskrnl.c > +++ b/dlls/ntoskrnl.exe/ntoskrnl.c > @@ -2927,6 +2927,42 @@ static BOOL get_driver_for_id( const WCHAR *id, WCHAR *driver ) > } > > > +static NTSTATUS send_pnp_irp( DEVICE_OBJECT *device, UCHAR minor ) > +{ > + IO_STACK_LOCATION *irpsp; > + IO_STATUS_BLOCK irp_status; Did you forget to declare irp here and in the function below? > + > + if (!(irp = IoBuildSynchronousFsdRequest( IRP_MJ_PNP, device, NULL, 0, NULL, NULL, &irp_status ))) > + return STATUS_NO_MEMORY; > + > + irpsp = IoGetNextIrpStackLocation( irp ); > + irpsp->MinorFunction = minor; > + > + irpsp->Parameters.StartDevice.AllocatedResources = NULL; > + irpsp->Parameters.StartDevice.AllocatedResourcesTranslated = NULL; > + > + return send_device_irp( device, irp, NULL ); > +} > + > + > +static NTSTATUS send_power_irp( DEVICE_OBJECT *device, DEVICE_POWER_STATE power ) > +{ > + IO_STATUS_BLOCK irp_status; > + IO_STACK_LOCATION *irpsp; > + > + if (!(irp = IoBuildSynchronousFsdRequest( IRP_MJ_POWER, device, NULL, 0, NULL, NULL, &irp_status ))) > + return STATUS_NO_MEMORY; > + > + irpsp = IoGetNextIrpStackLocation( irp ); > + irpsp->MinorFunction = IRP_MN_SET_POWER; > + > + irpsp->Parameters.Power.Type = DevicePowerState; > + irpsp->Parameters.Power.State.DeviceState = power; > + > + return send_device_irp( device, irp, NULL ); > +} > + > + > static void handle_bus_relations( DEVICE_OBJECT *device ) > { > static const WCHAR driverW[] = {'\\','D','r','i','v','e','r','\\',0}; > @@ -2990,7 +3026,13 @@ static void handle_bus_relations( DEVICE_OBJECT *device ) > ObDereferenceObject( driver_obj ); > > if (status != STATUS_SUCCESS) > + { > ERR_(plugplay)( "AddDevice failed for driver %s\n", debugstr_w(driver) ); > + return; > + } > + > + send_pnp_irp( device, IRP_MN_START_DEVICE ); > + send_power_irp( device, PowerDeviceD0 ); > } > > > > >

1 0

Re: [PATCH v2] ntoskrnl.exe: Implement DevicePropertyEnumeratorName for IoGetDeviceProperty
by Sebastian Lackner Sept. 15, 2016

Sept. 15, 2016

On 14.09.2016 18:06, Aric Stewart wrote: > v2: Cleanup and resend > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > > > v2-0001-ntoskrnl.exe-Implement-DevicePropertyEnumeratorName.txt > > > diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c > index aebb3de..d1b0ee9 100644 > --- a/dlls/ntoskrnl.exe/ntoskrnl.c > +++ b/dlls/ntoskrnl.exe/ntoskrnl.c > @@ -94,6 +94,8 @@ struct wine_driver > DRIVER_EXTENSION driver_extension; > }; > > +static NTSTATUS get_device_id( DEVICE_OBJECT *device, BUS_QUERY_ID_TYPE type, WCHAR **id ); > + > static int wine_drivers_rb_compare( const void *key, const struct wine_rb_entry *entry ) > { > const struct wine_driver *driver = WINE_RB_ENTRY_VALUE( entry, const struct wine_driver, entry ); > @@ -1132,6 +1134,34 @@ NTSTATUS WINAPI IoGetDeviceProperty( DEVICE_OBJECT *device, DEVICE_REGISTRY_PROP > property_buffer, result_length ); > switch (device_property) > { > + case DevicePropertyEnumeratorName: > + { > + DWORD len; > + WCHAR *id, *ptr; > + status = get_device_id( device, BusQueryInstanceID, &id ); > + if (status != STATUS_SUCCESS) > + { > + ERR( "Failed to get device id\n" ); > + break; > + } > + struprW( id ); > + TRACE( "Device ID %s\n",debugstr_w( id ) ); I am not sure if the TRACE is very useful here. Its not the value returned by get_device_id() and not the result returned by this function. Does it really make sense to dump this intermediate value here? > + ptr = strchrW( id, '\\' ); > + if (ptr) > + len = (ptr - id); It would be easier to replace the '\\' with a null character, and then always use strlenW() to get the length. This also allows to simplify the code below. > + else > + len = strlenW( id ); > + *result_length = sizeof( WCHAR ) * (len + 1); > + if (buffer_length < *result_length) > + { > + status = STATUS_BUFFER_TOO_SMALL; You are leaking the id buffer here and in the return path below. > + break; > + } > + > + lstrcpynW( property_buffer, id, len + 1 ); > + ((WCHAR*)property_buffer)[len] = 0; When the string is properly null terminated you could just use memcpy() here and copy *result_length bytes. > + break; > + } > case DevicePropertyPhysicalDeviceObjectName: > { > ULONG used_len, len = buffer_length + sizeof(OBJECT_NAME_INFORMATION); > > >

1 0

Re: [1/4] gdiplus: Add FIXME for EMF records we need to implement.
by Vincent Povirk Sept. 14, 2016

Sept. 14, 2016

Please don't commit this for now. I did some testing today that suggests GdipPlayMetafileRecord is the wrong place to handle this.

1 0

Re: ucrtbase: Add __std_type_info_hash implementation
by Huw Davies Sept. 14, 2016

Sept. 14, 2016

Hi Piotr, On Wed, Sep 14, 2016 at 03:23:04PM +0200, Piotr Caban wrote: > +/****************************************************************** > + * __std_type_info_hash (UCRTBASE.@) > + * > + * TODO: 64-bit version of the function uses different constatns typo: 'constatns'. Huw.

1 0