March 2017 - Wine-Devel - list.winehq.org

Outreachy applicant
by Prerna Garg March 14, 2017

March 14, 2017

Hi, I would like to participate in the current round of Outreachy. I am new to the world of open source. I am interested to contribute in the project Winetest Graphical User Interface. Can somebody please guide me as to how I should go about it. Regards, Prerna Garg B. Tech. Computer Science NIT Hamirpur India

2 1

Re: appwiz.cpl: Use sha256 checksums to validate Mono/Gecko downloads.
by Alexandre Julliard March 14, 2017

March 14, 2017

Sebastian Lackner <sebastian(a)fds-team.de> writes: > This patch also replaces the memory mapping logic with ReadFile. That's noticeably slower, any particular reason for doing this? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/2] include: Introduce a with_context macro and use it to simplify vcomp tests. [RFC]
by Bruno Jesus March 14, 2017

March 14, 2017

On Tue, Mar 7, 2017 at 2:29 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Based on ideas by Mark Jansen. > ... > > The with_context macro allows to specify a format string which is printed in > case of test failures and for trace messages. Currently, to track down the > origin of a test failure, it is necessary to write down all relevant variables > in each ok message. With the new macro it is much easier: > ... Hi, Sebastian. I like this idea, it would be specially useful for table struct tests (eg ws2_32) and functions that are called more than once for different tests (eg rsaenh). Each maintainer/helper could slowly update the tests as they think it fits and new tests could start benefiting from it. I hope more people join this conversation as it clearly took a long time to produce the patch and letting it drop from the list without talk would not be nice ;-)

3 3

Re: [PATCH 8/8] d3d9/tests: Add test for vertex textures.
by Marvin March 14, 2017

March 14, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29507 Your paranoid android. === w8 (32 bit visual) === visual.c:8099: Test failed: Got unexpected color 0x00ff00ff for no color attribute test. === w864 (64 bit visual) === visual.c:8099: Test failed: Got unexpected color 0x00ff00ff for no color attribute test.

1 0

Re: [PATCH 3/3] msvcrt100/tests: Add tests for concurrency::event
by Piotr Caban March 14, 2017

March 14, 2017

Hi, On 03/13/17 21:53, Daniel Lehman wrote: > +static void test_event(void) > +{ > + int i; > + int ret; > + int left; > + int wait; > + event evt; > + event *evts[70]; > + HANDLE thread; > + HANDLE threads[NUMELMS(evts)]; > + > + call_func1(p_event_ctor, &evt); > + > + ret = call_func2(p_event_wait, &evt, 100); > + ok(ret == -1, "expected -1, got %d\n", ret); > + > + call_func1(p_event_set, &evt); > + ret = call_func2(p_event_wait, &evt, 100); > + ok(!ret, "expected 0, got %d\n", ret); Could you please add following test here (to show that event is not reset after wait): ret = call_func2(p_event_wait, &evt, 100); ok(!ret, "expected 0, got %d\n", ret); > + i = 0; > + left = NUMELMS(evts); > + while (left) { > + wait = min(left, MAXIMUM_WAIT_OBJECTS); > + WaitForMultipleObjects(wait, &threads[i], TRUE, 5000); > + left -= wait; > + i += wait; > + } > + > + for (i = 0; i < NUMELMS(evts); i++) > + CloseHandle(threads[i]); I think it's cleaner if you change the while and for loop to something like: for (i = 0; i < NUMELMS(threads); i++) { WaitForSingleObject(threads[i], INFINITE); CloseHandle(threads[i]); } > + /* reset and test wait for multiple with any */ > + for (i = 0; i < NUMELMS(evts); i++) > + call_func1(p_event_reset, evts[i]); > + > + for (i = 0; i < NUMELMS(evts); i++) > + threads[i] = CreateThread(NULL, 0, test_event_thread, (void*)evts[i], 0, NULL); > + > + ret = p_event_wait_for_multiple(evts, NUMELMS(evts), FALSE, 5000); > + ok(ret != -1, "didn't expect -1\n"); Could you please start only one thread in this case and check exact return value from p_event_wait_for_multiple. Could you please also add following test: static DWORD WINAPI multiple_events_thread(void *arg) { event **events = arg; Sleep(50); call_func1(p_event_set, events[0]); call_func1(p_event_reset, events[0]); call_func1(p_event_set, events[1]); call_func1(p_event_reset, events[1]); return 0; } call_func1(p_event_reset, evts[0]); call_func1(p_event_reset, evts[1]); thread = CreateThread(NULL, 0, multiple_events_thread, (void*)evts, 0, NULL); ret = p_event_wait_for_multiple(evts, 2, TRUE, 500); ok(ret == -1, "expect -1, got %d\n", ret); WaitForSingleObject(thread, INFINITE); CloseHandle(thread); Thanks, Piotr

1 0

1.8.7 maintenance release?
by version2013＠openmailbox.org March 14, 2017

March 14, 2017

I still have much to learn. Why have a 1.8.7 maintenance release after a 2.0 stable release? In advance, thank you for sharing your knowledge as to why.

4 4

Re: [PATCH 1/3] msvcrt: Add Concurrency::event stubs
by Piotr Caban March 14, 2017

March 14, 2017

Hi Daniel, On 03/13/17 21:53, Daniel Lehman wrote: > include/concrt.h | 25 ++++++++++++++++ The c-runtimes related headers are defined in include/msvcrt/*. In this case I think that it will be better to define needed constants in dlls/msvcrt/msvcrt.h because the concrt.h header is not useful. Thanks, Piotr

1 0

Re: [PATCH] user32: Removed 16-bit windows position and size constraints
by Alexandre Julliard March 14, 2017

March 14, 2017

Kees Beets <kbeets68(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38231 > > Removed 16-bit windows position and size constraints > introduced in 2006. Only kept truncation to 16-bit > in windows messaging to keep same behaviour as windows. I'd find it surprising that the messages wouldn't match the actual window sizes. This would need more test cases. In fact we already had some window size tests, but they were commented out. I've re-enabled them now, so if you try your patch against latest git you'll see new failures, indicating that fixing up the messages is not correct. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] msvcrt: Implement Concurrency::event
by Sebastian Lackner March 14, 2017

March 14, 2017

On 13.03.2017 21:53, Daniel Lehman wrote: > > From 44d603b75fe10d51377c20e4c3c2a1bf031c4fcf Mon Sep 17 00:00:00 2001 > From: Daniel Lehman <dlehman(a)esri.com> > Date: Mon, 12 Dec 2016 16:44:44 -0800 > Subject: [PATCH 2/3] msvcrt: Implement Concurrency::event > > wait_for_multiple can handle more than WaitForMultipleObjects' limit of 64 > a separate thread is used to handle threads that wait on multiple handles > and is loosely modeled after wineserver's select request handler > a very simple command structure is used to communicate with it over a single shared pipe > > Signed-off-by: Daniel Lehman <dlehman(a)esri.com> > --- > dlls/msvcrt/lock.c | 387 +++++++++++++++++++++++++++++++++++++++++++++++++-- > dlls/msvcrt/main.c | 3 + > dlls/msvcrt/msvcrt.h | 18 +++ > 3 files changed, 397 insertions(+), 11 deletions(-) Not sure if its suitable here, but please note that Wines threadpool implementation also supports waiting on more than 64 objects (using similar tricks). If possible, it would be better to avoid the second implementation.

2 3

Re: [PATCH 3/3] d3dx9: Apply changed states only in CommitChanges.
by Matteo Bruni March 14, 2017

March 14, 2017

2017-03-09 23:15 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/d3dx9_private.h | 8 ++- > dlls/d3dx9_36/effect.c | 146 ++++++++++++++++++++++++++++-------------- > dlls/d3dx9_36/preshader.c | 40 ++++++++++-- > dlls/d3dx9_36/tests/effect.c | 13 ---- > 4 files changed, 137 insertions(+), 70 deletions(-) > > diff --git a/dlls/d3dx9_36/d3dx9_private.h b/dlls/d3dx9_36/d3dx9_private.h > index 27b91a7..53cf99f 100644 > --- a/dlls/d3dx9_36/d3dx9_private.h > +++ b/dlls/d3dx9_36/d3dx9_private.h > @@ -222,6 +222,11 @@ struct d3dx_parameter > DWORD *dirty_flag_ptr; > }; > > +static inline BOOL is_param_dirty(struct d3dx_parameter *param) > +{ > + return (*param->dirty_flag_ptr & PARAMETER_FLAG_DIRTY); > +} > + > struct d3dx9_base_effect; > > struct d3dx_parameter *get_parameter_by_name(struct d3dx9_base_effect *base, > @@ -233,6 +238,7 @@ void d3dx_free_param_eval(struct d3dx_param_eval *peval) DECLSPEC_HIDDEN; > HRESULT d3dx_evaluate_parameter(struct d3dx_param_eval *peval, > const struct d3dx_parameter *param, void *param_value) DECLSPEC_HIDDEN; > HRESULT d3dx_param_eval_set_shader_constants(struct IDirect3DDevice9 *device, > - struct d3dx_param_eval *peval) DECLSPEC_HIDDEN; > + struct d3dx_param_eval *peval, BOOL update_all) DECLSPEC_HIDDEN; > +BOOL is_param_eval_input_dirty(struct d3dx_param_eval *peval) DECLSPEC_HIDDEN; > > #endif /* __WINE_D3DX9_PRIVATE_H */ > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index ada78f9..b18465c 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -123,6 +123,9 @@ struct d3dx_pass > > struct d3dx_state *states; > struct d3dx_parameter *annotations; > + > + D3DLIGHT9 current_light[8]; > + D3DMATERIAL9 current_material; > }; I think these might be stored in the effect struct instead. > +static void clear_dirty_all(struct d3dx9_base_effect *base) clear_dirty_params() or something like that would be a clearer name. > @@ -1570,8 +1587,12 @@ static HRESULT d3dx9_base_effect_set_int(struct d3dx9_base_effect *base, D3DXHAN > { > if (param->rows == 1 && param->columns == 1) > { > - set_number(param->data, param->type, &n, D3DXPT_INT); > - set_dirty(param); > + DWORD value; > + > + set_number(&value, param->type, &n, D3DXPT_INT); > + if (value != *(DWORD *)param->data) > + set_dirty(param); > + *(DWORD *)param->data = value; Shouldn't this go in the previous patch?

2 1