April 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] wmvcore: Add WMReader stubs
by Nikolay Sivov April 7, 2017

April 7, 2017

On 07.04.2017 6:51, Jefferson Carpenter wrote: > Adds interfaces used by IMesh in bug 42416, except for these: > > 5c938aeb-6378-479e-bfd5-eafba63dc6e9 > 7af7d5ed-4ef9-48da-a4b6-8ea7eb38f5cc > --- > dlls/wmvcore/wmvcore_main.c | 1301 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 1301 insertions(+) > Hi, this is too much for a single patch. Please split it up and add some tests that shows such interfaces are actually supported. To add tests create a 'tests' directory, Makefile.in in it, and wmvcore.c (file name could be different), where you place tests. You'll have to modify configure.ac to add WINE_CONFIG_TEST line in it. If you need to link to wmvcore.dll from your test, you'll need to modify WINE_CONFIG_DLL too, to include implib directive.

2 1

Re: shell32: Fix the 'OK' button is always gray when call SHBrowseForFolder with flags BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS (try 2)
by Xu Wenlong April 7, 2017

April 7, 2017

------------------ Original ------------------ From: "Marvin"<testbot(a)winehq.org>; Date: Fri, Apr 7, 2017 04:05 AM To: "Xu Wenlong"<xuwenlong(a)deepin.com>; Subject: Re: shell32: Fix the 'OK' button is always gray when call SHBrowseForFolder with flags BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS (try 2) Thank you for your contribution to Wine! This is an automated notification to let you know that your patch has been reviewed and its status set to "No patch". This means that no patch was found in your mail. If you do not understand the reason for this status, disagree with our assessment, or are simply not sure how to proceed next, please ask for clarification by replying to this email.

1 0

Mailing List Issues
by Jeremy Newman April 6, 2017

April 6, 2017

We have been having issues with bounces and people getting removed from the list subscriptions as of late. It seems to mostly affect Gmail users, but some others have been getting kicked as well. Gmail is getting particularly picky about valid mail headers. I'm looking into ways of preventing this from happening. I've done the following to prevent further issues: * Raise the bounce threshold in mailman to 10.0 * Add SPF record to DNS * Add DMARC policy to DNS * Add DKIM key signing to all outbound mail, and matching key in DNS We also have been hitting our bandwidth threshold at our co-lo. When this happens they start to drop packets on us as a form of throttling. This always happens when I do a full CDN flush. As this really chews up the bits when the mirrors re-sync. To prevent that, we now have a background process watching for changed files on our master, and only changes will be flushed. If you notice any further issues, or have suggestions, let me know. Thanks. -N

1 0

Re: [PATCH 2/2] odbccp32: Implement SQLRemoveTranslator/W
by Huw Davies April 6, 2017

April 6, 2017

On Wed, Apr 05, 2017 at 09:51:15AM +0000, Alistair Leslie-Hughes wrote: > v3 - Fix trace message. > v4 - Fixed assignment of usage_count > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/odbccp32/odbccp32.c | 69 +++++++++++++++++++++++++++++++++++++++++----- > dlls/odbccp32/tests/misc.c | 8 +++--- > 2 files changed, 66 insertions(+), 11 deletions(-) > > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 7b2f020bbe..161f2c2bd2 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -1229,20 +1229,75 @@ BOOL WINAPI SQLRemoveDSNFromIni(LPCSTR lpszDSN) > return FALSE; > } > > -BOOL WINAPI SQLRemoveTranslatorW(LPCWSTR lpszTranslator, LPDWORD lpdwUsageCount) > +BOOL WINAPI SQLRemoveTranslatorW(const WCHAR *translator, DWORD *usage_count) > { > + HKEY hkey; > + DWORD usagecount = 1; > + > clear_errors(); > - FIXME("%s %p\n", debugstr_w(lpszTranslator), lpdwUsageCount); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + TRACE("%s %p\n", debugstr_w(translator), usage_count); > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if (RegOpenKeyW(hkey, translator, &hkeydriver) == ERROR_SUCCESS) > + { > + DWORD size, type; > + DWORD count; > + > + size = sizeof(usagecount); > + RegGetValueA(hkeydriver, NULL, "UsageCount", RRF_RT_DWORD, &type, &usagecount, &size); > + TRACE("Usage count %d\n", usagecount); > + count = usagecount - 1; > + if (count) > + { > + if (RegSetValueExA(hkeydriver, "UsageCount", 0, REG_DWORD, (BYTE*)&count, sizeof(count)) != ERROR_SUCCESS) > + ERR("Failed to write registry UsageCount key\n"); > + } > + > + RegCloseKey(hkeydriver); > + } > + > + if (usagecount) > + usagecount--; > + > + if (!usagecount) > + { > + if(RegDeleteKeyW(hkey, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry key: %s\n", debugstr_w(translator)); > + > + if (RegOpenKeyW(hkey, odbctranslators, &hkeydriver) == ERROR_SUCCESS) > + { > + if(RegDeleteValueW(hkeydriver, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry value: %s\n", debugstr_w(translator)); > + > + RegCloseKey(hkeydriver); > + } > + } > + > + RegCloseKey(hkey); > + } > + > + if (usage_count) > + *usage_count = usagecount; > + > + return TRUE; > } Sorry, I've just noticed that this returns TRUE even if the requested translator isn't installed, which is not correct. A test for that would be good too. Huw.

1 0

Re: gdi32: Change default interface font to Gothic typeface for CJK.
by Akihiro Sagawa April 6, 2017

April 6, 2017

> On Tue, Apr 04, 2017 at 11:25:18PM +0800, Jactry Zeng wrote: > > This patch changes default interface typeface of CJK from Mincho font to > > Gothic font. > > Windows had made this change since Windows Vista. macOS and most of Linux > > distros are using Gothic typeface by default for CJK, too. > > This seems to be confirmed by the great oracle of truth that is Wikipedia. > > Signed-off-by: Huw Davies <huw(a)codeweavers.com> I'm not sure about this. On my Japanese Windows 7, MS Shell Dlg points to MS UI Gothic, not Meiryo. If I remember correctly, it also points to legacy Mincho font in Chinese/Korean environment. I'm afraid that this change also affects dialog base units (e.g. GetDialogBaseUnits). A lot of application dialogs depend on default font's dialog units. Though Windows 7 introduces new type faces, we should use legacy font face in GDI for that reason. Instead of MS Shell Dlg, how about using "MS Shell Dlg 2" for system dialog windows? Regards, Akihiro Sagawa

3 3

Re: [PATCH 2/6] comctl32/tests: Test messages sent to the pager child.
by Nikolay Sivov April 5, 2017

April 5, 2017

On 05.04.2017 10:15, Stefan Dösinger wrote: > --- > dlls/comctl32/tests/msg.h | 19 ++++++++++-- > dlls/comctl32/tests/pager.c | 70 ++++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 83 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h > index b30b5d8..a3c789b 100644 > --- a/dlls/comctl32/tests/msg.h > +++ b/dlls/comctl32/tests/msg.h > @@ -39,7 +39,8 @@ typedef enum > hook = 0x100, > winevent_hook =0x200, > id = 0x400, > - custdraw = 0x800 > + custdraw = 0x800, > + child1 = 0x1000, > } msg_flags_t; > Maybe I don't see a full picture yet, but doesn't this duplicate 'id' flag? We use it for ListView/Header combined sequences for example. > struct message > @@ -182,6 +183,8 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index, > { > if (expected->message == actual->message) > { > + const char *expected_win = NULL; > + > if (expected->flags & wparam) > { > if (expected->wParam != actual->wParam && todo) > @@ -304,11 +307,23 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index, > context, expected->message, (expected->flags & posted) ? "posted" : "sent"); > if ((expected->flags & (sent|posted)) != (actual->flags & (sent|posted))) dump++; > > + if (expected->flags & parent) > + expected_win = "parent"; > + else if (expected->flags & child1) > + expected_win = "child 1"; > + else > + expected_win = "pager"; This has to be generic, something neutral like "control" instead of "pager" is better, if we'll end up using new flag.

2 2

Re: [PATCH 1/4] regedit: Concatenate the next line when a comment follows the backslash
by Alexandre Julliard April 5, 2017

April 5, 2017

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > @@ -715,7 +715,7 @@ static char *get_lineA(FILE *fp) > > while (next) > { > - char *p = strpbrk(line, "\r\n"); > + char *p = strpbrk(line, "\r\n"), *s; > if (!p) > { > size_t len, count; > @@ -741,10 +741,11 @@ static char *get_lineA(FILE *fp) > next = p + 1; > if (*p == '\r' && *(p + 1) == '\n') next++; > *p = 0; > - if (p > buf && *(p - 1) == '\\') > + if ((s = strchr(line, ':')) && (*(s - 1) == 'x' || *(s - 1) == ')')) > { > - while (*next == ' ' || *next == '\t') next++; > - memmove(p - 1, next, strlen(next) + 1); > + s = strchr(s, '\\'); > + if (!s) return line; > + memmove(s, next, strlen(next) + 1); This looks wrong. I assume it's meant to check for hex() and the like, but this would have to be done in the parser, not in the line reading code. There could just as well be a "hex:" inside a value string for instance. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Store render target info instead of surfaces in "blit_targets".
by Henri Verbeet April 5, 2017

April 5, 2017

On 5 April 2017 at 15:38, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -2678,17 +2713,17 @@ BOOL context_apply_clear_state(struct wined3d_context *context, const struct win > > if (!rt_count || wined3d_resource_is_offscreen(rts[0]->resource)) > { > + memset(context->blit_targets, 0, gl_info->limits.buffers * sizeof(context->blit_targets)); Is that sizeof missing a '*'?

1 0

Re: [PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.
by Nikolay Sivov April 5, 2017

April 5, 2017

On 05.04.2017 10:15, Stefan Dösinger wrote: > --- > dlls/comctl32/tests/msg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h > index 3fa0fae..b30b5d8 100644 > --- a/dlls/comctl32/tests/msg.h > +++ b/dlls/comctl32/tests/msg.h > @@ -369,7 +369,7 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index, > context, expected->message, actual->message); > } > > - if(todo && !failcount) /* succeeded yet marked todo */ > + if(todo && !failcount && !broken(TRUE)) /* succeeded yet marked todo */ > { > dump++; > todo_wine > This patch is marked is failed by testbot, but it looks like bot inability to deal with header file change in tests directory, as it still tries to run some tests. Anyway, could you make it look similar to user32/tests/msg.c? It's using: --- if( todo && !failcount) /* succeeded yet marked todo */ todo_wine { if (!strcmp(winetest_platform, "wine")) dump++; --- Platform is tested directly. It's not the only place where it's done like that, and it's more readable than broken(1), I think.

3 2

Re: [PATCH 2/4] ws2_32/tests: Added WSARecv tests using completion function.
by Marvin April 5, 2017

April 5, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29976 Your paranoid android. === w2008s64 (64 bit sock) === sock.c:6817: Test failed: got 0

1 0