April 2017 - Wine-Devel - list.winehq.org

Re: [8/10] wsdapi: Add stub implementation of IWSDiscoveryPublisher
by Alexandre Julliard April 3, 2017

April 3, 2017

Owen Rudge <orudge(a)codeweavers.com> writes: > diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c > index 913e99c..ac98522 100644 > --- a/dlls/uuid/uuid.c > +++ b/dlls/uuid/uuid.c > @@ -89,6 +89,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > #include "netcfgx.h" > #include "shimgdata.h" > #include "comsvcs.h" > +#include "wsdapi.h" I don't see any IWSD interfaces in the PSDK uuid library. > +static HRESULT WINAPI IWSDiscoveryPublisherImpl_Publish(IWSDiscoveryPublisher *This, LPCWSTR pszId, ULONGLONG ullMetadataVersion, ULONGLONG ullInstanceId, > + ULONGLONG ullMessageNumber, LPCWSTR pszSessionId, const WSD_NAME_LIST *pTypesList, > + const WSD_URI_LIST *pScopesList, const WSD_URI_LIST *pXAddrsList) > +{ > + FIXME("(%p, %s, %llu, %llu, %llu, %s, %p, %p, %p)\n", This, debugstr_w(pszId), ullMetadataVersion, ullInstanceId, ullMessageNumber, > + debugstr_w(pszSessionId), pTypesList, pScopesList, pXAddrsList); Please use wine_dbgstr_longlong instead of %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] wbemdisp: Add missing methods to the ISWbemObjectVtbl.
by Huw Davies April 3, 2017

April 3, 2017

> On 3 Apr 2017, at 09:57, Huw Davies <huw(a)codeweavers.com> wrote: > > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/wbemdisp/locator.c | 285 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 284 insertions(+), 1 deletion(-) Please ignore this series. I sent it too early. Huw.

1 1

Re: maintainers: Take over the world of dmusic.
by Austin English April 1, 2017

April 1, 2017

Signed-off-by: Austin English <austinenglish(a)gmail.com> -- -Austin GPG: 14FB D7EA A041 937B On Apr 1, 2017 4:02 PM, "André Hentschel" <nerv(a)dawncrow.de> wrote: >:) Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Am 01.04.2017 um 16:05 schrieb Michael Stefaniuc: > Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> > --- > André, this is how you properly do an Aprils Fools Day joke! > > > MAINTAINERS | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 878e210..732b898 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -91,6 +91,10 @@ DirectInput > P: Andrew Eikum <aeikum(a)codeweavers.com> > F: dlls/dinput/ > > +DirectMusic > +M: Michael Stefaniuc <mstefani(a)winehq.org> > +F: dlls/dm*/ > + > DirectPlay > M: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > F: dlls/dplayx/ >

1 0

Re: [PATCH 2/5] ddraw: Implement depth/colour fills on top of wined3d_device_clear_rendertarget_view().
by Stefan Dösinger April 1, 2017

April 1, 2017

> Am 29.03.2017 um 22:17 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > > + struct wined3d_color colour; Out of curiosity, why is this patch introducing the British spelling of colo[u]r? The code was consistently using the American spelling before, except for a few comments / trace messages.

1 0

Re: [PATCH] usp10: Handle invalid arguments in ScriptIsComplex()
by Marvin April 1, 2017

April 1, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29873 Your paranoid android. === wxppro (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 09e8:usp10: unhandled exception c0000005 at 74DA37CD === w2003std (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 05f0:usp10: unhandled exception c0000005 at 754A73F9 === wvistau64 (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 00c4:usp10: unhandled exception c0000005 at 76089892 === w2008s64 (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 0b54:usp10: unhandled exception c0000005 at 76729892 === wvistau64 (64 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 00c4:usp10: unhandled exception c0000005 at 000007FEFEE0119A === w2008s64 (64 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 07ec:usp10: unhandled exception c0000005 at 000007FEFD9F119A

1 0