May 2017 - Wine-Devel - list.winehq.org

Re: [PATCH 7/7] wined3d: Add support for patch constant signatures.
by Henri Verbeet May 11, 2017

May 11, 2017

On 10 May 2017 at 15:54, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->input_signature, &len))) > + return hr; > + total = len; > + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->output_signature, &len))) > + return hr; > + total += len; > + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->patch_constant_signature, &len))) > + return hr; > + total += len; It's perhaps a fairly theoretical concern, but I think you can still make "total" overflow here.

1 0

Re: [PATCH 3/6 v2] dmusic: Implement IDirectMusic8::SetDirectSound()
by Sebastian Lackner May 10, 2017

May 10, 2017

On 10.05.2017 15:13, Michael Stefaniuc wrote: > + > + if (This->dsound) > + IDirectSound_Release(This->dsound); > + > + if (!dsound) { > + hr = DirectSoundCreate8(NULL, (IDirectSound8 **)&This->dsound, NULL); > + if (FAILED(hr)) > + return hr; > + hr = IDirectSound_SetCooperativeLevel(This->dsound, hwnd ? hwnd : GetForegroundWindow(), > + DSSCL_PRIORITY); > + if (FAILED(hr)) > + IDirectSound_Release(This->dsound); > + return hr; > + } > Shouldn't you unset This->dsound in the error paths (especially the last one)?

2 1

Re: [PATCH 3/6] d3d11/tests: Port test_clear_state() from d3d10core.
by Henri Verbeet May 10, 2017

May 10, 2017

On 9 May 2017 at 12:51, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + refcount = ID3D11Device_Release(device); > + ok(!refcount, "Device has %u references left.\n", refcount); > +} This test hangs for me on Windows. Specifically, the issue seems to be the final release of the device.

2 1

Wine native fps overlay
by CARLOS RODRIGUEZ May 10, 2017

May 10, 2017

>The big picture answer to your feature requests is that Wine is a tool to run Windows apps and all these things are side features that can be added with other tools and partially exist in drivers.If we add code for that it needs to be maintained, taking away attention from our main goal. I once tried to make FRAPS run in Wine, which would give you an option to add an FPS overlay to pretty much all d3d or GL apps. Unfortunately its DLL injection code doesn't work, and fixing it would require changes to the linker and/or dynamic loader, which is rather tricky. Likewise you can write a more generic FPS limiting or vsync forcing tool with LD_PRELOAD. That way it would also work with non-wine apps.>Unfortunate but for now nikolay suggestion (WINEDEBUG=-all,+fps) works without issues (only shows fps information and seems improve performance in some apps too)

1 0

Re: [PATCH] ws2_32: Use unsigned interface index on interface_bind_check
by Alexandre Julliard May 10, 2017

May 10, 2017

Bruno Jesus <bjesus(a)codeweavers.com> writes: > The exotic interface indexes used by linux for tun/ppp connections may > cause problems resulting in interface_bind_check not finding the > expected interface during loop. > > Signed-off-by: Bruno Jesus <bjesus(a)codeweavers.com> > --- > dlls/ws2_32/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The error checking would need to be adapted then, checking ifindex > 0 no longer makes much sense. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v4 PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

Getting closer. + HRESULT GetPriorityRecords( + [out] WM_STREAM_PRIORITY_RECORD *arrray, + [in, out] WORD *records); + + HRESULT SetPriorityRecords( + [in] WM_STREAM_PRIORITY_RECORD *arrray, + [in] WORD records); "array" is spelled with two R's. + HRESULT ResetLoggingUrlList( ); None of the other zero-argument functions in this file have a space between the parentheses. + HRESULT SetMaxPacketSize([in] DWORD size); + HRESULT SetMinPacketSize([in] DWORD size); None of the other functions in this file have two spaces between [in] and the variable type. + HRESULT GetPlayOutputLevels( + [out, size_is( *length )] DRM_PLAY_OPL *play, + [in, out] DWORD *length, + [out] DWORD *level); + + HRESULT GetCopyOutputLevels( + [out, size_is( *length )] DRM_COPY_OPL *copy, + [in, out] DWORD *length, + [out] DWORD *compliance); Why did you name the variable "level" in the first function and "compliance" in the second? It seems like they should be the same. -Alex

1 0

Re: [v3 PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

These functions have formatting inconsistencies: + HRESULT GetPriorityRecords( + [out] WM_STREAM_PRIORITY_RECORD *arrray, + [in, out] WORD *records); + HRESULT SetPriorityRecords( + [in] WM_STREAM_PRIORITY_RECORD *arrray, + [in] WORD records); + HRESULT ResetLoggingUrlList( ); + HRESULT SetMaxPacketSize([in] DWORD size); + HRESULT SetMinPacketSize([in] DWORD size); + HRESULT GetDRMProperty( + [in] const WCHAR *name, + [out] WMT_ATTR_DATATYPE* type, + [out, size_is( *length )] BYTE *value, + [in, out] WORD *length); These functions have naming inconsistencies: + HRESULT GetPlayOutputLevels( + [out, size_is( *length )] DRM_PLAY_OPL *play, + [in, out] DWORD *length, + [out] DWORD *pdwMinAppComplianceLevel); + HRESULT GetTimecodeRangeBounds( + [in] WORD stream, + [in] WORD Range, + [out] DWORD *start_timecode, + [out] DWORD *end_timecode); Please spend some time double and triple checking before submitting again. -Alex

1 0

Re: [v2 PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

The formatting is a little better now, but it's still all over the place. Please make every function declaration match the existing code in this file. For example, for a function with one argument: HRESULT GetType([out] GUID *guid); And for a function with multiple arguments: HRESULT GetProxyPort( [in] LPCWSTR protocol, [out] DWORD *port); -Alex

1 0

Re: [PATCH 2/3] include/wmsdkidl.idl: Add more interfaces
by Alex Henrie May 10, 2017

May 10, 2017

- WMT_CODECINFO_UNKNOWN = 0xFFFFFFFF, + WMT_CODECINFO_UNKNOWN = 0xffffffff, I think this qualifies as a gratuitous formatting change. + HRESULT GetBandwidth( [out] DWORD *bitrate, + [out] DWORD *buffer ); + + HRESULT SetBandwidth( [in] DWORD bitrate, + [in] DWORD buffer ); The extra spaces after the left parentheses look like a mistake; they don't match the format in the rest of the file. + HRESULT GetBandwidthSharing( [in] DWORD index, + [out] IWMBandwidthSharing **bandwidth ); + HRESULT GetExpectedPacketCount( [in] QWORD duration, + [out] QWORD *packets ); + HRESULT SetDRMProperty( [in] const WCHAR *name, [in] WMT_ATTR_DATATYPE type, + [in, size_is( length )] const BYTE *value, + [in] WORD length ); + HRESULT GetDRMProperty( [in] const WCHAR *name, [out] WMT_ATTR_DATATYPE* type, + [out, size_is( *length )] BYTE *value, + [in, out] WORD *length ); Again, pick a whitespace style and stick to it. In particular, decide whether you want to break the line after each variable or after reaching 80, 100, or 120 characters. -Alex

3 3

Re: [RFC] README: Update Linux version requirement to 2.3.31.
by wylda＠volny.cz May 9, 2017

May 9, 2017

>>If winecfg runs, that should be good enough. Optional packages can be >>backported if necessary. >> > >OK, then I will concentrate on min kernel version :) > Currently blocked by Bug 42986.

1 0