May 2017 - Wine-Devel - list.winehq.org

Outreachy: Rosanne DiMesio accepted for AppDB Improvements
by Austin English May 8, 2017

May 8, 2017

Howdy all, Please welcome me in congratulating Roseanne on being accepted for Outreachy. She will be working on improving the AppDB (which greatly needs it), and is being mentored by Jeremy Newman. Congrats Rosanne! -- -Austin GPG: 14FB D7EA A041 937B

4 3

Re: [PATCH 2/6] wined3d: Disable EXT_TEXTURE_LOD_BIAS on core profile.
by Henri Verbeet May 8, 2017

May 8, 2017

On 7 May 2017 at 20:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > glTexEnvf(..., GL_TEXTURE_LOD_BIAS, ...) is not available in core profile. > Just disable the extension for now. > Is the extension advertised on core profiles then?

2 3

Re: [PATCH 4/6] wined3d: Disable YUV formats when fixups are not supported.
by Henri Verbeet May 8, 2017

May 8, 2017

On 7 May 2017 at 20:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -5192,8 +5193,19 @@ static BOOL wined3d_check_surface_capability(const struct wined3d_format *format > > if (format->glInternal) > { > - TRACE("[OK]\n"); > - return TRUE; > + switch (format->id) > + { > + case WINED3DFMT_YUY2: > + case WINED3DFMT_UYVY: > + case WINED3DFMT_YV12: > + case WINED3DFMT_NV12: > + TRACE("%s\n", gl_info->supported[ARB_FRAGMENT_PROGRAM] > + ? "[OK]" : "[FAILED] - No YUV fixups support."); > + return gl_info->supported[ARB_FRAGMENT_PROGRAM]; > + default: > + TRACE("[OK]\n"); > + return TRUE; > + } Generally speaking, we've been moving away from this kind of "list some formats somewhere" approach. If we really have to disable these formats, I'd argue apply_format_fixups() would be the correct place, since creating the surfaces should probably also fail then. There's also an argument that the CPU blitter should be able to handle these though.

1 0

Re: [PATCH 3/6] wined3d: Disable ARB program extensions on core profile.
by Henri Verbeet May 8, 2017

May 8, 2017

On 7 May 2017 at 20:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > None of the ARBfp shader backend, fragment pipe replacement or blitter > are currently in working condition in core profiles (nor they are > expected to be in the foreseeable future). > Sure, but you can just check for WINED3D_GL_LEGACY_CONTEXT in e.g. wined3d_arbfp_blitter_create(). (And arguably, the shader backend and fragment pipe cases can't even happen unless you took extra steps to break your setup.)

1 0

Re: [PATCH 4/6] wined3d: Disable YUV formats when fixups are not supported.
by Stefan Dösinger May 8, 2017

May 8, 2017

> Am 07.05.2017 um 20:32 schrieb Matteo Bruni <mbruni(a)codeweavers.com>: > > + switch (format->id) > + { > + case WINED3DFMT_YUY2: > + case WINED3DFMT_UYVY: > + case WINED3DFMT_YV12: > + case WINED3DFMT_NV12: > + TRACE("%s\n", gl_info->supported[ARB_FRAGMENT_PROGRAM] > + ? "[OK]" : "[FAILED] - No YUV fixups support."); > + return gl_info->supported[ARB_FRAGMENT_PROGRAM]; Once upon a time blitting YUY2 and UYVY via regular 3D draws worked with GL_APPLE_ycbcr_422, and afaics the necessary format definitions are still in place.

1 0

Re: [PATCH] msi: Add MsiGetPatchFileListA/W stubs.
by Hans Leidekker May 8, 2017

May 8, 2017

On Mon, 2017-05-08 at 00:47 +0300, Andrey Gusev wrote: > +UINT WINAPI MsiGetPatchFileListA(LPCSTR szProductCode, LPCSTR szPatchList, > + LPDWORD pcFiles, MSIHANDLE **pphFileRecords) > +{ > + FIXME("(%s, %s, %p, %p) stub!\n", debugstr_a(szProductCode), > + debugstr_a(szPatchList), pcFiles, pphFileRecords); > + return ERROR_SUCCESS; You should set the output parameters to sensible values, or return an error.

1 0

Re: [PATCH v2 5/6] wined3d: Fix specular lighting calculation.
by Marvin May 7, 2017

May 7, 2017

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30826 Your paranoid android. === w1064 (32 bit visual) === visual.c:8016: Test failed: Got unexpected color 0x00008080 for quad 2 (different colors). === w1064 (64 bit visual) === visual.c:8016: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

1 0

Re: [PATCH] user32: Removed 16-bit windows position trunc in WINPOS_SetPlacement.
by Alexandre Julliard May 6, 2017

May 6, 2017

Kees Beets <kbeets68(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38231 > > Replaced SetWindowPos in WINPOS_SetPlacement with an implementation that > does not truncate windows positions to 16-bit. Fixes a bug in Adobe > Lightroom under wine that is not present under windows (7, 8, 10), > while still running all win tests successfully. It's good that it doesn't break the other tests, but since we currently don't have tests for SetWindowPlacement, that's not very convincing. You'd want to add some tests at least for the truncation thing, and also probably some for the message sequences. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcp90: Call invalid_parameter_handler on index out of range in basic_string::operator[]
by Piotr Caban May 5, 2017

May 5, 2017

On 05/05/17 19:01, Piotr Caban wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/msvcp90/string.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) Please ignore this patch for now. Thanks, Piotr

1 0

Re: [PATCH] wined3d: Add NVIDIA GTX 1080 Ti to the GPU list
by Henri Verbeet May 5, 2017

May 5, 2017

On 4 May 2017 at 22:53, Björn Bidar <theodorstormgrade(a)googlemail.com> wrote: DRIVER_NVIDIA_GEFORCE8, 8192}, > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GTX1080TI, "NVIDIA GeForce GTX 1080 Ti", DRIVER_NVIDIA_GEFORCE8, 11169}, That's an unusual amount of memory, should that be 11264?

1 0