- Wine-Devel - list.winehq.org

Staging WRITECOPY fixes
by DodoGTA GT Sept. 20, 2024

Sept. 20, 2024

Hello, I found a few issues with the WRITECOPY patch after wine-staging commit ae46f56f2cf20585387ff61cb7b36fd5f3d84837 which I managed to pretty much fix Patch 0003 is a replacement for the previous 0003 patch (apparently very early signal handling is still needed for some Unix-side ntdll functions); the added early argument checks could be replaced with NtCurrentTeb() instead (this would lead to 2 identical signal_init_process() calls though which may look weird) Patch 0004 updates the previous 0004 patch by removing a forgotten i386 compile-time check (which didn't make sense after that wine-staging commit) Patch 0005 is updated to fix conflicts because of the patch 0004 update (so it can be ignored for a manual rebase) Patch 0010 enables the WRITECOPY stuff by default (this is effectively a replacement for patches 0010 and 0011 without their hacky logic which really only works for Chromium-based applications); if this patch addition is too radical, then at least patches 0010 and 0011 should definitely be removed (hopefully there won't be another patch race anytime soon) Please note that patch 0003 also adds an extra ntdll-Syscall_Emulation dependency to fix a bad interaction with that patchset (also I should've sent this email at least a day earlier but hopefully some of these patches can get pushed) Thanks

1 0

[PATCH] Correction for Bug 52627 - Wishlist: add ohm symbol (greek capital Omega) to wine tahoma font
by MATHEUS VENTURINI BORTOLUZZI Sept. 20, 2024

Sept. 20, 2024

Good afternoon, I've made a patch to fix the Ohm sign not appearing in LTSpice. I followed what was written in the discussion of Bug 52627 <https://bugs.winehq.org/show_bug.cgi?id=52627> - I copied the glyph for "OHM SIGN" and pasted it for "GREEK CAPITAL LETTER OMEGA" using FontForge. Since this is my first contribution to anything ever, I would greatly appreciate if someone could test this patch... Thank you in advance Matheus

2 1

Wine staging 9.17 release
by Alistair Leslie-Hughes Sept. 6, 2024

Sept. 6, 2024

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 9.17 (354 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * cmd: Support for launching programs based on file association. * cmd: Changed errorlevel type to DWORD. * winemapi: Directly use xdg-email if available, enabling file attachments. Removed (No longer required). * None Added: * None Updated: * vkd3d-latest * odbc32-fixes Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Wine staging 9.16 release
by Alistair Leslie-Hughes Aug. 24, 2024

Aug. 24, 2024

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 9.16 (355 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * odbc32: Support freeing SQL handles for ODBC v2 drivers. * odbc32: Support Allocating SQL handles for ODBC v2 drivers. * odbc32: Support Driver in connection string. * odbc32: SQLSetDescFieldW pass correct handle onto driver. * odbc32: Use SQLAllocHandle to allocate a STMT handle. * odbc32: Call drivers SQLBindCol function. * printdlg: Allow button id psh1 for "Properties" button. * odbc32: Store handles when requesting information of Columns. * odbc32: Pass statment when creating a descriptor. * odbccp32: Support System wide ODBC DSN keys. * odbccp32: SQLWritePrivateProfileStringW check for existing DSN first. * odbc32: SQLSetEnvAttr isnt supported in ODBC v2.0. * odbc32: set_con_attr return success by default. * odbc32: SQLColAttributeW support fallback function. * odbc32: SQLGetDiagRec/W handle fallback function. * setupapi: Add stub for DriverStoreFindDriverPackageW. * winex11.drv: Update a candidate window's position with over-the-spot style. Removed (No longer required). * None Added: * None Updated: * vkd3d-latest * eventfd_synchronization * ntdll-WRITECOPY Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Staging dinput-scancode fix
by DodoGTA GT Aug. 23, 2024

Aug. 23, 2024

Hello Here's a better regression fix for the dinput-scancode patchset (the 0001 patch of that patchset caused NFS Underground to segfault since Wine 9.15 with the addition of a keycode loop in keyboard_create_device() because of DIPROP_SCANCODE stuff); I modified the existing 0001 patch to solve this by copying the duplicate object checks to that new loop (maybe I should create a separate 0003 patch to show the changes better?) Hopefully the patch can be merged before 9.16 to not re-introduce that regression after it has been worked around in wine-staging 9.15 Thanks

3 2

stack size change
by Mahin Pandya Aug. 16, 2024

Aug. 16, 2024

Hello everyone, I am looking to change stack size of Wine executable. Apart from specifying .def (which contains STACKSIZE value) file during compilation, is there any other option which is supported by Wine? Some kind configurable runtime option without modifying binary? Sample code: $ cat hello.c #include <stdio.h> #include <windows.h> int PASCAL WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, PSTR szCmdLine, int iCmdShow) { char buffer [1024*1024*3]; printf( "Hello world\n"); return 0; } $ winegcc hello.c $ ./a.out Segmentation fault (core dumped) Note: I am able to change/patch stack size via modifying a.out.so file. Any pointers/suggestion are welcome. Thanks in advance. regards, Mahin

1 1

[PATCH v5 00/28] NT synchronization primitive driver
by Elizabeth Figura Aug. 12, 2024

Aug. 12, 2024

This patch series implements a new char misc driver, /dev/ntsync, which is used to implement Windows NT synchronization primitives. NT synchronization primitives are unique in that the wait functions both are vectored, operate on multiple types of object with different behaviour (mutex, semaphore, event), and affect the state of the objects they wait on. This model is not compatible with existing kernel synchronization objects or interfaces, and therefore the ntsync driver implements its own wait queues and locking. This patch series is rebased against the "char-misc-next" branch of gregkh/char-misc.git. == Background == The Wine project emulates the Windows API in user space. One particular part of that API, namely the NT synchronization primitives, have historically been implemented via RPC to a dedicated "kernel" process. However, more recent applications use these APIs more strenuously, and the overhead of RPC has become a bottleneck. The NT synchronization APIs are too complex to implement on top of existing primitives without sacrificing correctness. Certain operations, such as NtPulseEvent() or the "wait-for-all" mode of NtWaitForMultipleObjects(), require direct control over the underlying wait queue, and implementing a wait queue sufficiently robust for Wine in user space is not possible. This proposed driver, therefore, implements the problematic interfaces directly in the Linux kernel. This driver was presented at Linux Plumbers Conference 2023. For those further interested in the history of synchronization in Wine and past attempts to solve this problem in user space, a recording of the presentation can be viewed here: https://www.youtube.com/watch?v=NjU4nyWyhU8 == Performance == The performance measurements described below are copied from earlier versions of the patch set. While some of the code has changed, I do not currently anticipate that it has changed drastically enough to affect those measurements. The gain in performance varies wildly depending on the application in question and the user's hardware. For some games NT synchronization is not a bottleneck and no change can be observed, but for others frame rate improvements of 50 to 150 percent are not atypical. The following table lists frame rate measurements from a variety of games on a variety of hardware, taken by users Dmitry Skvortsov, FuzzyQuils, OnMars, and myself: Game Upstream ntsync improvement =========================================================================== Anger Foot 69 99 43% Call of Juarez 99.8 224.1 125% Dirt 3 110.6 860.7 678% Forza Horizon 5 108 160 48% Lara Croft: Temple of Osiris 141 326 131% Metro 2033 164.4 199.2 21% Resident Evil 2 26 77 196% The Crew 26 51 96% Tiny Tina's Wonderlands 130 360 177% Total War Saga: Troy 109 146 34% =========================================================================== == Patches == The intended semantics of the patches are broadly intended to match those of the corresponding Windows functions. For those not already familiar with the Windows functions (or their undocumented behaviour), patch 27/28 provides a detailed specification, and individual patches also include a brief description of the API they are implementing. The patches making use of this driver in Wine can be retrieved or browsed here: https://repo.or.cz/wine/zf.git/shortlog/refs/heads/ntsync5 == Previous versions == Changes from v4: * Rework wait-all locking code to avoid taking more than one spinlock at a time, and also to fix a race where the wait-all lock would not be not correctly taken. The new locking mechanism involves taking a simple spinlock for normal "any" waits, and taking a device-wide mutex for "all" waits or when locking any object that is involved in an "all" wait. The mechanism was written by Peter Zijlstra. * Try to reword or clarify various parts of the documentation (patch 27), per Peter Zijlstra. * I did not rename NTSYNC_IOC_SEM_POST to RELEASE (like NT) although this was suggested by Peter Zijlstra, mostly because it's not clear to me that renaming an already committed ioctl would be fine. The API committed isn't actually usable yet, though, so if altering it would be fine on those grounds, I can revise this series to rename the function accordingly. * Similarly, I did not change the create ioctls to return the fd directly, although this was suggested and would be a bit simpler and cleaner, because NTSYNC_IOC_CREATE_SEM already exists upstream and returns the fd through a struct. I can make this change in the next revision if that'd be preferable. I also still would appreciate a clarification on the advice in [1]. [1] https://docs.kernel.org/driver-api/ioctl.html#return-code * Link to v4: https://lore.kernel.org/lkml/20240416010837.333694-1-zfigura(a)codeweavers.… * Link to v3: https://lore.kernel.org/lkml/20240329000621.148791-1-zfigura(a)codeweavers.… * Link to v2: https://lore.kernel.org/lkml/20240219223833.95710-1-zfigura(a)codeweavers.c… * Link to v1: https://lore.kernel.org/lkml/20240214233645.9273-1-zfigura(a)codeweavers.co… * Link to RFC v2: https://lore.kernel.org/lkml/20240131021356.10322-1-zfigura(a)codeweavers.c… * Link to RFC v1: https://lore.kernel.org/lkml/20240124004028.16826-1-zfigura(a)codeweavers.c… Elizabeth Figura (28): ntsync: Introduce NTSYNC_IOC_WAIT_ANY. ntsync: Introduce NTSYNC_IOC_WAIT_ALL. ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX. ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK. ntsync: Introduce NTSYNC_IOC_MUTEX_KILL. ntsync: Introduce NTSYNC_IOC_CREATE_EVENT. ntsync: Introduce NTSYNC_IOC_EVENT_SET. ntsync: Introduce NTSYNC_IOC_EVENT_RESET. ntsync: Introduce NTSYNC_IOC_EVENT_PULSE. ntsync: Introduce NTSYNC_IOC_SEM_READ. ntsync: Introduce NTSYNC_IOC_MUTEX_READ. ntsync: Introduce NTSYNC_IOC_EVENT_READ. ntsync: Introduce alertable waits. selftests: ntsync: Add some tests for semaphore state. selftests: ntsync: Add some tests for mutex state. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for manual-reset event state. selftests: ntsync: Add some tests for auto-reset event state. selftests: ntsync: Add some tests for wakeup signaling with events. selftests: ntsync: Add tests for alertable waits. selftests: ntsync: Add some tests for wakeup signaling via alerts. selftests: ntsync: Add a stress test for contended waits. maintainers: Add an entry for ntsync. docs: ntsync: Add documentation for the ntsync uAPI. ntsync: No longer depend on BROKEN. Documentation/userspace-api/index.rst | 1 + Documentation/userspace-api/ntsync.rst | 398 +++++ MAINTAINERS | 9 + drivers/misc/Kconfig | 1 - drivers/misc/ntsync.c | 989 +++++++++++- include/uapi/linux/ntsync.h | 39 + tools/testing/selftests/Makefile | 1 + .../selftests/drivers/ntsync/.gitignore | 1 + .../testing/selftests/drivers/ntsync/Makefile | 7 + tools/testing/selftests/drivers/ntsync/config | 1 + .../testing/selftests/drivers/ntsync/ntsync.c | 1407 +++++++++++++++++ 11 files changed, 2850 insertions(+), 4 deletions(-) create mode 100644 Documentation/userspace-api/ntsync.rst create mode 100644 tools/testing/selftests/drivers/ntsync/.gitignore create mode 100644 tools/testing/selftests/drivers/ntsync/Makefile create mode 100644 tools/testing/selftests/drivers/ntsync/config create mode 100644 tools/testing/selftests/drivers/ntsync/ntsync.c base-commit: f5b335dc025cfee90957efa90dc72fada0d5abb4 -- 2.43.0

1 30

Wine staging 9.15 release
by Alistair Leslie-Hughes Aug. 11, 2024

Aug. 11, 2024

Binary packages for various distributions will be available from: https://www.winehq.org/download We have included a few PR to fix regressions with the current wine release. If you want to play NFS Underground or connect to a database via ODBC, take wine-staging for a spin. Summary since last release * Rebased to current wine 9.15 (376 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * None Removed (No longer required). * None Added: * dinput-regression-fix - Fix crash in NFS Underground. * printdlg-properties_btn - [55841] Lotus Approach: print "Properties" button ignored. Updated: * vkd3d-latest * odbc32-fixes * eventfd_synchronization * winemapi-user-xdg-mail Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Wine staging 9.14 release
by Alistair Leslie-Hughes July 28, 2024

July 28, 2024

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 9.14 (371 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * odbc32: SQLError/W handle NULL handles * odbc32: SQLSetEnvAttr fake success for SQL_ATTR_CONNECTION_POOLING * odbc32: SQLSetConnectAttrW correct default return value * odbc32: SQLTransact handle NULL EnvironmentHandle Removed (No longer required). * None Added: * [53696] d3d11: Semi-stub IDXGISwapChain::GetFrameStatistics. Updated: * vkd3d-latest * odbc32-fixes * ntdll-WRITECOPY Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Staging WRITECOPY fix
by DodoGTA GT July 26, 2024

July 26, 2024

Hello, I finally managed to submit a regression fix for the ntdll-WRITECOPY patchset (it's a normal Wine patch so there should be no diff confusion this time) Hopefully this can be merged soon because it fixes annoying segfaults in 3 apps (2 of these have a bug report) Thanks

1 0