- Wine-Devel - list.winehq.org

Re: [PATCH v4 03/13] mmdevapi: Integrate winepulse's additions in unixlib.h
by Marvin Aug. 10, 2022

Aug. 10, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120814 Your paranoid android. === debian11 (32 bit Chinese:China report) === mmdevapi: capture.c:205: Test failed: GCP 16553 past ReleaseBuffer(0) initially 16058

1 0

Re: [PATCH 1/1] d3d11: Validate layout description in d3d_input_layout_create().
by Marvin Aug. 9, 2022

Aug. 9, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120787 Your paranoid android. === w1064 (32 bit report) === d3d11: d3d11.c:5908: Test failed: Got unexpected query result 0x0000000000000000. === debian11 (64 bit WoW report) === d3d11: d3d11.c:1567: Test succeeded inside todo block: d3d11.c:1570: Test marked todo: Format 0x57 - display not supported, feature_level 0x9200, format support 0x200f3f2.

1 0

Re: [PATCH v2 1/2] mshtml: Semi-implement non-string primitive data for postMessage.
by Marvin Aug. 9, 2022

Aug. 9, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120782 Your paranoid android. === w10pro64 (64 bit report) === mshtml: htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

WinRt activable class registration
by Kacper rączy Aug. 9, 2022

Aug. 9, 2022

Hi everyone, First of all, I’m not really familiar with Windows dev environment and tools outside of wine. I’m building custom implementation of some Windows Runtime modules (separate project outside of wine-tree). Similarly to windows.gaming.input in wine, I’ve created classes.idl with `#pragma makedep register`, and using widl to compile it into classes_r.res script file. Then I’m using windres to convert to coff and link it against my dll. Then the runtime classes implemented by dll have to registered. So far I was adding registry entries with DllPath manually in regedit (in HKLM.Software.Microsoft.WindowsRuntime.ActivatableClassId.[CLASS_NAME]) for testing purposes, because I don’t really know how utilize registration script that’s already embedded in dll. So my question is, how do I register Dll for activable winrt classes? Is there a tool for that? Thanks, Kacper Rączy

1 0

Re: [PATCH 2/2] ntdll: Fix leak of mach_host_self port.
by Marvin Aug. 8, 2022

Aug. 8, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120698 Your paranoid android. === debian11 (32 bit WoW report) === ntdll: change.c:277: Test failed: should be ready

1 0

Re: [PATCH v2 1/2] mf: Handle timer time behind clock time in present_clock_schedule_timer().
by Marvin Aug. 8, 2022

Aug. 8, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120690 Your paranoid android. === w7u_el (32 bit report) === mf: mf: Timeout

1 0

[PATCH] srvsvc: Add LanmanServer stub service.
by Dmitry Timoshkov Aug. 8, 2022

Aug. 8, 2022

wine.inf already has an entry for it. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- configure.ac | 1 + dlls/srvsvc/Makefile.in | 5 +++ dlls/srvsvc/srvsvc.c | 87 +++++++++++++++++++++++++++++++++++++++++ dlls/srvsvc/srvsvc.spec | 1 + loader/wine.inf.in | 4 +- 5 files changed, 96 insertions(+), 2 deletions(-) create mode 100644 dlls/srvsvc/Makefile.in create mode 100644 dlls/srvsvc/srvsvc.c create mode 100644 dlls/srvsvc/srvsvc.spec diff --git a/configure.ac b/configure.ac index dd4abd39e32..bec0513c46d 100644 --- a/configure.ac +++ b/configure.ac @@ -3035,6 +3035,7 @@ WINE_CONFIG_MAKEFILE(dlls/spoolss/tests) WINE_CONFIG_MAKEFILE(dlls/sppc) WINE_CONFIG_MAKEFILE(dlls/srclient) WINE_CONFIG_MAKEFILE(dlls/srvcli) +WINE_CONFIG_MAKEFILE(dlls/srvsvc) WINE_CONFIG_MAKEFILE(dlls/sspicli) WINE_CONFIG_MAKEFILE(dlls/stdole2.tlb) WINE_CONFIG_MAKEFILE(dlls/stdole32.tlb) diff --git a/dlls/srvsvc/Makefile.in b/dlls/srvsvc/Makefile.in new file mode 100644 index 00000000000..f9c68fd12aa --- /dev/null +++ b/dlls/srvsvc/Makefile.in @@ -0,0 +1,5 @@ +MODULE = srvsvc.dll +IMPORTS = advapi32 + +C_SRCS = \ + srvsvc.c diff --git a/dlls/srvsvc/srvsvc.c b/dlls/srvsvc/srvsvc.c new file mode 100644 index 00000000000..3b2b563bc6c --- /dev/null +++ b/dlls/srvsvc/srvsvc.c @@ -0,0 +1,87 @@ +/* + * LanmanServer Service + * + * Copyright 2022 Dmitry Timoshkov + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "winsvc.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(lanman); + +static SERVICE_STATUS_HANDLE svc_handle; +static HANDLE done_event; + +static void svc_update_status(DWORD state) +{ + SERVICE_STATUS status; + + status.dwServiceType = SERVICE_WIN32; + status.dwControlsAccepted = SERVICE_ACCEPT_STOP | SERVICE_ACCEPT_SHUTDOWN; + status.dwWin32ExitCode = 0; + status.dwServiceSpecificExitCode = 0; + status.dwCheckPoint = 0; + status.dwWaitHint = 0; + status.dwCurrentState = state; + + SetServiceStatus(svc_handle, &status); +} + +static void WINAPI svc_handler(DWORD control) +{ + TRACE("%#lx\n", control); + + switch (control) + { + case SERVICE_CONTROL_STOP: + case SERVICE_CONTROL_SHUTDOWN: + svc_update_status(SERVICE_STOP_PENDING); + SetEvent(done_event); + break; + + default: + svc_update_status(SERVICE_RUNNING); + break; + } +} + +void WINAPI ServiceMain(DWORD argc, LPWSTR *argv) +{ + TRACE("Starting LanmanServer\n"); + + svc_handle = RegisterServiceCtrlHandlerW(L"LanmanServer", svc_handler); + if (!svc_handle) + { + ERR("RegisterServiceCtrlHandler error %ld\n", GetLastError()); + return; + } + + svc_update_status(SERVICE_START_PENDING); + done_event = CreateEventW(NULL, TRUE, FALSE, NULL); + + svc_update_status(SERVICE_RUNNING); + WaitForSingleObject(done_event, INFINITE); + CloseHandle(done_event); + + svc_update_status(SERVICE_STOPPED); + + TRACE("Exiting LanmanServer\n"); +} diff --git a/dlls/srvsvc/srvsvc.spec b/dlls/srvsvc/srvsvc.spec new file mode 100644 index 00000000000..daa88578f7f --- /dev/null +++ b/dlls/srvsvc/srvsvc.spec @@ -0,0 +1 @@ +@ stdcall -private ServiceMain(long ptr) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index e7b435ed0f0..d686e0b4f2f 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -2396,12 +2396,12 @@ Description="Lanman Server" DisplayName="Lanman Server" ServiceBinary="%11%\svchost.exe -k netsvcs" ServiceType=32 -StartType=4 +StartType=3 ErrorControl=1 [LanmanServerServiceKeys] HKR,Parameters,"ServiceDll",,"%11%\srvsvc.dll" -;; HKLM,%CurrentVersionNT%\SvcHost,"netsvcs",0x00010008,"lanmanserver" +HKLM,%CurrentVersionNT%\SvcHost,"netsvcs",0x00010008,"lanmanserver" [FontCacheService] AddReg=FontCacheServiceKeys -- 2.37.1

1 0

[PATCH] wevtsvc: Remove duplicate dwControlsAccepted initialization.
by Dmitry Timoshkov Aug. 8, 2022

Aug. 8, 2022

dwControlsAccepted is initialized a few lines earlier. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/wevtsvc/wevtsvc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/wevtsvc/wevtsvc.c b/dlls/wevtsvc/wevtsvc.c index 2e303045740..78c68bac69b 100644 --- a/dlls/wevtsvc/wevtsvc.c +++ b/dlls/wevtsvc/wevtsvc.c @@ -40,7 +40,6 @@ static void eventlog_update_status(DWORD state) status.dwServiceSpecificExitCode = 0; status.dwCheckPoint = 0; status.dwWaitHint = 0; - status.dwControlsAccepted = 0; status.dwCurrentState = state; SetServiceStatus(svc_handle, &status); -- 2.37.1

1 0

[PATCH] schedsvc: Remove duplicate dwControlsAccepted initialization.
by Dmitry Timoshkov Aug. 8, 2022

Aug. 8, 2022

dwControlsAccepted is initialized a few lines earlier. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/schedsvc/svc_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/schedsvc/svc_main.c b/dlls/schedsvc/svc_main.c index 7681a220592..2250854e953 100644 --- a/dlls/schedsvc/svc_main.c +++ b/dlls/schedsvc/svc_main.c @@ -281,7 +281,6 @@ static void schedsvc_update_status(DWORD state) status.dwServiceSpecificExitCode = 0; status.dwCheckPoint = 0; status.dwWaitHint = 0; - status.dwControlsAccepted = 0; status.dwCurrentState = state; SetServiceStatus(schedsvc_handle, &status); -- 2.37.1

1 0

Re: [PATCH v8 2/5] winegstreamer: Implement IWMOutputMediaProps_SetMediaType.
by Marvin Aug. 8, 2022

Aug. 8, 2022

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120665 Your paranoid android. === debian11 (32 bit report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Arabic:Morocco report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit German report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit French report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Hebrew:Israel report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Hindi:India report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Japanese:Japan report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit Chinese:China report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (32 bit WoW report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2. === debian11 (64 bit WoW report) === wmvcore: wmvcore.c:1318: Test failed: Stream 1: Got hr 0xc00d0bc2. wmvcore.c:2590: Test failed: Output 1: Got hr 0xc00d0bc2.

1 0