- Wine-Devel - list.winehq.org

[PATCH 1/2] readme: Update Finnish translation.
by Lauri Kenttä Aug. 29, 2022

Aug. 29, 2022

Signed-off-by: Lauri Kenttä <lauri.kentta(a)gmail.com> --- documentation/README.fi | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/documentation/README.fi b/documentation/README.fi index e459bbc779a..00af959c033 100644 --- a/documentation/README.fi +++ b/documentation/README.fi @@ -146,6 +146,8 @@ Kysymyksiä: Wiki: Wine Wiki on osoitteessa https://wiki.winehq.org/. +Gitlab: Winen kehitykseen voi osallistua sivustolla https://gitlab.winehq.org + Postituslistat: Winen käyttäjille ja kehittäjille on joitakin postituslistoja, sivulla https://www.winehq.org/forums kerrotaan niistä lisää. @@ -157,14 +159,6 @@ Virheet: IRC: Online-apua voi saada kanavalta #WineHQ palvelimella irc.libera.chat. -Git: Winen tämänhetkinen kehitysversio on jaossa Git-järjestelmän kautta. - Sivulla https://www.winehq.org/git kerrotaan tästä lisää. - - -Jos lisäät jotain tai korjaat jonkin virheen, lähetä toki muutoksesi -(mieluiten komennon git-format-patch avulla) listalle wine-devel(a)winehq.org, -jotta se voidaan lisätä Winen seuraavaan versioon. - -- Alkuperäisen version tekstistä on kirjoittanut Alexandre Julliard -- 2.37.2

2 2

Upcoming vkd3d 1.5 release.
by Henri Verbeet Aug. 24, 2022

Aug. 24, 2022

Hi all, As previously discussed, we'd like to release vkd3d 1.5 in about 4 weeks. Practically speaking, that means that as we're nearing that date, the vkd3d tree is going to become progressively frozen, starting today. Now is the time to test your games for any regressions, review any API changes since vkd3d 1.4, review/improve the API documentation, and so on. If you're working on any larger features or architectural changes, ideally you'd have those ready to merge shortly after the 1.5 release, so that they'll make it into the 1.6 release, tentatively planned for early December. Regards, Henri

1 0

wine-devel moved to Mailman3
by Jeremy Newman Aug. 22, 2022

Aug. 22, 2022

This list has been migrated to a new interface. To manage your subscription go here: https://www.winehq.org/mailman3/postorius/lists/wine-devel.winehq.org/ To view the archives go here: https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.org/ The old archives will remain online to preserve links. -N

1 0

WINE and Haxial programs
by haxial Aug. 22, 2022

Aug. 22, 2022

Hi There My company produces a few programs that run on Windows and MacOS. Some of the users of these programs have been experimenting using WINE to run the programs on Linux. This is what they have been saying: "the KDX server runs FLAWLESSLY, 100% perfect, better than solitaire runs" However, there is one caveat to the above: I'm told that text input doesn't work when running KDX using WINE on Linux. I was wondering if I would be able to work with WINE developers in making KDX run perfectly on Linux using WINE. I think you would find this to be an easier task than usual because KDX only uses a *minimal* amount of windoze APIs. For example, KDX implements it's own GUI, it does not use the windoze API for that. Also, KDX even implements it's own graphics routines, it does not use the windoze GDI functions (except for the final step of getting the images onto the screen). KDX loads no obscure DLL's, it's just a single .exe file. It does not use MDI or any crap like that. It does not access the registry. It does not use MFC. So I think it would be much easier for WINE than your average windoze program. Which probably explains why it's already running well, except there is some bug, probably a minor little thing, that is preventing text input from working. The website is: http://www.haxial.com Thanks.

1 0

[PATCH 1/2] user32/tests: Add some tests for font charset returned by SPI_GETICONTITLELOGFONT and SPI_GETNONCLIENTMETRICS.
by Dmitry Timoshkov Aug. 18, 2022

Aug. 18, 2022

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/user32/tests/sysparams.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/dlls/user32/tests/sysparams.c b/dlls/user32/tests/sysparams.c index 4f2709094e9..e354ef69a94 100644 --- a/dlls/user32/tests/sysparams.c +++ b/dlls/user32/tests/sysparams.c @@ -4124,6 +4124,31 @@ static void test_GetAutoRotationState(void) ok(ret, "Expected GetAutoRotationState to succeed, error %ld\n", GetLastError()); } +static void test_LOGFONT_charset(void) +{ + CHARSETINFO csi; + LOGFONTA lf; + NONCLIENTMETRICSA ncm; + BOOL ret; + + ret = TranslateCharsetInfo(ULongToPtr(GetACP()), &csi, TCI_SRCCODEPAGE); + ok(ret, "TranslateCharsetInfo(%d) error %lu\n", GetACP(), GetLastError()); + + GetObjectA(GetStockObject(DEFAULT_GUI_FONT), sizeof(lf), &lf); + ok(lf.lfCharSet == csi.ciCharset, "got %d, expected %d\n", lf.lfCharSet, csi.ciCharset); + + ret = SystemParametersInfoA(SPI_GETICONTITLELOGFONT, sizeof(lf), &lf, FALSE); + ok(ret, "SystemParametersInfoW error %lu\n", GetLastError()); + todo_wine + ok(lf.lfCharSet == DEFAULT_CHARSET, "got %d\n", lf.lfCharSet); + + ncm.cbSize = FIELD_OFFSET(NONCLIENTMETRICSA, iPaddedBorderWidth); + ret = SystemParametersInfoA(SPI_GETNONCLIENTMETRICS, 0, &ncm, 0); + ok(ret, "SystemParametersInfoW error %lu\n", GetLastError()); + todo_wine + ok(ncm.lfCaptionFont.lfCharSet == DEFAULT_CHARSET, "got %d\n", ncm.lfCaptionFont.lfCharSet); +} + START_TEST(sysparams) { int argc; @@ -4172,6 +4197,8 @@ START_TEST(sysparams) strict=(argc >= 3 && strcmp(argv[2],"strict")==0); trace("strict=%d\n",strict); + test_LOGFONT_charset(); + trace("testing GetSystemMetrics with your current desktop settings\n"); test_GetSystemMetrics( ); test_metrics_for_dpi( 192 ); -- 2.37.2

2 2

[PATCH 2/2] user32: Set font charset to DEFAULT_CHARSET to support locale change.
by Dmitry Timoshkov Aug. 18, 2022

Aug. 18, 2022

Otherwise when the prefix was created with one locale and later an application in the prefix is running with a different locale values cached in the registry lead to broken UI. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/user32/tests/sysparams.c | 4 ++-- dlls/win32u/sysparams.c | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/user32/tests/sysparams.c b/dlls/user32/tests/sysparams.c index e354ef69a94..6ab7010c4ed 100644 --- a/dlls/user32/tests/sysparams.c +++ b/dlls/user32/tests/sysparams.c @@ -4139,14 +4139,13 @@ static void test_LOGFONT_charset(void) ret = SystemParametersInfoA(SPI_GETICONTITLELOGFONT, sizeof(lf), &lf, FALSE); ok(ret, "SystemParametersInfoW error %lu\n", GetLastError()); - todo_wine ok(lf.lfCharSet == DEFAULT_CHARSET, "got %d\n", lf.lfCharSet); ncm.cbSize = FIELD_OFFSET(NONCLIENTMETRICSA, iPaddedBorderWidth); ret = SystemParametersInfoA(SPI_GETNONCLIENTMETRICS, 0, &ncm, 0); ok(ret, "SystemParametersInfoW error %lu\n", GetLastError()); - todo_wine ok(ncm.lfCaptionFont.lfCharSet == DEFAULT_CHARSET, "got %d\n", ncm.lfCaptionFont.lfCharSet); + ok(ncm.lfSmCaptionFont.lfCharSet == DEFAULT_CHARSET, "got %d\n", ncm.lfSmCaptionFont.lfCharSet); } START_TEST(sysparams) diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index 52665f7a641..879dffb58e2 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -3039,12 +3039,14 @@ static BOOL get_font_entry( union sysparam_all_entry *entry, UINT int_param, voi switch (load_entry( &entry->hdr, &font, sizeof(font) )) { case sizeof(font): + font.lfCharSet = DEFAULT_CHARSET; /* Support locale change */ if (font.lfHeight > 0) /* positive height value means points ( inch/72 ) */ font.lfHeight = -muldiv( font.lfHeight, USER_DEFAULT_SCREEN_DPI, 72 ); entry->font.val = font; break; case sizeof(LOGFONT16): /* win9x-winME format */ logfont16to32( (LOGFONT16 *)&font, &entry->font.val ); + entry->font.val.lfCharSet = DEFAULT_CHARSET; /* Support locale change */ if (entry->font.val.lfHeight > 0) entry->font.val.lfHeight = -muldiv( entry->font.val.lfHeight, USER_DEFAULT_SCREEN_DPI, 72 ); break; @@ -3055,6 +3057,7 @@ static BOOL get_font_entry( union sysparam_all_entry *entry, UINT int_param, voi /* fall through */ case 0: /* use the default GUI font */ NtGdiExtGetObjectW( GetStockObject( DEFAULT_GUI_FONT ), sizeof(font), &font ); + font.lfCharSet = DEFAULT_CHARSET; /* Support locale change */ font.lfHeight = map_from_system_dpi( font.lfHeight ); font.lfWeight = entry->font.weight; entry->font.val = font; @@ -3094,6 +3097,7 @@ static BOOL set_font_entry( union sysparam_all_entry *entry, UINT int_param, voi static BOOL init_font_entry( union sysparam_all_entry *entry ) { NtGdiExtGetObjectW( GetStockObject( DEFAULT_GUI_FONT ), sizeof(entry->font.val), &entry->font.val ); + entry->font.val.lfCharSet = DEFAULT_CHARSET; /* Support locale change */ entry->font.val.lfHeight = map_from_system_dpi( entry->font.val.lfHeight ); entry->font.val.lfWeight = entry->font.weight; get_real_fontname( &entry->font.val, entry->font.fullname ); -- 2.37.2

1 0

wine-cvs renamed to wine-commits
by Jeremy Newman Aug. 17, 2022

Aug. 17, 2022

The wine-cvs mailing list for git push notifications has *finally* been renamed to wine-commits. How many years has it been since we switched away from cvs? Something like 15 years! We also migrated the list over to mailman v3 so the links to the archives and subscription management have changed. The old archives will remain online to not break links. All the lists save one have been migrated. We will be migrating wine-devel soonish(tm). Updated links to the mailing lists and archives are here: https://www.winehq.org/forums Remember to update your email filters. -N

1 0

Patch tracker
by Alexandre Julliard Aug. 16, 2022

Aug. 16, 2022

Folks, We now have an automated reviewer assignment bot in Gitlab, thanks to the work of Jeremy White, so I think it's time to retire the wine-devel patch tracker. From now on, please submit everything through merge requests; patches sent to wine-devel will no longer be applied. Some reminders about the new policies: - Adding a Signed-off-by header is no longer necessary. This is replaced by the Gitlab approval mechanism. - When a new MR is submitted, the bot will assign reviewers based on the MAINTAINERS file. If the bot got it wrong, or if you would like to request reviews from other people, feel free to modify the list of reviewers. - If you don't have permission to modify reviewers, you should request access to the Wine project. There should be a link for this on the main project page at https://gitlab.winehq.org/wine/wine - I won't merge a MR until all reviewers have approved it. If you are assigned as reviewer but are unable/unwilling to review that MR, please unassign yourself so that the MR isn't blocked waiting for your approval. - In general, approving your own MR is not necessary or useful. - As an exception to the above, if your MR contains commits authored by someone else, you are asked to explicitly approve it. The bot will assign you as an extra reviewer in that case. - Approval information is stored in git notes. You can fetch the refs/notes/commits head if you'd like to see that information in your local tree. - We now have a CI pipeline to make sure that all the commits of a MR compile cleanly. Later on, the pipeline will also run the tests. Make sure to check the pipeline results; a MR with a failed pipeline won't be merged. Questions? Comments? -- Alexandre Julliard julliard(a)winehq.org

4 7

[PATCH] qedit: Remove "ugly" work around
by Brendan McGrath Aug. 15, 2022

Aug. 15, 2022

This patch removes a work around that causes a crash in Unravel Two. There is a callback in Unravel Two that appears to add a reference to a IMediaSample, which this work around treats as a leak and releases. However, the application also releases the reference causing a negative overflow and an assertion failure on line 345 of dlls/quartz/memallocator.c. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51616 Signed-off-by: Brendan McGrath <brendan(a)redmandi.com> --- Although I'm not convinced just deleting 12 yr old code is a great idea, the original author did describe this work around as "ugly". I would describe it as unsafe. See Wine Bug 51616. I think it may also be possible for the work around to fail in a multi-threaded scenario, where the IMediaSample is accessed in parallel to the callback; potentially with a negative overflow of its own (and looping 4294967295 times). Although I'm not familiar enough with the uses of qedit to understand if this is even plausible. Unfortunately, I've only tested the removal of this work around with the one application; Unravel Two. Also note that I've only been able to test this "fix" with a local build of Proton 7 Experimental. I couldn't get the application to run in vanilla Wine (as the Origin launcher failed to install). Definitely interested in thoughts. dlls/qedit/samplegrabber.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c index 9b9780e564a8..cefb2f370785 100644 --- a/dlls/qedit/samplegrabber.c +++ b/dlls/qedit/samplegrabber.c @@ -164,9 +164,6 @@ static void SampleGrabber_callback(struct sample_grabber *This, IMediaSample *sa if (ref) { ERR("(%p) Callback referenced sample %p by %lu\n", This, sample, ref); - /* ugly as hell but some apps are sooo buggy */ - while (ref--) - IMediaSample_Release(sample); } } break; -- 2.34.1

4 6

Wine staging 7.15 release
by Alistair Leslie-Hughes Aug. 14, 2022

Aug. 14, 2022

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.15 (536 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * xactengine3_7: Record context for each notification. * xactengine3_7: Add helper function to add entries. * xactengine3_7: Map SoundBank interfaces. * xactengine3_7: Map IXACT3Cue interfaces. * xactengine3_7: Map IXACT3Wave interfaces. * xactengine3_7: Implement callback for supported messages. Added: * [52396] ntdll: Don't use Wine frames during exception processing on x64. * [52396] dsdmo: Add more FX interfaces. * [53497] wined3d: Use wined3d_array_reserve() in wined3d_adapter_create_output() Updated: * none Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0