- Wine-Devel - list.winehq.org

Re: [Resent] Disable CopyImage for IMAGE_BITMAP for now
by Alexandre Julliard July 11, 2005

July 11, 2005

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Changelog: > dlls/user/cursoricon.c: CopyImage() for IMAGE_BITMAP > Disable for now, code causes memory corruption Then it should be fixed, not disabled. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: msi: source one off error correction
by Mike McCormack July 11, 2005

July 11, 2005

Aric Stewart wrote: > rc = RegQueryValueExW(sourcekey, INSTALLPROPERTY_LASTUSEDSOURCEstringW, > 0, 0, (LPBYTE)buffer,&size); > ptr = strchrW(buffer,';'); > + ptr ++; > ptr = strchrW(ptr,';'); > if (!ptr) > rc = ERROR_UNKNOWN_PROPERTY; This will crash immediately if there's anything other than a string with ;; in it in the registry. Mike

2 1

Re: [kernel/module.c] Return ERROR_PROC_NOT_FOUND for NULL hModule
by Paul Vriens July 11, 2005

July 11, 2005

> "Paul Vriens" <paul.vriens(a)xs4all.nl> wrote: > >> Process Explorer tries to load a dll with LoadLibraryA. This fails and >> NULL is returned. PE is however still trying to do GetProcAddress on >> this >> (not loaded) dll. Windows returns ERROR_PROC_NOT_FOUND, we get into an >> exception. >> >> I will send a test tonight that confirms the above. >> >> Changelog >> Return ERROR_PROC_NOT_FOUND if hModule is NULL > > Probably the test also should confirm whether it's a responsibility of > dlls/ntdll/loader.c,LdrGetProcedureAddress() to return > STATUS_ENTRYPOINT_NOT_FOUND > which will be converted by GetProcAddress to ERROR_PROC_NOT_FOUND. > > -- > Dmitry. > > Hi Dmitry, how do I make sure that's the case. Obviously a seperate test case for LdrGetProcedureAddress can be made but that doesn't prove your question. Cheers, Paul.

2 1

Re: commctrl: initial button theming support
by Jonathan Wilson July 11, 2005

July 11, 2005

Frank Richter wrote: > Frank Richter <frank.richter(a)gmail.com> > Add theming support. When comctl32.dll is attached to a thread, a CBT > hook is set up for the current thread which intercepts all window > creations. There, the class name of the window is checked. In case of a > known class, the window is subclassed, and the subclass is handling the > theming-related stuff. > Add initial theming support for the "Button" class. Not that I am any kind of expert here but would it not make sense to implement things the way windows does it? From what I know, windows implements it via activation contexts and manifests.

2 1

Re: [Wine]june 2005 release and 'registry' ?
by Hiji July 11, 2005

July 11, 2005

--- Dan Sawyer <dansawyer(a)earthlink.net> wrote: > All, > > I am testing with the wine 2005 release. The release > notes state config > file control has been moved to the registry and that > winecfg is active. > winecfg does not seem to recognize dll overrides. > Has anyone else seen > this? If so were you able to work around it? > > Thanks, > Dan I'd be interested to know as well! I could not find how to do DLL overrides with winecfg. I believe that some portions of the config file will still work, but I didn't know what parts were referred to. I'm adding the wine-devel alias to this email; maybe someone there can help. How are DLL overrides done in winecfg? Hiji __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

11 11

Did anything happen with WINEDLLOVERRIDES?
by Uwe Bonnes July 11, 2005

July 11, 2005

hertz:/spare/bon/Wine/drive_c/Programme/GALEP32> env WINEDEBUG=+loaddll WINEDLLOVERRIDES=msvcrt=n /spare/bon/wine-realclean/wine/wine Galep32.exe trace:loaddll:load_builtin_dll Loaded module L"kernel32.dll" : builtin trace:loaddll:load_builtin_dll Loaded module L"c:\\windows\\system\\msvcrt.dll" : builtin Also explicitly requested, msvcrt is loaded as builtin. native msvcrt.dll is available in the system directory and the application directory (where Galep32.exe resides) -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Looking for a good disassembler
by James Liggett July 11, 2005

July 11, 2005

Hi all, Can someone recommend a good win32 disassembler, preferably one that shows the contents of data segments and shows imports/exports? Thanks a lot, James Liggett

8 7

Re: ListBox: Fix LB_SETTABSTOPS (Resend)
by Alexandre Julliard July 10, 2005

July 10, 2005

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -1277,12 +1286,14 @@ static INT LISTBOX_SetFont( LB_DESCR *de > return 16; > } > if (font) oldFont = SelectObject( hdc, font ); > - GetTextMetricsW( hdc, &tm ); > + GetTextExtentPointA( hdc, alphabet, 52, &sz); > if (oldFont) SelectObject( hdc, oldFont ); > ReleaseDC( descr->self, hdc ); > + > + descr->avg_char_width = (sz.cx / 26 + 1) / 2; > if (!IS_OWNERDRAW(descr)) > - LISTBOX_SetItemHeight( descr, 0, tm.tmHeight, FALSE ); > - return tm.tmHeight; > + LISTBOX_SetItemHeight( descr, 0, sz.cy, FALSE ); > + return sz.cy; I think tm.tmHeight is a better choice for the height. Do you have evidence that Windows doesn't use the font metrics here? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: AppDB Not accepting backslashes in HOWTOs
by James Liggett July 10, 2005

July 10, 2005

Thanks Andrew, that worked. Duh...I should have thought of that. BTW, did you get Windows Installer working? James On Sun, 2005-07-10 at 03:08 +0100, Andrew Neil Ramage wrote: > Sounds like a Unix/Linux feature where the backslash is used for escape > codes, so you should use double backslashes. eg, C:\\Some\\Directory\\File > > Andrew > > You can be the captain > I will draw the chart > Sailing into destiny > Closer to the heart > > Closer to the Heart by Rush (A Farewell to Kings, 1977) > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > James Liggett wrote: > > I took a look at a howto in one of my AppDB entries, and I noticed that > > where thare are supposed to be backslash characters (mostly in windows > > paths,) they don't show up. If I enter something like Windows\system, it > > shows up fine in the preview, but when it actually goes to the real page > > it shows as Windowssystem. See > > http://appdb.winehq.org/appview.php?versionId=1043 for a few more > > examples. Has anyone seen anything like this before? > > > > Thanks, > > James Liggett > > > > > > > >

2 1

Managementness of borderless windows
by Stefan Dösinger July 10, 2005

July 10, 2005

Hello List, Wine has problems with Windows which don't have the WS_CAPTION flag set. These Windows are usually not managed, which leads to focus problems(no keyboard) and the window constantly stays on top. I had a look on this and tried to find a solution: (Applications tested: Steam, Quicktime, Realoneplayer) *All windows seem to have the WS_POPUP and WS_SYSMENU flag set *GetParent(hwnd) returns NULL on the windows hwnd. *GetAncestor(hwnd, GA_PARENT) returns the same as GetDesktopWindow() I added a line which checks for GetAncestor() in is_window_managed(). This made the problematic windows managed nicely on my KDE Desktop, but it broke the menus which are also children of the desktop window. Checking GetParent(hwnd) == NULL seems to work too, and it doesn't break the menus. I've sent a patch in March 2005 (http://www.winehq.org/hypermail/wine-patches/2005/03/0504.html) but it wasn't accepted, and according to my information using GetParent in this situation is wrong, and it affects other windows too, like some parts of the main window of Half Life 1. The last thing that came into my mind is to make windows with WS_SYSMENU managed. This works without any side effects for me, but it doesn't appear right to me. Can anyone suggest a solution? Are there any other apps which I can test(Freely downloadable, small download preferable)? Thanks, Stefan Dösinger

3 3