- Wine-Devel - list.winehq.org

Wrapping around stdcall
by Maarten Lankhorst July 7, 2005

July 7, 2005

I have been trying to get some work done on a class returned by CreateTextServices, but the differences between windows' stdcall and linux' are giving me a few headaches. right now I've done it pretty much like this: /* These macros are taken from wine/dlls/msvcrt/cpp.c */ #ifdef __i386__ /* thiscall functions are i386-specific */ #define THISCALL(func) __thiscall_ ## func #define THISCALL_NAME(func) __ASM_NAME("__thiscall_" #func) #define DEFINE_THISCALL_WRAPPER(func) \ extern void THISCALL(func)(); \ __ASM_GLOBAL_FUNC(__thiscall_ ## func, \ "popl %eax\n\t" \ "pushl %ecx\n\t" \ "pushl %eax\n\t" \ "jmp " __ASM_NAME(#func) ) #else /* __i386__ */ #define THISCALL(func) func #define THISCALL_NAME(func) __ASM_NAME(#func) #define DEFINE_THISCALL_WRAPPER(func) /* nothing */ #endif /* __i386__ */ DEFINE_THISCALL_WRAPPER(fnTextSrv_TxSendMessage); static HRESULT __stdcall fnTextSrv_TxSendMessage(ITextServices *iface, UINT msg, WPARAM wparam, LPARAM lparam, LRESULT* plresult) { .... } static const ITextServicesVtbl textservices_Vtbl = { fnTextSrv_QueryInterface, fnTextSrv_AddRef, fnTextSrv_Release, THISCALL(fnTextSrv_TxSendMessage), ... }; This works, however it is not clean, it gives me 2 compiler warnings: 1: fnTextServ_TxSendMessage defined but not used 2: initialisation from incompatible pointer type (in the vtable) I wonder how I can do this cleaner (Meaning no compiler warnings without ugly hacks). Also I would like to know how to call a function like __thiscall_fnTextSrv_TxSendMessage, because some methods I need are implemented in windows' stdcall. And I would like to know wether include/textserv.h needs to be adjusted now that I know they are not WINAPI.

4 11

Re: commctrl: initial button theming support
by Kevin Koltzau July 7, 2005

July 7, 2005

On Sunday 03 July 2005 9:16 am, Frank Richter wrote: > Add initial button theming support. Upon initialization, the "Button" > class is subclassed. In case theming is activated, the subclass will > take control of painting and state management; without theming, all > theming-unrelated messages are forwarded to the old button class. + /* internal stuff */ +#define BUTTON_HOT 0x80000000 +#define BUTTON_INTERNAL (BUTTON_HOT) Under windows, the mouseover state is 0x200 + theme = themingActive ? OpenThemeData( hWnd, themeClass ) : NULL; + set_button_theme( hWnd, theme ); Calling OpenThemeData with a handle associates that theme with the window, which can then be retrieved with GetWindowTheme(hWnd), you don´t need to track the window theme handle yourself

2 2

_setmbcp giving error for codepage -3
by Vijay Kiran Kamuju July 7, 2005

July 7, 2005

Hi, according to http://msdn2.microsoft.com/library/883tf19a(en-us,vs.80).aspx or msdn.microsoft.com/library/ en-us/vccore98/HTML/_crt__setmbcp.asp it should not get errored out for _MB_CP_ANSI which is actually defined in mbctype.h the value's are /* _setmbcp parameter defines */ #define _MB_CP_SBCS 0 #define _MB_CP_OEM -2 #define _MB_CP_ANSI -3 #define _MB_CP_LOCALE -4 so it should not get erroed out for code page of -3 and also i think that we should add mbctype.h to the include. If u agree i would like to write it or anyone can do it. Thanks, Vijay

1 1

Get FireFox button ?
by Sijmen Mulder July 7, 2005

July 7, 2005

He's got a point there. The target audience is mostly the Linux user - which won't be using Internet Explorer anyways! 2005/7/6, Marcelo Duarte <marcelotduarte(a)gmail.com>: > Wine uses an Mozilla ActiveX in shdocvw, and Jacek is using Gecko in > another part, forcing the user to have Firefox, no? > In another side, the user of Wine, is using Linux and Firefox or another > Open Source Browser, not IE. > > wino(a)piments.com escreveu: > > > Yes but anyone looking a wine knows about Linux and knows about the > > ammount crap to expect for IE be it on wine or windows > > > > I find it hard to imagine that anyone coming to wine needs to be made > > aware of FF or any other non-IE browser. > > > > The Open-standards link suggested would be a good idea for a link page > > but I agree with Marcus that it is not needed on the front page. > > > > Why not some worthy appeal buttons as well , Tsunami victims are less > > important than FireFox? > > > > m2c ;) > > > > On Wed, 06 Jul 2005 14:27:12 +0200, Andreas Mohr > > <andi(a)rhlx01.fht-esslingen.de> wrote: > > > >> Hi, > >> > >> On Wed, Jul 06, 2005 at 01:46:06PM +0200, Holly Bostick wrote: > >> > >>> By the way, did you guys know that Mozilla.org links to CX on the > >>> plugins page? > >>> > >>> http://plugindoc.mozdev.org/linux.html > >>> > >>> Check the bottom of the page. > >>> > >>> They even bring Wine into it, and compliment Codeweavers for their > >>> support of the Wine project. > >>> > >>> Damn decent of them, really. > >>> > >>> But, whatever. > >>> > >>> Holly > >> > >> Do I sense some slight disagreement in this mail? ;-) > >> > >> Well, I for one am slightly astonished about that FireFox button > >> reaction. > >> > >> The whole world is talking about the lack of interoperability or > >> community > >> efforts within the OSS community, and here we are blindly rejecting > >> any attempt to go into such a direction. > >> > >> So, while it can very easily be considered not very "PC" to place a > >> specific > >> Mozilla button on the main page, a non-specific "you may get a > >> standards-compliant browser here" button surely cannot hurt? > >> (provided a decent web site exists for such an effort, and provided we > >> really want to do that) > >> > >> I mean, *did* we have a huge amount of pain from all the non-standard > >> web pages caused by the "less than perfectly" interoperable > >> Intrusion Engine, > >> or didn't we? > >> And *did* we have huge pains from the continually reoccurring security > >> issues of IE or didn't we? > >> > >> Next time you tell us we should remove the donation button from the > >> web page since it distracts users... > >> > >> Andreas Mohr > >> > >> > > > > > > > > > > -- Sijmen Mulder -- Sijmen Mulder

6 6

re: cabinet.dll dev. - Using external compression libraries
by Dan Kegel July 6, 2005

July 6, 2005

Gerold J. Wucherpfennig wrote: > I'd like to use an LGPL licensed LZX compressor > for the compression part of cabinet.dll. > > What's the best way to accomplish this? > - copy and pasting the code as required. > - dynamically loading an elf library at runtime > - do configure checks at ./configure and link statically > - do the same and link dynamically > - checkin a windows-version of this LZX compressor to wine cvs and use that at > runtime. > > Web site: > http://www.speakeasy.org/~russotto/chm/ I had a look at the source for this compressor. It's pretty small. I recommend unpacking lzxcomp.tar.gz right into dlls/cabinet and simply using the source files completely unchanged if possible. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

cabinet.dll dev. - Using external compression libraries
by Gerold J. Wucherpfennig July 6, 2005

July 6, 2005

Hi all, I'd like to use an LGPL licensed LZX compressor for the compression part of cabinet.dll. What's the best way to accomplish this? - copy and pasting the code as required. - dynamically loading an elf library at runtime - do configure checks at ./configure and link statically - do the same and link dynamically - checkin a windows-version of this LZX compressor to wine cvs and use that at runtime. Web site: http://www.speakeasy.org/~russotto/chm/ Regards Gerold

2 1

Re: shell32.dll/Printer_LoadIconsW implemented (v2)
by Frank Richter July 6, 2005

July 6, 2005

On 06.07.2005 01:01, Detlef Riekenberg wrote: > + /* Icon in native printui.dll: "Not the default, connected Local Printer" */ > + SHELL32_hmodule = LoadLibraryA("printui.dll"); > + iconindex = 1; > + > + if (SHELL32_hmodule == NULL) > + { > + /* Icon in shell32.dll: "Not the default, connected Local Printer" */ > + SHELL32_hmodule = shell32_hInstance; > + iconindex = IDI_SHELL_PRINTER; > + } Actually, all the different printer icons are contained in shell32.dll; hence, trying to use printui.dll there is probably rather counter-productive... -f.r.

2 1

Theming
by Frank Richter July 6, 2005

July 6, 2005

Hi, I've recently submitted a patch to add initial theming support for push buttons. Most likely I'll have to iterate over it a few times before it could get accepted into CVS, so I'd like to just query for comments/questions/criticism on it. Thanks! Patch: http://www.winehq.org/hypermail/wine-patches/2005/07/0073.html -f.r.

2 3

Re: [WINECFG] Japanese translation
by Frank Richter July 6, 2005

July 6, 2005

On 05.07.2005 09:28, Hajime Segawa wrote: > +FONT 9, "MS UI Gothic" Isn't it on Windows the case that dialogs generally use "MS Shell Dlg[ 2]", which is at runtime mapped to a font appropriate for the language (e.g. "MS UI Gothic" for Japanese)? This link, while not 100% on that topic, contains some links: http://blogs.msdn.com/michkap/archive/2005/03/20/399322.aspx -f.r.

3 2

Re: support for gradient captions (resend)
by Dmitry Timoshkov July 6, 2005

July 6, 2005

"Frank Richter" <frank.richter(a)gmail.com> wrote: > (Now using GradientFill() instead of GdiGradientFill().) > --- dlls/user/Makefile.in (/wine/trunk/dlls/user) (revision 21713) > +++ dlls/user/Makefile.in (/me/trunk/dlls/user) (local) > @@ -5,7 +5,7 @@ > VPATH = @srcdir@ > MODULE = user32.dll > IMPORTLIB = libuser32.$(IMPLIBEXT) > -IMPORTS = gdi32 advapi32 kernel32 ntdll > +IMPORTS = gdi32 msimg32 advapi32 kernel32 ntdll It's even worse. user32 can't depend on msimg32 or any other high level dll. Just add GdiGradientFill to wingdi.h and resend your 1st patch. -- Dmitry.

2 2