- Wine-Devel - list.winehq.org

Re: uxtheme: also send WM_THEMECHANGED to child windows (resend)
by Alexandre Julliard July 5, 2005

July 5, 2005

Frank Richter <frank.richter(a)gmail.com> writes: > +static BOOL CALLBACK UXTHEME_broadcast_msg (HWND hWnd, LPARAM msg) > +{ > + if (hWnd == NULL) > + { > + EnumWindows (UXTHEME_broadcast_msg, msg); > + } > + else > + { > + PostMessageW(hWnd, msg, 0, 0); > + EnumChildWindows (hWnd, UXTHEME_broadcast_msg, msg); The recursion is redundant here, EnumChildWindows already enumerates all children. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: OLE32/compobj: gcc 4.0 -Wpointer-sign fixes
by Robert Shearman July 5, 2005

July 5, 2005

Mike McCormack wrote: >Index: dlls/ole32/compobj.c >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/compobj.c,v >retrieving revision 1.154 >diff -u -p -r1.154 compobj.c >--- dlls/ole32/compobj.c 20 Jun 2005 14:18:04 -0000 1.154 >+++ dlls/ole32/compobj.c 4 Jul 2005 14:51:31 -0000 >@@ -787,6 +787,26 @@ HRESULT WINAPI CoCreateGuid(GUID *pguid) > return UuidCreate(pguid); > } > >+static LPBYTE validate_clsid_string( LPCSTR s ) >+{ >+ int i; >+ >+ if (strlen(s) != 38) >+ return NULL; >+ >+ if ((s[0]!='{') || (s[9]!='-') || (s[14]!='-') || (s[19]!='-') || (s[24]!='-') || (s[37]!='}')) >+ return NULL; >+ >+ for (i=1; i<37; i++) { >+ if ((i == 9)||(i == 14)||(i == 19)||(i == 24)) continue; >+ if (!(((s[i] >= '0') && (s[i] <= '9')) || >+ ((s[i] >= 'a') && (s[i] <= 'f')) || >+ ((s[i] >= 'A') && (s[i] <= 'F')))) >+ return NULL; >+ } >+ return (LPBYTE) s; >+} >+ > /****************************************************************************** > * CLSIDFromString [OLE32.@] > * IIDFromString [OLE32.@] >@@ -813,28 +833,16 @@ HRESULT WINAPI CoCreateGuid(GUID *pguid) > */ > HRESULT WINAPI __CLSIDFromStringA(LPCSTR idstr, CLSID *id) > { >- const BYTE *s = (const BYTE *) idstr; >- int i; > BYTE table[256]; >+ LPBYTE s; >+ int i; > >- if (!s) >- s = "{00000000-0000-0000-0000-000000000000}"; >- else { /* validate the CLSID string */ >- >- if (strlen(s) != 38) >- return CO_E_CLASSSTRING; >- >- if ((s[0]!='{') || (s[9]!='-') || (s[14]!='-') || (s[19]!='-') || (s[24]!='-') || (s[37]!='}')) >- return CO_E_CLASSSTRING; >- >- for (i=1; i<37; i++) { >- if ((i == 9)||(i == 14)||(i == 19)||(i == 24)) continue; >- if (!(((s[i] >= '0') && (s[i] <= '9')) || >- ((s[i] >= 'a') && (s[i] <= 'f')) || >- ((s[i] >= 'A') && (s[i] <= 'F')))) >- return CO_E_CLASSSTRING; >- } >- } >+ if (!idstr) >+ idstr = "{00000000-0000-0000-0000-000000000000}"; >+ >+ s = validate_clsid_string( idstr ); >+ if( !s ) >+ return CO_E_CLASSSTRING; > > TRACE("%s -> %p\n", s, id); > I don't think there is any need to split the function into two as you can just use 'idstr' directly, instead of 's'. Also, note that this function will soon be converted into using WCHARs, but I don't think that should change anything. -- Rob Shearman

2 1

Re: OLE32: fix gcc 4.0 -Wpointer-sign warnings
by Robert Shearman July 5, 2005

July 5, 2005

Mike McCormack wrote: > ChangeLog: > * fix gcc 4.0 -Wpointer-sign warnings > >------------------------------------------------------------------------ > >Index: dlls/ole32/antimoniker.c >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/antimoniker.c,v >retrieving revision 1.25 >diff -u -p -r1.25 antimoniker.c >--- dlls/ole32/antimoniker.c 6 Jun 2005 19:50:37 -0000 1.25 >+++ dlls/ole32/antimoniker.c 4 Jul 2005 14:48:34 -0000 >@@ -49,7 +49,7 @@ typedef struct AntiMonikerImpl{ > */ > const IROTDataVtbl* lpvtbl2; /* VTable relative to the IROTData interface.*/ > >- ULONG ref; /* reference counter for this object */ >+ LONG ref; /* reference counter for this object */ > > } AntiMonikerImpl; > IUnknown_AddRef and IUnknown_Release both return ULONGs so it looks like you are just moving the problem elsewhere. I think you should be casting the values passed into Interlocked{Increment,Decrement} or find some other nicer way of preventing that warning, possibly by ignoring them or just turning off the -Wpointer-sign flag. -- Rob Shearman

2 1

Running Palm Desktop
by James Liggett July 5, 2005

July 5, 2005

Hi all, I have a palm pilot that came with a lot of different apps, but they have conduits that need windows to function. I have been experimenting with getting Palm Desktop to run with Wine. It installs OK, but it doesn't run because of a bug in WinMM. I can, however, get the Hotsync service to run. But, it doesn't see my USB cradle. Has anyone tried setting this kind of thing up to get Wine to interface with the cradle using the visor driver? I thought this might work, since it emulates a serial port. But, I don't know how to map a COM port to the device. Does anyone know how to do that with Wine 20050628? Thanks, James Liggett

3 8

Failure in gdi/tests/metafile.c
by Uwe Bonnes July 4, 2005

July 4, 2005

Hallo, ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so metafile.c failes like: metafile.c:457: Test failed: (0,0)->(10,10), expected (0,0)->(18,67) metafile.c:457: Test failed: (0,0)->(10,10), expected (0,0)->(18,67) Some discussion on #winehackers brought up some clues, but no real fix. Shouls the test be a todo_wine? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 3

Re: PATCH: olepicture without libgif/libjpeg
by Robert Shearman July 4, 2005

July 4, 2005

Marcus Meissner wrote: >Hi, > >some confused users compile WINE without libgif or libjpeg >support. > >Make sure the testcase works without this compiled in. > Here is my opinion: the test cases running in Wine are designed to make sure that any program that uses the same code paths in the tested functions will work on Wine. If the user hasn't got libgif or libjpeg support then their Wine build isn't fully functional and the failing tests should be putting up a red flag for them to fix that by adding libgif-devel or libjpeg-devel to their system. -- Rob Shearman

2 1

Re: [x11drv] d3d stencil support
by Adam D. Moss July 4, 2005

July 4, 2005

Hi! Oliver Stieber wrote: > + if (visual == NULL) { > + /* fallback to a 1 bit stencil (opengl states that at least 1 bit of stencil must be provided for on of the available configurations) */ > + WARN("Failed to get a visual with at least 8 bits of stencil\n"); > + int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE,16,GLX_STENCIL_SIZE,1,GLX_DOUBLEBUFFER,None}; > + > + wine_tsx11_lock(); > + visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf2); > + wine_tsx11_unlock(); > + if (visual == NULL) { > + /* This should only happen if we cannot fidn a match with a depth size 16 */ > + FIXME("Failed to find a suitable visual\n"); > + } > + } It's always nice to have a fallback, but in real life I've never seen PC hardware (even back to the 90s) which supports a 1-bit stencil buffer and not a 8-bit stencil buffer, so this may be over-redundant. (Would be interested in hearing of any consumer hardware which only does a 1-bit stencil.) Regards, --adam

3 4

Re: winnt.h - Add AMD64 Context Definition
by Dmitry Timoshkov July 4, 2005

July 4, 2005

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > +#ifdef _M_AMD64 > + > +#define CONTEXT_AMD64 0x100000 ... > +#endif /* __x86_64__ */ Shouldn't be __x86_64__ here be _M_AMD64 instead? -- Dmitry.

2 1

Re: [x11drv] d3d stencil support
by Frank Richter July 4, 2005

July 4, 2005

On 04.07.2005 02:21, Oliver Stieber wrote: > Hi, > This patch makes sure that the OpenGL visual created > for a window has a stencil buffer. > This is a requirement for stencil buffer support in d3d. Hm, isn't it possible that on some pathetic hardware or when lower color depths are used (e.g. 16bpp) stencil is not supported and that software emulation instead of hardware acceleration may be used? Wouldn't it be better to somehow query for a stencil buffer only when really needed? Just a thought. -f.r.

2 1

ie6setup still failing
by Robert Lunnon July 4, 2005

July 4, 2005

ie6setup is still failing to run to completion on my system even after upgrading my OGL to the nvidia one. OGL initialization in ddraw is still my prime suspect as per my last note on the matter. Can anyone say whether internet explorer setup (via sidenet) runs OK under linux since this problem might be an Solaris specific issue Bob

1 0