- Wine-Devel - list.winehq.org

Re: list: make LIST_FOR_EACH_ENTRY look more like a for loop
by Alexandre Julliard May 19, 2005

May 19, 2005

Dimi Paun <dimi(a)lattica.com> writes: > I've always been a bit confused about the parameters to the > list macros. If you don't use them much (which I didn't) it's > hard to remember them. I think it would be best if we are > consistent with other for loops out there. I think they are perfectly consistent as they are. The common form of a for loop is something like 'for cursor in list', that's also what LIST_FOR_EACH does, so it makes sense to have LIST_FOR_EACH_ENTRY do the same. The extra 2 parameters are implementation details about the object structure, that are just fine at the end. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: list: make LIST_FOR_EACH_ENTRY look more like a for loop
by Robert Shearman May 19, 2005

May 19, 2005

Dimi Paun wrote: >I've always been a bit confused about the parameters to the >list macros. If you don't use them much (which I didn't) it's >hard to remember them. I think it would be best if we are >consistent with other for loops out there. > >ChangeLog > Change the parameter order for LIST_FOR_EACH_ENTRY() > to more closely match the for loop. > > > > >------------------------------------------------------------------------ > >Index: ./include/wine/list.h >=================================================================== >RCS file: /var/cvs/wine/include/wine/list.h,v >retrieving revision 1.6 >diff -u -p -r1.6 list.h >--- ./include/wine/list.h 18 May 2005 13:24:46 -0000 1.6 >+++ ./include/wine/list.h 19 May 2005 12:19:33 -0000 >@@ -55,7 +55,7 @@ struct list > * And to iterate over it: > * > * struct gadget *gadget; >- * LIST_FOR_EACH_ENTRY( gadget, &global_gadgets, struct gadget, entry ) >+ * LIST_FOR_EACH_ENTRY( struct gadget, entry, &global_gadgets, gadget ) > * { > * ... > * } > > I don't think this makes any more sense with your patch than before. LIST_FOR_EACH_ENTRY is different to a for statement because LIST_FOR_EACH_ENTRY doesn't declare the start condition, end condition and iterator because these are defined by the macro itself. The parameters are really just defining what you are iterating on and what you are using. Rob

1 0

Re: Corrected the priority of operators for LISTVIEW_GetNextItem function.
by taro-x＠justsystem.co.jp May 19, 2005

May 19, 2005

2005-05-19 Kouji Sasaki <taro-x(a)justsystem.co.jp> > > Changelog: > > > > * dlls/comctl32/listview.c > > > > Corrected the priority of operators for LISTVIEW_GetNextItem function. > > > --- dlls/comctl32/listview.c 2005-04-14 22:58:24.000000000 +0900 > > +++ dlls/comctl32/listview.c 2005-05-16 11:29:08.003084512 +0900 > > @@ -5665,7 +5665,7 @@ > > * so it's worth optimizing */ > > if (uFlags & LVNI_FOCUSED) > > { > > - if (!(LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) == uMask) return -1; > > + if (!((LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) == uMask)) return -1; > > Wouldn't it be more readable and less confusing in the below form? > > if ((LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) != uMask) return -1; > > > -- > Dmitry. > I will send the modified patch, as changing the patch accordingly will make the source much easier to read. Changelog: * dlls/comctl32/listview.c Corrected the priority of operators for LISTVIEW_GetNextItem function. -- Justsystem Corporation <taro-x(a)justsystem.co.jp>

1 0

Re: Added the callback item processing for LISTVIEW_EndEditLabelT function.
by Dimitrie Paun May 19, 2005

May 19, 2005

> Added the callback item processing for LISTVIEW_EndEditLabelT function. I think this would be a bit more explicit and correct (is_textW() returns false if pszText == NULL) if the test is the other way around: + if (lpItem && lpItem->hdr.pszText == LPSTR_TEXTCALLBACKW) + { + LISTVIEW_InvalidateItem(infoPtr, infoPtr->nEditLabelItem); + } + else + { + ZeroMemory(&dispInfo, sizeof(dispInfo)); + dispInfo.item.mask = LVIF_TEXT; + dispInfo.item.iItem = infoPtr->nEditLabelItem; + dispInfo.item.iSubItem = 0; + dispInfo.item.pszText = pszText; + dispInfo.item.cchTextMax = textlenT(pszText, isW); + return LISTVIEW_SetItemT(infoPtr, &dispInfo.item, isW); + } -- Dimi.

2 1

Re: Implement NtQuerySystemInformation(SystemTimeOfDayInformation)
by Rein Klazes May 19, 2005

May 19, 2005

On Tue, 17 May 2005 23:06:51 +0200, you wrote: > + RtlSystemTimeToLocalTime(&sys_time, &local_time); > + /* liExpTimeZoneBias is not the same as tzi.Bias since it takes > + * disabled DST correction into account (tested on WinXP). */ > + local_diff.QuadPart = sys_time.QuadPart - local_time.QuadPart; You mean the "Automatically adjust clock for daylight saving"? Wine does not follow this silly flag and at a couple of places it depends on it. I doubt whether it should. > + > + sti->liKeBootTime = NTDLL_BootTime; > + sti->liKeSystemTime = sys_time; > + sti->liExpTimeZoneBias = local_diff; > + sti->uCurrentTimeZoneId = RtlQueryTimeZoneInformation(&tzi); This does not look correct. AFAIK RtlQueryTimeZoneInformation returns an NT-status code, 0 is no success, otherwise it is an error code. Have a look at GetTimeZoneInformation how to compute a TimeZoneId. Rein.

2 3

Re: [crypt32] take 3: CryptProtectData/CryptUnprotectData helper functions
by Mike McCormack May 18, 2005

May 18, 2005

Kees Cook wrote: > Corrected for MESSAGE() use and a botch of wine_dbg_sprintf usage. Julliard won't commit dead code, so you have to make sure that each function that you send is used by something else. How about sending a patch implementing CryptProtectData()? Mike

1 0

Re: [crypt32] CryptProtectData/CryptUnprotectData helper functions
by Alexandre Julliard May 18, 2005

May 18, 2005

Kees Cook <kees(a)outflux.net> writes: > +static int > +hexprint(const char *s, unsigned char *p, int n) > +{ > + char report[80]; > + int r=-1; > + snprintf(report,16,"%14s:", s); > + while (--n >= 0) > + { > + if (r++ % 20 == 19) > + { > + wine_dbg_printf("%s\n",report); > + snprintf(report,16,"%14s ", ""); > + } > + sprintf(report+strlen(report)," %02x", *p++); > + } > + wine_dbg_printf("%s\n",report); You should use wine_dbg_sprintf here and return a string. > +static > +void serialize_dword(DWORD value,BYTE ** ptr) > +{ > + /*TRACE("called\n");*/ > + > + *((DWORD*)*ptr)=value; > + *ptr+=sizeof(DWORD); This (and other similar things later on) isn't safe for CPUs that don't allow unaligned accesses, you have to use memcpy instead. > +static > +BOOL fill_protect_data(struct protect_data_t * pInfo, LPCWSTR szDataDescr, > + HCRYPTPROV hProv) > +{ > + DWORD dwStrLen; > + > + TRACE("called\n"); > + > + if (!pInfo) return FALSE; > + > + dwStrLen=lstrlenW(szDataDescr); > + > + memset(pInfo,0,sizeof(*pInfo)); > + > + pInfo->count0=0x0001; > + > + pInfo->info0.cbData=strlen(crypt_magic_str)+1; > + pInfo->info0.pbData=strdup(crypt_magic_str); You don't want to use strdup, you should use HeapAlloc and friends (especially since you use HeapFree later on). > +static void > +crypt_report_func_input(DATA_BLOB* pDataIn, > + DATA_BLOB* pOptionalEntropy, > + CRYPTPROTECT_PROMPTSTRUCT* pPromptStruct, > + DWORD dwFlags) > +{ > + wine_dbg_printf("\tpPromptStruct: 0x%x\n",(unsigned int)pPromptStruct); > + if (pPromptStruct) > + { > + wine_dbg_printf("\t\tcbSize: 0x%x\n",(unsigned int)pPromptStruct->cbSize); > + wine_dbg_printf("\t\tdwPromptFlags: 0x%x\n",(unsigned int)pPromptStruct->dwPromptFlags); > + wine_dbg_printf("\t\thwndApp: 0x%x\n",(unsigned int)pPromptStruct->hwndApp); > + wine_dbg_printf("\t\tszPrompt: 0x%x %s\n", > + (unsigned int)pPromptStruct->szPrompt, > + pPromptStruct->szPrompt ? debugstr_w(pPromptStruct->szPrompt) > + : ""); > + } > + wine_dbg_printf("\tdwFlags: 0x%04x\n",(unsigned int)dwFlags); > + wine_dbg_printf("\tpDataIn->cbData: %u\n",(unsigned int)pDataIn->cbData); > + wine_dbg_printf("\tpDataIn->pbData: 0x%x\n",(unsigned int)pDataIn->pbData); > + hexprint("pbData", pDataIn->pbData, pDataIn->cbData); > + if (pOptionalEntropy) > + { > + wine_dbg_printf("\tpOptionalEntropy->cbData: %u\n",(unsigned int)pOptionalEntropy->cbData); > + wine_dbg_printf("\tpOptionalEntropy->pbData: 0x%x\n",(unsigned int)pOptionalEntropy->pbData); > + hexprint("pbData", pOptionalEntropy->pbData, pOptionalEntropy->cbData); > + wine_dbg_printf("\t\t%s\n",debugstr_an(pOptionalEntropy->pbData,pOptionalEntropy->cbData)); > + } > + > +} > + > +static void > +announce_bad_opaque_data() > +{ > + wine_dbg_printf("CryptUnprotectData received the following pDataIn DATA_BLOB that seems to\n"); > + wine_dbg_printf("have NOT been generated by Wine:\n"); > +} You should use the TRACE/FIXME macros here, not raw wine_dbg_printf. -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: [crypt32] CryptProtectData/CryptUnprotectData helper functions
by Kees Cook May 18, 2005

May 18, 2005

On Wed, May 18, 2005 at 12:29:58PM -0700, Kees Cook wrote: > Take two. Ignore... this patch is broken, and I need to do an update of wine_dbg_printf() -> MESSAGE() -- Kees Cook @outflux.net

1 0

Re: [wine] Re: A better Beep
by Marcelo Duarte May 18, 2005

May 18, 2005

David Lee Lambert escreveu: >On Tue, May 17, 2005 at 10:43:25AM -0300, Marcelo Duarte wrote: > > >>Whats happens if a program calls bepp with invalid values for dwFreq and >>dwDur on a linux console? >> >> > >The bell becomes inaudible until reset by another terminal-control >sequence. However, the special value (duration=-1) does not have the >same semantics; it's simply ignored. > >On my box that has a PC speaker, the bell is silent when any of the >following are true: > >freq < 21 >dur == 0 >dur > 1999 > >I can't hear any tones above 12000 Hz or so, but I'm not sure whether >that's my hearing, the speaker-hardware, or the kernel's decision. > >Should I add range-checks on frequency and duration? > > > >>(the programmer thinks that dwFreq and dwDur are ignored by Win95). >> >> > >That's what the API documentation says. Are they used on WinXP or Win2k? > > > If you have programs to test, send me.

1 0

MSN Webcam
by Joaquín Fernández May 18, 2005

May 18, 2005

hmmmm... can you use a webcam in msn under wine???? If yes, can you explain to me how to do it? I was not able to run msn messenger in wine. Regards Joaquín -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

2 1