- Wine-Devel - list.winehq.org

Re: list.h: document the more convenient iteration method
by Dimi Paun May 18, 2005

May 18, 2005

On Wed, 2005-05-18 at 08:01 -0400, Dimi Paun wrote: > * struct list *cursor; > - * LIST_FOR_EACH( cursor, &global_gadgets ) > + * LIST_FOR_EACH_ENTRY( cursor, &global_gadgets, struct gadget *, > gadget ) > * { Looking at this, why do we need cursor at all for the LIST_FOR_EACH_ENTRY? Also the type and iteration var should come first, to be simiar for loops in pretty much any language out there. I think it should just be: LIST_FOR_EACH_ENTRY( struct gadget *, gadget, &global_gadgets ) Ah, I see now the problem. We would need to end it with LIST_END instead of just doing {...}. Not such a big deal, we do the same for server requests too :) But I can see why we would like to keep cursor. If so, it should come at the end: LIST_FOR_EACH_ENTRY(struct gadget *,gadget,&global_gadgets,cursor) -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: Small cleanup in list handling
by Robert Shearman May 18, 2005

May 18, 2005

Dimi Paun wrote: >Index: dlls/ntdll/exception.c >=================================================================== >RCS file: /var/cvs/wine/dlls/ntdll/exception.c,v >retrieving revision 1.75 >diff -u -p -r1.75 exception.c >--- dlls/ntdll/exception.c 13 May 2005 13:56:47 -0000 1.75 >+++ dlls/ntdll/exception.c 13 May 2005 19:01:31 -0000 >@@ -480,7 +480,8 @@ ULONG WINAPI RtlRemoveVectoredExceptionH > RtlEnterCriticalSection( &vectored_handlers_section ); > LIST_FOR_EACH( ptr, &vectored_handlers ) > { >- if (ptr == &((VECTORED_HANDLER *)handler)->entry) >+ VECTORED_HANDLER *curr_handler = LIST_ENTRY( ptr, VECTORED_HANDLER, entry ); >+ if (curr_handler == handler) > { > list_remove( ptr ); > ret = TRUE; > > This patch has already been committed, but for future reference code of this form: LIST_FOR_EACH( cursor, list) { TYPE list_entry = LIST_ENTRY( cursor, TYPE, entry ); ... Can be replaced by the following for IMHO, slightly more readable code: LIST_FOR_EACH_ENTRY( list_entry, list, TYPE, entry) { ... Rob

2 1

Re: MSN Webcam
by Maarten Lankhorst May 18, 2005

May 18, 2005

MediaHost (TM) wrote: > Looks interesting! Any idea, when your patches get committed into the > "official" releases? > >> Maarten Lankhorst wrote: >> >>> Status: Nearly complete, need testers. >>> >>> http://wiki.winehq.org/MSN_Messenger_webcam_support >>> >>> You need the native quartz dll, which get installed with internet >>> explorer, as the builtin quartz doesn't work properly when changing >>> media format on initialisation. >> >> Possibly a problem with the code I wrote. Can you provide more >> details on this? >> >>> IFilterGraph Reconnect isn't implemented, and for some reason *looks >>> strangely at Robert* instead of a FIXME() there's a TRACE telling it >>> is a stub... >> >> I didn't write any of the IFilterGraph implementation, but you are >> right that it is crazy. >> >> Rob >> Writing some final bugfixes at the moment, so I think a matter of days before it'll be done in a state that julliard might commit.. There were 2 small reasons why builtin quartz wasn't working 1. if format changed, it would need to reconnect with new size (Quartz, submitted a patch) 2. if format wasn't changed, I used my own optimized code, that wrote 960 bytes to a wrong place, so it crashed. (Totally my fault) btw, nice name and signature...

1 0

Re: [WINEDOCS] Add missing tag
by Dimi Paun May 18, 2005

May 18, 2005

On Wed, 2005-05-18 at 10:37 +0200, Francois Gouget wrote: > Add missing <qandaentry> tag. Oops, too late, I've already committed the fix last night. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: comctl32: Move mouse tracking to MouseMove [RESEND]
by Dimi Paun May 18, 2005

May 18, 2005

On Wed, 2005-05-18 at 00:31 -0500, James Hawkins wrote: > + LVHITTESTINFO lvHitTestInfo; > + INT nItem; > + > + if (infoPtr->bLButtonDown) > + { > + lvHitTestInfo.pt = infoPtr->ptClickPos; > + nItem = LISTVIEW_HitTest(infoPtr, &lvHitTestInfo, TRUE, > TRUE); > + > + if (DragDetect(infoPtr->hwndSelf, infoPtr->ptClickPos)) > + { > + NMLISTVIEW nmlv; > + > + ZeroMemory(&nmlv, sizeof(nmlv)); Why not move the lvHitTestInfo and nItem into the inner scope: if (infoPtr->bLButtonDown && DragDetect(infoPtr->hwndSelf, infoPtr->ptClickPos)) { LVHITTESTINFO lvHitTestInfo; NMLISTVIEW nmlv; ZeroMemory(&nmlv, sizeof(nmlv)); lvHitTestInfo.pt = infoPtr->ptClickPos; nmlv.iItem = LISTVIEW_HitTest(infoPtr, &lvHitTestInfo, TRUE, TRUE); .... } -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

MSN Webcam
by Maarten Lankhorst May 18, 2005

May 18, 2005

Status: Nearly complete, need testers. http://wiki.winehq.org/MSN_Messenger_webcam_support You need the native quartz dll, which get installed with internet explorer, as the builtin quartz doesn't work properly when changing media format on initialisation. IFilterGraph Reconnect isn't implemented, and for some reason *looks strangely at Robert* instead of a FIXME() there's a TRACE telling it is a stub...

2 1

Re: [crypt32] implementation of CryptProtectData/CryptUnprotectData
by Mike McCormack May 18, 2005

May 18, 2005

Kees Cook wrote: > Hi, I'm back again. :) This implements the crypt32 functions > CryptProtectData and CryptUnprotectData, using a best-guess at the true > Windows opaque data format and encryption methods. It attempts to > follow the "details" in the MSDN article that described > CryptProtectData. > > Please let me know how this all looks. Hopefully I've got it mostly > right this time. If there is a more sane way to handle the structure > serialization/unserialization, I'm all ears. > > (Anyone paying really close attention will note that I uncovered some > crash bugs in rsaenh as a result of my crypt32 test cases. Make sure > you've done a "cvs update" to catch those changes before running them.) > > ChangeLog: > Implements a best-guess of CryptProtectData/CryptUnprotectData. Hi Kees, Wow. That's alot of work :) It's usually easier to review these things in smaller chunks. An easy way to do that is to submit header changes first, then stub functions, implementation of each function and a test program, all as seperate patches. A further way for your patch would be to seperate CryptProtectData and CryptUnprotectData data into to two seperate patches, though I understand they are dependent on each other to some extent. This patch looks OK to me at a quick glance, but if it's not applied, please consider breaking it up. At least that way, you'll have less to submit next time round. Mike

3 2

Re: winecfg: Add handling for drive options
by Mike McCormack May 18, 2005

May 18, 2005

James Hawkins wrote: > case WM_COMMAND: > - if (HIWORD(wParam) == EN_CHANGE) > + switch (HIWORD(wParam)) > { I don't know if it's just my opinion, but case statements within case statements make the code more difficult to read. Would you consider creating a new function instead? eg. case WM_COMMAND: OnCommand( dialog, HIWORD(wParam), LOWORD(wParam) ); break; Mike

1 0

Re: comctl32: Move mouse tracking to MouseMove
by Dimi Paun May 18, 2005

May 18, 2005

On Tue, 2005-05-17 at 23:18 -0500, James Hawkins wrote: > Changelog > * Store the click point in LISTVIEW_INFO. > * Move mouse tracking to MouseMove. > * Use DragDetect instead of TrackMouse. > * Remove the unused TrackMouse function. I think you've sent the wrong patch... -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: Corrected the priority of operators for LISTVIEW_GetNextItem function.
by Dmitry Timoshkov May 18, 2005

May 18, 2005

<taro-x(a)justsystem.co.jp> wrote: > Changelog: > > * dlls/comctl32/listview.c > > Corrected the priority of operators for LISTVIEW_GetNextItem function. > --- dlls/comctl32/listview.c 2005-04-14 22:58:24.000000000 +0900 > +++ dlls/comctl32/listview.c 2005-05-16 11:29:08.003084512 +0900 > @@ -5665,7 +5665,7 @@ > * so it's worth optimizing */ > if (uFlags & LVNI_FOCUSED) > { > - if (!(LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) == uMask) return -1; > + if (!((LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) == uMask)) return -1; Wouldn't it be more readable and less confusing in the below form? if ((LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) != uMask) return -1; -- Dmitry.

1 0