- Wine-Devel - list.winehq.org

Re: Anyone remember winemine?
by William Poetra Yoga H May 3, 2005

May 3, 2005

--- Richard Cohen <richard(a)daijobu.co.uk> wrote: > The original patch > > http://www.winehq.org/hypermail/wine-patches/2004/09/0395.html > > was from me, back in last September. It included a test which showed > that it was correct. But AJ didn't like the way I did the test :( and I > haven't got round to resubmitting it. > > Richard. > Oops, sorry. Well, I think you should resubmit it then :) Maybe without the test attached it would be accepted by Alexandre? --- Detlef Riekenberg <wine.dev(a)web.de> wrote: > William Poetra Yoga H wrote: > > > > Sorry, I mean winmine, one that comes with Windows 98, for example. > > > Well, can you post a link to the binary? I don't have Win98 right now... > The > > WinXP winmine doesn't. > > winmine.exe (from win98se) does not shift > (tested with wine-cvs.2005.05.02 and win98se) > Weird... Did it call AdjustWindowRect? But after opening winmine.exe (from winxp) with vi, I didn't find an AdjustWindowRect, which means that the two programs are different in the way they handle the screen for new games. I think Richard should try again (yes, try without the test if Alexandre doesn't like it...) William Poetra Yoga Hadisoeseno __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: winamp and OleMainThreadWindow
by luis lenders May 3, 2005

May 3, 2005

Hi, whenever i run winamp i get an "extra" window like in attached screenshot (in the upper left corner): http://uk.f257.mail.yahoo.com/ym/ShowLetter/Untitled.jpg?viewimg=1&box=Inbo… Further investigation shows it's this window: trace:win:WIN_CreateWindowEx "OleMainThreadWndName" "OleMainThreadWndClass 0x### ##### " ex=00000000 style=88000000 -2147483648,-2147483648 -2147483648x-21474836 48 parent=(nil) menu=(nil) inst=0x65f00000 params=(nil) trace:win:dump_window_styles style: WS_POPUP WS_DISABLED trace:win:dump_window_styles exstyle: trace:win:WIN_CreateWindowEx winproc type is 2 (WIN_PROC_32A) trace:win:WIN_SetWindowLong 0x10022 -12 0 3 trace:win:WIN_CreateWindowEx created window 0x10022 Googling shows it's a kind of hidden window but somehow in wine it gets displayed. Anyone knows why it is displayed and how to get rid of the window, as in windows it is not shown.. Send instant messages to your online friends http://uk.messenger.yahoo.com

2 1

Re: Anyone remember winemine?
by William Poetra Yoga H May 2, 2005

May 2, 2005

--- Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > > Sorry, I mean winmine, one that comes with Windows 98, for example. > Well, can you post a link to the binary? I don't have Win98 right now... The WinXP winmine doesn't. > > Assuming winemine shouldn't shift down by 1 pixel (and it shouldn't), > > Why it shouldn't, when the real minesweeper shifts? > > > the old winemine behaviour is a bug, right? > > I was pretty sure it is an exact mimic of original binary, which comes > from M$. And yes, I didn't look at the code. > Because I think (by reading the code) that the winemine code didn't tell it to shift down... :P William Poetra Yoga Hadisoeseno __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Re: Quicken/CreateCompatibleBitmap issue revisited
by Juan Lang May 2, 2005

May 2, 2005

Hi Rein, > Indeed, what happens if you try this obvious patch: (snip context) - if ((width >= 0x10000) || (height >= 0x10000)) + if ((height && width >= 0x10000) || (width && height >= 0x10000)) This obvious patch is quite wrong, height && width evaluantes to either 0 or 1, same with width && height, so now the fixme will never be produced. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Re: Anyone remember winemine?
by William Poetra Yoga H May 2, 2005

May 2, 2005

--- Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: > Hi, > > On Mon, May 02, 2005 at 02:31:10AM -0700, William Poetra Yoga H wrote: > > > > --- Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > > > > > > Sorry, I mean winmine, one that comes with Windows 98, for example. > > > > > > > Well, can you post a link to the binary? I don't have Win98 right now... > The > > WinXP winmine doesn't. > You certainly know that you'd be bound to violate the > Winmine Software Licensing Restrictions Contractual Terms Of Use > Legal End-User License Agreement > then, right? ;-)) > > Andreas Mohr > Well... I'd rather be bound by the LGPL (winemine) :-D Have you tried the patch? If it's good then I'll submit it :) William Poetra Yoga Hadisoeseno __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

2 1

Re: Make test status - latest CVS
by Juan Lang May 2, 2005

May 2, 2005

Shachar Shemesh wrote: > make[3]: Entering directory `/home/sun/sources/wine/dlls/ole32/tests' > ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p > ole32_test.exe.so stg_prop.c && touch stg_prop.ok > err:heap:HEAP_ValidateInUseArena Heap 401e0000: in-use arena 40218fc8 > next block has PREV_FREE flag > err:heap:HEAP_ValidateInUseArena Heap 401e0000: prev arena 40218f60 is > not prev for in-use 40218fc8 > err:heap:HEAP_ValidateInUseArena Heap 401e0000: prev arena 40218f60 is > not prev for in-use 40218fc8 > err:heap:HEAP_ValidateInUseArena Heap 401e0000: in-use arena 40218fe8 > next block has PREV_FREE flag > err:heap:HEAP_ValidateInUseArena Heap 401e0000: in-use arena 40218fe8 > next block has PREV_FREE flag > stg_prop.c:372: Test failed: Didn't get expected type or value for > property I don't see the same thing here. Could you send me a heap trace? --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: Make test fails on pristine CVS checkout
by gslink May 2, 2005

May 2, 2005

The RH updates for FC3 include a new version of gcc. If you install this it causes problems with things like the kernel and Wine. The Wine CVS will not compile with the new gcc 4. I have not had time to find out why.

2 1

Re: Anyone remember winemine?
by William Poetra Yoga H May 2, 2005

May 2, 2005

--- Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: > Hi, > > On Sun, May 01, 2005 at 08:45:46PM -0700, William Poetra Yoga H wrote: > > Hi, anyone here remember winemine? The whole window just shifts down by one > > pixel whenever we click the smiley in the middle. This patch fixes it. > Oh, I certainly do! > > Nice to have this *very* long-standing bug finally fixed! > > Andreas > Well, being a newbie I simply changed the 2 lines (in the patch). I think it would fix other things too, and I actually still have some fixes for menu bars but I think I'll post them one by one. But I think someone needs to actually verify that the patch doesn't break other apps (hey, maybe a simple check is to submit it and see if it gets merged :P). William Poetra Yoga Hadisoeseno __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: Anyone remember winemine?
by William Poetra Yoga H May 2, 2005

May 2, 2005

--- Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > * On Sun, 1 May 2005, William Poetra Yoga H wrote: > > Hi, anyone here remember winemine? The whole window just shifts down by > > one pixel whenever we click the smiley in the middle. This patch fixes > > it. > > And so does the original winemine, doesn't it? > Which "original winemine"? I mean, this patch fixes the canculations of the window size in user32.dll.so, and it indirectly affects winemine. Assuming winemine shouldn't shift down by 1 pixel (and it shouldn't), the old winemine behaviour is a bug, right? William Poetra Yoga Hadisoeseno __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Anyone remember winemine?
by William Poetra Yoga H May 2, 2005

May 2, 2005

Hi, anyone here remember winemine? The whole window just shifts down by one pixel whenever we click the smiley in the middle. This patch fixes it. P.S: Sorry about my last patch, I didn't check that nonclient.c has moved from windows/ to dlls/user/ :P William Poetra Yoga Hadisoeseno __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com Index: dlls/user/nonclient.c =================================================================== RCS file: /home/wine/wine/dlls/user/nonclient.c,v retrieving revision 1.1 diff -p -u -r1.1 nonclient.c --- dlls/user/nonclient.c 25 Apr 2005 11:33:36 -0000 1.1 +++ dlls/user/nonclient.c 2 May 2005 03:38:54 -0000 @@ -398,7 +398,7 @@ LONG NC_HandleNCCalcSize( HWND hwnd, REC winRect->top += MENU_GetMenuBarHeight( hwnd, winRect->right - winRect->left, - -tmpRect.left, -tmpRect.top ) + 1; + -tmpRect.left, -tmpRect.top ); } if( exStyle & WS_EX_CLIENTEDGE) @@ -1025,7 +1025,7 @@ static void NC_DoNCPaint( HWND hwnd, H TRACE("Calling DrawMenuBar with rect (%ld, %ld)-(%ld, %ld)\n", r.left, r.top, r.right, r.bottom); - rect.top += MENU_DrawMenuBar( hdc, &r, hwnd, suppress_menupaint ) + 1; + rect.top += MENU_DrawMenuBar( hdc, &r, hwnd, suppress_menupaint ); } TRACE("After MenuBar, rect is (%ld, %ld)-(%ld, %ld).\n",

1 0