- Wine-Devel - list.winehq.org

Wine Debugger
by Cal Pierog March 31, 2005

March 31, 2005

I am trying to write a script which, at one point, needs to run the wine test suite, accomplished with: make -k test Even though this skips over bad tests, it does not prevent the debugger from kicking in every once in a while and asking for user input. I would like this script to be robust enough to run the test suite without user input, even when one of the tests fails badly enough to call the debugger. So, is there any way to disable the debugger so that the script can just continue on errors and not sit at a "Wine-dbg>" prompt? Thanks, Cal Pierog

2 1

Regression in comctl32 Treeview (breaks Filezilla)
by Hannu Valtonen March 30, 2005

March 30, 2005

Hi, The following patch: ChangeSet ID: 15259 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/01/07 09:34:25 Modified files: dlls/comctl32 : treeview.c Log message: Crestez Leonard <cleonard(a)go.ro> Fix bug with Treeview_SelectItem reselecting the same item. Patch: http://cvs.winehq.org/patch.py?id=15259 Old revision New revision Changes Path 1.160 1.161 +0 -3 wine/dlls/comctl32/treeview.c Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The way to reproduce it is to go to the Site manager and click the "New site" button. (Doesn't work even with latest CVS) Without the check which the patch removes, if (prevSelect == newSelect) return FALSE; The dialog goes to an infinite loop. (you can exit it if you just hold the ESC-key down for long enough) I have no idea whether the rationale Leonard provided with his patch is correct, but it does break Filezilla. The binary file for Filezilla can be gotten from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?dow… and the source file from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?downl… I would appreciate it if some comctl32 messaging guru could step up and take look at this problem -- - Hannu Valtonen Hannu.Valtonen(a)hut.fi +358408030179

1 1

Re: ScrollWindow fix for windows with WS_CLIPCHILDREN style, with tests - version 2
by Alexandre Julliard March 30, 2005

March 30, 2005

Rein Klazes <wijn(a)wanadoo.nl> writes: > windows : scroll.c > dlls/user/tests : win.c > > If ScrollWindowEx is called with SW_SCROLLCHILDREN flags for a window > with a WS_CLIPCHILDREN style, then do not use the DCX_USESTYLE flag > option to get a DC for this window. With a couple of regression tests. DCX_USESTYLE has other effects, is it really correct to disable them all? And if so, wouldn't it be better to never use DCX_USESTYLE? -- Alexandre Julliard julliard(a)winehq.org

2 1

Fwd: Wine install fails on Gentoo with `SYS_sigaction' undeclared
by Ferenc Wagner March 30, 2005

March 30, 2005

Hi, I think this message better fits here on the devel list. Cheers, Feri. -------------------- Start of forwarded message -------------------- From: "Jonathan Duncan" <googlegroups(a)nacnud.com> Newsgroups: comp.emulators.ms-windows.wine Date: 25 Mar 2005 10:26:46 -0800 Message-ID: <1111775206.112993.209430(a)f14g2000cwb.googlegroups.com> I downloaded "Wine-20050310.tar.gz" Untar/zipped it. Entered the directory "wine-20050310" Typed "./configure" -> Success Typed "make depend" -> Success Typed "make" -> The following is the last of the make process: ------------------------------------------------------------- gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o server.o server.c gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o signal_i386.o signal_i386.c signal_i386.c: In function `wine_sigaction': signal_i386.c:114: error: `SYS_sigaction' undeclared (first use in this function) signal_i386.c:114: error: (Each undeclared identifier is reported only once signal_i386.c:114: error: for each function it appears in.) make[2]: *** [signal_i386.o] Error 1 make[2]: Leaving directory `/home/jduncan/downloads/wine-20050310/dlls/ntdll' make[1]: *** [ntdll] Error 2 make[1]: Leaving directory `/home/jduncan/downloads/wine-20050310/dlls' make: *** [dlls] Error 2 ------------------------------------------------------------- I have tried this as a regualar user and as root. I have tried "./tools/wineinstall". I have tried "make distclean" and then reinstalling. I have tried deleting and recreating the install directory. I am using Gentoo with a linux kernel of 2.6.10 on a dual-Xeon 3.2ghz 64-bit system. Any other ideas would be helpful. Thank you. -------------------- End of forwarded message --------------------

4 3

Re: MSVCRT: implement _chsize
by Alexandre Julliard March 30, 2005

March 30, 2005

Hans Leidekker <hans(a)it.vu.nl> writes: > int _chsize(int fd, long size) > { > - FIXME("(fd=%d, size=%ld): stub\n", fd, size); > - return -1; > + DWORD cur, pos; > + HANDLE handle; > + BOOL ret = FALSE; > + > + TRACE("(fd=%d, size=%ld)\n", fd, size); > + > + LOCK_FILES(); > + > + handle = msvcrt_fdtoh(fd); > + if (handle != INVALID_HANDLE_VALUE) > + { > + /* save the current file pointer */ > + cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); > + if (cur != INVALID_SET_FILE_POINTER) > + { > + pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); > + if (pos != INVALID_SET_FILE_POINTER) > + ret = SetEndOfFile(handle); > + > + /* restore the file pointer */ > + pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); > + } > + } > + > + UNLOCK_FILES(); > + return ret ? 0 : -1; > } SetFilePointer can return INVALID_SET_FILE_POINTER on success if the current pointer is 0xffffffff, you have to check last error in that case. Also you need to set errno on failure. It may be easier to use _lseek instead of SetFilePointer as it takes care of all that already. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: increase robustness for incorrect api usage
by Alexandre Julliard March 30, 2005

March 30, 2005

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > When a context is released, the corresponding heap based struct variable is > zero'ed before being released. When the CryptDestroyHash function is called, > the corresponding context is checked if it was already being zero'ed out. > Note that a heap location is read, which has already been released. However, > this only happens in case of incorrect api usage. This is not guaranteed to > work, but it should be more robust. > > I suspect that windows does it in a similar way. Looking at the actual values > of HCRYPTHASH variables shows that those are addresses in WinXP SP2. > Considering this, I think that the only 100% clean way to implement this > behaviour would be to have a list of currently existing hash and key objects > in the context, which then would be marked invalid when the context is > released. I don't think there's any need to go that far, and I doubt Windows does either. The usual way to handle that is to store a magic number in the struct and clear it on destroy; this is more robust than simply zeroing the pointer since even if the block gets reused it's very unlikely that the proper magic number would get restored. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winetest: ask for a tag
by Robert Shearman March 30, 2005

March 30, 2005

Ferenc Wagner wrote: >ChangeLog: Ask for a tag if one was not given on the command line. > >This patch depends on sizeof(int)==sizeof(char*) for >returning the buffer address from the dialog. If it should >be done differently, please tell me how. > > Use DialogBoxParam. Rob

1 0

Re: MSVCRT: implement _chsize
by Dmitry Timoshkov March 30, 2005

March 30, 2005

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > int _chsize(int fd, long size) > { > - FIXME("(fd=%d, size=%ld): stub\n", fd, size); > - return -1; > + DWORD cur, pos; > + HANDLE handle; > + BOOL ret = FALSE; > + > + TRACE("(fd=%d, size=%ld)\n", fd, size); > + > + LOCK_FILES(); > + > + handle = msvcrt_fdtoh(fd); > + if (handle == INVALID_HANDLE_VALUE) goto exit; > + > + /* save the current file pointer */ > + cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); > + if (cur == INVALID_SET_FILE_POINTER) goto exit; > + > + pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); > + if (pos == INVALID_SET_FILE_POINTER) goto restore; > + > + ret = SetEndOfFile(handle); > + > +restore: > + /* restore the file pointer */ > + pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); > + > +exit: > + if (ret == FALSE) > + { UNLOCK_FILES(); return -1; } > + else > + { UNLOCK_FILES(); return 0; } > } This a pure coding style comment, just ignore it if you are not agree. In order to avoid goto's (absolutely not needed here IMO) and doubled UNLOCK_FILES(): LOCK_FILES(); handle = msvcrt_fdtoh(fd); if (handle != INVALID_HANDLE_VALUE) { /* save the current file pointer */ cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); if (cur != INVALID_SET_FILE_POINTER) { pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); if (pos != INVALID_SET_FILE_POINTER) ret = SetEndOfFile(handle); /* restore the file pointer */ pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); } } UNLOCK_FILES(); return ret ? 0 : -1; -- Dmitry.

1 0

Regression: origin6 crashes with 20050310 (20050211 works)
by Tobias Burnus March 30, 2005

March 30, 2005

Hello, I try to run a freshly installed Origin6.0 with 20050310, but it shows only the splash window and crashes then. Using the previous release 20050211 it runs just fine. While I don't mind compiling Wine and hunting for the patch which causes this problem, the number of patches is rather huge. Do you have some ideas which can shortcut the regression search? Tobias -------------Working-------------- wine-20050211-1.1.i586.rpm: > wine Origin60.exe fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window width -22 fixme:profile:GetPrivateProfileIntW result may be wrong! fixme:storage:StgCreateDocfile Transacted mode not implemented. fixme:storage:StgCreateDocfile Transacted mode not implemented. [...] ----------Crashing---------------- wine-20050310-0.1.i586.rpm: > wine Origin60.exe fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window width -22 fixme:msvcrt:_XcptFilter (-1073741819,0x406db1cc)semi-stub wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x20649124 in 32-bit code (0x40f27ca0). In 32 bit mode. Register dump: [...] Stack dump: [...] Backtrace: =>1 0x40f27ca0 cxx_frame_handler+0x1c0 in msvcrt (0x406db6e4) 2 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406db708) 3 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dba70) 4 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dbabc) 5 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dbb6c) 6 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dbb88) 7 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x406dbf78) 8 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406dbf9c) 9 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dc304) 10 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dc350) 11 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dc400) 12 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dc41c) 13 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x406dc80c) 14 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406dc830) 15 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dcb98) 16 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dcbe4) 17 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dcc94) 18 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dccb0) 19 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x40450358) 20 0x00000001 (0x00407244) 21 0x00401970 in origin60 (+0x1970) (0x00401910) 22 0x9090c300 (0x407190b8) 0x40f27ca0 cxx_frame_handler+0x1c0 in msvcrt: movl 0xc(%edi),%eax Modules:[...] +relay output: ---------------------- 000b:Call user32.CallWindowProcA(409def2c,00010084,00000111,050103e9,00010088) ret=5f401ee9 000b:Call window proc 0x409def2c (hwnd=0x10084,msg=WM_COMMAND,wp=050103e9,lp=00010088) 000b:Call window proc 0x5f4019fa (hwnd=0x10066,msg=WM_COMMAND,wp=ffff026e,lp=00010084) 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call user32.GetParent(0001003a) ret=5f401281 000b:Ret user32.GetParent() retval=00000000 ret=5f401281 000b:Call user32.SendMessageA(0001003a,00000111,ffff026e,00010084) ret=5f462ceb 000b:Call window proc 0x5f4019fa (hwnd=0x1003a,msg=WM_COMMAND,wp=ffff026e,lp=00010084) 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.UnhandledExceptionFilter(406cd50c) ret=40c8f2b8 000b:Call ntdll.NtQueryVirtualMemory(ffffffff,000000b4,00000000,406cd410,0000001c,406cd3cc) ret=40532d52 000b:Ret ntdll.NtQueryVirtualMemory() retval=00000000 ret=40532d52 000b:Call ntdll.RtlImageDirectoryEntryToData(00000000,00000001,00000002,406cd40c) ret=404f6029 000b:Ret ntdll.RtlImageDirectoryEntryToData() retval=00000000 ret=404f6029 000b:Call ntdll.NtCreateEvent(406cd3d8,001f0003,406cd3dc,00000001,00000000) ret=404f5f79 000b:Ret ntdll.NtCreateEvent() retval=00000000 ret=404f5f79 wine: Unhandled exception (thread 000b), starting debugger..

1 1

specified Windows directory not accessible
by Wesley Parish March 30, 2005

March 30, 2005

I get this response when I try to install the VCToolkit. [wparish(a)localhost wine-hdd]$ wine ./VCToolkitSetup.exe Warning: the specified Windows directory L"C:\\windows" is not accessible. Warning: the specified System directory L"C:\\windows\\system" is not accessible. Warning: could not find DOS drive for current working directory '/home/wparish/wine-hdd', starting in the Windows directory. wine: cannot find './VCToolkitSetup.exe' What have I missed, or misconfigured? (I'm officially running 20040813, though I compiled and installed 20050211 over it - I hadn't read that I should uninstall the previous wine installation before installing a new one. :) Wesley Parish -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

2 1