- Wine-Devel - list.winehq.org

Re: MSVCRT: implement _chsize (RESEND)
by Alexandre Julliard March 29, 2005

March 29, 2005

Hans Leidekker <hans(a)it.vu.nl> writes: > Anything wrong with this one? > > This should fix apps built with MinGW (bug report 2826). You should at least restore the file position before returning, though it would probably be better to not change the file position at all, this is not thread safe. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: KERNEL: improve stubs for DnsHostnameToComputerName{A,W} (RESEND)
by Dmitry Timoshkov March 29, 2005

March 29, 2005

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > +BOOL WINAPI DnsHostnameToComputerNameA(LPCSTR hostname, > + LPSTR computername, LPDWORD size) > + for (i = 0; i <= len; i++) > + computername[i] = toupper(hostname[i]); You can't use toupper() from glibc on a name in a Windows encoding. Why not just call a W version to do the job? -- Dmitry.

2 1

BadDrawable and install shield.
by Oliver Stieber March 29, 2005

March 29, 2005

Hi, I've been having a lot of problems with install shield and BadDrawables. 1: Does anyone know what's causing the problem? 2: Are there any plans to implement XSetErrorHandler and manager the errors better, even if it's an int3 that winedbg can catch. e.g. int myXErrorHandler(Display *display, XErrorEvent *xError){ switch(xError->type){ case BadDrawable: break; default: int3(); return XErrorHandler(NULL); } Xerror = xError->error_code; return 0; /* return value ignored */ } oid setErrorHandler(void){ XSetErrorHandler(myXErrorHandler); } void dosomething(void){ Xerror = 0; SomeXCall(); if(Xerror){ /* call failed, take appropriate action */ } } Some examples are.... http://www.download.com/Aliens-vs-Predator-2-single-player-demo/3000-7563_4… fixme:sync:SetNamedPipeHandleState 0xa8 0xb5bd50d4 (nil) (nil) wine: Unhandled exception (thread 002f), starting debugger... WineDbg starting on pid 0x11 X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 67 (X_PolyRectangle) Resource id in failed request: 0x6200007 Serial number of failed request: 989 Current serial number in output stream: 1049 http://games.softpedia.com/get/Games-Demo/Crazy-Taxi-Demo.shtml X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 62 (X_CopyArea) Resource id in failed request: 0x6000007 Serial number of failed request: 3252 Current serial number in output stream: 3258 http://www.download.com/1503-A-D-The-New-World-demo/3000-7485_4-10228730.ht… fixme:x11drv:X11DRV_SetWindowRgn not supported on other thread window 0x3002e X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 62 (X_CopyArea) Resource id in failed request: 0x5a00007 Serial number of failed request: 3152 Current serial number in output stream: 3158 http://www.download.com/Colin-McRae-Rally-2005-demo/3000-7531_4-10312485.ht… crashes at the end with fixme:propsheet:PROPSHEET_UnImplementedFlags PSH_RTLREADING X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 62 (X_CopyArea) Resource id in failed request: 0x6600007 Serial number of failed request: 28770 Current serial number in output stream: 28799 -- ICQ 169222899 MSN oliverthered(a)hotmail.com

2 2

Re: [PATCH] MapiSendMail() implementation
by Andreas Mohr March 29, 2005

March 29, 2005

Hi, On Mon, Mar 07, 2005 at 11:54:56AM +0100, Jan Schiefer wrote: > This is an attempt of an basic MAPISendMail() implementation. > It does, what is should, it sends mails. > > Much more work is needed especially to clean it up and to implement more > features. ( Getting rid of printf's would be a good point to start... ) You mean much more work such as including mail.c in the patch? :) Andreas Mohr

6 7

Max Payne 2 IDirect3DDevice8Impl_ActiveRender error
by Tom Huckstep March 29, 2005

March 29, 2005

Max Payne 2 works fine under the latest Wine CVS through all the 2D parts (menus), but as soon as I start a new game and it gets to a 3D bit the screen goes completely blank and I get lots of the following error on my terminal: err:d3d:IDirect3DDevice8Impl_ActiveRender cannot get valides GLXFBConfig for ... Does anyone have any idea why this is? Tom

2 4

Preloader Compiles with Coverage Flags
by Aaron Arvey March 29, 2005

March 29, 2005

This is handy for when you want to compile entire wine source with gcov coverage analysis enabled. See http://www.winehq.org/hypermail/wine-patches/2005/02/0000.html for more information on how to compile wine with gcov support. Changelog: * loader/preloader.c adds empty __bb_init_func function Signed-off-by: Aaron Arvey <aarvey_at_cs.hmc.edu> Index: loader/preloader.c =================================================================== RCS file: /home/wine/wine/loader/preloader.c,v retrieving revision 1.13 diff -u -3 -p -r1.13 preloader.c --- loader/preloader.c 22 Mar 2005 16:42:25 -0000 1.13 +++ loader/preloader.c 29 Mar 2005 10:51:06 -0000 @@ -143,6 +143,12 @@ struct wld_link_map { ElfW(Addr) l_interp; }; +/* + * The __bb_init_func is an empty function only called when file + * is compiled with gcc flags "-fprofile-arcs -ftest-coverage". + * If using these flags, this function is necessary to compile. + */ +void __bb_init_func(){return;} /* * The _start function is the entry and exit point of this program

2 1

Re: winspool: some unicodification
by Huw D M Davies March 29, 2005

March 29, 2005

On Tue, Mar 29, 2005 at 12:26:47AM -0500, Dimitrie O. Paun wrote: > ChangeLog > Unicodify WINSPOOL_OpenDriverReg(). > > > Index: dlls/winspool/info.c > =================================================================== > RCS file: /var/cvs/wine/dlls/winspool/info.c,v > retrieving revision 1.101 > diff -u -r1.101 info.c > --- dlls/winspool/info.c 21 Feb 2005 18:33:55 -0000 1.101 > +++ dlls/winspool/info.c 29 Mar 2005 05:23:05 -0000 > @@ -70,8 +70,13 @@ > > static const char Printers[] = > "System\\CurrentControlSet\\control\\Print\\Printers\\"; > -static const char Drivers[] = > -"System\\CurrentControlSet\\control\\Print\\Environments\\%s\\Drivers\\"; > + > +static const WCHAR DriversW[] = { 'S','y','s','t','e','m','\\','\\', > + 'C','u', 'r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\','\\', > + 'c','o','n','t','r','o','l','\\','\\', > + 'P','r','i','n','t','\\','\\', > + 'E','n','v','i','r','o','n','m','e','n','t','s','\\','\\', > + '%','s','\\','\\','D','r','i','v','e','r','s','\\','\\',0 }; > That's not quite right. I guess you need to tweak your unicodification macro ;-) Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: KERNEL32: implement CallNamedPipe
by Dmitry Timoshkov March 29, 2005

March 29, 2005

"Mike McCormack" <mike(a)codeweavers.com> wrote: > ChangeLog: > * implement CallNamedPipe > + handle = CreateFileW( lpNamedPipeName, GENERIC_READ|GENERIC_WRITE, > + 0, NULL, OPEN_EXISTING, 0, NULL ); > + if( !handle ) > + return FALSE; CreateFile returns INVALID_HANDLE_VALUE on failure. -- Dmitry.

1 0

Re: Patch
by Dmitry Timoshkov March 29, 2005

March 29, 2005

"Leonardo Krause" <leonardo.krause(a)serpro.gov.br> wrote: > + if ( ((keysym == 0xFF9F) || (keysym == 0x2C)) && (e->state & NumLockMask)) > + { > + if (keysym == 0xFF9F) > + return nonchar_key_vkey[keysym & 0xFF]; > + if (keysym == 0x2C) > + return keyc2vkey[0x3B]; > + } You need to at least use appropriate symbolic names instead of vague numbers. -- Dmitry.

1 0

Re: version: Use proper type for third parameter of VerQueryValue
by Dmitry Timoshkov March 29, 2005

March 29, 2005

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * Use proper type for third parameter of VerQueryValue > -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); > -DWORD WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); > +BOOL WINAPI VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*); > +BOOL WINAPI VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*); Where did you get it? PSDK agrees with current Wine definition on the 3rd param type. Also the 2nd param should not be 'const'. -- Dmitry.

3 3