- Wine-Devel - list.winehq.org

SetFocus and DefPushButton management
by Katia Maculan March 16, 2005

March 16, 2005

After the creation of a dialog if the focus is set on a PushButton this one must have also the BS_DEFPUSHBUTTON style like in windows. Attached the patch with a regression test. Katia -- Katia Maculan Developer ISIS Papyrus Italy Srl Tel: (+39) 0125 6455400 Fax: (+39) 0125 6455400 E-mail: katia.maculan(a)isis-papyrus.com Info: info(a)isis-papyrus.com Hotline: +43-2236-27551-111 Visit our Website: http://www.isis-papyrus.com diff -urN oldwinedir/dlls/user/tests/dialog.c newwinedir/dlls/user/tests/dialog.c --- oldwinedir/dlls/user/tests/dialog.c 2005-03-07 12:12:40.000000000 +0100 +++ newwinedir/dlls/user/tests/dialog.c 2005-03-14 16:33:03.000000000 +0100 @@ -849,6 +849,40 @@ } } +static LRESULT CALLBACK DlgFocusProc (HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) +{ + HWND hwndFocusCtrl = NULL; + HWND hwndDefPushButton = NULL; + LRESULT DlgCode; + LRESULT CtrlState; + switch (message) + { + case WM_INITDIALOG: + PostMessage(hDlg, WM_USER, 0, 0); + return TRUE; + + case WM_USER: + // Check if the focus is on IDOK button + CtrlState = SendMessage (GetDlgItem(hDlg, IDOK), BM_GETSTATE, 0, 0); + if (CtrlState == BST_FOCUS) + hwndFocusCtrl = GetDlgItem(hDlg, IDOK); + // Check if IDOK is the default push button + DlgCode = SendMessage (GetDlgItem(hDlg, IDOK), WM_GETDLGCODE, 0, 0); + if (DlgCode & DLGC_DEFPUSHBUTTON) + hwndDefPushButton = GetDlgItem(hDlg, IDOK); + ok (hwndFocusCtrl && hwndDefPushButton, "The focus and the DLGC_DEFPUSHBUTTON style are not in the same button\n"); + EndDialog(hDlg, LOWORD(wParam)); + return TRUE; + } + return FALSE; + +} + +static void InitialFocusTest1 (void) +{ + DialogBox(g_hinst, "DEFPUSHBUTTON_TEST_DIALOG", NULL, (DLGPROC)DlgFocusProc); + +} START_TEST(dialog) { @@ -860,4 +894,5 @@ IsDialogMessageWTest(); WM_NEXTDLGCTLTest(); InitialFocusTest(); + InitialFocusTest1(); } diff -urN oldwinedir/windows/dialog.c newwinedir/windows/dialog.c --- oldwinedir/windows/dialog.c 2005-03-07 12:12:54.000000000 +0100 +++ newwinedir/windows/dialog.c 2005-03-14 16:30:19.000000000 +0100 @@ -669,8 +669,23 @@ { /* By returning TRUE, app has requested a default focus assignment */ dlgInfo->hwndFocus = GetNextDlgTabItem( hwnd, 0, FALSE); - if( dlgInfo->hwndFocus ) - SetFocus( dlgInfo->hwndFocus ); + if (dlgInfo->hwndFocus) + { + SetFocus( dlgInfo->hwndFocus ); + HWND hWndOldDefPushButton = NULL; + if (SendMessageW(dlgInfo->hwndFocus, WM_GETDLGCODE, 0, 0) + & (DLGC_UNDEFPUSHBUTTON | DLGC_BUTTON)) + { + SendMessageA (dlgInfo->hwndFocus, BM_SETSTYLE, BS_DEFPUSHBUTTON, TRUE); + /*Check for a previous defpushbutton*/ + if (dlgInfo->idResult) + { + hWndOldDefPushButton = GetDlgItem (hwnd,dlgInfo->idResult); + if (hWndOldDefPushButton && (hWndOldDefPushButton != dlgInfo->hwndFocus)) + SendMessageA (hWndOldDefPushButton, BM_SETSTYLE, BS_PUSHBUTTON, TRUE); + } + } + } } if (template.style & WS_VISIBLE && !(GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE))

3 2

wine + winamp: fixme:wave:OSS_AddRingMessage two fast messages in the queue!!!!
by seut March 16, 2005

March 16, 2005

hello, we are using winamp 2.95 with latest wine 0.0.20040914 and are wondering what there is about these 'fixme:wave:OSS_AddRingMessage two fast messages in the queue!!!!' messages dumped out at the console every few seconds... Same happens(but with 'ALSA_AddRingMessages' of course) if we're using the wine alsa-driver. Winamp normally works, but sometimes there is a 15sec pause at the playback, so we are trying to search the problem. I watched the wine source-code, but as my less C knowledge I didn't really understand the part where this 'FIXME' message is implemented. As I understand the code, why somebody added the 'FIXME' message to the code, if the code can handle this problem(two fast messages)? Or can somebody explain me the reason for this 'two fast messages'? thanks a lot seut btw. I'm not a member of the mailing-list, so please send answer to me too! and please don't suggest us to use a native linux-player instead, for some reasons, we have to use winamp..

2 2

Re: Are mailslots implemented?
by Kuba Ober March 16, 2005

March 16, 2005

> |>>Which application uses mailslots? I only ever found one real > |>>application that used them, and that was "Declan's Korean Dictionary" > |>>from [1]. > |> > |>The browse (Network Neighborhood) service uses them. Other then that, > |>I have not seen any uses of it. > | > | Protel 98 (likely higher versions too) uses them. > | > | MSDN says that the datagrams are limited to 424 bytes in length, so > > even if > > | they are not very useful otherwise, getting Protel running on wine > > seems a > > | worthy goal to me. I'll try hacking on it and seeing where I end up. > > See http://www.ubiqx.org/cifs/Browsing.html#BRO.3 for more information > libsmbclient from Samba 3 does not support it at the moment What do the "match_mailslot_name" and "cli_send_mailslot" functions do, then? Anyway, if the wire protocol is simple enough, and so it seems from ubiqx.org article, then I can just synthesize all the relevant layers to send the multicast UDP. The only piece of info that I'll (hopefully) need from wine is the netbios node name. For reception, I'll bind UDP port 138 (netbios-dgm) if it's not already bound, to receive the mailslots coming in. Now, if a samba server is already running on given host, which is reasonable if the person running wine wants to share something with other windows hosts, is it possible to somehow poll the nmbd and/or smbd to get the mailslot datagrams that weren't "consumed" by the browsing protocols? Does that make sense? Any more hints? Cheers, Kuba

7 8

Problem with winebuild
by Robert Lunnon March 16, 2005

March 16, 2005

The following problem is evident under solaris NULL pointer passed to printf I'm not sure if this is a poblem with the spec file or winebuild.... Still it's not good to pass NULL pointers to printf Starting program: /export/home/src/wine2004/wine/tools/winebuild/winebuild -w --def -o amstream/amstream.spec.def --export amstream/amstream.spec Program received signal SIGSEGV, Segmentation fault. 0xd2722a6c in strlen () from /usr/lib/libc.so.1 (gdb) bt #0 0xd2722a6c in strlen () from /usr/lib/libc.so.1 #1 0xd2777d3e in _ndoprnt () from /usr/lib/libc.so.1 #2 0xd277a8b7 in fprintf () from /usr/lib/libc.so.1 #3 0x0805d962 in BuildDef32File (outfile=0x8077078, spec=0x8077630) at spec32.c:848 #4 0x08054819 in main (argc=7, argv=0x80477f4) at main.c:469

3 4

Re: dlls/shell32/shelllink.c
by Mike McCormack March 16, 2005

March 16, 2005

Ge van Geldorp wrote: > I have some shortcuts (created in Windows 2000) which only have 24 bytes of > LOCATION_INFO, i.e. they are missing the dwFinalPathOfs member. > Also lots of shortcuts seem to have another chunk at the end of the stream, > I get a lot of "Last word was not zero" messages. Could you send me a shortcut like that, or even modify winedump (lnk mode) to dump out the right thing in that case? thanks, Mike

2 1

Re: dlls/shell32/shelllink.c (please don't apply)
by Mike McCormack March 16, 2005

March 16, 2005

Ge van Geldorp wrote: > - ERR("Last word was not zero\n"); > + TRACE("Last word was not zero\n"); btw. the right solution is to fix the problem, not ignore it, so I object to this patch being applied as is. Mike

1 0

Re: combo - implement GetComboBoxInfo
by Steven Edwards March 16, 2005

March 16, 2005

Hi, --- Alexandre Julliard <julliard(a)winehq.org> wrote: > The IsWindow check is useless, what you need is to verify that it's > really a combobox. The right way to do that is probably to send a > CB_GETCOMBOBOXINFO message instead. How about something like this instead? Index: dlls/user/combo.c =================================================================== RCS file: /home/wine/wine/dlls/user/combo.c,v retrieving revision 1.8 diff -u -r1.8 combo.c --- dlls/user/combo.c 23 Dec 2004 17:21:05 -0000 1.8 +++ dlls/user/combo.c 15 Mar 2005 19:09:52 -0000 @@ -27,7 +27,6 @@ * If you discover missing features, or bugs, please note them below. * * TODO: - * - GetComboBoxInfo() * - ComboBox_[GS]etMinVisible() * - CB_GETCOMBOBOXINFO * - CB_GETMINVISIBLE, CB_SETMINVISIBLE @@ -2293,10 +2292,27 @@ /************************************************************************* * GetComboBoxInfo (USER32.@) */ -BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ - PCOMBOBOXINFO pcbi /* [in/out] combo box information */) -{ - FIXME("\n"); - return FALSE; - +BOOL WINAPI +GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ + PCOMBOBOXINFO pcbi /* [in/out] combo box information */) +{ + static const WCHAR ComboBoxW[] = { 'C', 'o', 'm', 'b', 'o', 'B', 'o', 'x', 0 }; + CHAR szBuffer[MAX_PATH + 1]; + int dwSize; + LPHEADCOMBO lphc; + + dwSize = GetClassNameW(hwndCombo, szBuffer, sizeof(szBuffer)/sizeof(szBuffer[0])-1); + + if (lstrcmpiW(szBuffer, ComboBoxW) != 0) + return FALSE; + + lphc = (LPHEADCOMBO)GetWindowLongPtrW( hwndCombo, 0 ); + + pcbi->hwndCombo = hwndCombo; + pcbi->hwndList = lphc->hWndLBox; + pcbi->hwndItem = lphc->hWndEdit; + pcbi->rcItem = lphc->textRect; + pcbi->rcButton = lphc->buttonRect; + pcbi->stateButton = lphc->wState; + return TRUE; } __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

5 5

Debugging idiosyncrasy
by Paul Millar March 16, 2005

March 16, 2005

Hi, Something I've noticed whilst playing with winedbg (and its auto mode). If there's no AeDebug key in the registry, then the default is to run the debugger in non-interactive mode: paul(a)scaramanga:~/CVS/wine$ grep cmdline.*winedbg dlls/kernel/except.c sprintf(cmdline, "winedbg --auto %ld %ld", Yet, if there's no registry at all, then the default registry values are configured to run the debugger in interactive mode: paul(a)scaramanga:~/CVS/wine$ grep AeDebug.*Debugger tools/wine.inf HKLM,Software\Microsoft\Windows NT\CurrentVersion\AeDebug,"Debugger",,"winedbg %ld %ld" I think we should be consistent here, no? Cheers, Paul

1 0

Got message form ./configure to send this e-mail
by Lauris Misa March 16, 2005

March 16, 2005

Hello! I'm trying to compile wine on my AMD64 system and I got this message on STDERR: configure: WARNING: valgrind/memcheck.h: present but cannot be compiled configure: WARNING: valgrind/memcheck.h: check for missing prerequisite headers? configure: WARNING: valgrind/memcheck.h: see the Autoconf documentation configure: WARNING: valgrind/memcheck.h: section "Present But Cannot Be Compiled" configure: WARNING: valgrind/memcheck.h: proceeding with the preprocessor's result configure: WARNING: valgrind/memcheck.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## and of course it crashes when I run make depend.;( Is there some way to get wine compiled? Thank You! Lauris >LMP< -- For people who like peace and quiet: a phoneless cord.

1 0

Re: shell32: set %AllUsersProfile%, and fix shell folder registration
by Juan Lang March 16, 2005

March 16, 2005

--- Alexandre Julliard <julliard(a)winehq.org> wrote: > > ChangeLog: > > - %AllUsersProfile% was not getting set in the environment, spotted by > > Vitaly Lipatov > > This should be done in wine.inf, not in the code. Okay, but it's a subdirectory of the windows directory, and that's no longer getting set in wine.inf either. I rely on GetWindowsDirectory to find it. If you want it back here though I'll move it. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

2 1