- Wine-Devel - list.winehq.org

[badpenguin79@hotmail.com: [Full-disclosure] [ZH2005-02SA] Insecure tmp file creation in Wine]
by Marcus Meissner March 15, 2005

March 15, 2005

Hi, >From full-disclosure, a security mailing list. Fix seems trivial, just use 0600. (untested, uncompiled ;) Ciao, Marcus Changelog: Temporary registries exported only user read/writeable to avoid information leaks. Index: server/registry.c =================================================================== RCS file: /home/wine/wine/server/registry.c,v retrieving revision 1.63 diff -u -r1.63 registry.c --- server/registry.c 10 Mar 2005 11:18:31 -0000 1.63 +++ server/registry.c 14 Mar 2005 16:38:54 -0000 @@ -1610,7 +1610,7 @@ for (;;) { sprintf( p, "reg%lx%04x.tmp", (long) getpid(), count++ ); - if ((fd = open( tmp, O_CREAT | O_EXCL | O_WRONLY, 0666 )) != -1) break; + if ((fd = open( tmp, O_CREAT | O_EXCL | O_WRONLY, 0600 )) != -1) break; if (errno != EEXIST) goto done; close( fd ); } Index: misc/registry.c =================================================================== RCS file: /home/wine/wine/misc/registry.c,v retrieving revision 1.149 diff -u -r1.149 registry.c --- misc/registry.c 25 Aug 2004 00:48:47 -0000 1.149 +++ misc/registry.c 14 Mar 2005 16:38:55 -0000 @@ -1227,7 +1227,7 @@ ret = _xmalloc(50); for (count = 0;;) { sprintf(ret,"/tmp/reg%lx%04x.tmp",(long)getpid(),count++); - if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0666)) != -1) break; + if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0600)) != -1) break; if (errno != EEXIST) { ERR("Unexpected error while open() call: %s\n",strerror(errno)); free(ret);

3 4

Re: dinput.diff
by Alexandre Julliard March 15, 2005

March 15, 2005

Tom Wickline <twickline(a)gmail.com> writes: > Changelog: increase the maximum number of devices to 16 Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Are mailslots implemented?
by Kuba Ober March 15, 2005

March 15, 2005

Hi, Is the one-way mailslot IPC implemented in wine? I'm getting fixme:sync:CreateMailslotW(...): stub messages. Is this a simple thing to implement, or would it require additions to the server protocol? Thanks, Kuba Ober

4 5

Re: make_ctests - convert make_ctests to C
by Andreas Mohr March 15, 2005

March 15, 2005

Hi, On Mon, Mar 14, 2005 at 08:35:19PM -0800, Steven Edwards wrote: > Convert make_ctests script to C That one contains DOS line endings (^M). Andreas Mohr

1 0

Re: [DSOUND] little patch
by Robert Reif March 15, 2005

March 15, 2005

Raphael wrote: >Hi > >Changelog: > - try to have better match caps with hw caps so games can active more hw >support > >Regards, >Raphael > > > >- This->lock.DebugInfo->Spare[1] = 0; >+ /*This->lock.DebugInfo->Spare[1] = 0;*/ > DeleteCriticalSection(&(This->lock)); > > You have to zero this out or DeleteCriticalSection will try to delete that static memory. >+ if (pDS->drvcaps.dwFlags | DSCAPS_PRIMARYMONO) pDS->pwfx->nChannels = 1; >+ if (pDS->drvcaps.dwFlags | DSCAPS_PRIMARY16BIT) pDS->pwfx->wBitsPerSample = 16; >+ pDS->pwfx->nBlockAlign = pDS->pwfx->wBitsPerSample * pDS->pwfx->nChannels / 8; >+ pDS->pwfx->nAvgBytesPerSec = pDS->pwfx->nSamplesPerSec * pDS->pwfx->nBlockAlign; >+ > You can't do this and be compatible with windows. > >+#ifndef __WINE_DSOUND_PRIVATE_H >+#define __WINE_DSOUND_PRIVATE_H > You can't include this more than once because there is only one .h file so it's not really necessary. >+#define WINE_SET_CS_NAME(cs, name) (cs)->DebugInfo->Spare[1] = (DWORD) name >+#define WINE_GET_CS_NAME(cs) (const char*) (cs)->lock.DebugInfo->Spare[1] > > This is a wine specific trick and should probably be put somewhere global so all users can be consistent. The name should have DEBUG in it somewhere.

3 5

Re: wine/ misc/registry.c documentation/samples/co ...
by Dimitrie O. Paun March 15, 2005

March 15, 2005

On Mon, Mar 14, 2005 at 11:18:40AM -0600, Alexandre Julliard wrote: > Log message: > Get rid of the remaining registry configuration parameters. Any plans on getting the global registry back? -- Dimi.

2 1

Problems with VirtualAlloc/Lock
by MIchael Ost March 15, 2005

March 15, 2005

There are major differences in the handling of virtual memory in Wine vs WinXP that are causing problems for my winelib application. Can someone provide background and/or workarounds for these issues? As near as I can tell the main differences are: * VirtualLock does nothing in Wine * Wine makes no distinction between MEM_RESERVE and MEM_COMMIT * Wine has no implementation of Windows' process working sets * Wine limits MEM_RESERVE to 1GB, but WinXP goes up to 2GB The above problems seem relatively harmless on systems with < 1GB RAM. But when our units go greater than 1GB we are seeing spectacular crash-and-burn failures. The code-only DLLs we are running on such systems are crashing at a stage when I suspect they are attempting to lock RAM. I suspect that they are confused by the report from GlobalMemoryStatus that more than 1GB of RAM is installed, but that they are only able to VirtualLock up to 1GB. And in this unexpected situation, they are crashing. Further, these DLLs are audio processing plugins. The apparent fact that VirtualLock doesn't _actually_ lock memory into RAM for real time processing is a disaster for our system, in that it causes audio glitches when a page fault is handled. But that is not a problem which crashes the system. Any suggestions on what to do? Is there any pending work on this area out there? I've attached a little table that describes what I found. It shows the differences in how Wine and WinXP handle memory related calls. I have also attached a simple program which can be run to see these differences. Thanks for any help... mo

4 4

Re: combo - implement GetComboBoxInfo
by Dimitrie O. Paun March 15, 2005

March 15, 2005

On Mon, Mar 14, 2005 at 08:02:00PM -0800, Steven Edwards wrote: > - FIXME("\n"); > - return FALSE; > + LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongA( hwndCombo, 0 ); Please use GetWindowLongW(), the combo box is fully Unicode. > + pcbi->hwndCombo = hwndCombo; > + pcbi->hwndList = lphc->hWndLBox; > + pcbi->hwndItem = lphc->hWndEdit; > + pcbi->rcItem = lphc->textRect; > + pcbi->rcButton = lphc->buttonRect; > + pcbi->stateButton = (DWORD) lphc->wState; Fancy formatting... Bit yucky, no? -- Dimi.

2 1

Re: combo - implement GetComboBoxInfo
by Dmitry Timoshkov March 15, 2005

March 15, 2005

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ > PCOMBOBOXINFO pcbi /* [in/out] combo box information */) > { > - FIXME("\n"); > - return FALSE; > + LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongA( hwndCombo, 0 ); > + > + pcbi->hwndCombo = hwndCombo; > + pcbi->hwndList = lphc->hWndLBox; > + pcbi->hwndItem = lphc->hWndEdit; > + pcbi->rcItem = lphc->textRect; > + pcbi->rcButton = lphc->buttonRect; > + pcbi->stateButton = (DWORD) lphc->wState; > > + return TRUE; > } Is it possible to do a check for lphc being NULL and keep indentation/spacing similar to the rest of the file? Also (DWORD) cast should not be needed. -- Dmitry.

1 0

Re: combo - implement GetComboBoxInfo
by Steven Edwards March 15, 2005

March 15, 2005

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > Please use GetWindowLongW(), the combo box is fully Unicode. OK I will hack it for him. This guy is new to C programing and I should have caught that. He has a bunch of VB apps that he uses this function in. > > + pcbi->hwndCombo = hwndCombo; > > + pcbi->hwndList = lphc->hWndLBox; > > + pcbi->hwndItem = lphc->hWndEdit; > > + pcbi->rcItem = lphc->textRect; > > + pcbi->rcButton = lphc->buttonRect; > > + pcbi->stateButton = (DWORD) lphc->wState; > > Fancy formatting... Bit yucky, no? Argh. Welcome to the Visual Studio 2005 Beta1, It even fscks your formatting in all sorta nice new ways. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0