- Wine-Devel - list.winehq.org

Re: WIDL - Sync to ReactOS 20050308
by Rob Shearman March 8, 2005

March 8, 2005

Steven Edwards wrote: >No one really got back to me on how handles should be done in the dcom.idl so I am going assume >this is correct. If this has gotten too big let me know and I can break it up in to smaller >patches over the next week. > > Sorry Steven, I meant to investigate this before but I forgot. >Index: dlls/ole32/dcom.idl >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/dcom.idl,v >retrieving revision 1.1 >diff -u -b -r1.1 dcom.idl >--- dlls/ole32/dcom.idl 22 May 2003 03:36:26 -0000 1.1 >+++ dlls/ole32/dcom.idl 8 Mar 2005 18:28:18 -0000 >@@ -217,6 +217,7 @@ > > cpp_quote("#if 0") > [ >+ explicit_handle, > uuid(99fcfec4-5260-101b-bbcb-00aa0021347a), > pointer_default(unique) > ] > > explicit_handle is an ACF attribute and not something that should normally be put in an IDL file. Furthermore, it is not necessary, as stated by MSDN: "If the *[explicit_handle]* attribute is not used, the application can still specify that an operation have an explicit handle (binding or serialization) directing the call." I think there is an MIDL command-line option to allow ACF attributes in IDL files though. Rob

1 0

Re: More implementation of IRecordInfo
by Maxime Bellengé March 8, 2005

March 8, 2005

You have forgotten the patch :) On Tue, 2005-03-08 at 20:18 +0100, Jacek Caban wrote: > This patch makes IRecordInfo almost complete. > If anyone knows any application using it I could test on, > please let me know. > > Changelog: > More implementation of IRecordInfo > >

1 0

Re: [PATCH] Add search functionality to WINE regedit
by Oliver Stieber March 8, 2005

March 8, 2005

--- Mike Hearn <mike(a)navi.cx> wrote: > Jan Schiefer wrote: > > It's already fully cleaned up and ready to go! I > know other people hate > > my coding style... :) > > Awww, it's not hate, you just need to be careful > about how the code is > laid out and what features you use. You'll need to > fix this patch in a > few places so here are some comments: > Also.. if(uMsg != 193) { // if uMsg == 193, tmpLen is always 0! no C++ style comments. try to use /* comment */ I use this a file containing ^[[:space:]]+# // /\*[^[:space:]]\w \w[^[:space:]]\*/ if\( )[[:alpha:]] with find -mtime -10 -iregex ".*\.[c | h]" -exec egrep --file="filewithchecks" "{}" -n \; -print add -wError and -Werror-implicit-function-declaration and -Wdeclaration-after-statement for gcc >= 3.4 to cflags in your Makefile. I'll post a patch so that the whole of wine can be built with -wError on gcc >=3.3 soon, for the brave use: (long long) for shift errors >> 32 is greater than .... programs/winehlp uses %x so the Makefile needs -Wno-format-y2k in it's CFLAGS and add register int src char * in libs/port/memmove.c Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Re: [PATCH] Add search functionality to WINE regedit
by Mike Hearn March 8, 2005

March 8, 2005

Jan Schiefer wrote: > It's already fully cleaned up and ready to go! I know other people hate > my coding style... :) Awww, it's not hate, you just need to be careful about how the code is laid out and what features you use. You'll need to fix this patch in a few places so here are some comments: It's usually a good idea to submit the backend *first* and then the frontend, or better .. have them done all at once. Patches are supposed to be standalone, not stuff that'll only start working later (in the general case). For now I'd combine the two patches. > + GROUPBOX "Look at",IDC_FIND_GROUPBOX, 5, 25, 194, 46, BS_GROUPBOX > + CHECKBOX "Keys", IDC_CHECKBOX_KEYS, 10, 36, 60, 10 Try and keep alignment consistent, otherwise there's just extra visual noise for no good reason! > +LRESULT CALLBACK findedit_proc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam) { > +if(uMsg != 193) { // if uMsg == 193, tmpLen is always 0! > +int tmpLen = SendMessage(hWnd, EM_LINELENGTH, 0, 0); > +if(tmpLen != searchStringLen) { > +if(tmpLen > 0)EnableWindow(hFindButton, TRUE); > +else EnableWindow(hFindButton, FALSE); > +searchStringLen = tmpLen; > +} > +} > +return CallWindowProc ((WNDPROC) prevWndProcEdit, hWnd, uMsg, wParam, lParam); > +} I'm afraid that unless my mail client is playing up that type of code isn't acceptable. You need to use indenting! Also please try and space stuff out, eg rather than: if(tmpLen > 0)EnableWindow use if (tmpLen > 0) EnableWindow(....); > + > +INT_PTR CALLBACK searchingdlg_proc(HWND hWnd, UINT uMsg, WPARAM wParam,LPARAM lParam) { > + switch(uMsg) { > + case WM_INITDIALOG: > + //SearchRegistryRecrusively("",HKEY_CLASSES_ROOT,TRUE); No C++/C99 style comments unfortunately. Also please don't submit patches that have code commented out for no obvious reason. > + break; > + case WM_COMMAND: > + switch(LOWORD(wParam)) { > + case IDCANCEL: > + HeapFree(GetProcessHeap(),0,searchString); > + EndDialog(hWnd, 0); > + return(TRUE); > + break; > + } Indenting is good, but indenting consistently is even better! > + break; > + } > + > +return(FALSE); > +} > + > +INT_PTR CALLBACK finddlg_proc(HWND hWnd, UINT uMsg, WPARAM wParam,LPARAM lParam) { > + > + switch(uMsg) { > + case WM_INITDIALOG: > + hFindEdit = GetDlgItem(hWnd, IDC_FINDEDIT); > + hFindButton = GetDlgItem(hWnd, IDOK); > + prevWndProcEdit = SetWindowLongPtr (hFindEdit, GWLP_WNDPROC, (LONG_PTR) findedit_proc); > + EnableWindow(hFindButton, FALSE); > + CheckDlgButton( hWnd, IDC_CHECKBOX_KEYS, BST_CHECKED ); > + CheckDlgButton( hWnd, IDC_CHECKBOX_VALUES, BST_CHECKED ); > + CheckDlgButton( hWnd, IDC_CHECKBOX_DATA, BST_CHECKED ); > + return(TRUE); I think you may be mixing tabs and spaces or something here. Also making return look like a function is rather non-standard for C, use it as a statement: return TRUE; > + break; > + case WM_COMMAND: > + switch(LOWORD(wParam)) { > + case IDOK: > + searchString = (LPTSTR)HeapAlloc(GetProcessHeap(),0,searchStringLen + 1); > + GetWindowText(hFindEdit, searchString, searchStringLen + 1 ); > + > + searchForKeys = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_KEYS ) == BST_CHECKED); > + searchForValues = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_VALUES ) == BST_CHECKED); > + searchForData = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_DATA ) == BST_CHECKED); > + searchMatchWholeString = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_MATCHSTRING ) == BST_CHECKED); If you're going to fall through please put a comment like /* fall through */ otherwise it looks an awful lot like a mistake. thanks -mike

1 0

Suggestion For Wine Loader
by Jason Couture March 8, 2005

March 8, 2005

How hard would it be to introduce a "Re-Compiler" instead of an interpreter? To convert PE -> ELF without having the source. The output would not have to be a user runnable file maybe just a cache? Possiable Speed up? To avoid copyright issues maybe the elf could require the pe to run? In my experience JIT Compiling or interpreting is much slower than a recompiled program... Let me know what you people think.

4 4

Gmail accounts
by Jason Couture March 8, 2005

March 8, 2005

Sorry i know this seems like spam but it is an offer. Anyone who emails plaguethenet(a)gmail.com will recieve a gmail invite until i run out of invites. later

1 0

Voodoo3, Banshee and D3D
by Troy Rollo March 8, 2005

March 8, 2005

---CONTEXT--- <http://dri.sourceforge.net/doc/dri_driver_features.phtml> The Voodoo3/Banshee driver reverts to software rendering under the following conditions: - Setting GL_LIGHT_MODEL_COLOR_CONTROL to GL_SEPARATE_SPECULAR_COLOR. - Enabling line stippling or polygon stippling. - Enabling point smoothing or polygon smoothing. - Enabling line smoothing when line width is not 1.0. That is, antialiased lines are done in hardware only when the line width is 1.0. - Using 1-D or 3-D texture maps. - Using the GL_BLEND texture environment. - Using stencil operations. - Using the accumulation buffer. - Using glBlendEquation(GL_LOGIC_OP). - Using glDrawBuffer(GL_FRONT_AND_BACK). - Using glPolygonMode(face, GL_POINT) or glPolygonMode(face, GL_LINE). - Using point size attenuation (i.e. GL_DISTANCE_ATTENUATION_EXT). - Using glColorMask(r, g, b, a) when r!=g or g!=b. ---END-CONTEXT--- Both wined3d/directx.c and d3d8/directx.c have an IWineD3DImpl_CreateDevice that includes the following call: glLightModeli(GL_LIGHT_MODEL_COLOR_CONTROL, GL_SEPARATE_SPECULAR_COLOR); In effect this prevents WINE from using the Voodoo3 for 3D rendering. Not only does this make D3D games intolerably slow (forget measuring FPS - start measuring FPM or worse), the result for many operations is just plain wrong. Commenting out the offending line makes it work much better (at least until it hits one of the other problems), but with a list of software fallbacks this large, and given that the Voodoo3 is over 5 years old now, there must be some question as to whether this is worth fixing. Is the response to people with this problem "just go pick up an old GeForce card for $30"?

3 3

[HELP] Quartz and FFMpeg question
by Christian Costa March 8, 2005

March 8, 2005

Hi, I'm working on a video wrapper around libavcodec from FFMpeg. Currently I can play rle, msvideo1 and mjpeg movies. But before submitting anything I must handle the dependency with libavcodec (and maybe libavformat in the future). AFAIK there is no stable API so we need to incorporate FFMpeg source code into the wine tree and update it whenever it's needed. The difficulty here is to add these sources to the build process. There are several solutions : - reuse all FFMpeg build process (configure & makefile) or part of it (makefile only) - add all necessary files in the quartz makefile with slight modifications to FFMpeg sources (IIRC it's what was done in previous quartz code) Currently I use the second solution with all optimizations disabled. This is a bit hackish and not that portable I guess. Enabling optimizations and portability requires using our config.h in FFMpeg sources but also adding additionnal files depending on the platform which complicate things a bit. I'm not a makefile and autoconf expert and before digging deeper I would like some advices. Thansk in advance. Christian

2 1

Re: ScrollDC fixes.
by Alexandre Julliard March 8, 2005

March 8, 2005

Rein Klazes <wijn(a)wanadoo.nl> writes: > + if(( size = GetRegionData( SrcRgn, 0, NULL )) && > + (rdata = HeapAlloc( GetProcessHeap(), 0, size ))) { > + GetRegionData( SrcRgn, size, rdata ); > + /* the rectangles in the region data are ordered top-to-bottom > + * So if the scrolling is downward, traverse the array backwards > + * to avoid touching pixels that have yet to be scrolled */ > + /* FIXME: implement something similar for left-to-right > + * scrolling. */ > + if( dydev < 0 ) { > + step = 1; > + rect = (RECT *)rdata->Buffer; > + } else { > + step = -1; > + rect = ((RECT *)rdata->Buffer) + rdata->rdh.nCount - 1; > + } > + for( i = 0; i < rdata->rdh.nCount; i++, rect += step) { > + DPtoLP(hdc, (LPPOINT)rect, 2); > + TRACE("Bit blitting %s to %ld,%ld\n", wine_dbgstr_rect(rect), > + rect->left + dx, rect->top + dy); > + BitBlt( hdc, rect->left + dx, rect->top + dy, > + rect->right - rect->left, rect->bottom -rect->top, > + hdc, rect->left, rect->top, SRCCOPY); > + } You really shouldn't need to scroll the region rectangle by rectangle. Selecting the proper clip region and then copying the whole area should have the same effect. > { > XEvent event; > > - XWindowEvent( gdi_display, physDev->drawable, ~0, &event ); > - if (event.type == NoExpose) break; > + if( !XCheckWindowEvent( gdi_display, physDev->drawable, ~0, &event )) > + break; > + if (event.type == NoExpose) continue; You can't use XCheckWindowEvent, you need to wait for the events that haven't arrived yet. -- Alexandre Julliard julliard(a)winehq.org

2 3

documentation for SERVER_START_REQ
by James Hawkins March 8, 2005

March 8, 2005

Hi, I'm implementing NtLoadKey, but I can't find any documentation on making server requests, ie SERVER_START_REQ, the different tracing abilitites such as using fprintf(stderr,...) instead of the known TRACE, style of code etc. The latter two are not as important to me because I've picked them up while perusing the code, but it might be important to someone who hasn't looked through it before. I do need the semantics for SERVER_START_REQ, so if you could point me in the right direction or tell me I would really appreciate it. -- James Hawkins

3 3