- Wine-Devel - list.winehq.org

Re: [shell32tests/shelllink.c] Use aliases for ordinals (resend/rediff)
by Francois Gouget Feb. 18, 2005

Feb. 18, 2005

Paul Vriens wrote: > Hi, > > to ease Alexandre's work I re-diffed the patch. The consensus on > wine-devel was that this patch is fine. > > This patch makes the crosstest compile work again for shell32. Result > tested on win98/winxp/Wine/W2KProf. > > Changelog: > Use aliases for calls to ordinals. I don't think that's what the consensus says, if a consensus there is in the first place. If I understand Filip Navara's patch correctly, it shows that the fix belongs in MinGW's shell32.def file. And if that's the case then I'm arguing this test should remain as is. As I understand it, once MinGW's file is fixed, the compiler sees that there is an ordinal associated to SHSimpleIDListFromPath and then generates an executable which imports SHSimpleIDListFromPath by ordinal. This seems to be exactly what Visual C++ does on Windows. It's perfectly acceptable to import SHSimpleIDListFromPath by name in programs compiled using Visual C++, and the resulting executable works even if shell32.dll exports this API by ordinal only. Our conformance tests should reflect that. That's because they are meant to reflect the Windows behavior (not the MinGW one), including where compilation and linking are concerned. -- Francois Gouget fgouget(a)codeweavers.com

6 9

Re: distcc and wine-installer
by Damian Dimmich Feb. 18, 2005

Feb. 18, 2005

Ah, it helps to attach the patch.... On Friday 18 February 2005 18:34, Damian Dimmich wrote: > Hi, > > Just made a little patch to the wine installer script which allows the user > to specify a commandline flag to enable distcc support (using --distcc). > > This makes compiling loads faster if you have more than one machine to > compile on. > > Let me know if it does not work for you. > > Thanks, > Damian

1 0

dll/shell32/shlfileop.c cleanup questions
by Rolf Kalbermatter Feb. 18, 2005

Feb. 18, 2005

Joris Huizer <jorishuizer(a)planet.nl> wrote: >I'm looking at the dll/shell32/shlfileop.c file; the function >SHFileOperationW is still huge but in order to split off sections (some >are clear to see but difficult to seperate from the rest) >I'd either have to use huge parameter lists, or put parts together in >structs (some vars are used everywhere in combination) What is your >opinion about this? > >Also, I found something weird, the line at the top of the while loop: > nFileOp.wFunc = ((level + 1) << 4) + FuncSwitch; >seems to be equivalent to > nFileOp.wFunc = (((lpFileOp->wFunc >> 4) + 1) << 4) + >(lpFileOp->wFunc & FO_MASK); >and > nFileOp.wFunc = (((lpFileOp->wFunc >> 4) + 1) << 4) + >(lpFileOp->wFunc & 0xF); >and > nFileOp.wFunc = (lpFileOp->wFunc & (~(0xF))) + (1 << 4) + >(lpFileOp->wFunc & 0xF); >and > nFileOp.wFunc = (lpFileOp->wFunc & (~(0xF))) + (0x10) + >(lpFileOp->wFunc & 0xF); >and > nFileOp.wFunc = lpFileOp->wFunc + 0x10; /* what's this 0x10? */ Well, Dietrich Teickner from whom I got that code implemented in this way a method to detect the nesting level of SHFileOperation calls as they can get called recursively. I have currently a version of the SHFileOperation lying around here which is still huge but I did start to place some parts in separate functions already. It is a considerably extended version of SHFileOperation than what is in CVS at the moment. It implements a few more features and also fixes some not so common cases where the current function can go havok with certain parameter combinations. But it was rejected for its sheer size, which I wasn't happy myself with but I inherited most of that and hadn't time until now to finish the cleanup and won't be able to do that in a short term either. My next step was to actually create a custom structure with some more parameters and implement a core file_operation() function which is eventually called recursively when necessary. The current SHFileOperation then will do some parameter checks and then prepare the new structure and call that file_operation(). When I get home, I will send the current code in an archive to you together with a tool I wrote to make a very thorough test of several thousend parameter combinations. The way I implemented that test tool was to simply dump the results of all those tests into a file to be able to make a diff with a known log from W2K. As it is at the moment it would not be good to include in the test framework because of the necessary comparison to a good log file and also because it takes about 90 seconds alone to run on my computer. (Well on Windows it takes actually at least double that but there the function also does Undo/Recycle Bin which I guess will take some time to do). Rolf Kalbermatter

1 0

Halflife II
by Roderick Colenbrander Feb. 18, 2005

Feb. 18, 2005

Hi, The past few weeks I have been experimenting a bit with Wine's d3d9. After new updates appeared in cvs I tried games like halife2. Yesterday I tried (a cracked) halflife2 and cstrike:source again using Oliver's latest d3d9 patch and it now shows stuff! For shots check http://roderick.student.utwente.nl/hl2.png and http://roderick.student.utwente.nl/cstrike.png. Both games come to the menu screens I think (not sure what it all has to look like) but from then on not much happens. In case of halfife2 I see some birds flying on the background so the game isn't stuck. I think the menus aren't drawn and I guess that might be related to the fixme "d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0" which I'm seeing hundreds of times. Below is a small log of this: trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(7) Value(0) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(8) Value(0) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(9) Value(0) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(10) Value(1) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(11) Value(0) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(12) Value(0) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(13) Value(0) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(14) Value(0) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 trace:d3d:IWineD3DDeviceImpl_SetSamplerState (0x403e08b0) Sampler(0), Type(15) Value(1) fixme:d3d:IWineD3DDeviceImpl_SetSamplerState out of range sampler 0 I'm amazed with the progress made on the d3d9 front. During the weekend I will try to get halflife2 working on windows to see what it has to look like and I might also have time to fix this problem if it is trivial. Just wanted to let you know that some major d3d9 game is now starting to work. Regards, Roderick

1 1

Re: [shell32tests/shelllink.c] Use aliases for ordinals (resend/rediff)
by Rolf Kalbermatter Feb. 18, 2005

Feb. 18, 2005

Alexandre Julliard <julliard(a)winehq.org> wrote: >Hans Leidekker <hans(a)it.vu.nl> writes: > >> Filip's patch was not quite right, these functions need to be exported >> ordinal *only*, otherwise the resulting test binary won't link at >> runtime on systems older than xp. With the patch below I am able to >> produce binaries that run on xp as well as 2k and 98. > >And actually the same thing should be done in the Wine spec file (in fact most of >the shell32 functions should probably be marked noname). I think "most" is in this case quite overexagerating. There certainly are quite some functions which should be always imported by ordinal, as they were exported that way before they were documented by MS, but a lot of the rest of shell32 is simply exported by name only. Thinking a little about this I think exporting the ordinals by name too is not a problem at all, as long as the import libraries which get generated from the .spec file or .def file import all APIs with a defined ordinal through their ordinal instead. This way the DLLs are forgiving about someone trying to import by name and the newest Windows versions seem to allow linking to those functions by name too, but the import libraries will also work on older systems where the functions Are exported as ordinals only. This may require a modification to the import library generation to make sure that for defined ordinals the apropriate code to import that function by ordinal is Generated, instead of prefering import by name if both are present. Rolf Kalbermatter

2 1

dll/shell32/shlfileop.c cleanup questions
by Joris Huizer Feb. 18, 2005

Feb. 18, 2005

Hello, I'm looking at the dll/shell32/shlfileop.c file; the function SHFileOperationW is still huge but in order to split off sections (some are clear to see but difficult to seperate from the rest) I'd either have to use huge parameter lists, or put parts together in structs (some vars are used everywhere in combination) What is your opinion about this? Also, I found something weird, the line at the top of the while loop: nFileOp.wFunc = ((level + 1) << 4) + FuncSwitch; seems to be equivalent to nFileOp.wFunc = (((lpFileOp->wFunc >> 4) + 1) << 4) + (lpFileOp->wFunc & FO_MASK); and nFileOp.wFunc = (((lpFileOp->wFunc >> 4) + 1) << 4) + (lpFileOp->wFunc & 0xF); and nFileOp.wFunc = (lpFileOp->wFunc & (~(0xF))) + (1 << 4) + (lpFileOp->wFunc & 0xF); and nFileOp.wFunc = (lpFileOp->wFunc & (~(0xF))) + (0x10) + (lpFileOp->wFunc & 0xF); and nFileOp.wFunc = lpFileOp->wFunc + 0x10; /* what's this 0x10? */ and in turn, no tests go off when changing that to: nFileOp.wFunc = lpFileOp->wFunc; Am I missing something here? regards, Joris

1 0

Grid And GetFocus()
by George Ginden Feb. 18, 2005

Feb. 18, 2005

Hi, I've noticed, a wrong behavior in a simple program that has a grid implementation. Basically you can move around the grid with the direction keys. If you press enter, the cell lets you enter text. (just as excel works.). Also a mouse click on the cell does the same thing. The problem is that when you write something into the cell then you cannot move around the grid with the arrows anymore. (the GetFocus() function returns "nil" everytime you hit a arrow key...) To make the grid work again a mouse click out of the cell is necessary. I'd like to try and fix this, what have I to start with first ? Maybe it's the edit control ? PS: part of the strace log is attacched. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event ButtonRelease for hwnd/window 0x3002e/3c00043, GetFocus()=0x20048 trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=0x20048 trace:event:EVENT_ProcessEvent returns. trace:win:WIN_CreateWindowEx (null) "EDIT" ex=00000000 style=50000000 122,136 55x12 parent=0x20048 menu=(nil) inst=0x400000 params=(nil) trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE trace:win:dump_window_styles exstyle: trace:win:WIN_CreateWindowEx winproc type is 2 (WIN_PROC_32A) trace:win:WIN_SetWindowLong 0x30046 -12 0 3 trace:edit:EditWndProc_common hwnd=0x30046 msg=81 (WM_NCCREATE) wparam=0 lparam=4061eb3c trace:edit:EDIT_WM_NCCreate Creating ANSI edit control, style = 50000000 trace:win:WIN_SetWindowLong 0x30046 0 40378cf0 3 trace:edit:EditWndProc_common hwnd=0x30046 msg=83 (WM_NCCALCSIZE) wparam=0 lparam=4061e93c trace:edit:EditWndProc_common hwnd=0x30046 msg=83 (WM_NCCALCSIZE) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=1 (WM_CREATE) wparam=0 lparam=4061eb3c trace:edit:EDIT_WM_Create (null) trace:edit:EDIT_EM_SetMargins left=0, right=0 trace:edit:EDIT_SetCaretPos 0 - 0x0 trace:edit:EditWndProc_common hwnd=0x30046 msg=1 (WM_CREATE) -- 0x00000001 trace:edit:EditWndProc_common hwnd=0x30046 msg=5 (WM_SIZE) wparam=0 lparam=c0037 trace:edit:EDIT_WM_Size width = 55, height = 12 trace:edit:EDIT_SetCaretPos 0 - 0x0 trace:edit:EditWndProc_common hwnd=0x30046 msg=5 (WM_SIZE) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=3 (WM_MOVE) wparam=0 lparam=88007a trace:edit:EditWndProc_common hwnd=0x30046 msg=3 (WM_MOVE) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=18 (WM_SHOWWINDOW) wparam=1 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=18 (WM_SHOWWINDOW) -- 0x00000000 trace:win:SetWindowPos hwnd 0x30046, after (nil), 0,0 (0x0), flags 00000057 trace:win:dump_winpos_flags flags: SWP_NOSIZE SWP_NOMOVE SWP_NOZORDER SWP_NOACTIVATE SWP_SHOWWINDOW trace:edit:EditWndProc_common hwnd=0x30046 msg=46 (WM_WINDOWPOSCHANGING) wparam=0 lparam=4061e8cc trace:edit:EditWndProc_common hwnd=0x30046 msg=46 (WM_WINDOWPOSCHANGING) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=47 (WM_WINDOWPOSCHANGED) wparam=0 lparam=4061e8cc trace:edit:EditWndProc_common hwnd=0x30046 msg=47 (WM_WINDOWPOSCHANGED) -- 0x00000000 trace:win:WIN_CreateWindowEx created window 0x30046 trace:win:WIN_SetWindowLong 0x30046 -4 6023f150 2 trace:win:WINPROC_AllocProc reusing 0x40720ac0 for 0x6023f150/2 trace:edit:EditWndProc_common hwnd=0x30046 msg=30 (WM_SETFONT) wparam=12be lparam=0 trace:edit:EDIT_EM_SetMargins left=1, right=1 trace:edit:EDIT_SetCaretPos 0 - 1x0 trace:edit:EditWndProc_common hwnd=0x30046 msg=30 (WM_SETFONT) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=d3 (EM_SETMARGINS) wparam=3 lparam=0 trace:edit:EDIT_EM_SetMargins left=0, right=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=d3 (EM_SETMARGINS) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=c (WM_SETTEXT) wparam=0 lparam=40364be0 trace:edit:EDIT_WM_SetText L"" trace:edit:EDIT_EM_ReplaceSel L"", can_undo 0, send_update 0 trace:edit:EDIT_WM_SetText notification EN_CHANGE sent to hwnd=0x20048 trace:edit:EDIT_WM_SetText notification EN_UPDATE sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=c (WM_SETTEXT) -- 0x00000001 trace:win:RedrawWindow 0x30046 whole window flags: RDW_INVALIDATE RDW_ERASE trace:win:SetFocus 0x30046 prev 0x20048 trace:win:RedrawWindow 0x20048 rect (117,130)-(182,154) flags: RDW_INVALIDATE trace:win:SetFocus 0x30046 prev 0x30046 trace:edit:EditWndProc_common hwnd=0x30046 msg=b1 (EM_SETSEL) wparam=0 lparam=ffffffff trace:edit:EditWndProc_common hwnd=0x30046 msg=b1 (EM_SETSEL) -- 0x00000001 trace:edit:EditWndProc_common hwnd=0x30046 msg=7 (WM_SETFOCUS) wparam=20048 lparam=0 trace:edit:EDIT_SetCaretPos 0 - 1x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_WM_SetFocus notification EN_SETFOCUS sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=7 (WM_SETFOCUS) -- 0x00000000 trace:win:RedrawWindow 0x20048 rect (117,130)-(182,154) flags: RDW_INVALIDATE trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) wparam=46 lparam=210001 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) wparam=66 lparam=210001 trace:edit:EDIT_EM_ReplaceSel L"f", can_undo 1, send_update 1 trace:edit:EDIT_EM_ReplaceSel inserting stuff (tl 0, strl 1, selstart 0 ('L""'), text 'L""') trace:edit:EDIT_UpdateText notification EN_UPDATE sent to hwnd=0x20048 trace:win:RedrawWindow 0x30046 whole window flags: RDW_INVALIDATE RDW_ERASE trace:edit:EDIT_SetCaretPos 1 - 4x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_EM_ReplaceSel notification EN_CHANGE sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) wparam=44 lparam=200001 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) wparam=64 lparam=200001 trace:edit:EDIT_EM_ReplaceSel L"d", can_undo 1, send_update 1 trace:edit:EDIT_EM_ReplaceSel inserting stuff (tl 1, strl 1, selstart 1 ('L""'), text 'L"f"') trace:edit:EDIT_UpdateText notification EN_UPDATE sent to hwnd=0x20048 trace:win:RedrawWindow 0x30046 whole window flags: RDW_INVALIDATE RDW_ERASE trace:edit:EDIT_SetCaretPos 2 - 11x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_EM_ReplaceSel notification EN_CHANGE sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) -- 0x00000000 trace:win:RedrawWindow 0x3002e whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:win:BeginPaint hdc = 0x9e0 box = (129,149 - 184,161), fErase = 0 trace:win:RedrawWindow 0x30030 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:win:GetWindowRect hwnd 0x30030 (318,101)-(798,401) trace:win:BeginPaint hdc = 0x9e0 box = (129,149 - 184,161), fErase = 0 trace:win:RedrawWindow 0x20048 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:win:GetWindowRect hwnd 0x20048 (324,113)-(792,304) trace:win:BeginPaint hdc = 0x9e0 box = (117,130 - 182,154), fErase = 0 trace:win:RedrawWindow 0x30046 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) wparam=0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=85 (WM_NCPAINT) wparam=1 lparam=0 trace:win:GetWindowRect hwnd 0x30046 (447,250)-(502,262) trace:edit:EditWndProc_common hwnd=0x30046 msg=85 (WM_NCPAINT) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) wparam=74 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) -- 0xffffffff trace:win:BeginPaint hdc = 0x74 box = (0,0 - 55,12), fErase = 0 trace:edit:EDIT_PaintLine line=0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) wparam=47 lparam=220001 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) wparam=67 lparam=220001 trace:edit:EDIT_EM_ReplaceSel L"g", can_undo 1, send_update 1 trace:edit:EDIT_EM_ReplaceSel inserting stuff (tl 2, strl 1, selstart 2 ('L""'), text 'L"fd"') trace:edit:EDIT_UpdateText notification EN_UPDATE sent to hwnd=0x20048 trace:win:RedrawWindow 0x30046 whole window flags: RDW_INVALIDATE RDW_ERASE trace:edit:EDIT_SetCaretPos 3 - 18x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_EM_ReplaceSel notification EN_CHANGE sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) -- 0x00000000 trace:win:RedrawWindow 0x30046 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) wparam=0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) wparam=9e0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) -- 0xffffffff trace:win:BeginPaint hdc = 0x9e0 box = (0,0 - 55,12), fErase = 0 trace:edit:EDIT_PaintLine line=0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) wparam=46 lparam=c0210001 trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) wparam=44 lparam=c0200001 trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) wparam=47 lparam=c0220001 trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) wparam=44 lparam=200001 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) wparam=64 lparam=200001 trace:edit:EDIT_EM_ReplaceSel L"d", can_undo 1, send_update 1 trace:edit:EDIT_EM_ReplaceSel inserting stuff (tl 3, strl 1, selstart 3 ('L""'), text 'L"fdg"') trace:edit:EDIT_UpdateText notification EN_UPDATE sent to hwnd=0x20048 trace:win:RedrawWindow 0x30046 whole window flags: RDW_INVALIDATE RDW_ERASE trace:edit:EDIT_SetCaretPos 4 - 25x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_EM_ReplaceSel notification EN_CHANGE sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) -- 0x00000000 trace:win:RedrawWindow 0x30046 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) wparam=0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) wparam=74 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) -- 0xffffffff trace:win:BeginPaint hdc = 0x74 box = (0,0 - 55,12), fErase = 0 trace:edit:EDIT_PaintLine line=0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) wparam=46 lparam=210001 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) wparam=66 lparam=210001 trace:edit:EDIT_EM_ReplaceSel L"f", can_undo 1, send_update 1 trace:edit:EDIT_EM_ReplaceSel inserting stuff (tl 4, strl 1, selstart 4 ('L""'), text 'L"fdgd"') trace:edit:EDIT_UpdateText notification EN_UPDATE sent to hwnd=0x20048 trace:win:RedrawWindow 0x30046 whole window flags: RDW_INVALIDATE RDW_ERASE trace:edit:EDIT_SetCaretPos 5 - 28x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_EM_ReplaceSel notification EN_CHANGE sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) -- 0x00000000 trace:win:RedrawWindow 0x30046 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) wparam=0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) wparam=9e0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) -- 0xffffffff trace:win:BeginPaint hdc = 0x9e0 box = (0,0 - 55,12), fErase = 0 trace:edit:EDIT_PaintLine line=0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) wparam=47 lparam=220001 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) wparam=67 lparam=220001 trace:edit:EDIT_EM_ReplaceSel L"g", can_undo 1, send_update 1 trace:edit:EDIT_EM_ReplaceSel inserting stuff (tl 5, strl 1, selstart 5 ('L""'), text 'L"fdgdf"') trace:edit:EDIT_UpdateText notification EN_UPDATE sent to hwnd=0x20048 trace:win:RedrawWindow 0x30046 whole window flags: RDW_INVALIDATE RDW_ERASE trace:edit:EDIT_SetCaretPos 6 - 35x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_EM_ReplaceSel notification EN_CHANGE sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=102 (WM_CHAR) -- 0x00000000 trace:win:RedrawWindow 0x30046 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) wparam=0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) wparam=74 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=14 (WM_ERASEBKGND) -- 0xffffffff trace:win:BeginPaint hdc = 0x74 box = (0,0 - 55,12), fErase = 0 trace:edit:EDIT_PaintLine line=0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EditWndProc_common hwnd=0x30046 msg=f (WM_PAINT) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) wparam=46 lparam=c0210001 trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) wparam=44 lparam=c0200001 trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) wparam=47 lparam=c0220001 trace:edit:EditWndProc_common hwnd=0x30046 msg=101 (WM_KEYUP) -- 0x00000000 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=0x30046 trace:event:EVENT_ProcessEvent returns. trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) wparam=d lparam=1c0001 trace:edit:EditWndProc_common hwnd=0x30046 msg=100 (WM_KEYDOWN) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=d (WM_GETTEXT) wparam=800 lparam=40364be0 trace:edit:EditWndProc_common hwnd=0x30046 msg=d (WM_GETTEXT) -- 0x00000006 trace:win:DestroyWindow (0x30046) trace:edit:EditWndProc_common hwnd=0x30046 msg=18 (WM_SHOWWINDOW) wparam=0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=18 (WM_SHOWWINDOW) -- 0x00000000 trace:win:SetWindowPos hwnd 0x30046, after (nil), 0,0 (0x0), flags 00000097 trace:win:dump_winpos_flags flags: SWP_NOSIZE SWP_NOMOVE SWP_NOZORDER SWP_NOACTIVATE SWP_HIDEWINDOW trace:edit:EditWndProc_common hwnd=0x30046 msg=46 (WM_WINDOWPOSCHANGING) wparam=0 lparam=4061ec18 trace:edit:EditWndProc_common hwnd=0x30046 msg=46 (WM_WINDOWPOSCHANGING) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=47 (WM_WINDOWPOSCHANGED) wparam=0 lparam=4061ec18 trace:edit:EditWndProc_common hwnd=0x30046 msg=47 (WM_WINDOWPOSCHANGED) -- 0x00000000 trace:win:SetFocus 0x20048 prev 0x30046 trace:edit:EditWndProc_common hwnd=0x30046 msg=8 (WM_KILLFOCUS) wparam=20048 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=8 (WM_KILLFOCUS) -- 0x00000000 trace:win:RedrawWindow 0x20048 rect (117,130)-(182,154) flags: RDW_INVALIDATE trace:win:SetFocus 0x30046 prev 0x20048 trace:win:RedrawWindow 0x20048 rect (117,130)-(182,154) flags: RDW_INVALIDATE trace:win:SetFocus 0x30046 prev 0x30046 trace:edit:EditWndProc_common hwnd=0x30046 msg=b1 (EM_SETSEL) wparam=0 lparam=ffffffff trace:edit:EDIT_SetCaretPos 6 - 35x0 trace:edit:EditWndProc_common hwnd=0x30046 msg=b1 (EM_SETSEL) -- 0x00000001 trace:edit:EditWndProc_common hwnd=0x30046 msg=7 (WM_SETFOCUS) wparam=20048 lparam=0 trace:edit:EDIT_SetCaretPos 6 - 35x0 trace:win:WINPROC_AllocProc reusing 0x40720aac for 0x406959e8/2 trace:edit:EDIT_WM_SetFocus notification EN_SETFOCUS sent to hwnd=0x20048 trace:edit:EditWndProc_common hwnd=0x30046 msg=7 (WM_SETFOCUS) -- 0x00000000 trace:edit:EditWndProc_common hwnd=0x30046 msg=2 (WM_DESTROY) wparam=0 lparam=0 trace:win:WIN_DestroyWindow 0x30046 trace:edit:EditWndProc_common hwnd=0x30046 msg=82 (WM_NCDESTROY) wparam=0 lparam=0 trace:edit:EditWndProc_common hwnd=0x30046 msg=82 (WM_NCDESTROY) -- 0x00000000 trace:win:RedrawWindow 0x20048 rect (117,130)-(182,154) flags: RDW_INVALIDATE trace:win:RedrawWindow 0x3002e whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:win:BeginPaint hdc = 0x74 box = (129,149 - 184,161), fErase = 0 trace:win:RedrawWindow 0x30030 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:win:GetWindowRect hwnd 0x30030 (318,101)-(798,401) trace:win:BeginPaint hdc = 0x74 box = (129,149 - 184,161), fErase = 0 trace:win:RedrawWindow 0x20048 whole window flags: RDW_NOINTERNALPAINT RDW_NOCHILDREN trace:win:GetWindowRect hwnd 0x20048 (324,113)-(792,304) trace:win:BeginPaint hdc = 0x74 box = (117,130 - 182,154), fErase = 0 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyPress for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event KeyRelease for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event MotionNotify for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:win:GetWindowRect hwnd 0x20048 (324,113)-(792,304) trace:win:WINPOS_WindowFromPoint scope 0x3002e (463,246) returning 0x20048 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event MotionNotify for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:win:GetWindowRect hwnd 0x20048 (324,113)-(792,304) trace:win:WINPOS_WindowFromPoint scope 0x3002e (469,226) returning 0x20048 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event MotionNotify for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:win:GetWindowRect hwnd 0x20048 (324,113)-(792,304) trace:win:WINPOS_WindowFromPoint scope 0x3002e (473,198) returning 0x20048 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event MotionNotify for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:win:GetWindowRect hwnd 0x20048 (324,113)-(792,304) trace:win:WINPOS_WindowFromPoint scope 0x3002e (475,168) returning 0x20048 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event MotionNotify for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:win:GetWindowRect hwnd 0x20048 (324,113)-(792,304) trace:win:WINPOS_WindowFromPoint scope 0x3002e (473,136) returning 0x20048 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event MotionNotify for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_ProcessEvent returns. trace:win:GetWindowRect hwnd 0x30030 (318,101)-(798,401) trace:win:WINPOS_WindowFromPoint scope 0x3002e (471,102) returning 0x30030 trace:event:EVENT_ProcessEvent called. trace:event:EVENT_ProcessEvent Got event FocusOut for hwnd/window 0x3002e/3c00043, GetFocus()=(nil) trace:event:EVENT_FocusOut win 0x3002e xwin 3c00043 detail=NotifyNonlinear trace:event:EVENT_FocusOut lost focus, setting fg to 0 trace:win:SetForegroundWindow (nil) trace:event:EVENT_ProcessEvent returns.

1 0

LPRECT parameters for Main_DirectDrawSurface_Lock
by Andreas Eckstein Feb. 18, 2005

Feb. 18, 2005

Good morning, wine devs! When playing Icewind Dale II (using wine-20050111), the game sometimes crashed with these messages: trace:ddraw:Main_DirectDrawSurface_Lock lprect: 0x0-0x0 err:ddraw:Main_DirectDrawSurface_Lock Invalid values in LPRECT !!! or, on another occasion: trace:ddraw:Main_DirectDrawSurface_Lock lprect: 0x0-2x0 err:ddraw:Main_DirectDrawSurface_Lock Invalid values in LPRECT !!! As you notice, the game tries to lock a surface with width and/or height equal to zero. Frankly I have no idea what the expected behavior is in this case, however playing the critical passages on Windows worked without crash. A quick patch to let Main_DirectDrawSurface_Lock not choke on zero-width or -height LPRECTs solved the problem with wine. Since I don't plan to dig into wine hacking any time soon, could someone merge it into cvs for me (if the new behavior of the function is acceptable, that is)? Thanks in advance! Andreas Eckstein --- The patch: --- dlls/ddraw/dsurface/main.c 2005-01-09 18:35:44.000000000 +0100 +++ dlls/ddraw/dsurface/main.c 2005-02-14 21:03:36.511738080 +0100 @@ -1111,8 +1111,8 @@ (prect->left < 0) || (prect->bottom < 0) || (prect->right < 0) || - (prect->left >= prect->right) || - (prect->top >= prect->bottom) || + (prect->left > prect->right) || + (prect->top > prect->bottom) || (prect->left >= This->surface_desc.dwWidth) || (prect->right > This->surface_desc.dwWidth) || (prect->top >= This->surface_desc.dwHeight) ||

2 1

Re: advapi32: Add RegOpen/CloseKey test and fixes
by Alexandre Julliard Feb. 18, 2005

Feb. 18, 2005

James Hawkins <truiken(a)gmail.com> writes: > + ret = RegOpenKeyA(HKEY_CURRENT_USER, "Software\\Wine\\Test", &hkHandle); > + hkPreserve = hkHandle; > + ret = RegCloseKey(hkHandle); > + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > + ok(hkHandle == hkPreserve, "expected hkHandle != hkPreserve\n"); This test is meaningless, since the handle is passed by value to RegCloseKey it cannot possibly be modified. -- Alexandre Julliard julliard(a)winehq.org

1 0

WINE on x86-64 Fedora Core 4 Prerelease Kernels (2.6.10) [Workaround]
by Erich Hoover Feb. 18, 2005

Feb. 18, 2005

Haven't been able to use WINE for quite a while and have been getting the error: err:seh:EXC_DefaultHandling Unhandled exception code c000013a flags 0 addr 0xffffe403 So I finally found a workaround, hopefully it can help someone else: LD_ASSUME_KERNEL=2.4 setarch i386 -X wine <program>

1 0