- Wine-Devel - list.winehq.org

cleanroom legalaties
by Oliver Stieber Feb. 17, 2005

Feb. 17, 2005

I've been using GPL software, and reverse engineering for years (manuals with more than an int13 reference used to be hard to get hold of) and have just stumbled onto an interesting link. In the US there a process called 'Abstraction, Filtration, Comparison' that is used to determine if a work falls under the copyright of another work. It doesn't look like anything that affects wine, but interesting anyway. http://digital-law-online.info/lpdi1.0/treatise22.html ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

1 0

Re: portability fixes (yet another attempt)
by Steven Edwards Feb. 17, 2005

Feb. 17, 2005

Hi Thomas, --- Thomas Weidenmueller <wine-patches(a)reactsoft.com> wrote: > I unfortunately don't know as I couldn't find referencces to the other > HAVE_* definitions, which I guess are somewhere outside of wine sources. > There however needs to be a macro for strtoulW which can be named > differently... .e.g. HAVE__VSNPRINTF is also just undef'ed, I'm sorry I > don't know if that's defined in some gcc headers (mingw at least doesn't > define them), libc or somewhere else. You need to add a check to the configure and configure.ac scripts for these functions. When you run ./configure it will check to see if this function is implemented on the given platform and define as needed. Thanks Steven __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

wineprefixcreate
by Ann and Jason Edmeades Feb. 16, 2005

Feb. 16, 2005

Hiya, I was working on bug#2716 - a trap running install which turned out to be due to a missing registry key which wineprefixcreate should have created. Now I had an excuse (I deleted *.reg for another test previously!) but the reporter also got the same problem. To quote: "I've installed WINE via RPM package (there's a link to Mandrake package maintainer's RPM with WINE version 20050211 on www.winehq.com) There is no wineprefixcreate in it. I downloaded source tarball, which contains this utility, but it is part of another script, which COMPILES wine and that's what i want to avoid - system based on RPM's is more easily to maintain - you don't have to search for all installed files when uninstalling.... (Compiled programs must always be deleted manually..... :-( ) But i don't understand why running wine rundll32.exe setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf DIDN'T put it in? No error messages..... (That was what i did before running any program with RPM based WINE). Although this helped, i found other problems, so i finally installed WINE from source tarball, just to be sure, there is no installation problem.... " Can someone please clarify when wineprefixcreate is actually driven, and for an RPM (which I've never installed, so apologies) how should this problem have been created. (Mind you, in my case ie after deleting the registry, it would have been nice for it to be pre-populate with some of the keys too!) Thanks! Jason

2 1

Re: x11drv: make minimizing windows work again
by Vitaliy Margolen Feb. 16, 2005

Feb. 16, 2005

Ok, that semi-helps. Now I don't have an extra window that was showing up after minimize. But programs still don't want to stay minimized. They blink in the task bar and immediately restore themselves. Any suggestions where could it be? People have commented on this before. To reiterate: all programs (that I have) behave in this manner, not staying minimized. BTW one side affect of this patch - application icon is not displayed in the task bar anymore. Now it's back to wine's logo. Vitaliy Margolen Tuesday, February 15, 2005, 5:51:34 AM, Vitaliy Margolen wrote: > changelog: > - make minimized windows stay minimized

3 2

Re: CVS Update/Quicken popup/Help please/Followup
by Carl Sopchak Feb. 16, 2005

Feb. 16, 2005

>> Carl Sopchak writes: > > I guess my problem is that I have NO CLUE as to how this SHOULD be handled. > > Should the style be set to (style & ~WS_VISIBLE) when the rectangle is > > {0,0;0,0}? Should {0,0;0,0} be considered a valid rectangle in > > validate_window_rectangles()? Should validate_window_rectangles() only get > > called if the rectangle is not {0,0;0,0}? Or, very possibly, is there > > something else that should happen? Just to see what happened, I commented > > out the call to validate_window_rectangles, and the popup disappeared as it > > should. > Alexandre Julliard replied: > > The client rectangle should have been set to {0,0;0,0} too. You should > look at the WM_NCCALCSIZE processing (SWP_DoNCCalcSize in > dlls/x11drv/winpos.c) and check what's happening there with the > rectangles. > > Ok, so what is happening is this: In dlls/x11drv/winpos.c, the pNewWindowRect is coming into SWP_DoNCCalcSize as (0,0;0,0), wndPtr->rectWindow is (182,977;662;998), and wndPty->rectClient is (183,978;661,997). Then winpos.c sends it's own WM_NCCALCSIZE message, and upon return, params.rgrc[0] is (1,1;1,1)! This, in turn, causes the third and fourth conditions in the section commented as "If the application sends back garbage, ignore it" to be true, which in turn causes the next condition to be false, so the client rectangle (pNewClientRect) does NOT get set. (Follow that?? <g>) Tracing through the processing of this WM_NCCALCSIZE, I find it ends up generating two WM_NCCALCSIZE messages, one being handled by DefWindowProc32. This leads me to ./windows/defwnd.c, which calls NC_HandleNCCalcSize in ./windows/nonclient.c. Within NC_HandleNCCalcSize, a call is made to NC_AdjustRectOuter, then the window's rectangle (winRect) is adjusted based on this call. It is this call and adjustment of winRect that changes winRect from (0,0;0,0) to (1,1;-1,-1), which is later "fixed" to (1,1;1,1). Diving deeper, into NC_AdjustRectOuter, I find that because the window style has WS_BOARDER set, adjust is set to 1, then InflateRect is called, which sets rect to (-1,-1;1,1) [returned to NC_HandleNCCalcSize tmpRect variable]. So, there's the problem. The new rectangle size is (0,0;0,0), but has WS_BOARDER set, so the WM_NCCALCSIZE message returns (1,1;1,1) erroneously. The only thing is, I'm still not sure where the "best" place would be to check for the new window rectangle of (0,0;0,0) and handle it appropriately - or what "appropriate" would be, for that matter... Further help would be appreciated. Thanks, Carl

1 0

Re: [shell32tests/shelllink.c] Use aliases for ordinals
by Francois Gouget Feb. 16, 2005

Feb. 16, 2005

Hi, Paul Vriens wrote: > Hi, > > this makes the crosstest compile work again for shell32. Result tested > on win98/winxp. > > Changelog: > Use aliases for calls to ordinals. As far as I know, SHILCreateFromPath, ILFree and ILIsEqual are all exported by name on Windows. So, IMHO, unless we find a problem running the test on some Windows versions it would be better to fix MinGW. -- Francois Gouget fgouget(a)codeweavers.com

6 8

Re: dlls/shell32/shlfileop.c cleanup
by Alexandre Julliard Feb. 16, 2005

Feb. 16, 2005

Joris Huizer <jorishuizer(a)planet.nl> writes: > Changelog: > * renamed file_operation_delete to SHFileDelete > * renamed file_operation_checkFlags to SHFileCheckFlags Please don't do that. Internal functions should not be named to look like the exported ones, that's very confusing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: add RegOpenKey, RegCloseKey tests
by Alexandre Julliard Feb. 16, 2005

Feb. 16, 2005

James Hawkins <truiken(a)gmail.com> writes: > The last patch forgot to close the keys opened. Use this one instead. > > Changelog > * Add RegOpenKey, RegCloseKey tests. The tests fail on Wine. You need to add todo_wine blocks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: portability fixes (yet another attempt)
by Mike McCormack Feb. 16, 2005

Feb. 16, 2005

Thomas Weidenmueller wrote: > I unfortunately don't know as I couldn't find referencces to the other > HAVE_* definitions, which I guess are somewhere outside of wine sources. The HAVE_* definitions are set by the configure script. You need to add a test into configure.ac that detects the presence or absence of strtoulW and vnsprintf. Mike

1 0

Re: get rid of unnecessary libunicode dependencies in some more places
by Mike McCormack Feb. 16, 2005

Feb. 16, 2005

Thomas Weidenmueller wrote: > - sz = strlenW(fmt) + 1; > + sz = wcslen(fmt) + 1; libc and wine may have differing interpretations of what wchar_t. Specifically, if -fshort-wchar is not used, wchar_t will be int, won't it? You'd be better off using lstrlenW() than wcslen(), but that will be slow since it has an exception handler. Alexandre was talking about making an inline wine only version of lstrlenW() without the exception handler to solve that problem. Mike

4 4