- Wine-Devel - list.winehq.org

Re: [LOSTWAGES] Add janitorial task to avoid using strncpy
by Joris Huizer Jan. 13, 2005

Jan. 13, 2005

Mike McCormack wrote: > ChangeLog: > * Add janitorial task to avoid using strncpy > > > ------------------------------------------------------------------------ > > Index: templates/en/janitorial.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/janitorial.template,v > retrieving revision 1.61 > diff -u -r1.61 janitorial.template > --- templates/en/janitorial.template 11 Jan 2005 20:33:41 -0000 1.61 > +++ templates/en/janitorial.template 13 Jan 2005 15:15:44 -0000 > @@ -7,6 +7,24 @@ > Janitor's List</a>), and it's high time that we have one too. > What is there to clean up? Well, lots of things! :) > > + <h2>Eliminate uses of strncpy/strncpyW</h2> > + > + <i>strncpy(dst,src,n)</i> has two subtle > + <a href="http://weblogs.asp.net/oldnewthing/archive/2005/01/07.aspx"> > + problems</a>. The first is that it always fills the whole <i>dst</i> > + buffer (<i>n</i> characters). The second is that it doesn't always nul > + terminate the <i>dst</i> buffer that it's filling.<p> > + > + Wine code should avoid the use of strncpy for these reasons, and instead > + use lstrcpyA/W or memcpy. You can use the following command to find > + occurences of strncpy in the Wine source code:<p> > + > + <tt>find . -name \*.c -exec grep strncpy {} \; -ls</tt><p> > + > + The aim is to make sure that we only copy as many bytes as necessary into > + the <i>dst</i> buffer, and always nul terminate the buffer when we > + intended to.<p> > + > <h2>Regedit fixes</h2> > > Regedit lacks a few features. We need to improve regedit to: Couldn't we just make a sane implementation of strncpy, not adding more '\0' characters than necessary and making sure the last character is an '\0'? (untested ofcourse ;)) char *strncpy(char *dst,char *src,int n) { int i; for (i = 0; (dst[i] = src[i]) != '\0' && i < n; i++) ; /* n - 1 is '\0'; ensures the end of the string is '\0' */ dst[n - 1] = '\0'; } Now, something like this would at least save us of replacing all strncpyW, wouldn't it? regards, Joris

5 5

Re: NOTIFY_PRE and NOTIFY_POST definitions in include files
by Juan Lang Jan. 13, 2005

Jan. 13, 2005

Francois wrote: > So I would say the correct values are the ones in npapi.h and that > netspi.h should be moved to dlls/mpr which is the only place where it is > used. But this needs a bit more investigation. I agree. I would conjecture that netspi.h is old, and the declarations in it have been superceded by those in npapi.h. For example, the definitions of NOFIYADD, NOTIFYCANCEL, and NOTIFYINFO don't match MSDN: http://msdn.microsoft.com/library/en-us/secauthn/security/notifyadd.asp http://msdn.microsoft.com/library/en-us/secauthn/security/notifycancel.asp http://msdn.microsoft.com/library/en-us/secauthn/security/notifyinfo.asp but those in npapi.h do. The main use of netspi.h seems to be to declare the NPS functions defined in mpr/nps.c. These aren't documented on MSDN, but are exported by Win9x versions of mpr.dll. Anything that doesn't support these functions should be deleted, and since it's not part of the PSDK, making it a private header is fine, or just moving the required declarations to nps.c should be fine too. --Juan __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

[AppDB] create new users is Br0ck.
by tony_lambregts＠telusplanet.net Jan. 13, 2005

Jan. 13, 2005

The last patch broke make_bugzilla_version_list() which is used by account.php and admin/editAppVersion.php. That means that new users can not create accounts and maintainers cannot edit their versions. http://cvs.winehq.org/patch.py?id=15387 The same code on my machine works fine with my test databases. I do not know how to fix this other than reversing the patch. -- Tony Lambregts.

4 7

NOTIFY_PRE and NOTIFY_POST definitions in include files
by Paul Vriens Jan. 13, 2005

Jan. 13, 2005

Hi, just found the following: [paul(a)penguin include]$ grep -e NOTIFY_PRE -e NOTIFY_POST * netspi.h:#define NOTIFY_PRE 0x00 netspi.h:#define NOTIFY_POST 0x01 npapi.h:#define NOTIFY_PRE 0x00000001 npapi.h:#define NOTIFY_POST 0x00000002 this doesn't look right although they do not seem to be used anywhere in the code currently. Any comments? Cheers, Paul.

2 1

Re: The use of a zero flag
by Rolf Kalbermatter Jan. 13, 2005

Jan. 13, 2005

Paul Vriens wrote: >a few days ago I found a bug in ole32/compobj.c where we did something >like: > >if ( foo & FLAG) .... where FLAG=0 > >This 'inspired' me to check for more of these kind of checks. > >One that I already found is in dlls/dplayx/dplay.c > >We are checking for DPSET_REMOTE (which is zero) where we should have >checked for !DPSET_LOCAL or something alike. Often flag sets with a zero flag are more like an enumeration than real flags and have some sort of mask defined which specifies which bits are relevant for that group of flags. Microsoft does something mix real flags and enumeration flags in the same integer but always at different bit locations. Something like if ((foo & MASK) == FLAG) will usually work fine then. Rolf Kalbermatter

1 0

[COMCTL32] The use of the PGS_VERT flag
by Paul Vriens Jan. 13, 2005

Jan. 13, 2005

Hi, the flag PGS_VERT is zero and should not be checked against. It's only the lack of PGS_HORZ that should be checked. Is the following piece of code needed in dll//comctl32/pager.c: 851 if (!(dwStyle & PGS_HORZ) && !(dwStyle & PGS_VERT)) 852 { 853 dwStyle |= PGS_VERT; 854 SetWindowLongA(hwnd, GWL_STYLE, dwStyle); 855 } The check is whether any of the flags is set, but PGS_VERT is already the default when there is a lack of PGS_HORZ. Cheers, Paul.

1 0

Best DLLs to write conformance tests for?
by Dan Kegel Jan. 13, 2005

Jan. 13, 2005

Recently, I helped a student at Harvey Mudd college write and submit a conformance test for the lzexpand dll: http://www.winehq.com/hypermail/wine-cvs/2004/11/0164.html I picked lzexpand.dll since (lacking a GUI) it seemed simple to test. Now I'm putting together a reusable lab project for other colleges, at http://kegel.com/wine/sweng, and am trying to pick a few good DLLs for the students to write tests for. (I plan ask the students to send me their patches so I can review them before they post them on wine-patches.) Clearly, I shouldn't ask anyone to write a conformance test for a huge DLL in a term, so I guess I'll focus on on the DLLs with under 100 functions. And I'd like to skip DLLs that have GUIs, so I guess I'll omit any where the word HWND occurs. That leaves the following 53 DLLs or VxDs: amstream atl cabinet capi2032 cards cfgmgr32 comcat crypt32 d3dx8 d3dxof dbghelp devenum dinput8 dmband dmcompos dmscript dmsynth dmusic32 dplayx dpnet dpnhpast dswave dxdiagn dxerr8 dxerr9 glu32 iccvid icmp ifsmgr.vxd imagehlp itss mmdevldr.vxd monodebg.vxd msdmo mshtml msimg32 msisys msnet32 msvidc32 mswsock olepro32 olesvr qcap secur32 vdhcp.vxd vmm.vxd vnbt.vxd vnetbios.vxd vtdapi.vxd vwin32.vxd win32s winaspi wsock32 That's a small enough list that I can start guessing at which ones are worth writing tests for. Let's see, how 'bout the following 12: amstream atl cabinet crypt32 dplayx dpnet icmp imagehlp itss mswsock winaspi wsock32 Are any of those obviously poor choices for writing a conformance test? Or are there others that are obviously good choices, but that I missed? Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Re: USER32: Implement SPI_{GET,SET}MINIMIZEDMETRICS
by Mike McCormack Jan. 13, 2005

Jan. 13, 2005

jchevrier(a)nexicom.net wrote: > *Implemented SPI_GETMINIMIZEDMETRICS calculated from values returned by > GetSystemMetrics. The math applied to the values returned from > GetSystemMetrics was verified against Windows 98 and XP using a simple test > program. Yey for test programs :) Would you mind sending it to the list or adding some tests in dlls/user/tests/sysparams.c ? thanks, Mike

1 0

[AppDB] script to clean duplicate users
by Jonathan Ernst Jan. 12, 2005

Jan. 12, 2005

This script will remove duplicate users from the appdb (same email address), give their data to the most recently logged user that has the same email address and then fix the db structure so that it's not possible anymore to have two time the same email address. Usage: 1)chmod u+x ./clean.php 2)edit clean.php to set up the database connection (line 11 and 12) 3)./clean.php (if php is not in /usr/bin/php you'll have to edit the first line too)

1 0

Re: [QUARTZ] Revert regsvr.c patch
by Robert Shearman Jan. 12, 2005

Jan. 12, 2005

Paul Vriens wrote: >Hi, > >Christian made me aware of the following: > >--- >As long as this object is not implemented, the FIXME should remain to >remind us that something is missing from quartz. >--- > >As 'Seeking' is not yet implemented I would like to have this patch >reverted. > >Sorry for any inconvenience. > >Cheers, > >Paul > >Changelog > Remove CLSID for registration as it's not implemented yet. > > There is no need to revert the patch because, although the CLSID is not implement yet, it will still print out a fixme in DllGetClassObject (line 181 in dlls/quartz/main.c). Rob

1 0