- Wine-Devel - list.winehq.org

Re: [LOSTWAGES] Add regedit janitorial project
by Michael Stefaniuc Jan. 10, 2005

Jan. 10, 2005

Mike McCormack wrote: > > ChangeLog: > * Add regedit janitorial project > > ------------------------------------------------------------------------ > > > Janitorial Projects > > Any self respecting project has a Janitorial project (e.g. Kernel > Janitor's List <http://janitor.kernelnewbies.org>), and it's high time > that we have one too. What is there to clean up? Well, lots of things! :) > > > Regedit fixes > > Regedit lacks a few features. We need to improve regedit to: > > * Allow display and editting of binary (REG_BINARY) values. > * Allow display and editting of multi-string (REG_SZ_MULTI) values. > * Import registry files regerated by Windows 2000 regedit Are you sure this is a janitorial project? It sounds to me more like a normal development work and not janitorial. It would better fit into "tasks" or the "todo" lists. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

4 4

Fwd: Foobar2000 audio player Regression
by Nick Hornback Jan. 10, 2005

Jan. 10, 2005

I originally posted this to the -users list, but I was contacted by Robbert Xerox, who had the exact same issue, and thus far nobody has replyed in the users list, so maybe it will get more attention here. > Foobar2000 worked virtually perfectly in the 20041019 > release (aside from some comctrl32 repainting issues > -- which native comctrl32.dll fixed), but in 20041201 > it is completely unuseable. Two major problems: > 1) The toolbars are completely gone. They are sort-of > displayed when they get activity via mouse-press or > whatever, but they do not repaint correctly at all. > See this screenshot for details: > http://img20.exs.cx/my.php?loc=img20&image=w1ifoobar.gif > 2) It takes 100% cpu. In the 20041021 release, it > hovered around 5% cpu (on my athlon 64 3200+), which > was excellent because that beat most native linux > audio players. > The console log is as follows (no errors or warnings): > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,1)-stub! > fixme:hook:NotifyWinEvent (32780,0x10026,-4,2)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002a,-4,0)-stub! > fixme:hook:NotifyWinEvent (32772,0x1002c,-4,0)-stub! > fixme:win:SetWindowTextA cannot set text "" of other > process window (nil) > Does anyone know what is going on here? I have since found out that if you use a the builtin comctrl32.dll, none of the window repaints at all. In previous wine releases, using the builtin comctrl32.dll would just create minor glitches (ex. the status bar wouldn't update). __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail

4 6

RtlQueryRegistryValues implementation, probably not prefect but makes safedisc happy
by Ivan Leo Puoti Jan. 10, 2005

Jan. 10, 2005

I've attempted to implement RtlQueryRegistryValues() This code is probably buggy, as I haven't tested it much, but it makes safedisc happy. If it's OK I'll send a patch to add it to ntdll, ntoskrnl will then forward calls. comments/corrections/thoughts welcome. Ivan.

1 0

Warnings left when compiling on GNU/Linux
by Gerald Pfeifer Jan. 10, 2005

Jan. 10, 2005

When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the only warnings I'm getting for current Wine CVS: metafile.c:395: warning: `test_mf_PatternBrush' defined but not used rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used rtlstr.c:578: warning: `test_RtlUpcaseUnicodeString' defined but not used rtlstr.c:629: warning: `test_RtlDowncaseUnicodeString' defined but not used hlp2sgml.c:219: warning: `%x' yields only last 2 digits of year in some locales On FreeBSD 4.10 using GCC 3.3.4 I am also seeing the following one: fd.c:572: warning: right shift count >= width of type fd.c:574: warning: right shift count >= width of type Any chance we could get rid of these? :-) Gerald

5 5

ole32 : wrong check in compobj.c
by Paul Vriens Jan. 10, 2005

Jan. 10, 2005

Hi, while looking through the code I saw: if (model & COINIT_MULTITHREADED) this will never work as COINIT_MULTITHREADED = 0. The attached patch fixes the 3 occurrences of a check against COINIT_*. This patch however makes the COM_CreateApartment in compobj.c: 545 if (!(apt = COM_CurrentInfo()->apt)) 546 { 547 apt = COM_CreateApartment(dwCoInit); 548 if (!apt) return E_OUTOFMEMORY; 549 } return E_OUTOFMEMORY, always (?). And that makes sure that we have a mismatch between CoInitialize and CoUninitialize. So there's definitely something else wrong as well. Any idea ? Cheers, Paul.

3 4

Re: Minor wine-devel DCOM corrections
by Mike Hearn Jan. 10, 2005

Jan. 10, 2005

On Mon, 10 Jan 2005 10:56:30 -0800, Bill Medland wrote: > Bill Medland (billmedland(a)mercuryspeed.com) > Minor typo correction and term expansion changes Bill, if that document was helpful I'll write some more docs for you.

3 3

Use Interlocked* functions
by Joris Huizer Jan. 10, 2005

Jan. 10, 2005

To see how far we are, I tried grepping to get This->refs stuff grep -r -n -e 'TRACE(.*This->ref)' * grep -r -n "++(This->ref)" * grep -r -n -- "--(This->ref)" * I hope there are a lot of false positives there :-/ regards, Joris

5 7

Re: ntdll / kernel32 : #52 (take #2)
by Alexandre Julliard Jan. 10, 2005

Jan. 10, 2005

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > +/****************************************************************** > + * NtAddAtom (NTDLL.@) > + */ > +NTSTATUS WINAPI NtAddAtom( const WCHAR* name, ULONG name_len, ATOM* atom ) > +{ > + return RtlAddAtomToAtomTable( get_global_table(), name, atom ); > +} You can't do that, if the name is a counted string you cannot ignore the length and assume it is null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Give a more informative error when a DLL fails to initialize
by Mike Hearn Jan. 10, 2005

Jan. 10, 2005

Hi Alexandre, This patch was missed, does it no longer apply? Also is it OK to just put the changelog as the first line of the email like that? thanks -mike On Wed, 22 Dec 2004 18:19:47 +0000, Mike Hearn wrote: > Give a more informative error when a DLL fails to initialize > --- dlls/ntdll/loader.c (revision 3) > +++ dlls/ntdll/loader.c (local) > @@ -893,9 +893,14 @@ static NTSTATUS process_attach( WINE_MOD > WINE_MODREF *prev = current_modref; > current_modref = wm; > if (MODULE_InitDLL( wm, DLL_PROCESS_ATTACH, lpReserved )) > + { > wm->ldr.Flags |= LDR_PROCESS_ATTACHED; > + } > else > + { > + ERR("Initialization of %s failed\n", debugstr_w(wm->ldr.BaseDllName.Buffer)); > status = STATUS_DLL_INIT_FAILED; > + } > current_modref = prev; > }

3 4

Re: WININET: implement InternetTime{From,To}SystemTime{A,W} (#2)
by Dmitry Timoshkov Jan. 10, 2005

Jan. 10, 2005

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > Changelog: > Implement and test InternetTime{From,To}SystemTime{A,W}. If you could also make the attached tests pass (applied over your tests) that would be great. The tests show that strings should be parsed a bit smarter and comparisons should be case insensitive. -- Dmitry.

1 0