- Wine-Devel - list.winehq.org

Re: [LOSTWAGES]New short About blurb on the Front Page
by Scott Ritchie Dec. 20, 2004

Dec. 20, 2004

http://www.winehq.org/hypermail/wine-patches/2004/12/0343.html Is there a reason why this little update hasn't been committed? I think it makes the front page a bit more user-friendly, as well as updating some of the links. Thanks, Scott Ritchie

1 0

Re: Make winetest.exe detect if it is running on a visible desktop. Now without the linewrap.
by Ferenc Wagner Dec. 20, 2004

Dec. 20, 2004

Jakob Eriksson <jakov(a)vmlinux.org> writes: > Now without the linewrap. I hate to say this, but it's still wrapped... :( -- Feri.

1 0

Janitorial: HeapFree of NULL
by Michael Stefaniuc Dec. 20, 2004

Dec. 20, 2004

Hello, there is a lot (my attached smatch script found 234 occurences) of code like if (this) HeapFree(GetProcessHeap(), 0, this); HeapFree(GetProcessHeap(), 0, that); which is redundant because after Win2000 (if i can trust the comment in RtlFreeHeap) freeing a NULL pointer isn't an error. I've checked it Win2000 and can confirm that. I've also checked Win95 and Win98 and both don't crash when HeapFree'ing a NULL but they return an error and SetLastError to 212 "ERROR_LOCKED". In the above code the return code of HeapFree isn't checked so this wouldn't matter if somebody would run the Wine code on that Win versions. So i propose to shorten that code to HeapFree(GetProcessHeap(), 0, this); HeapFree(GetProcessHeap(), 0, that); I've done this already for the wininet dll (see patch to wine-patches) and if it gets accepted i'll take care of the rest. Advantages: - less (redundant) code - more pleasant to the eye - for the wininet.dll it saves 1.1kB (FC2, gcc-3.3.3-7) in the generated code (ok, the wininet.dll.so is 1.6 MB but still) Disadvantages: - if the pointer is NULL it takes longer for that code path. But i don't think it matters cause this happens mostly only on the (unlikely) error path. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: OpenSCManager() bug
by Ivan Leo Puoti Dec. 20, 2004

Dec. 20, 2004

>Hello, > >initially i tested this stuff under XP and it raised exception if lpDatabaseName >is invalid pointer. But after you noticed the bug i run the test under 2000 and >it has been returned ERROR_NOACCESS. > >Both versions return ERROR_INVALID_NAME if lpDatabaseName is empty string. > >I think the patch should look like this: In Age of Empires 2 lpDatabaseName is just an empty string, so I've sent a patch to wine-patches that allows the database name to be '\0'. Ivan.

1 0

Re: TopLevelWindow Maximize
by Dmitry Timoshkov Dec. 20, 2004

Dec. 20, 2004

"Katia Maculan" <katia.maculan(a)isis-papyrus.com> wrote: > + switch (message) > + { > + case WM_SHOWWINDOW: > + case WM_SIZE: > + DefWindowProc(hWnd, message, wParam, lParam); > + PostMessage (hWnd, WM_PAINT, 0, 0); If you wish to schedule a WM_PAINT message you have to invalidate a window. -- Dmitry.

2 1

Re: OpenSCManager() bug
by Alexander Yaworsky Dec. 19, 2004

Dec. 19, 2004

Hello, initially i tested this stuff under XP and it raised exception if lpDatabaseName is invalid pointer. But after you noticed the bug i run the test under 2000 and it has been returned ERROR_NOACCESS. Both versions return ERROR_INVALID_NAME if lpDatabaseName is empty string. I think the patch should look like this: @@ -750,6 +750,11 @@ if( lpDatabaseName ) { + if( IsBadStringPtrW( lpDatabaseName, -1 ) ) + { + SetLastError( ERROR_NOACCESS ); + return NULL; + } if( strcmpiW( lpDatabaseName, SERVICES_ACTIVE_DATABASEW ) == 0 ) { /* noop, all right */ On the other hand i think that all this stuff is a kind of masturbation. When i implemented this, i used some tests (i'm going to put them into shape of unit tests) to investigate the real behaviour. The last patch establishes that behaviour replacing fixme that was an eyesore, but in reality the database name is not used and IMO will never be used. Ivan Leo Puoti wrote: > This patch http://cvs.winehq.org/patch.py?id=14769 had caused a problem with Age > of Empires. The game uses a copy protection system that is installed as a > service, before your patch, the service tried to load the copy protection driver > (This fails, but that's another story), after your patch wine goes straight to > the debugger after calling OpenSCManager. I added a trace and found that this > code is executed > { > FIXME("ERROR_INVALID_NAME"); > return NULL; > } > and causes the crash. The value of lpDatabaseName that AoE passes to the > function is 1; also according to MSDN > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/ba… > lpDatabaseName can be NULL, and in this case SERVICES_ACTIVE_DATABASE is opened. > As it's late here the only idea I get at the moment is to print the value as a > FIXME or ERR or whatever, and not return NULL, as this doesn't appear to be the > correct behavior. As you've implemented this stuff and I don't know much about > it I would like to know what you think.

1 0

safedisc
by Ivan Leo Puoti Dec. 19, 2004

Dec. 19, 2004

The attached patch is the first step towards supporting safedisc, it adds code sent from Marcus a few months ago to the current dlls/ntdll/virtual.c It allows us to successfully load the secdrv.sys file into memory. It has been tested with the copy of safedisc that comes with Age of Empires 2. I've just checked that it compiles without warnings and loads the file, there may be room for improvement, so I'm posting it here for review. The next step will be to merge Marcus's implementation of ntloskrnl.exe, that is needed because safedisc imports some functions from that file. Ivan.

1 0

Re: [AppDB] big AppDB refactoring
by tony_lambregts＠telusplanet.net Dec. 19, 2004

Dec. 19, 2004

Jonathan Ernst wrote: > This patch is a big refactoring of the AppDB. Some files have been > moved and renamed, others were simply deleted and many where fixed and > improved. No functional differences (apart the fixed global vars). > > *The configuration (config.inc.php) has to be updated on the live server* > > CHANGELOG: > - moved functional code out of procedural code > - moved functional code out of object oriented code > - moved classes in /include/classes/ > - moved functions libraries in /includes/functions/ > - deleted some no more needed files (content was duplicate or included in other files) > - created a library for bugzilla related functions > - moved some code from one library to another library (db related in /include/db.php, etc.) > - improved the config file (using constants, ability to specify new parameters that would make it very easy to integrate the appdb on another site like ReactOS as they can replace references to winehq and bugs.winehq.org for example) > - the debug parameter of the config file is now taken into consideration in the code (function isdebugging() has been improved) > - fixed some obvious global vars bugs when encountered (so that the help system re-works and most broken admin functions are back) > - replaced apidb occurences with appdb as it's the name of the application > - replaced $apidb_root occurences with BASE constant because both were used and had the same value (so no more glbal $apidb_root needed) > - updated TODO and CODING_STANDARD regarding these changes > - overall improved security (because of global vars and using constants for the config so that it can't be changed using php injection) > > Files added: > - include/classes/application.php > - include/classes/menu.php > - include/classes/screenshot.php > - include/classes/tableve.php > - include/classes/category.php > - include/classes/query.php > - include/classes/session.php > - include/classes/user.php > - include/functions/appdb.php > - include/functions/date.php > - include/functions/maintainer.php > - include/functions/rating.php > - include/functions/util.php > - include/functions/banner.php > - include/functions/db.php > - include/functions/pn_buttons.php > - include/functions/sidebar_admin.php > - include/functions/vote.php > - include/functions/bugzilla.php > - include/functions/help.php > - include/functions/sidebar_login.php > - include/functions/comments.php > - include/functions/html.php > - include/functions/query.php > - include/functions/sidebar.php > > > Files deleted: > - include/appbyvendor_inc.php > - include/appdb.php > - include/application.php > - include/appversion_inc.php > - include/banner.php > - include/category.php > - include/comments.php > - include/db.php > - include/html.php > - include/maintainer.php > - include/menu.php > - include/parsedate.php > - include/pn_buttons.php > - include/qclass.php > - include/query_inc.php > - include/rating.php > - include/session.php > - include/sidebar.php > - include/sidebar_admin.php > - include/sidebar_login.php > - include/tableve.php > - include/user.php > - include/util.php > - include/vote.php > > File changed: > - CODING_STANDARD > - TODO > - account.php > - addcomment.php > - appbrowse.php > - appdbStats.php > - appsubmit.php > - appview.php > - bugs.php > - commentview.php > - deletecomment.php > - edituser.php > - index.php > - maintainerdelete.php > - maintainersubmit.php > - noteview.php > - preferences.php > - screenshots.php > - search.php > - stdquery.php > - support.php > - updaterating.php > - updatevote.php > - vendorview.php > - votestats.php > - admin/addAppFamily.php > - admin/addAppNote.php > - admin/addAppVersion.php > - admin/addCategory.php > - admin/addVendor.php > - admin/adminAppQueue.php > - admin/adminCommentView.php > - admin/adminMaintainerQueue.php > - admin/adminMaintainers.php > - admin/deleteAny.php > - admin/editAppFamily.php > - admin/editAppNote.php > - admin/editAppOwners.php > - admin/editAppVersion.php > - admin/editBundle.php > - admin/editCategory.php > - admin/editVendor.php > - admin/index.php > - admin/adminAppDataQueue.php > - help/index.php > - include/config.php.sample > - include/header.php > - include/incl.php > - include/query_users.php > <gack> you _can't_ be serious. - One patch to do one thing. For example each of the following should their own patch. Change apidb_header() and apidb_footer() to appdb_header() and appdb_footer() Change apidb_fullurl() to appdb_fullurl Move include/tableve.php to include/classes/tableve.php Move include/application.php to include/classes/application.php ... I know you probably will end up sending more than a dozen patches that way. However, I can't approve of a wholesale change, like this, in one go. </gack> The changes you propose are good ones. Just break them down. -- Tony Lambregts

3 3

Loading a .dll.so from current directory
by Frank Richter Dec. 18, 2004

Dec. 18, 2004

Hi, I would like to load a .dll.so from the current directory, and I wonder what's the best way to accomplish this... I tried to set WINEDLLPATH, but it doesn't seem to have an effect (the .dll.so is still only tried to be loaded from /usr/lib, as I can see from the trace:module output). The .dll.so is loaded from a .dll that in turn is called by rundll32... could I perhaps "patch" the DllOverrides for rundll32 in the registry? -f.r.

1 0

Re: [AppDB] screenshot patch
by Chris Morgan Dec. 18, 2004

Dec. 18, 2004

Please convert tabs to spaces. Chris On Saturday 11 December 2004 1:07 pm, Jonathan Ernst wrote: > This patch let user click on the random screenshot displayed for an app > so that he can see the whole gallery by version. The patch displays the > name of the application in the gallery as well (even if we choose a > particular gallery). > > Screenshot gallery's screenshot: http://ernstfamily.ch/screenshot.png > > File changed: > - appview.php > - screenshots.php

2 1