- Wine-Devel - list.winehq.org

Re: Stubs in PE build
by Alexandre Julliard Dec. 14, 2004

Dec. 14, 2004

Ge van Geldorp <gvg(a)reactos.com> writes: > Send for review to wine-devel: http://www.winehq.org/hypermail/wine-devel/2004/11/0658.html (no comments) > Submitted to wine-patch: http://www.winehq.org/hypermail/wine-patches/2004/11/0327.html > Resubmitting against current CVS > > Changelog: > Ge van Geldorp <gvg(a)reactos.com> > - Generate and export stubs specified in .spec files for PE builds I don't think we want to add a special mode just for stubs; they should really be replaced by proper functions (even if the functions are stubs themselves, at least they can print the parameters and try to return something meaningful instead of killing the app). You can view the lack of stubs support on PE as an encouragement to help us remove them from the spec files ;-) -- Alexandre Julliard julliard(a)winehq.org

7 13

Re: [AppDB] Remove borders=0 from img
by tony_lambregts＠telusplanet.net Dec. 14, 2004

Dec. 14, 2004

Paul van Schayck wrote: > Ok, since we have img{border: 0;} in our stylesheet we can now remove > border=0 from all img elements. > > Changelog: > Remove border=0 from img tags > > A patch would be nice.. ;-) -- Tony Lambregts

1 0

"Debugging" a password dialog
by David Gümbel Dec. 14, 2004

Dec. 14, 2004

Hi everybody, I am trying to get an application to run under Wine that requires a login with a username and a password. The program runs all fine, however I can't login with data that should work (and AFAIK works under Windows). Having entered the password, in the corresponding part of the dialog I only see "*****" (which is correct). However, when I change focus to some other part of that dialog afterwards, the password field shows "*************" (way more asterisks than before). The previous (i.e. correct) length of ****s is restored when setting the focus back onto the password field. I have reason to believe that the password I entered is not correctly passed on to the login procedure of the program. However, I am sort of badly lacking a nice idea how to efficiently debug this thingy and verify (falsify ;) that I'm right. So, does anybody have an idea? Bye, David

5 7

wineprefixcreate and config file
by Raul Dias Dec. 14, 2004

Dec. 14, 2004

Hi, Shouldn't tools/wineprefixcreate copy a sample config file? Right now it does all the job to create a standalone wine environment, but with no config. I would suggest copying documentation/samples/config to tools/config, installing it at $(SRCDIR) and them just copying it during wineprefixcreate call. I can do that if no one disagrees with the change. Some rpms in the sourceforge does not even have the sample config file in it. -- Raul Dias

2 1

Dodgy NetBSD code in dlls/kernel/cpu.c?
by Jon Griffiths Dec. 14, 2004

Dec. 14, 2004

Hi, in dlls/kernel/cpu.c, around line 430, is the following code for NetBSD: { int mib[2]; int value[2]; ... if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) if (value) PF[PF_FLOATING_POINT_EMULATED] = FALSE; else PF[PF_FLOATING_POINT_EMULATED] = TRUE; This looks dodgy, the "if (value)" test will always be true. I gather it should be "if (value[0])" or "if (value)[1]", but I'm no NetBSD guru. Also, there should be not need to set values to FALSE, since the flag array is cleared to 0 at the start of this function. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Visual studio 6 build fix.
by Rein Klazes Dec. 14, 2004

Dec. 14, 2004

Hi, MS Visual C++ v6, when invoking the compiler and other build tools does the following: create anonymous pipe; duplicate the pipes write handle; open's the file NUL calls CreateProcess starting vcspawn.exe with: startup info iohandles set to the 3 handles obtained above; the startup info flag STARTF_USESTDHANDLES set; create flag CREATE_NEW_CONSOLE set. the parent process reads from the pipe, and analyses the compiler and other messages that are obtained that way. Wine's console startup code is not really expecting this and insists on creating new stdio handles instead of inheriting them. The attached patch makes this work properly. Changelog: server : process.c dlls/kernel : console.c A starting process must obey the STARTF_USESTDHANDLES flag, even it is starting a new console. Rein. -- Rein Klazes rklazes(a)xs4all.nl

3 5

Re: Perform automatic bitmap font configuration based on the current locale
by Huw D M Davies Dec. 14, 2004

Dec. 14, 2004

On Mon, Dec 13, 2004 at 11:39:58PM +0800, Dmitry Timoshkov wrote: > Hello, > > due to a GDI bug new values don't actually work, and that's another > thing I'm going to look at. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Perform automatic bitmap font configuration based on the current locale. > > diff -up cvs/hq/wine/dlls/kernel/locale.c wine/dlls/kernel/locale.c > --- cvs/hq/wine/dlls/kernel/locale.c 2004-11-22 17:52:19.000000000 +0800 > +++ wine/dlls/kernel/locale.c 2004-12-13 23:25:50.000000000 +0800 > @@ -5,6 +5,7 @@ > * Copyright 1998 David Lee Lambert > * Copyright 2000 Julio C?sar G?zquez > * Copyright 2002 Alexandre Julliard for CodeWeavers > + * Copyright 2003, 2004 Dmitry Timoshkov > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -226,25 +227,175 @@ inline static HKEY create_registry_key(v > { > static const WCHAR intlW[] = {'C','o','n','t','r','o','l',' ','P','a','n','e','l','\\', > 'I','n','t','e','r','n','a','t','i','o','n','a','l',0}; > - OBJECT_ATTRIBUTES attr; > - UNICODE_STRING nameW; > HKEY hkey; > > if (RtlOpenCurrentUser( KEY_ALL_ACCESS, &hkey ) != STATUS_SUCCESS) return 0; > > - attr.Length = sizeof(attr); > - attr.RootDirectory = hkey; > - attr.ObjectName = &nameW; > - attr.Attributes = 0; > - attr.SecurityDescriptor = NULL; > - attr.SecurityQualityOfService = NULL; > - RtlInitUnicodeString( &nameW, intlW ); > + return NLS_RegOpenSubKey( hkey, intlW ); > +} > > - if (NtCreateKey( &hkey, KEY_ALL_ACCESS, &attr, 0, NULL, 0, NULL ) != STATUS_SUCCESS) hkey = 0; > - NtClose( attr.RootDirectory ); > - return hkey; > +/*********************************************************************** > + * create_fonts_registry_key > + * > + * Create the HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion\\Fonts > + * registry subkey. > + */ > +inline static HKEY create_fonts_registry_key(void) > +{ > + static const WCHAR fontsW[] = { > + 'M','a','c','h','i','n','e','\\','S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\','W','i','n','d','o','w','s',' ','N','T','\\', > + 'C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\', > + 'F','o','n','t','s',0}; > + > + return NLS_RegOpenKey( 0, fontsW ); > } You should probably put them under HKLM\Software\Microsoft\Windows\CurrentVersion\Fonts too. (Or at least use this key for winver=win9x, since this is where we'll look if running in win9x mode). Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by Ivan Leo Puoti Dec. 14, 2004

Dec. 14, 2004

>I just tried Ivan's patch on my program, and get the same insufficient >version >error that I was getting with the original, unpatched, version. My >original patch did not have this problem. Why don't you add a few traces to see what's going on? I've already explained that your orginal patch is wrong. Also check the versions of the dlls that the function is calling, and the winver setting. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti Dec. 14, 2004

Dec. 14, 2004

I just tried Ivan's patch on my program, and get the same insufficient version error that I was getting with the original, unpatched, version. My original patch did not have this problem. William

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by Ivan Leo Puoti Dec. 13, 2004

Dec. 13, 2004

> It was 4. Pehaps there is yet another bug someplace else. That's why in my updated patch I check the OS using the available info. It's here, you may want to try it out and check if it works for you app http://www.winehq.com/hypermail/wine-patches/2004/12/att-0275/01-wkivcf2.di… You patch was wrong because the fact that MajorSubsystemVersion is 4 and MinorOperatingSystemVersion is 0 doesn't mean the OS is win2k, it could be nt4 or win95, and returning win2000 when winver is set to win95 could cause problems. See http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/ba… Also it's better to use switch when comparing a variable to multiple values, it's more readable, and you added some useless braces. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0