- Wine-Devel - list.winehq.org

Re: Fix For Menu Bar (resend)
by Ivan Leo Puoti Nov. 11, 2004

Nov. 11, 2004

> I know this sounds a bit unethical (maybe impolite would be a better word), but > for practical reasons I think this is permittable. Or maybe I should > specifically state (at wine-patches) that I "allow anyone else to fix the patch > should it contain errors, and resubmit it"? If you licence the patch for inclusion with wine, you licence it under the LGPL, that does allow this, as it's free software. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Ekush
by Ivan Leo Puoti Nov. 11, 2004

Nov. 11, 2004

> Ekush (http://www.ekush.com) published some binaries. At time of writing the hoster has taken them down. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: [AppDB] apidb_fullurl() does not act as expected...
by Jeremy Newman Nov. 10, 2004

Nov. 10, 2004

No this will not work. You need to keep the paths relative. Do not use full URLs as then if you have a development/test server running, it will take you back to the production site. If you look at index.php, there is an include("path.php"), which defines the static BASE. If you always inclide path.php from the cwd, your scripts will get BASE, and you can use that for the relative path. On Tue, 2004-11-09 at 19:33 -0700, Tony Lambregts wrote: > apidb_fullurl() does not give the Full URL go figure.. > > Change log: fix up the notify for add and delete comment so it gives a proper back link > > files changed: addcomment.php > deletecomment.php > include/incl.php > > Index: addcomment.php > =================================================================== > RCS file: /home/wine/appdb/addcomment.php,v > retrieving revision 1.2 > diff -u -r1.2 addcomment.php > --- addcomment.php 9 Nov 2004 22:42:12 -0000 1.2 > +++ addcomment.php 10 Nov 2004 02:15:50 -0000 > @@ -49,7 +49,7 @@ > if($email) > { > $fullAppName = "Application: ".lookupAppName($appId)." Version: ".lookupVersionName($appId, $versionId); > - $ms .= apidb_fullurl("appview.php?appId=$appId&versionId=$versionId")."\n"; > + $ms .= APPDB_ROOT."appview.php?appId=$appId&versionId=$versionId"."\n"; > $ms .= "\n"; > $ms .= ($current->username ? $current->username : "Anonymous")." added comment to ".$fullAppName."\n"; > $ms .= "\n"; > Index: deletecomment.php > =================================================================== > RCS file: /home/wine/appdb/deletecomment.php,v > retrieving revision 1.3 > diff -u -r1.3 deletecomment.php > --- deletecomment.php 9 Nov 2004 22:42:12 -0000 1.3 > +++ deletecomment.php 10 Nov 2004 02:15:50 -0000 > @@ -65,7 +65,7 @@ > if($email) > { > $fullAppName = "Application: ".lookupAppName($appId)." Version: ".lookupVersionName($appId, $versionId); > - $ms .= apidb_fullurl("appview.php?appId=$appId&versionId=$versionId")."\n"; > + $ms .= APPDB_ROOT."appview.php?appId=$appId&versionId=$versionId"."\n"; > $ms .= "\n"; > $ms .= ($current->username ? $current->username : "Anonymous")." deleted comment from ".$fullAppName."\n"; > $ms .= "\n"; > Index: include/incl.php > =================================================================== > RCS file: /home/wine/appdb/include/incl.php,v > retrieving revision 1.3 > diff -u -r1.3 incl.php > --- include/incl.php 9 Nov 2004 22:42:13 -0000 1.3 > +++ include/incl.php 10 Nov 2004 02:15:51 -0000 > @@ -241,6 +241,7 @@ > define("STANDARD_NOTIFY_FOOTER","------- You are receiving this mail because: -------\n". > "You are an maintainer of this app or an appdb administrator\n". > "to change your preverences go to: http://appdb.winehq.org/preferences.php\n"); > +define("APPDB_ROOT", "http://appdb.winehq.org/"); > > > ?> > >

2 1

FW: [dx9-12 next try] SetStreamSource changes
by Ann and Jason Edmeades Nov. 10, 2004

Nov. 10, 2004

Was there a problem with this one - Its really holding me up with progress, so I need to ensure I resolve any issues asap. Thanks Jason -----Original Message----- From: Ann and Jason Edmeades [mailto:us(a)the-edmeades.demon.co.uk] Sent: 06 November 2004 21:52 To: 'wine-patches(a)winehq.org' Subject: [dx9-12 next try] SetStreamSource changes This makes the change as per my previous note - Any better? >When I call addref the wined3dvb interface, I addref on the d3dvb >interface, and similarly on release, I release the d3d interface >from release on the wined3dvb? Let me know if there are any problems Changelog - Implement SetStreamSource - Ensure wined3d objects maintain a reference count of at least that of the d3dx version Jason

1 0

[setupx_main.c] SETUPX_CreateStandardLDDs: question about a FIXME
by Fabrice Ménard Nov. 10, 2004

Nov. 10, 2004

Hi, In setupapi/setupx_main.c, function SETUPX_CreateStandardLDDs: There is a FIXME("LDID_SRCPATH: what exactly do we have to do here ?\n"). It concerns the registry value: SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Setup\\SourcePath. AFAIK, this value defines the location where the setup of windows was done. As we don't have a real windows installation, this key is naturally not set. I'm wondering if it will hurt to set it to a fallback string (maybe the most common one: "D:\\") and get rid of this FIXME. I think if a windows application need this value and don't find what it wants, it justs throw a message box asking for the correct CD (in fact it is very common to have this value set to a wrong path when you have more than one CD device). I know it is not so important, but I really enjoy having one less FIXME :-)) If you're ok with that, I'll send a tiny patch Fabrice Ménard menard.fabrice(a)wanadoo.fr

1 0

Ekush
by Ge van Geldorp Nov. 10, 2004

Nov. 10, 2004

> From: Ge van Geldorp > > Ekush (http://www.ekush.com) published some binaries. > Surprise, surprise, it looks like ReactOS very much (Check > e.g. the radio buttons on the "Accept License" screen during > 2nd stage setup). > Some string searching in their binaries reveals: > > $ strings -a ver.dll | grep ReactOS > OS2 Images not supported under ReactOS at this time. Shortly after I sent this email to ros-dev yesterday the Ekush website went down. Today they are back, with a slightly changed set of binaries. The strings I reported yesterday are gone now (well, except for the CcRosInitializeFileCache and CcRosReleaseFileCache exports from NTOSKRNL, maybe changing the name of an exported symbol was too difficult???). There's still plenty of other evidence of the ReactOS heritage though. I guess since I only reported about ReactOS they forgot to remove the references to Wine (except ofcourse the copyright notices, those are gone). This pisses me off bigtime. I can only explain it as a deliberate attempt to use the work of Qemu, FreeType, Wine and ReactOS without giving credit. Gé van Geldorp.

2 1

Latent memory corruption bug in widl, with workaround
by Dan Kegel Nov. 10, 2004

Nov. 10, 2004

I ran into the error Oops, segment violation while running make to build wine from cvs. It failed on the command ../tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include -h -H ocidl.h ../../wine/include/ocidl.idl Turning on logging showed that it happened while processing an import statement. Running under valgrind yielded output like this: ==10699== Invalid read of size 1 ==10699== at 0x4002273E: strlen (mac_replace_strmem.c:164) ==10699== by 0x805E0D1: pp_xstrdup (../../../wine/libs/wpp/preproc.c:108) ==10699== by 0x805E7B2: pp_add_define (../../../wine/libs/wpp/preproc.c:231) ==10699== by 0x805FB21: add_cmdline_defines (../../../wine/libs/wpp/wpp.c:48) ==10699== Address 0x41233334 is 0 bytes inside a block of size 29 free'd ==10699== at 0x40029961: free (vg_replace_malloc.c:231) ==10699== by 0x805B9B6: yylex (../../../wine/tools/widl/parser.l:126) ==10699== by 0x80548B3: yyparse (/usr/share/bison/bison.simple:573) ==10699== by 0x8054295: main (../../../wine/tools/widl/widl.c:265) Commenting out the free on line 126 of widl/parser.l solved the problem. Uncommenting it and building again, I couldn't reproduce the original crash, but running under valgrind revealed the problem was still there, just hidden. I tried tracing through why the free on line 126 of widl/parser.l was bad, but it was too late, and I was too tired. Can somebody else have a look? It was quite annoying to be dead in the water, unable to build wine... Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [lostwages] developer cheatsheet
by Jeremy Newman Nov. 10, 2004

Nov. 10, 2004

Added this. The text in the <code> tag on line 78 is long. It needs a line break or something. And I fixed the url in documentation template. Otherwise it looks fine to me. On Fri, 2004-11-05 at 19:00 +0000, Mike Hearn wrote: > Add a developer getting started guide to the website. Hack to your > satisfaction, I probably did it totally wrong ;)

1 0

Thanks
by Frank v Waveren Nov. 9, 2004

Nov. 9, 2004

I felt nostalgic for starcraft today, so for fun and kicks decided to see if wine was up to the task. Not only did it run, it worked perfectly, using RandR and everything. Very impressive, thanks for the wonderful work everyone! -- Frank v Waveren Fingerprint: 9106 FD0D fvw(a)[var.cx|stack.nl] ICQ#10074100 D6D9 3E7D FAF0 92D1 Public key: hkp://wwwkeys.pgp.net/8D54EB90 3931 90D6 8D54 EB90

1 0

Re: dlls/rsaenh/rsaenh.c
by Alexandre Julliard Nov. 9, 2004

Nov. 9, 2004

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > Changelog: > CPAcquireContext: Set last error to ERROR_SUCCESS in case of success. There are very few functions that set last error on success, do you have a test demonstrating that Windows does it in this case? -- Alexandre Julliard julliard(a)winehq.org

2 6