- Wine-Devel - list.winehq.org

Update to flymake patch
by Mike Hearn Nov. 8, 2004

Nov. 8, 2004

This adds support for the lovely flymake-mode, which compiles C as you write it in the background and highlights errors and warnings. It's an update to the patch I sent in about a year ago. Since then GNU Emacs has changed (in cvs) so I've attached the version of flymake-mode you need to make it all work. Not expecting this to get merged so it goes to wine-devel.

1 0

registry test incorrect for xp
by James Hawkins Nov. 8, 2004

Nov. 8, 2004

I just completed building the wine conformance tests with Visual Studio .NET. When I ran the advapi32/security tests, there were 28 failures (compiled and tested on XP). The first error I looked at is: registry.c:93: Test failed: data_count set to 24 instead of 7 Looking at registry.c, this test calls RegEnumValue with an output data buffer that is too small, LONG RegEnumValue( HKEY hKey, DWORD dwIndex, LPTSTR lpValueName, LPDWORD lpcValueName, LPDWORD lpReserved, LPDWORD lpType, LPBYTE lpData, LPDWORD lpcbData ); so the lpcbData should contain the required size of the buffer on return. hKey is initialized to HKCU\Software\Wine\Test and dwIndex is 0, so we're reading this: Name: Test1 Type: REG_EXPAND_SZ Data: %LONGSYSTEMVAR%\subdir1 The current test expects RegEnumValue to expand the environment variable %LONGSYSTEMVAR%, leaving nothing since the variable doesn't exist. If this were the case then lpcbData would return the length of 'subdir1' which is 7, which is what the test expects, but testing shows that even though the type is REG_EXPAND_SZ, RegEnumValue does not expand the environment variable, so lpcbData contains the length of %LONGSYSTEMVAR%\subdir1 which is 24, and which is what is returned when called with XP. This is further clarified by msdn docs, "Your application should call ExpandEnvironmentStrings before attempting to read the value of a REG_EXPAND_SZ registry data type." http://msdn.microsoft.com/library/default.asp?url=/library/en-us/apcompat/a… While it never says that RegEnumValue doesn't expand REG_EXPAND_SZ, this evidence shows that this is the case. If anyone has any thoughts on this, please let me know. Otherwise I will be sending a patch that fixes this test and then checking the test in wine to see if our RegEnumValue needs to be fixed as well. -- James Hawkins

1 1

150 test failures. advapi32 test crashes.
by Dan Kegel Nov. 8, 2004

Nov. 8, 2004

Hey folks, I pulled down sources from CVS this morning, and tried running the regression tests. There are about 150 failures. Here's a summary: $ grep "Test failed" log | sed 's/:.*//' | uniq -c | sort 1 filtergraph.c 1 rsaenh.c 1 shelllink.c 1 shreg.c 2 typelib.c 4 capture.c 4 wave.c 6 dsound8.c 6 dsound.c 7 vartype.c 8 path.c 15 crypt.c 43 metafile.c 51 shellpath.c Is this unusual? How many failures are most people seeing? For what it's worth, this is a Red Hat 9.0 system with two processors, and this was done with no pre-existing .wine directory. Also, there was a crash during the test. Here's that part of the log: ../../../../wine/tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so ../../../../wine/dlls/advapi32/tests/crypt.c && touch crypt.ok crypt.c:104: Test failed: -2146893799 crypt.c:117: Test failed: 0/-2146893799 crypt.c:126: Test failed: 0/-2146893801 crypt.c:457: Test failed: expected 234, got -2146893801 crypt.c:464: Test failed: expected 0, got 0 crypt.c:471: Test failed: expected (null), got crypt.c:472: Test failed: expected 0, got 0 crypt.c:491: Test failed: -2146893805 crypt.c:494: Test failed: -2146893805 crypt.c:502: Test failed: expected Microsoft Base Cryptographic Provider v1.0, got crypt.c:503: Test failed: expected 43, got 0 crypt.c:491: Test failed: -2146893805 crypt.c:494: Test failed: -2146893805 crypt.c:502: Test failed: expected Microsoft Base Cryptographic Provider v1.0, got crypt.c:503: Test failed: expected 43, got 0 wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x8dbe4073 in 32-bit code (0x403602e2). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:003b GS:0033 EIP:403602e2 ESP:4073f9d2 EBP:4073fa5e EFLAGS:00010202( - 00 - -RI1) EAX:8dbe4073 EBX:404174c8 ECX:40053500 EDX:401f0b20 ESI:4073fe26 EDI:77f01330 Stack dump: 0x4073f9d2: 00004001 00000000 00000000 d14c0000 0x4073f9e2: 0c884001 13304020 fa3477f0 020f4073 0x4073f9f2: fa340000 a5864073 fa644001 009b4073 0x4073fa02: d8940000 00004002 00000001 6c644008 0x4073fa12: ffff4041 e384ffff fa2c400c 68114073 0x4073fa22: 6c644008 74c84041 fa544041 e3844073 Backtrace: =>1 0x403602e2 INSTR_EmulateInstruction+0xda(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/kernel/instr.c:449] in kernel32 (0x4073fa5e) 2 0x403a441e vectored_handler+0x5e(ptrs=0x4073fa8e) [../../../wine/dlls/kernel/wowthunk.c:358] in kernel32 (0x4073fa7e) 3 0x4008bf89 call_vectored_handlers+0x5a(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/exception.c:196] in ntdll (0x4073faa2) 4 0x4008c30d EXC_RtlRaiseException+0x239(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/exception.c:252] in ntdll (0x4073fb2a) 5 0x400abe12 raise_segv_exception+0x8b(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/signal_i386.c:888] in ntdll (0x4073fb46) 0x403602e2 INSTR_EmulateInstruction+0xda [../../../wine/dlls/kernel/instr.c:449] in kernel32: movzbl 0x0(%eax),%eax Unable to open file ../../../wine/dlls/kernel/instr.c Modules: Module Address Debug info Name (17 modules) ELF 0x40000000-40016000 Deferred ld-linux.so.2 ELF 0x40017000-40030000 Deferred libwine.so.1 ELF 0x40032000-4003e000 Deferred libnss_files.so.2 ELF 0x40043000-40050000 Deferred libpthread.so.0 ELF 0x40050000-40053000 Deferred libdl.so.2 ELF 0x40054000-400d1000 Stabs ntdll<elf> \-PE 0x40070000-400d1000 \ ntdll ELF 0x400d1000-401c5000 Deferred libwine_unicode.so.1 ELF 0x401c5000-401e7000 Deferred libm.so.6 ELF 0x40300000-40419000 Stabs kernel32<elf> \-PE 0x40330000-40419000 \ kernel32 ELF 0x40621000-4063c000 Deferred advapi32_test<elf> \-PE 0x40630000-4063c000 \ advapi32_test ELF 0x40740000-4077b000 Deferred advapi32<elf> \-PE 0x40750000-4077b000 \ advapi32 ELF 0x42000000-42133000 Deferred libc.so.6 ELF 0x77f00000-77f03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\dank\demo\build\dlls\advapi32\tests\advapi32_test.exe 00000009 0 <== WineDbg terminated on pid 0x8 -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

5 11

Re: signaling unix threads
by Jukka Heinonen Nov. 8, 2004

Nov. 8, 2004

Markus Amsler wrote: > There's a fundamental bug in winedos/dosvm. c[1]. SIGUSR2 is sent to the > current process, but it should be sent to the dosvm thread. This causes > various ugly bugs. > I found no way signaling a unix thread, without modifing the wineserver. > I have implemented a thread_kill command in the wineserver, this solves > my problem, but i'm quite sure it won't get applied. > > I'm really not a wineserver/threading expert. Have I missed something? Yep. If using Linux 2.6 kernel and recent pthread library, threads share the same pid and they must be signalled using tkill and not kill. The only place which knows how to correctly signal threads is send_thread_signal function in server/ptrace.c. So, the easy way to fix signalling is to use Windows thread identifier for identifying dosvm thread instead of pids (which don't work anyway) and add to wineserver a handler that just calls send_thread_signal, which I guess is what you have been doing, anyway. Now, I have tried this approach and it seems to work. I have some prototype implementation lying around but I was thinking about doing something more complicated at the time, like using SIGUSR2 handler for doing Win32 remote operations discussed earlier on wine-devel, because signal handler is probably running in the correct context for doing this kind of things but I guess locking issues are going to be pretty complicated so it is probably better to just fix dosvm issues with a simple mechanism and not worry about anything else. So, feel free to submit a patch, if it is simple enough it should get accepted or at least you should get some suggestions how to change the patch in order for it to get accepted. -- Jukka Heinonen <http://www.iki.fi/jhei>

4 5

Re: Fix DLL loader regression
by Mike Hearn Nov. 8, 2004

Nov. 8, 2004

Any problem with this one Alexandre? On Thu, 04 Nov 2004 01:00:37 +0000, Mike Hearn wrote: > - Always add .dll extension when loading modules > > > Index: loader.c > =================================================================== > RCS file: /home/wine/wine/dlls/ntdll/loader.c,v > retrieving revision 1.78 > diff -u -p -r1.78 loader.c > --- loader.c 11 Oct 2004 20:59:06 -0000 1.78 > +++ loader.c 4 Nov 2004 00:56:48 -0000 > @@ -1432,12 +1432,18 @@ static NTSTATUS find_dll_file( const WCH > len = nt_name.Length - 4*sizeof(WCHAR); /* for \??\ prefix */ > if (len >= *size) goto overflow; > memcpy( filename, nt_name.Buffer + 4, len + sizeof(WCHAR) ); > + > + /* do we need to add the .dll extension? */ > if (file_part && !strchrW( file_part, '.' )) > { > len += sizeof(dllW) - sizeof(WCHAR); > if (len >= *size) goto overflow; > strcatW( filename, dllW ); > + RtlFreeUnicodeString( &nt_name ); > + if (!RtlDosPathNameToNtPathName_U( filename, &nt_name, &file_part, NULL )) > + return STATUS_NO_MEMORY; > } > + > if (!(*pwm = find_fullname_module( filename ))) > { > attr.Length = sizeof(attr);

2 1

Scrollbars
by Nicolai Kuntze Nov. 8, 2004

Nov. 8, 2004

Hi, I have played with my continuing bug (#2302) but I have some problems understanding the meaning of the output: fixme:win:GetWindowModuleFileNameA GetWindowModuleFileNameA(hwnd 0x40032, lpszFileName 0x40670548, cchFileNameMax 80) stub! trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=1 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=1 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=2 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=2 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=3 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=3 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 If my blue bar in the list disappears pos Value counts how many lines under the window I am. I have added a little debug to follow the source ... From the developer I got the following snipplet: int SViewLow::ViewSetScrollY( int PPos, int PMax, int PPage) { SCROLLINFO Scroll; memset( &Scroll, 0, sizeof( Scroll)); Scroll.cbSize= sizeof( SCROLLINFO); Scroll.fMask= 0; if (PPos!=-1) Scroll.fMask|= SIF_POS; if (PMax!=-1) Scroll.fMask|= SIF_RANGE; if (PPage!=-1) Scroll.fMask|= SIF_PAGE; Scroll.nPos= PPos; Scroll.nPage= PPage; Scroll.nMax= PMax-1; return SetScrollInfo( (HWND)ViewGetHWND(), SB_VERT, &Scroll, TRUE); } Does anyone has an idea what this could be? Yours, Nicolai

2 1

Re: Re: Winetest questions
by Chris Morgan Nov. 8, 2004

Nov. 8, 2004

> On Sun, Nov 07, 2004 at 02:01:13PM -0800, Dan Kegel wrote: > > 1. Why are all the archived posts to wine-test-results empty? > > See http://www.winehq.org/hypermail/wine-tests-results/2004/11 > > Every message body is empty! What's up with that? > > That's a good question. Chris, what's going on? > I suspect these are clients that have issues connecting to the net to upgrade their version of winrash since there are relatively few error reports compared to the number of test result submissions. We should really have the script ignore empty requests like this as they don't tell us anything and simply spam the mailing list every day. Chris

1 0

Re: Fix for metafile test
by Dan Kegel Nov. 8, 2004

Nov. 8, 2004

jakov(a)vmlinux.org wrote: > This is from when I ran winetest.exe from the desktop: > > http://test.winehq.org/data/200411021000/2000/gdi32:metafile.txt : > > metafile.c:126:hdcDisplay 76010815 > metafile.c:154:hdcMetafile 202107C1 > metafile.c:40:hdc 76010815, emr->iType 1, emr->nSize 108, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 82, emr->nSize 368, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 40, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 14, emr->nSize 20, param 0022FB58 > metafile: 151 tests executed, 0 marked as todo, 0 failures. Here's what I get when I run 'make test' on Wine: ../../../../wine/tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so ../../../../wine/dlls/gdi/tests/metafile.c && touch metafile.ok metafile.c:91: Test failed: pass 0: dx[0] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[1] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[2] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[3] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[4] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[5] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[6] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[7] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[8] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[9] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[10] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[11] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[12] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[13] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[14] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[15] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[16] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[17] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[18] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[19] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[20] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[21] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[22] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[23] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[24] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[25] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[26] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[27] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[28] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[29] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[30] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[31] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[32] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[33] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[34] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[35] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[36] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[37] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[38] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[39] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[40] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[41] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[42] (1081735508) didn't match 4 make[3]: *** [metafile.ok] Error 43 Is the metafile test supposed to be broken like this under Wine? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 2

Re: wine/ tools/wine.inf include/config.h.in dlls/ ...
by Vincent Béron Nov. 8, 2004

Nov. 8, 2004

Le jeu 04/11/2004 à 16:15, Alexandre Julliard a écrit : > Log message: > Michael Jung <mjung(a)iss.tu-darmstadt.de> > Implemented a substantial part of rsaenh.dll. > > Patch: http://cvs.winehq.org/patch.py?id=14412 The committed patch doesn't compile on RH8. OpenSSL doesn't use the same name for some datatypes/functions as the version used by Michael (actually the prototype is different as well). OpenSSL 0.9.7a (as found on FC1) will use OPENSSL_ENABLE_OLD_DES_SUPPORT by default which will #define the old names to the new ones for the DES functions. RSAPrivateKey_dup is only defined in x509.h in OpenSSL 0.9.6b, not in rsa.h. But pulling in x509.h also includes md4.h, md5.h and sha.h (via evp.h), which redefine MD4_CTX (and MD5 and SHA _CTX also) with an incompatible definition if the NO_MD4, etc. are not defined. Changelog: Allow rsaenh compilation with older (0.9.6b) OpenSSL version. Remove a cast from const to not-const. Vincent

2 1

Do we need one of those on our docs?
by Shachar Shemesh Nov. 8, 2004

Nov. 8, 2004

From the samba developer's guide, http://us1.samba.org/samba/devel/ > *Important:* In order to avoid any potential licensing issues we > also ask that anyone who has signed the Microsoft CIFS Royalty > Free Agreement > <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cifs/proto…> > not submit patches to Samba, nor base patches on the referenced > specification. We ask, too, that patches submitted to Samba not > infringe on any known patents. Finally, as with all GPL work, the > submitter should ensure that submitted patches do not conflict > with any third-party copyright. > > Do we need to put in something like that too? I'm not a lawyer (but I can probably get one). My understanding is that the "protocols" Microsoft policy don't really affect us. What may affect us is the wider and wider distribution of the Windows source code (Shared Source). We should not be highly affected by trade secrets: anyone publishing a trade secret is nullifying the secretness of it, and is the one bearing the responsibility for this action. However, copyright problems may be a problem for us. If someone takes a significant amount of code from MS and submits it, we may have some backtracking to do. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1