- Wine-Devel - list.winehq.org

Re: dlls/x11drv/winpos.c::SWP_DoOwnedPopups()
by Dmitry Timoshkov Oct. 20, 2004

Oct. 20, 2004

"Peter Riocreux" <par+wine_patches(a)silistix.com> wrote: > The comment above SWP_DoOwnedPopups in dlls/x11drv/winpos.c suggests > that the only thing missing is what I *might* have fixed here, > therefore the patch also removes the FIXME and the WARN. It compiles > and doesn't break any behaviour I can test, but I am only guessing > whether I have done the right thing. You have to write a test case and add it to existing ones in dlls/user/tests/win.c to confirm that the patch is correct. -- Dmitry.

2 3

DrawTextA: regarding the nCount variable
by William Poetra Yoga H Oct. 20, 2004

Oct. 20, 2004

In the MSDN, it is stated that if nCount is 1, then it is assumed that lpString is a null-terminated string. But in the DrawTextExA function, it is -1, as in the code: if (count == -1) count = strlen(str); Shouldn't this be 1 instead of -1? CMIIW. (But theForger's tutorial also uses -1) _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

3 3

Re: ADVAPI32: implement ChangeServiceConfigA using ChangeServiceConfigW (take 2)
by Robert Shearman Oct. 20, 2004

Oct. 20, 2004

Mike McCormack wrote: > > oops. The macro functions for duplicating strings already exist, so > use them instead. > > Mike > > > ChangeLog: > * implement ChangeServiceConfigA using ChangeServiceConfigW > >------------------------------------------------------------------------ > >Index: dlls/advapi32/service.c >=================================================================== >RCS file: /home/wine/wine/dlls/advapi32/service.c,v >retrieving revision 1.60 >diff -u -r1.60 service.c >--- dlls/advapi32/service.c 27 Sep 2004 20:35:27 -0000 1.60 >+++ dlls/advapi32/service.c 20 Oct 2004 07:28:54 -0000 >@@ -810,7 +810,8 @@ > > static inline VOID SERV_free( LPWSTR wstr ) > { >- HeapFree( GetProcessHeap(), 0, wstr ); >+ if (wstr) >+ HeapFree( GetProcessHeap(), 0, wstr ); > } > > There is no need for this check. Freeing NULL pointers is not an error and is handled by the RtlFreeHeap code. Rob

1 0

Re: fix tbn_deletingbutton
by Dmitry Timoshkov Oct. 19, 2004

Oct. 19, 2004

"Thorsten Kani" <beebix(a)gmx.net> wrote: > I'm a bit unsure about my solution, but actually everything works. > -complaints appreciated- > --- toolbar.c 23 Sep 2004 22:51:14 -0000 1.194 > +++ toolbar.c 10 Oct 2004 17:29:01 -0000 > @@ -3191,12 +3191,20 @@ > TOOLBAR_INFO *infoPtr = TOOLBAR_GetInfoPtr (hwnd); > INT nIndex = (INT)wParam; > NMTOOLBARW nmtb; > + WCHAR Buffer[256]; > > if ((nIndex < 0) || (nIndex >= infoPtr->nNumButtons)) > return FALSE; > > memset(&nmtb, 0, sizeof(nmtb)); > nmtb.iItem = nIndex; > + memcpy(&nmtb.tbButton, &infoPtr->buttons[nIndex], sizeof(nmtb.tbButton) ); > + nmtb.cchText = 256; > + nmtb.pszText = Buffer; > +#if (_WIN32_IE >= 0x500) > + nmtb.rcButton =(RECT)infoPtr->buttons[nIndex].rect; > +#endif > + > TOOLBAR_SendNotify((NMHDR *)&nmtb, infoPtr, TBN_DELETINGBUTTON); 1. do not use _WIN32_IE version checks in Wine code, they have no sense 2. there is no point in setting a pointer to a not initialized buffer 3. there is no need to cast RECT to a RECT -- Dmitry.

3 8

Re: add epoll implementation to libwine_port (take 3)
by Chris Dodd Oct. 19, 2004

Oct. 19, 2004

Mike McCormack <mike(a)codeweavers.com> wrote in news:4174D681.9050503(a)codeweavers.com: > A few more changes after consulting with Alexandre. > > ChangeLog: > * add epoll implementation to libwine_port : > + __asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl > %%ebx" + : "=a" (ret) : "0" : A random question here from someone who is not too familiar with wine internals -- why are you using inline asm code instead of syscall(2)? It seems like syscall would be both simpler and more portable. Chris Dodd cdodd(a)acm.org

1 0

Re: add epoll implementation to libwine_port (take 3)
by Boaz Harrosh Oct. 19, 2004

Oct. 19, 2004

Mike McCormack wrote: > > > ChangeLog: > * add epoll implementation to libwine_port > >.... > > >+ __asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl %%ebx" > > Grate ! [Q] Does that mean that we directly check if it is supported in kernel, bypassing glibc all together? how do we avoid conflicts with glibc?

4 5

dlls/x11drv/winpos.c::SWP_DoOwnedPopups
by Peter Riocreux Oct. 19, 2004

Oct. 19, 2004

I have a lot of WARNs from this function so I thought I would have a shufty at it to see if it was easy to fix. The FIXME above it is written so as to suggest that it is a matter of mere keystrokes to fix it up, or weeks of work, depending on your frame of mind when you read it. Still being a beginner (first patch now committed be Aj - yay!) and not knowing about Windows programming, I don't know where to look to decide which is the case. The comment above it says: /*********************************************************************** * SWP_DoOwnedPopups * * fix Z order taking into account owned popups - * basically we need to maintain them above the window that owns them * * FIXME: hide/show owned popups when owner visibility changes. */ It looks like, depending on some property of 'owner' it should or shouldn't use the property SWP_HIDEWINDOW in the call to SetWindowPos <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winu…> If this is the case I could fix it, if I knew how to determine when 'owner' is visible. Do I also need a callback of some kind so that the popup is rendered invisible when the parent is, even if SWP_DoOwnedPopups is not called (or is that not (supposed to be) possible?)? Is the WARN there only because of the FIXME and if I fix the FIXME I should remove the WARN? Peter

1 1

Re: wine/dlls/ntdll time.c
by Dimitrie O. Paun Oct. 19, 2004

Oct. 19, 2004

On Mon, Oct 18, 2004 at 04:19:29PM -0500, Alexandre Julliard wrote: > Log message: > Rein Klazes <rklazes(a)xs4all.nl> > In RtlQueryTimezoneInformation use information from the registry if it > is available. > > Patch: http://cvs.winehq.org/patch.py?id=14188 Hmm, shouldn't we synch up with the Unix env instead? I assume this info is available in the Unix env... This would be preferable even in the case of a shared Windows install, me thinks. -- Dimi.

2 1

CreateFile GENERIC_WRITE on a directory
by ScratchMonkey Oct. 19, 2004

Oct. 19, 2004

Not sure if this should be in -users, but I'm trying to get the Tribes: Vengeance dedicated server going (1st person shooter) and it stops with a messagebox that it can't write to its own directory. Tracing the program with +relay reveals this: 000b:Call kernel32.CreateFileW(10415fc0 L"Z:\\home\\vengeance\\Server \\Program\\Bin\\",40000000,00000007,00000000,00000003,02000000,00000000) ret=1015b46d 000b:Call ntdll.RtlIsDosDeviceName_U(10415fc0 L"Z:\\home\\vengeance\\Server \\Program\\Bin\\") ret=554b4506 000b:Ret ntdll.RtlIsDosDeviceName_U() retval=00000000 ret=554b4506 000b:Call ntdll.RtlDosPathNameToNtPathName_U(10415fc0 L"Z:\\home\\vengeance \\Server\\Program\\Bin\\",559bebb0,00000000,00000000) ret=554b42c7 000b:Ret ntdll.RtlDosPathNameToNtPathName_U() retval=00000001 ret=554b42c7 000b:Call ntdll.NtCreateFile (559beba4,40000000,559bebb8,559beba8,00000000,00000000,00000007,00000001,00 004010,00000000,00000000) ret=554b438f 000b:Ret ntdll.NtCreateFile() retval=c00000ba ret=554b438f 000b:Call ntdll.RtlNtStatusToDosError(c00000ba) ret=554b43bd 000b:Ret ntdll.RtlNtStatusToDosError() retval=00000005 ret=554b43bd 000b:Call ntdll.RtlFreeUnicodeString(559bebb0) ret=554b43cc 000b:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=554b43cc 000b:Ret kernel32.CreateFileW() retval=ffffffff ret=1015b46d Decoding the parameters to CreateFile show it trying to open the directory for GENERIC_WRITE. I'm about to dig into the wine sources but am hoping someone can spot the problem more quickly than me. I'm using the 20040914 source RPM from NewRPMs.

2 3

Re: Turn off Antialiasing for Rendering with Palette
by Alexandre Julliard Oct. 19, 2004

Oct. 19, 2004

Glenn Wurster <gwurster(a)scs.carleton.ca> writes: > Description: > * When we are working with a palette, we need to disable antialiasing. > Antialiasing results in a lot of extra colour values which are not > mapped in the palette, causing bad display artifacts. > > Changelog: > * Disable antialiasing when working with the palette You shouldn't change the global antialias flag, this is ugly and it will most likely break the font caching. You have to add checks for a palette directly at the places that handle the anti-aliasing (and your palette check is wrong too, you shouldn't peek into the internals of the DC bitmap). -- Alexandre Julliard julliard(a)winehq.org

2 1