- Wine-Devel - list.winehq.org

Re: Server: Create and Use New mem_free Function
by Alexandre Julliard Oct. 19, 2004

Oct. 19, 2004

Robert Shearman <rob(a)codeweavers.com> writes: > We have our own mem_alloc memory allocator, so this patch adds the a > new free function, mem_free, and replaces instances of free with > mem_free. At the moment, the implementation completely defers to the > libc free function, but it makes sense to have this new function so > that we can easily change memory allocators. The patch also changes a > few instances of malloc to mem_alloc. You cannot do that, mem_alloc sets the error code but malloc doesn't, they are not the same thing. The purpose of mem_alloc is to simplify handling of allocation failures in common cases, it's not a general replacement for malloc. If you really want to change the memory allocator you can redefine malloc and free, but I'm not sure why you'd want to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

oleaut32: SafeArrayDestroyData
by Walt Ogburn Oct. 18, 2004

Oct. 18, 2004

Hi, I am working on getting a scientific / engineering application called SRIM (www.srim.org) specifically the batch-mode component SRModule of SRIM 2003. This is a Visual Basic program, so there's lots of reliance on oleaut32.dll. In addition to freeing the data memory of the SafeArray, Wine's implementation of SafeArrayDestroyData sets the pointer pvData to NULL. The native Windows version apparently does not do this, and SRIM depends on pvData still pointing to the same place afterwards. Wine's code also uses this nulling to keep track of the memory, so that it won't get freed again. I can't say why a program would still want pvData after a call to SafeArrayDestroyData, but there it is. Could the flag FADF_DATADELETED be used to keep track of this instead? That seems to be the case only for vector SafeArrays now. The following patch seems to make SRIM work: =================================================================== Index: dlls/oleaut32/safearray.c =================================================================== RCS file: /home/wine/wine/dlls/oleaut32/safearray.c,v retrieving revision 1.40 diff -u -r1.40 safearray.c --- dlls/oleaut32/safearray.c 20 Sep 2004 19:11:48 -0000 1.40 +++ dlls/oleaut32/safearray.c 18 Oct 2004 17:03:51 -0000 @@ -1254,7 +1254,7 @@ if (psa->cLocks) return DISP_E_ARRAYISLOCKED; /* Can't delete a locked array */ - if (psa->pvData) + if (psa->pvData && !(psa->fFeatures & FADF_DATADELETED)) { /* Delete the actual item data */ if (FAILED(SAFEARRAY_DestroyData(psa, 0))) @@ -1265,7 +1265,8 @@ { if (!SAFEARRAY_Free(psa->pvData)) return E_UNEXPECTED; - psa->pvData = NULL; + /* psa->pvData = NULL; */ + psa->fFeatures |= FADF_DATADELETED; } else psa->fFeatures |= FADF_DATADELETED; /* Mark the data deleted */ =================================================================== Also, is there a way to make the tests in oleaut32/tests/ run on the native dlls? If so, I could more clearly show that the Windows version doesn't null pvData. Thanks, Walter

2 2

Re: x11drv: Add stretching support to AlphaBlend
by Huw D M Davies Oct. 18, 2004

Oct. 18, 2004

On Sun, Oct 17, 2004 at 10:34:28PM -0400, Kevin Koltzau wrote: > Changelog: > Add stretching support to AlphaBlend XRenderSetPictureTransform is a relatively new addition to libxrender, arriving just before XFree 4.3. I don't think we want the whole xrender stuff to fail if this specific function isn't available in the library. Could you make the presence of this function optional and simply skip the stretched AlphaBlend if it's not there? Huw.

1 0

-fPIC on link line in winegcc for HPUX
by Warren_Baird/CSI＠cimmetry.com Oct. 18, 2004

Oct. 18, 2004

Hi all, Another change I had to make for HPUX that I'm not 100% sure about: The HPUX linker gets quite unhappy unless the gcc link line inside of winegcc is fed -fPIC. The problem is that the collect2 phase builds it's own temporary object file that gets included in the final link, and if that temp .o file isn't compiled with -fPIC, the HP linker complains. In order to get this to work, I had to add -fPIC to the list of link flags that winegcc recognizes: diff -ur patched/wine-20040914/tools/winegcc/winegcc.c wine-20040914/tools/winegcc/winegcc.c --- patched/wine-20040914/tools/winegcc/winegcc.c 2004-10-12 10:28:37.000000000 -0400 +++ wine-20040914/tools/winegcc/winegcc.c 2004-10-12 10:10:07.000000000 -0400 @@ -616,7 +616,7 @@ { "-nostartfiles", "-nodefaultlibs", "-nostdlib", "-s", "-static", "-static-libgcc", "-shared", "-shared-libgcc", "-symbolic", - "-framework" + "-framework", "-fPIC" }; int j; The question: is this going to be harmful on other platforms? I'm not sure whether I should protect it with ifdefs, or just leave it as is. Any suggestions? Thanks, Warren

3 6

Re: Resend: Honor --disable-debug or --disable-trace completely
by Alexandre Julliard Oct. 18, 2004

Oct. 18, 2004

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > wine/debug.h has some tests based on NO_{DEBUG,TRACE}_MSGS, which is set > (or not) in config.h. Quite a few files didn't #include config.h before > wine/debug.h, so some debugmsgs were always compiled in, even with > ./configure --disable-debug. > > Now maybe we want to install config.h as well, as debug.h is already > installed. I'll leave that one to Alexandre. No, the right fix is to put these defines in the Makefile and get rid of them in config.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: MinGW portability fix
by Hans Leidekker Oct. 18, 2004

Oct. 18, 2004

On Sunday 17 October 2004 16:16, Hans Leidekker wrote: > Changelog: > Add configure check for getpagesize() declaration, needed by MinGW. Hmm, I just found that the AC_CHECK_DECL macro doesn't work as expected. You can skip this patch. -Hans

1 0

Re: [wine] Re: window caption buttons
by William Poetra Yoga H Oct. 18, 2004

Oct. 18, 2004

--- David Lee Lambert <lamber45(a)cse.msu.edu> wrote: > On Wed, Oct 13, 2004 at 08:31:37AM -0700, William Poetra Yoga Hadisoesen > wrote: > > --- Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: > > > > If it really makes a functional difference, then I guess it should be > fixed, > > > otherwise why not leave it as is? > > > 1. Developers coming from Windows can have the same "look and feel". This > > increases their productivity, although indirectly. When people see > something > > different but similar to the one they see everyday, their attention will be > > divided to the new object and the work they are doing. And their motivation > to > > work will decrease, too, if the GUI doesn't get fixed. > > Once in a while on Windows, I tweak the desktop fonts and colors a little > bit just so it doesn't get boring. I've made document backgrounds > off-white; changed the menu font; even done a little bit with Active > Desktop on some boxes. An off-by-one error in a terminal emulator that > lets it only display 79 columns needs to be fixed, but I'd rather we kept > little oddities like this. Yeah, you've got a point there. But then wouldn't it be better if we start off emulating the "standard" win9x style, and then create themes and stuff? Just like reactos: they start by trying to be nt4.0-compatible, but have plans to do win2k. Or xpde: they start with the win2k shell and add the winxp features later ;) > > 2. Windows users looking at WINE will reject it straight away, because it > > doesn't look like a "professionaly-made" software, and maybe mocking it as > a > > carelessly written software, with sloppy GUI. Remember, some users become > > developers. > > I don't aggree with this either. "Professional" apps on Windows these > days go out of their way to look fancy, do their own drawing, be a > little bit different than Windows. (I know these have better alternatives > on Linux but) look at MusicMatch Jukebox, WinAmp, RealPlayer, Windows > Media Player, AOL, Kodak Photo Editor... these apps have all their own > icons anyway. The Win3.1->Win95 or WinNT->WinXP UI jump is already bigger > than that from Wine to the average of all versions it matches, in terms > of things like this. Yes, there are inconsistencies between Windows versions, and between some programs and programs which use the "standard" ui. It's true that there are many professional programs which draw their own windows. But have you looked more closely at WINE's window decorations? They're like Windows 95's, but they're somewhat different. I think it's better (and more appealing to the eye) if we were to define a theme (WINE theme) that looks at least obviously different from the Windows shell. It's because when we draw things so similar -- yet different -- to things found in Windows, people won't like it. It's like, doing a (sorry, just a comparison) fake thing that's similar to the original. If you have lived in China, you can find fake Nike's everywhere, for example. Or fake Yonex shuttlecocks. They're not so much different from the original, but they still look... odd. It's one reason people won't buy them. And one more thing, is that I've found numerous off-by-one bugs in the ui part (that draws buttons, decorations, etc), just by attacking the "caption buttons" problem. I know they're off-by one bugs because they don't look right :( I'm not a good programmer, and I don't know how the Windows UI work, so if I'm left to fix the UI bugs there would be little or no wastage of resources, it will make me learn, and also make WINE look better. So I think it should be okay for me to "fix" the buttons (and numerous bugs I find along the way). _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

1 0

Re: UCS2 vs. UTF16 question
by Shachar Shemesh Oct. 18, 2004

Oct. 18, 2004

Hi Juan, I took the liberty of answering to the list. I hope you don't mind. Juan Lang wrote: >Hi Schachar, something you said earlier this year at >wineconf caught my ear, and I think I'm finally >understanding enough to ask about it. You said >Windows uses UCS2-LE (I think you did, anyway) rather >than UTF16. Is that true? > I most certainly didn't say that. I may have mentioned UCS4, but to the best of my knowledge at the time, Windows uses UTF-16. As a result of your email, I tried to check it again, however. The results are somewhat inconclusive. I generated a file (attached) containing two musical symbols in Unicode. These are from the codepoints above U10000, and are therefor unrepresentable in UCS2. Opening this file up in notepad reveals a mixed result. On the one hand, they appear as two unknown characters (which seems to suggest that at least Notepad understands this is UTF-16LE). On the other hand, I did not manage to find any font that has any characters with codepoints above U10000. I'm hoping one of our far-eastern speakers jumps in with more insight (Mike?). Are surrogates used on Windows? How common are they? > Does that then imply that >Windows really can't handle characters outside the >Basic Multilingual Plane? Does that also imply that >WCHARs are in fact fixed-width in Windows? > > As far as I know, they are not. Sorry. >I'm planning to write a tool to detect the following >problematic bit of code: >char str[] = "hi", *p = str + sizeof(str) - 1; >p--; >At least, it's problematic when str contains >double-byte characters. > I'm not sure what you are aiming at achieving. Are you trying to hit the beginning of the last character of the string? If so, then you do, indeed, have a problem here. > If the type of char and p >were WCHAR * instead, and WCHARs are fixed width, >there isn't a problem. > >If you have thoughts on similar programming bugs >relating to internationalization (use of strchr and >strrchr, for example) I'd be interested to hear them. > > In the past I have written programs that had to do MBCS (the non-unicode Japanese encoding). This is an encoding in which some characters are one byte, and some two. The best I could come up with was to build a wrapper around std::string that had two bytes per character internally. When you loaded a string, it would check character by character for whether it's a double byte, and then have each string location contain exactly one character. This allowed random access, as well as both forward AND backwards scanning. Fortunately, UTF is much better than MBCS. Given a byte in either UTF-8 or UTF-16, it's fairly easy to figure out whether it's part of a surrogate, and what part. If you have assurance that the string you are handling is a well formed one, you can do backward scans of a UTF string fairly easily. >Thanks, >--Juan > >_______________________________ >Do you Yahoo!? >Declare Yourself - Register online to vote today! >http://vote.yahoo.com > > Do you want a gmail account? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Wineconf 2005
by Jeremy White Oct. 18, 2004

Oct. 18, 2004

Hey Folks, It's that time again, time to plan for another Wineconf. There has been some back room chatter about Wineconf this year, but no definitive plans. A small cabal of people (myself included) think that we should hold it in Southern Germany around February/March. Marcus and Michael have each expressed that they might be able to get a facility to hold it in, but those efforts have so far not yielded anything definitive (I think we're tied up in big company red tape). Also, Huw Davies has offered to help host Wineconf in Oxford; that essentially translates into an offer by CodeWeavers to host Wineconf in mid March in Oxford. However, I want to throw this open to discussion and see if others have great ideas or if someone outside our secret cabal wants to step up and make this happen in Southern Germany. Based on our experience last year, I feel pretty strongly that we need the following: 1. An inexpensive, yet easy to reach location. Connection to nice places to visit before/after is a plus, but should be a substantially secondary consideration imo. 2. Two rooms that can each hold about 30-40 people, ideally with white boards, power, and high speed internet. 3. Access to food and hotels, preferably all within walking distance of each other. Since Europe is civilized, we should be able to walk from our Hotel to the conference, to a variety of food sources, and then, of course, to the pub. Candidly, I don't know that this is all that complicated. We'll likely be bringing enough people in that we should be able to negotiate a pretty nice deal with a Hotel. (We promise them xxx heads in beds, they give us conference facilities for a weekend). If someone wanted to help host Wineconf, and was willing to facilitate a conversation between myself and a Hotel that was well situated, CodeWeavers would be happy to sponsor the conference (i.e. financially reassure the Hotel). Thoughts? Comments? Cheers, Jeremy

4 5

Re: Make TranslateAcceleratorA handle national characters
by Dmitry Timoshkov Oct. 18, 2004

Oct. 18, 2004

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > Make TranslateAcceleratorA handle national characters. Please ignore this patch, it apparently corrupts original msg structure but it shouldn't. I'll send a new patch tomorrow. -- Dmitry.

1 0