- Wine-Devel - list.winehq.org

Re: [janitor] tools -Wwrite-strings cleanup
by Alexandre Julliard Oct. 15, 2004

Oct. 15, 2004

Daniel Marmier <d.marmier(a)bluewin.ch> writes: > This is one situation I would like to discuss a bit more. > Some code uses a mix of static and dynamic structures containing strings. > The static instances have constant strings, the others are xmalloc'd. These > strings must be declared char *, since we need to be able to free them. But > this prevents us from initializing the static ones with constant strings. > > Solution 1 (double casting to avoid constness removal warning) > s->name = FAKE_CHARPTR("hello"); > > Solution 2 (shows clearly that we mix constant/variable and avoids casting): > union { > const char *c; > char *v; > } name; > s->name.c = "hello"; > > Can you think of a better solution? What is preferable? I think this sort of construct should be avoided. If we mix static and allocated data in the same structure, there is a big risk that we will one day try to free static data, with random results. We should change the code so that it doesn't need that, either by storing the static data in a separate structure, or for non performance critical code by allocating a copy of the static data. -- Alexandre Julliard julliard(a)winehq.org

3 2

Microsoft Data Access Components
by Tom Hibbert Oct. 15, 2004

Oct. 15, 2004

Hi All, I've been given the thankless task of getting a legacy application running under Linux. It requires the Microsoft Data Access Components (MDAC) to run, but I cant get them to install (either 2.6 or 2.8). Does anyone have a howto or can give me the skinny on what sacrifices I need to make to get this installed? I'm running Gentoo Wine 20040716. Thanks in advance Tom

2 1

winetest results refused when run by wine
by Robert Reif Oct. 15, 2004

Oct. 15, 2004

Couldn't winetest fill in the proper test results fields necessary for acceptance when compiled to an exe.so and run in wine?

8 13

Re: shlexec - skip argument identifier
by Vitaliy Margolen Oct. 15, 2004

Oct. 15, 2004

Oops, resend with the right patch. Vitaliy Margolen Wednesday, October 13, 2004, 5:58:22 AM, Vitaliy Margolen wrote: > Second char of argument identifier was getting into program name: > wine start http://yahoo.com > was executing: > winebrowser \"http://yahoo.com\"1 > Vitaliy Margolen > changelog: > dlls/shel32/shlexec.com > fix parameter parsing

3 2

env lookup in loading a dll
by Bill Medland Oct. 15, 2004

Oct. 15, 2004

Anyone any ideas about this? With recent changes in Wine, registering msxml4.dll results in the path in the registry being %SystemRoot%\system\msxml4.dll (which is correct). Previously it was the explicit C:\windows\system\msxml4.dll. The result is that CoCreateInstance results in an attempt to LoadLibraryExW ("%SystemRoot%..., which LoadLibraryEx cannot handle (even under Windows). There does not appear to be an attempt to call GetEnvironmentVariable or GetWindowDirectory between the registry access that gets the InProcServer32 and the call to LoadLibraryExW. Does anyone have any idea where the fault is likely to be? (Until I create a small test case I can't run with +relay) -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

1 1

Stupid thing to try ...
by Ivan Leo Puoti Oct. 15, 2004

Oct. 15, 2004

You can get the wine dlls build for windows from our sf.net page, look for the wine-dlls packages. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Commctl32 Stubs
by Dmitry Timoshkov Oct. 14, 2004

Oct. 14, 2004

"Thorsten Kani" <beebix(a)gmx.net> wrote: > +BOOL WINAPI > +SetPathWordBreakProc(DWORD par1, HWND hwndTo) > +{ > + LRESULT result; > + > + result=SendMessageA (hwndTo,EM_GETWORDBREAKPROC,0,0); > + TRACE("(par1: %lx, HwndTo: %p, CurrentPWBProc: %lx) Stub!\n", par1, hwndTo, result); ... > +BOOL WINAPI > +MirrorIcon(LONG par1) > +{ > + TRACE("(par1: %lx) empty stub!\n", par1); > + return FALSE; > +} You have to use FIXME not TRACE for stubs. -- Dmitry.

1 0

Re: Stupid thing to try ...
by Steven Edwards Oct. 14, 2004

Oct. 14, 2004

--- Lars Segerlund <lars.segerlund(a)comsys.se> wrote: > Ok, I get it, wine must us a binary loader for the windows dll's ... > areasonable ... Under Windows you can just compile the dll using mingw and then drop the dll in to the program direct that you want to test. Lets say you have a app name foo.exe you can copy the wine comctl32.dll to that directory that contains foo.exe and the make a copy of foo.exe and name the copy foo.exe.local When you create a *.exe.local file it exposes a hidden hack in Windows that forces it to search the local directory first for dlls no matter what the registry setting is. Note this only works for comctl32, shell32, shlwapi, ole32 and a few others. Dlls from Wine like user32, gdi32, ntdll, kernel32 and friends cannot be loaded on Windows. Like the other guy suggested you should checkout ReactOS. We support building a good number of the Wine dlls for Windows. Thanks Steven _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

1 0

Re: Commctl32 Stubs
by Robert Shearman Oct. 14, 2004

Oct. 14, 2004

Thorsten Kani wrote: > > Added > -SetPathWordBreakProc > -MirrorICON > -ImageList_SetColorTable > > This Patch makes MSGina and native Shlwapi happy. > With it, commctl32 can be replaced on Win2k SP4. Thanks for the patch, but I'd rather get the params correct for the stubs. Can you let me know where each function is used? > Changelog: New Stubs in Commctl32: SetPathWordBreakProc, MirrorICON > and ImageList_SetColorTable MirrorIcon is a nop on Wine at the moment. ImageList_SetColorTable is trivial with using DIBs internally now. That just leaves SetPathWordBreakProc. I believe that should set the word break proc of an edit control to one that understands paths. It shouldn't be too hard to implement if you leave it with me. > PS: FirstPatchWarning: Be warned (: Good first patch, but leave it with and I should be able to implement these functions for you. Rob

2 1

unusual debug message
by Ivan Leo Puoti Oct. 14, 2004

Oct. 14, 2004

does anyone know what this means, and what could be causing it? libpng warning: Invalid cHRM white point Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0