- Wine-Devel - list.winehq.org

Re: Remove debugmsg from guides
by Dimitrie O. Paun April 25, 2004

April 25, 2004

On Sun, 25 Apr 2004, Ivan Leo Murray-Smith wrote: > Please let me know if something isn't OK. A few points: -- I find the change confusing. There's no WINEDEBUG channel. I think most should just change from debugmsg -> debug -- Please provide only one .diff file. Multiple diffs are not necessary, and makes reviewing and applying so much more difficult. -- It would be nice if the diff would be either inlined or attached as text/plain. Inlining is prefered, this way people can quote easily when replying. -- Dimi.

1 0

Re: Remove debugmsg from guides
by Eric Pouech April 25, 2004

April 25, 2004

Ivan Leo Murray-Smith a écrit : > With this all unneeded references to debugmsg should be gone. Just one note, in > debugger.sgml I found this > [MACHINE\\Software\\Microsoft\\Windows NT\\CurrentVersion\\AeDebug] 957636538 > "Auto"=dword:00000001 > "Debugger"="winedbg --debugmsg -all %ld %ld" > As I don't know what it's meant to be now, I've left it, if it should change, > let me know. > Please let me know if something isn't OK. > > Ivan. this should be changed into "Debugger"="winedbg %ld %ld" (the issue is that the debugger will be inheriting the parent's debug channel, while this setting was turning off all debugging channels from debugger itself). A+

1 0

Re: PATCH: silence strict aliasing in dlls/opengl32
by Lionel Ulmer April 25, 2004

April 25, 2004

> Not sure how to regenerate the opemngl_ext.c file. You need the extension registry CVS (you can find it here http://oss.sgi.com/projects/ogl-sample/ - no idea where the exact CVS informations are). After, do 'make_opengl PATH_TO_EXTENSION_DIR 1.2' where PATH_TO_EXTENSION_DIR points to the '<OGL-SAMPLE-ROOT>/main/doc/registry/specs/' directory). Anyway, if it can wait, it will be updated the next time I generate the file. Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

dlls/d3d8/shader.c
by Marcus Meissner April 25, 2004

April 25, 2004

Hi, I was just fixing this code, but I wonder why floorf(s0->w) is overwritten right next with tmp_f = powf(2.0f, s0->w); What is the right version? Ciao, Marcus void vshader_expp(D3DSHADERVECTOR* d, D3DSHADERVECTOR* s0) { float tmp_f = floorf(s0->w); DWORD tmp_d = 0; tmp_f = powf(2.0f, s0->w); tmp_d = *((DWORD*) &tmp_f) & 0xFFFFFF00;

2 1

Bad string handling in PRINTDLG_UpdatePrintDlg?
by Francois Gouget April 24, 2004

April 24, 2004

In PRINTDLG_UpdatePrintDlgA() in dlls/commdlg/printdlg.c we do: ... LPPRINTER_INFO_2A pi = PrintStructures->lpPrinterInfo; ... pi->pPortName = "FILE:"; And in PRINTDLG_UpdatePrintDlgW() we do: ... LPPRINTER_INFO_2W pi = PrintStructures->lpPrinterInfo; ... static WCHAR file[] = {'F','I','L','E',':',0}; pi->pPortName = file; ... Now in gcc all string literals are read-only, even if you declare them as char* foo="bar", *foo='\0' will cause a segfault. So in the Ansi version we point pPortName to a read-only string. But if the application gets hold of that pointer we have no garantee that it won't expect to be able to modify that string: pPortName is an LPSTR. (this is a case where -Wwrite-strings will complain) And in the Unicode case we point pPortName to a static writable buffer. But in this case if the application writes in our buffer its contents is going to be messed up forever. However I don't know this code at all. So I'm asking, shoudln't we make a copy of these strings? Which also raises the ugly issue of later freeing the corresponding memory buffer... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux

1 0

Idea to fight spam
by Ivan Leo Murray-Smith April 24, 2004

April 24, 2004

What about having a link to this page somewhere on winehq? Maybe on the mailing lists page? http://www.hostedscripts.com/scripts/antispam.html Ivan.

2 1

Re: Docu: mention piping for debugmsgs
by Ferenc Wagner April 24, 2004

April 24, 2004

Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> writes: > Make people know how to reduce log size, using pipes. Hi Andi! Two notes: 1. The --debugmsg option is deprecated, people should use the WINEDEBUG environmental variable instead. 2. Won't the pipe block until you read from it, then give you all the data ever written? -- Feri.

1 0

winetest: build & publishing
by Dimitrie O. Paun April 24, 2004

April 24, 2004

Hi folks, I've checked the build this morning on SF, and it looks beautiful! So let's review the possible problems still outstanding: 1. Build Info Feri want to move that in the resources, with good reason. This will probably affect you very little, but needs to be done. We can still keep it in the .zip file (it is tiny) as it's a lot easier accessible for others. However, if we do that, the file will need to use DOS line ends, as this file will probably be viewed by folks on Windows boxes. Anyway, from your point of view it will probably mean a 'unix2dos' and a 'cp' before the build. 2. Uploading to SF This works nice now, but I'm afraid it may not when we have more than one person doing it. Namely, a release needs to be created, will that not fail if it already exists? Can we check that? If that's a problem, how are we going to deal with it? Kevin, can you please try to see if what happens if you upload two files (with differents sfutils invocations) into the same release? 3. Downloading from SF I just realized there is a time delay for the uploads to be propagated to the mirrors. What URL are we going to use for downloading? How long are we going to allow for the propagation to happen? Anyone has experience with this? 4. Release lifetime It would be nice to have the "WineTest Files" package visible on SF. I have made it so for testing purposes now. However, it will become ugly soon, because we don't hide the old releases. We can hide the entire package, and that would solve the ugliness problem, but it would be much nicer to have an automatic way of hiding old releases, and having just the latest releases visible. Can we maybe modify the sfutils to do this for us? We are very close on this front. I'm very happy with the state of things right now, I hope we can resolve these in a few days. -- Dimi.

5 6

Re: FILEDLG_MapOfnStructA bug?
by Dmitry Timoshkov April 24, 2004

April 24, 2004

"Francois Gouget" <fgouget(a)free.fr> wrote: > -static char defaultopen[]="Open File"; > -static char defaultsave[]="Save as"; > > /*********************************************************************** > * FileDlg_Init [internal] > @@ -970,9 +968,13 @@ > if (ofnA->lpstrTitle) > str = ofnA->lpstrTitle; > else > + { > /* Allocates default title (FIXME : get it from resource) */ > + static const char* defaultopen="Open File"; > + static const char* defaultsave="Save as"; Don't you really want to leave it as a static const array of characters as before and not a static const pointer? Same for your next patch. -- Dmitry.

1 0

Re: Fix for test of CreateFileMapping in dlls/kernel/tests/file.c
by Stefan Leichter April 24, 2004

April 24, 2004

Am Samstag, 24. April 2004 00:54 schrieb Jakob Eriksson: > From a run of winetest 20040423 on Windows XP: > > file.c:1075: Test failed: mapping should succeed > file.c:1077: Test failed: can't close mapping handle > file: 487696 tests executed, 0 marked as todo, 2 failures. > > > > Seems CreateFileMapping has some seriously strange behaviour. > I tested some more how XP behaves and produced a patch based on that. > > > regards, > Jakob Hello Jakob, + *handle = CreateFile(filename, GENERIC_READ|GENERIC_WRITE, 0, 0, + CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); + if (handle != INVALID_HANDLE_VALUE) { do you have to test the pointer not the value ? Bye Stefan

2 1