- Wine-Devel - list.winehq.org

speed up oleaut32: vartest
by Chris Morgan April 22, 2004

April 22, 2004

*dlls/oleaut32/tests/vartest.c: Chris Morgan<cmorgan(a)alum.wpi.edu> Skip over most of the unused variant types to speed up the variant tests. This look like a reasonable way to speed up the variant tests without losing testing functionality? Chris

1 1

RE: Fix for GetFileTime API - Incorrect Modified/Last access Time .
by Krishna Murthy April 22, 2004

April 22, 2004

We have Team Developer Product for MS Windows which has its own language and in the process of verifying on Wine. Few of test cases working on Windows are failing in Wine. Hence I have submitted this patch. Yes, since Pre-1970 times are not going to work on Unix anyway we could release note this in our product. Thanks for your input on this. Krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Wednesday, April 21, 2004 6:16 PM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: Fix for GetFileTime API - Incorrect Modified/Last access Time. Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > Change of argument type DWORD to LONGLONG of function > RtlSecondsSince1970ToTime() and RtlSecondsSince1980ToTime() to accept > negative values. These are Windows APIs, you cannot simply change their arguments, we have to be compatible. Pre-1970 times are not going to work right on Unix anyway; what do you need them for? -- Alexandre Julliard julliard(a)winehq.org

1 0

winetest oddity - oleaut32: VarTest
by Chris Morgan April 22, 2004

April 22, 2004

I've been looking at vartest, specifically to speed it up since the tests I added for VarMod() are the cause of its current excessive length. Something appears to be a bit different with mingw compiled tests vs. MSVC compiled tests. Under wine these tests run just fine, three fixmes popup. I get two failures when running the oleaut32 vartest on my XP machine. This is compiled with vc6sp5+processor pack. Running the mingw compiled test from Paul Millar, http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-20040421-100…, there are thousands of failures for the same test. Anyone have a clue what might be causing this? One thing that came to mind was that there are int64's used in the ole code, the test won't compile cleanly under vc6 without the processor pack. Maybe mingw is messing up the int64's? Chris

1 0

Re: Fix for GetFileTime API - Incorrect Modified/Last access Time.
by Alexandre Julliard April 22, 2004

April 22, 2004

Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > Change of argument type DWORD to LONGLONG of function > RtlSecondsSince1970ToTime() and RtlSecondsSince1980ToTime() to accept > negative values. These are Windows APIs, you cannot simply change their arguments, we have to be compatible. Pre-1970 times are not going to work right on Unix anyway; what do you need them for? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Wine detect patch (ignore previous whitespace patch)
by Ferenc Wagner April 21, 2004

April 21, 2004

Jakob Eriksson <jakov(a)vmlinux.org> writes: > (Sorry about the linespace noise after print_version(), > emacs seems to change stuff behind my back when I save.) Hi Jakob, You'd better educate Emacs about your ways, otherwise all your patches will be full of whitespace changes making them very hard to review. The indentation isn't consistent, but if you want to fix this, do so in a separate patch, please! > + static const TCHAR wine[128] = {"Wine"}; I think we could use static const char wine[] = "Wine"; instead. No wide characters in winetest for now. But see below! > + if (running_on_wine ()) { /* Make a an obvious signature for Wine */ > + ext = 1; > + > + ver.dwMajorVersion = 1; > + ver.dwMinorVersion = 1; > + ver.dwBuildNumber = 1; > + ver.dwPlatformId = 1; > + strncpy (ver.szCSDVersion, wine, sizeof (wine)); > + } > + I think we can do better. A single line like xprintf (" bRunningUnderWine=%d\n", running_under_wine ()); as the first line of print_version() would do a perfect job without masking anything else. -- Feri.

2 1

Re: Winetest results uploaded... where?
by Ivan Leo Murray-Smith April 21, 2004

April 21, 2004

On http://test.winehq.org/data/200404192305/ the "next build" and "previous build" buttons are broken. I get a error message, saying "You don't have permission to access /site on this server." Ivan.

4 12

Re: White-space patch for programs/winetest/main.c
by Alexandre Julliard April 21, 2004

April 21, 2004

Jakob Eriksson <jakov(a)vmlinux.org> writes: > This is also an example of how the file can store its indent > preference in a comment. > > I will run this when I'm done editing the file: > FILENAME=main.c && `grep indent $FILENAME` $FILENAME I don't think that's a good idea at all. It would require everybody to do that every time they make a change to that file, otherwise there will be plenty of spurious whitespace changes and conflicts. Please don't do that. -- Alexandre Julliard julliard(a)winehq.org

2 2

i810 audio fixes 1/2
by Roderick Colenbrander April 21, 2004

April 21, 2004

Hi, This is the first of two patches that will fix some problems on soundcards using the i810 audio codec. The main probem with this soundcard is that it only supports a frequency of 48kHz in 16bit stereo mode. This first patch to dsound queries if the card supports 16bit and if so it uses it, else it uses 8bit. Further it also detects if the card supports stereo or not. The patch was inspired by one from transgaming to rewind but that patch did a bit the opposite (defaulting to 8bit ..). Roderick Colenbrander

8 18

Re: Widl: Conditionals, Dotted Versions, Handles
by Robert Shearman April 21, 2004

April 21, 2004

>>> Ove Kaaven <ovek(a)arcticnet.no> 04/19/04 22:50 PM >>> man, 19.04.2004 kl. 17.03 skrev Robert Shearman: > > > Doesn't the "version" rule already handle this? > > > > It would appear not. The 'version' type is declared > as a number further up > > It's declared that the rule *returns* a number, you mean. The actual > rule is defined as > > version: > aNUM { $$ = MAKELONG($1, 0); } > | aNUM '.' aNUM { $$ = MAKELONG($1, $3); } > ; > > Now if this somehow returns 0, then you need to fix that rule, not add > another rule which makes a version of e.g. "1.2.3.4" valid syntax (but > still return a wrong result). Ok, I missed that before. I suspect it doesn't work properly because it correctly matches aNUM and attempts to convert it to a number and succeeds (but returning 0). We should re-arrange that rule so that the dotted version matches first and falls back to the second version if there is no '.'. However, I doubt I will have the time to resend that patch for a while. Rob

1 0

winetest reporting http://test.winehq.org/data/200404192305/
by Jakob Eriksson April 21, 2004

April 21, 2004

First of all, the report on http://test.winehq.org/data/200404192305/ is VERY pretty. Almost get misty eyed here. ;-) Things are coming along very nicely. Anyway, I am curious what happens if I run winetest.exe in Wine. Will it get reported accurately as Wine, or will it get misrepresented in for instance the XP column? regards, Jakob

4 7