- Wine-Devel - list.winehq.org

Re: Avoid a possible deadlock when stopping playback
by Christian Costa March 18, 2004

March 18, 2004

Hi Dmitry, Are you sure this is usefull. How can SetEvent cause a deadlock? Bye, Christian > Message du 16/03/04 14:54 > De : Dmitry Timoshkov > A : wine-patches(a)winehq.com > Copie à : > Objet : Avoid a possible deadlock when stopping playback > Hello, > > looks like it's a good idea to do the same when signalling hStopEvent. > > Changelog: > Dmitry Timoshkov > Avoid a possible deadlock when stopping playback. > > --- cvs/hq/wine/dlls/winmm/mciavi/mciavi.c 2004-03-16 18:37:03.000000000 +0800 > +++ wine/dlls/winmm/mciavi/mciavi.c 2004-03-16 19:38:42.000000000 +0800 > @@ -606,7 +606,9 @@ static DWORD MCIAVI_mciStop(UINT wDevID, > switch (wma->dwStatus) { > case MCI_MODE_PLAY: > case MCI_MODE_RECORD: > + LeaveCriticalSection(&wma->cs); > SetEvent(wma->hStopEvent); > + EnterCriticalSection(&wma->cs); > /* fall through */ > case MCI_MODE_PAUSE: > /* Since our wave notification callback takes the lock, > > > > >

2 3

Rundll32 needs X
by Vincent Béron March 18, 2004

March 18, 2004

Hi folks, Since wine.inf is now used as the source for the default values for the registry (via rundll32), importing it absolutely needs X (whereas the older regedit method didn't when importing a .reg file). This can be a problem for people running wineinstall via ssh from a Windows box. Is there a reason rundll32 needs user32 and cannot delayimport it? Vincent

3 3

PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa March 17, 2004

March 17, 2004

Hi, When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. After some investigations, I found that a part of the code uses the EBX register at one point without saving and restore it afterwards. Since this register contains the PLT pointer for standard unix functions like libc ones, this does not take a long time for Wine to crashing. I tested with the ugly hack attached that saves and restores the EBX register between the call to DllMain and that fixed the problem and the DLL works fine then. Can someone tell me what happens? Thanks in advance, Christian Index: loader.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/loader.c,v retrieving revision 1.66 diff -u -r1.66 loader.c --- loader.c 16 Mar 2004 03:10:07 -0000 1.66 +++ loader.c 17 Mar 2004 21:19:39 -0000 @@ -690,7 +690,9 @@ else TRACE("(%p %s,%s,%p) - CALL\n", module, debugstr_w(wm->ldr.BaseDllName.Buffer), reason_names[reason], lpReserved ); + __asm("push %ebx"); retv = entry( module, reason, lpReserved ); + __asm("pop %ebx"); /* The state of the module list may have changed due to the call to the dll. We cannot assume that this module has not been

4 3

Re: [AppDB] - Script the table creation, help users to setup local appdb
by Paul van Schayck March 17, 2004

March 17, 2004

Chris, On Wednesday 17 March 2004 19:16, Chris Morgan wrote: > README now has some instructions on how to setup a local > appdb. You should also note that magic_quotes_gpc should be off. Otherwise you would end up inside your database with \ everywhere. And for development display_errors is very handy. And great work on those tables. I was already wondered wy I couldn't login. Regards, Paul

1 0

Win32 packages released on sourceforge
by Ivan Leo Murray-Smith March 17, 2004

March 17, 2004

The win32 packages of wine are on sourceforge, you can get them from http://sourceforge.net/project/showfiles.php?group_id=6241 or to view the win32 packages only http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=112520 Ivan.

2 1

Re: Stubs needed by some Windows Update Installs
by Dmitry Timoshkov March 17, 2004

March 17, 2004

"Aric Stewart" <aric(a)codeweavers.com> wrote: > @@ -297,7 +297,7 @@ > @ stub SetupSetSourceListA > @ stub SetupSetSourceListW > @ stdcall SetupTermDefaultQueueCallback(ptr) > -@ stub SetupTerminateFileLog > +@ stdcall SetupTerminateFileLog(ptr) The argument here should be 'long'. -- Dmitry.

2 3

Current CVS msi build failure
by Ferenc Wagner March 17, 2004

March 17, 2004

Hi, with current CVS I get: [...] bison -p SQL_ -d ../../../src/dlls/msi/sql.y -o sql.tab.c ../../../src/dlls/msi/sql.y contains 4 shift/reduce conflicts and 10 reduce/reduce conflicts. bison -p SQL_ -d ../../../src/dlls/msi/sql.y -o sql.tab.c ../../../src/dlls/msi/sql.y contains 4 shift/reduce conflicts and 10 reduce/reduce conflicts. gcc -c -I../../../src/dlls/msi -I. -I../../../src/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o tokenize.o ../../../src/dlls/msi/tokenize.c ../../../src/dlls/msi/tokenize.c:58: `TK_CHAR' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:58: initializer element is not constant ../../../src/dlls/msi/tokenize.c:58: (near initialization for `aKeywordTable[12].tokenType') ../../../src/dlls/msi/tokenize.c:59: `TK_CHAR' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:59: initializer element is not constant ../../../src/dlls/msi/tokenize.c:59: (near initialization for `aKeywordTable[13].tokenType') ../../../src/dlls/msi/tokenize.c:90: `TK_HOLD' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:90: initializer element is not constant [etc., similar ones for TK_INT, TK_LONG, TK_LONGCHAR, TK_OBJECT and TK_SHORT] These IDs are really missing from my sql.tab.h. Any clues? -- Feri.

2 2

Re: Stub for SignalObjectAndWait
by Mike Hearn March 17, 2004

March 17, 2004

On Wed, 17 Mar 2004 01:50:40 +0100, Raphael wrote: > PS: i'm trying to get MSN Messenger working, how we can register some com dlls > into registry ? The app installer should do that for you (last time I tried MSN Messenger I didn't have any problems with missing registrations) but you can run regsvr32 on a DLL to reregister it if you want to. thanks -mike

1 0

Re: REBAR: prevent recursions with WM_SIZE reason
by Mike McCormack March 17, 2004

March 17, 2004

Alexandre, please don't apply this patch... it doesn't work the right way. Juan Lang pointed out that I have a = instead of a |= ... and after fixing it, it doesn't do what it mean to do. thanks, Mike Mike McCormack wrote: > > ChangeLog: > * prevent recursions with WM_SIZE reason

1 0

Re: tools/winetest winetest.cron
by Ferenc Wagner March 16, 2004

March 16, 2004

Jeremy Newman <jnewman(a)winehq.org> writes: > ChangeSet ID: 11483 > > Log message: > set the lang Did you check if it was needed? I thought my patch took care of this in a language/locale neutral way by opening the report file in :raw mode. I'd like to not if it's not the case. -- Feri.

2 1