- Wine-Devel - list.winehq.org

Browsing the wine source
by Blake Leverett March 16, 2004

March 16, 2004

Hello, I have been getting wine from CVS for a while now, and have been looking through the source. How do people who work with the wine code browse around in the source tree? I found that 'ctags -e -R' can be used with emacs, which works OK, but I was wondering if there is a better method. Thanks, Blake Leverett

2 1

Re: cards.dll improvements
by Tom March 16, 2004

March 16, 2004

Sam wrote: > Improvements to cards.dll based on documentation at > http://www.microsoft.com/mind/0396/games.asp. > I'm not sure if you have read this post or not but here it is. http://www.winehq.com/hypermail/wine-devel/2003/07/0691.html Tom

1 0

how to call setupapi / wine.inf
by Marcus Meissner March 16, 2004

March 16, 2004

Hi, I am trying to setup wine with wine.inf, with the following call: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 /usr/share/wine/wine.inf However, the /usr/share/wine/wine.inf path does not seem to be translated correctly. 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",00000000,00000000,00 000000) ret=40c8333c 0009:Ret kernel32.GetFullPathNameW() retval=0000001b ret=40c8333c 0009:Call ntdll.RtlAllocateHeap(40360000,00000000,00000036) ret=40c83542 0009:Ret ntdll.RtlAllocateHeap() retval=4039a0e0 ret=40c83542 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",0000001b,4039a0e0,00 000000) ret=40c83571 0009:Ret kernel32.GetFullPathNameW() retval=0000001a ret=40c83571 0009:Call kernel32.CreateFileW(4039a0e0 L"Y:\\usr\\share\\wine\\wine.inf",80000000,00000001,0 0000000,00000003,00000000,00000000) ret=40c835af 0009:Ret kernel32.CreateFileW() retval=ffffffff ret=40c835af The config script has: [Drive Y] "Type" = "network" "Path" = "%HOME%" [Drive Z] "Type" = "network" "Path" = "/" So it should have been using Z:\\ Is this a problem in GetFullPathName or should I better use: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 z:\\usr\\share\\wine\\wine.inf ? Ciao, Marcus

4 4

dlls/ntdll/directory.c portability breakage
by Gerald Pfeifer March 16, 2004

March 16, 2004

The new file dlls/ntdll/directory.c added by date: 2004/03/16 01:32:02; author: julliard; state: Exp; Implemented NtQueryDirectoryFile (partly based on a patch by Eric Pouech). broke non-Linux platforms (like FreeBSD): /usr/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o directory.o directory.c directory.c: In function `NtQueryDirectoryFile': directory.c:446: error: `O_DIRECTORY' undeclared (first use in this function) directory.c:446: error: (Each undeclared identifier is reported only once directory.c:446: error: for each function it appears in.) There *is* code to #define O_DIRECTORY /* To avoid blocking on non-directories in DOSFS_OpenDir_VFAT*/ #ifndef O_DIRECTORY # define O_DIRECTORY 0200000 /* must be directory */ #endif but it's in #ifdef linux only! Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 0

Re: cards.dll
by Joerg Mayer March 16, 2004

March 16, 2004

On Tue, Mar 16, 2004 at 12:09:24AM +0200, Shachar Shemesh wrote: > Can someone remind me again why we can't have GPL DLLs in the tree? > Doesn't the "call through documented interface blah blah blah not > derived work" argument cause the license for each two DLLs in Wine to be > independant? Basically it goes like this: LGPLed code can be run as a library, i.e. a function of an LGPLed dll can be called as a function call. GPLed code must be run as a (Unix) process if you want to use it from non-GPL-compatible code. See the GPL and especially the GPL FAQ for details. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

2 1

Re: shell32 patch 23 d [correction]
by Alexandre Julliard March 15, 2004

March 15, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > Alexandre - is there any thing wrong with this patch? Yes there has to be something wrong, you create a sei_tmp structure but you never actually use it. I'm not sure what your intent was. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [resend] rebar.c: RBBS_HIDETITLE support
by Alexandre Julliard March 15, 2004

March 15, 2004

Filip Navara <xnavara(a)volny.cz> writes: > I'm sending this patch second time. Is there any reason why it wasn't > commited previously or it just got lost? It will get in faster if you send a non wrapped version ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

dlls/glu32 compile error
by Peter Hyman March 15, 2004

March 15, 2004

Kernel 2.6.4 gcc = 3.2.3 The following compile time error occurs: make[2]: Entering directory `/mnt/src/src/wine/dlls/glu32' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o glu32.spec.o glu32.spec.c {standard input}: Assembler messages: {standard input}:274: Error: no such instruction: `yes "glu32.dll"' {standard input}:275: Error: no such instruction: `yes "gluBeginCurve"' {standard input}:276: Error: no such instruction: `yes "gluBeginPolygon"' {standard input}:277: Error: no such instruction: `yes "gluBeginSurface"' {standard input}:278: Error: no such instruction: `yes "gluBeginTrim"' {standard input}:279: Error: no such instruction: `yes "gluBuild1DMipmaps"' {standard input}:280: Error: no such instruction: `yes "gluBuild2DMipmaps"' {standard input}:281: Error: no such instruction: `yes "gluCheckExtension"' etc... The source file at this location is: "__wine_spec_exp_names:\n" "\tyes \"glu32.dll\"\n" "\tyes \"gluBeginCurve\"\n" "\tyes \"gluBeginPolygon\"\n" "\tyes \"gluBeginSurface\"\n" "\tyes \"gluBeginTrim\"\n" Seems like the \" is being taken as a literal ". Did you mean for a \ to occur? or a \glu... to occur? Regards -- Peter Hyman

2 1

Re: shell32 [was cards.dll]
by Martin Fuchs March 15, 2004

March 15, 2004

On 15.03.2004 23:01:56 Martin Fuchs wrote: > Well to take up for the ReactOS folks.... Martin and Ge have done one hell > of a fine job on shell32 !! > And they have given every thing back.. Not once but twice! > As AJ was on vacation at the time and Martin & Ge spent alot of time > i'm sure spliting the patch up into smaller chunks so it would be > excepted here. .. and the merge is not yet finished. I hope it will ever be finished. But it takes a very long time by sending out those small patch pieces, waiting for the commit, and then go on... Currently I'm splitting the ShellExecute patch (aka "shell32 patch 23") into small pieces, and sending them separately since most of them depends on some another piece. On my list there are also patch nr. 1 and 22 without any answer from Alexandre or some one else. Is there really no possibility to speed this up a bit? If it's going on at the current speed it may be finished at next christmas day. ;-) Martin

1 0

static.c patch
by Filip Navara March 15, 2004

March 15, 2004

Hi, I want to synchronize my change from ReactOS with the Wine tree. Unfortunetly I can't test it and I don't even know if it compiles under Wine. So if anyone want to take care of it, here it is. Regards, Filip --- static.c Tue Feb 10 20:09:04 2004 +++ static.c Mon Mar 15 21:34:06 2004 @@ -122,6 +122,7 @@ static HBITMAP STATIC_SetBitmap( HWND hwnd, HBITMAP hBitmap, DWORD style ) { HBITMAP hOldBitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); if ((style & SS_TYPEMASK) != SS_BITMAP) return 0; if (hBitmap && GetObjectType(hBitmap) != OBJ_BITMAP) { @@ -129,7 +130,7 @@ return 0; } hOldBitmap = (HBITMAP)SetWindowLongA( hwnd, HICON_GWL_OFFSET, (LONG)hBitmap ); - if (hBitmap) + if (hBitmap && !(full_style & SS_REALSIZEIMAGE)) { BITMAP bm; GetObjectW(hBitmap, sizeof(bm), &bm); @@ -559,6 +560,7 @@ HBRUSH hbrush; HDC hMemDC; HBITMAP hBitmap, oldbitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); GetClientRect( hwnd, &rc ); hbrush = (HBRUSH)SendMessageW( GetParent(hwnd), WM_CTLCOLORSTATIC, @@ -573,8 +575,17 @@ if (!(hMemDC = CreateCompatibleDC( hdc ))) return; GetObjectW(hBitmap, sizeof(bm), &bm); oldbitmap = SelectObject(hMemDC, hBitmap); - BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, - SRCCOPY); + if (full_style & SS_CENTERIMAGE) + { + BitBlt(hdc, (rc.right - bm.bmWidth) >> 1, + (rc.bottom - bm.bmHeight) >> 1, + bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, SRCCOPY); + } + else + { + BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, + SRCCOPY); + } SelectObject(hMemDC, oldbitmap); DeleteDC(hMemDC); }

1 0